Issues in cron.php - Fixed Issues - Inspection of "Merge pull request #22 from ggoffy/master" - XoopsModules25x/xnewsletter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 692213...d4ec0d )

by Goffy

created 2018-11-27 22:51 UTC

cron.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * ****************************************************************************
 *  - A Project by Developers TEAM For Xoops - ( http://www.xoops.org )
 * ****************************************************************************
 *  XNEWSLETTER - MODULE FOR XOOPS
 *  Copyright (c) 2007 - 2012
 *  Goffy ( wedega.com )
 *
 *  You may not change or alter any portion of this comment or credits
 *  of supporting developers from this source code or any supporting
 *  source code which is considered copyrighted (c) material of the
 *  original comment or credit authors.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *  ---------------------------------------------------------------------------
 *  @copyright  Goffy ( wedega.com )
 *  @license    GPL 2.0
 *  @package    xnewsletter
 *  @author     Goffy ( [email protected] )
 *
 *  Version : $Id $
 * ****************************************************************************
 */

$currentFile = basename(__FILE__);
include_once "header.php";

echo "<br/>start cron job<br/>";

require_once XOOPS_ROOT_PATH . "/modules/xnewsletter/include/task.inc.php";
$result_exec = xnewsletter_executeTasks($xnewsletter->getConfig('xn_send_in_packages'), 0);

if ($result_exec != '') {
    //you can enable the block for creating protocol for cron
    $protocolObj = $xnewsletter->getHandler('protocol')->create();
    $protocolObj->setVar("protocol_letter_id", "0");
    $protocolObj->setVar("protocol_subscriber_id", "0");
    $protocolObj->setVar("protocol_status", "Cron: ".$result_exec);
    $protocolObj->setVar("protocol_success", "1");
    $protocolObj->setVar("protocol_submitter", "0");
    $protocolObj->setVar("protocol_created", time());

    if ($xnewsletter->getHandler('protocol')->insert($protocolObj)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
        //create protocol is ok
    } else {
        echo $protocolObj->getHtmlErrors();
    }
}
echo "<br/>result cron: {$result_exec}";


1			<?php
2			/**
3			* ****************************************************************************
4			* - A Project by Developers TEAM For Xoops - ( http://www.xoops.org )
5			* ****************************************************************************
6			* XNEWSLETTER - MODULE FOR XOOPS
7			* Copyright (c) 2007 - 2012
8			* Goffy ( wedega.com )
9			*
10			* You may not change or alter any portion of this comment or credits
11			* of supporting developers from this source code or any supporting
12			* source code which is considered copyrighted (c) material of the
13			* original comment or credit authors.
14			*
15			* This program is distributed in the hope that it will be useful,
16			* but WITHOUT ANY WARRANTY; without even the implied warranty of
17			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18			* GNU General Public License for more details.
19			* ---------------------------------------------------------------------------
20			* @copyright Goffy ( wedega.com )
21			* @license GPL 2.0
22			* @package xnewsletter
23			* @author Goffy ( [email protected] )
24			*
25			* Version : $Id $
26			* ****************************************************************************
27			*/
28
29			$currentFile = basename(__FILE__);
30			include_once "header.php";
31
32			echo "<br/>start cron job<br/>";
33
34			require_once XOOPS_ROOT_PATH . "/modules/xnewsletter/include/task.inc.php";
35			$result_exec = xnewsletter_executeTasks($xnewsletter->getConfig('xn_send_in_packages'), 0);
36
37			if ($result_exec != '') {
38			//you can enable the block for creating protocol for cron
39			$protocolObj = $xnewsletter->getHandler('protocol')->create();
40			$protocolObj->setVar("protocol_letter_id", "0");
41			$protocolObj->setVar("protocol_subscriber_id", "0");
42			$protocolObj->setVar("protocol_status", "Cron: ".$result_exec);
43			$protocolObj->setVar("protocol_success", "1");
44			$protocolObj->setVar("protocol_submitter", "0");
45			$protocolObj->setVar("protocol_created", time());
46
47			if ($xnewsletter->getHandler('protocol')->insert($protocolObj)) {
			0 ignored issues – show Unused Code introduced 2016-06-01 02:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
48			//create protocol is ok
49			} else {
50			echo $protocolObj->getHtmlErrors();
51			}
52			}
53			echo "<br/>result cron: {$result_exec}";
54

XoopsModules25x / xnewsletter

Push — master ( 692213...d4ec0d )

cron.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like