mailinglist.php ➔ getActioncode() - Code Metrics - Inspection of "Merge pull request #29 from ggoffy/master" - XoopsModules25x/xnewsletter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 819fc9...f42eea )

by Goffy

created 2020-02-15 16:23 UTC

mailinglist.php ➔ getActioncode() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	3
nop	1
dl	0
loc	24
rs	9.536
c	0
b	0
f	0

<?php
/**
 * ****************************************************************************
 *  - A Project by Developers TEAM For Xoops - ( https://xoops.org )
 * ****************************************************************************
 *  XNEWSLETTER - MODULE FOR XOOPS
 *  Copyright (c) 2007 - 2012
 *  Goffy ( wedega.com )
 *
 *  You may not change or alter any portion of this comment or credits
 *  of supporting developers from this source code or any supporting
 *  source code which is considered copyrighted (c) material of the
 *  original comment or credit authors.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *  ---------------------------------------------------------------------------
 * @copyright  Goffy ( wedega.com )
 * @license    GNU General Public License 2.0
 * @package    xnewsletter
 * @author     Goffy ( [email protected] )
 *
 *  Version : 1 Thu 2012/12/06 12:57:01 :  Exp $
 * ****************************************************************************
 */

use XoopsModules\Xnewsletter;

// defined("XOOPS_ROOT_PATH") || die("XOOPS root path not defined");
require_once __DIR__ . '/common.php';

/**
 * @param int $type
 * @param int $subscr_id
 * @param $mailinglist_id
 *
 * @return bool|null
 */
function subscribingMLHandler($type, $subscr_id, $mailinglist_id)
{
    global $xoopsUser, $xoopsConfig;
    $helper = XoopsModules\Xnewsletter\Helper::getInstance();

    // get subscriber
    $subscrObj    = $helper->getHandler('Subscr')->get($subscr_id);
    $subscr_email = $subscrObj->getVar('subscr_email');

    // get mailinglist
    $mailinglistObj          = $helper->getHandler('Mailinglist')->get($mailinglist_id);
    $mailinglist_listname    = $mailinglistObj->getVar('mailinglist_listname');
    $mailinglist_email       = $mailinglistObj->getVar('mailinglist_email');
    $mailinglist_subscribe   = $mailinglistObj->getVar('mailinglist_subscribe');
    $mailinglist_unsubscribe = $mailinglistObj->getVar('mailinglist_unsubscribe');
    $mailinglist_system      = (int)$mailinglistObj->getVar('mailinglist_system');
    $mailinglist_target      = $mailinglistObj->getVar('mailinglist_target');
    $mailinglist_pwd         = $mailinglistObj->getVar('mailinglist_pwd');
    $mailinglist_notifyowner = $mailinglistObj->getVar('mailinglist_notifyowner');

    $senderUid = (is_object($xoopsUser) && isset($xoopsUser)) ? $xoopsUser->uid() : 0;

    if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_DEFAULT_VAL) {
        // this should not happen
        $protocolObj = $helper->getHandler('Protocol')->create();
        $protocolObj->setVar('protocol_letter_id', 0);
        $protocolObj->setVar('protocol_subscriber_id', $subscr_id);
        $protocolObj->setVar('protocol_status', 'Error adding mailing list: invalid mailing list type');
        $protocolObj->setVar('protocol_success', false);
        $protocolObj->setVar('protocol_submitter', $senderUid);
        $protocolObj->setVar('protocol_created', time());

        if ($helper->getHandler('Protocol')->insert($protocolObj)) {
            return true;
        }
        return $protocolObj->getHtmlErrors();
    }
    if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_MAJORDOMO_VAL) {

        if (_XNEWSLETTER_MAILINGLIST_SUBSCRIBE == $type) {
            $action_code = $mailinglist_subscribe;
        } else {
            $action_code = $mailinglist_unsubscribe;
        }
        $action_code = str_replace('{email}', $subscr_email, $action_code);
        $action_code = str_replace('{nameofmylist}', $mailinglist_listname, $action_code);

        require_once XOOPS_ROOT_PATH . '/class/mail/phpmailer/class.phpmailer.php';
        require_once XOOPS_ROOT_PATH . '/class/mail/phpmailer/class.pop3.php';
        require_once XOOPS_ROOT_PATH . '/class/mail/phpmailer/class.smtp.php';

        try {
            $xoopsMailer = xoops_getMailer();
            $xoopsMailer->reset();
            //$xoopsMailer->setTemplateDir();
            $xoopsMailer->useMail();
            $xoopsMailer->setHTML(false);
            //$xoopsMailer->setTemplate('activate.tpl');
            $xoopsMailer->setToEmails($mailinglist_email);
            if (isset($xoopsConfig['adminmail'])) {
                $xoopsMailer->setFromEmail($xoopsConfig['adminmail']);
            }
            if (isset($xoopsConfig['sitename'])) {
                $xoopsMailer->setFromName($xoopsConfig['sitename']);
            }
            //$xoopsMailer->setSubject($subject);
            $xoopsMailer->setBody($action_code);
            $xoopsMailer->send();

            $protocol_status = str_replace('%a', $action_code, _AM_XNEWSLETTER_SEND_SUCCESS_ML_DETAIL);
            $xoopsMailer->reset();
            $protocol_success = true;
        } catch (\Exception $e) {
            $protocol_status = _AM_XNEWSLETTER_SEND_ERROR_PHPMAILER . $xoopsMailer->getErrors(); //error messages
            $protocol_success = false;
            $helper->addLog($e);
        }

        //create item in protocol for this email
        $text_clean = ['<strong>', '</strong>', '<br/>', '<br>'];
        $protocol_status = str_replace($text_clean, '', $protocol_status);

        $protocolObj = $helper->getHandler('Protocol')->create();
        $protocolObj->setVar('protocol_letter_id', 0);
        $protocolObj->setVar('protocol_subscriber_id', $subscr_id);
        $protocolObj->setVar('protocol_status', $protocol_status);
        $protocolObj->setVar('protocol_success', $protocol_success);
        $protocolObj->setVar('protocol_submitter', $senderUid);
        $protocolObj->setVar('protocol_created', time());

        if ($helper->getHandler('Protocol')->insert($protocolObj)) {
            return true;
        }
        return $protocolObj->getHtmlErrors();
    }

    if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL) {

        $action_code = $mailinglist_target;
        if (substr($action_code, -1) !== '/') {
            $action_code .= '/';
        }
        $action_code .= 'mailman/admin/';
        $action_code .= $mailinglist_listname;
        $action_code .= '/members/';

        if (_XNEWSLETTER_MAILINGLIST_SUBSCRIBE == $type) {
            $action_code .= 'add?subscribe_or_invite=0&send_welcome_msg_to_this_batch=0&notification_to_list_owner=' . $mailinglist_notifyowner;
            $action_code .= '&subscribees_upload=';
        } else {
            $action_code .= 'remove?send_unsub_ack_to_this_batch=0&send_unsub_notifications_to_list_owner=' . $mailinglist_notifyowner;
            $action_code .= '&unsubscribees_upload=';
        }
        $action_code .= $subscr_email;
        $action_code .= '&adminpw=' .  $mailinglist_pwd;
        //echo "action_code:".$action_code;

        try {
            $req = curl_init();
            curl_setopt($req, CURLOPT_URL, $action_code);
            curl_setopt($req, CURLOPT_RETURNTRANSFER, true);

            $res_curl = curl_exec($req);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if(!curl_errno($req)){
                $status = (int)curl_getinfo($req, CURLINFO_HTTP_CODE);
                if ($status === 200) {
                    $protocol_status = str_replace('%a', $subscr_email, _AM_XNEWSLETTER_SEND_SUCCESS_ML_DETAIL);
                    $protocol_status = str_replace('%m', $mailinglist_listname, $protocol_status);
                    $protocol_success = true;
                } else {
                    $protocol_success = false;
                    $protocol_status = 'Curl error: ' . curl_error($req);
                }
            } else {
                $protocol_success = false;
                $protocol_status = 'Curl error: ' . curl_error($req);
            }
        } catch (\Exception $e) {
            $protocol_status = _AM_XNEWSLETTER_SEND_ERROR_PHPMAILER; //error messages
            $protocol_success = false;
            $helper->addLog($e);
        }
        curl_close($req);
        //create item in protocol for this email
        $text_clean = ['<strong>', '</strong>', '<br/>', '<br>'];
        $protocol_status = str_replace($text_clean, '', $protocol_status);

        $protocolObj = $helper->getHandler('Protocol')->create();
        $protocolObj->setVar('protocol_letter_id', 0);
        $protocolObj->setVar('protocol_subscriber_id', $subscr_id);
        $protocolObj->setVar('protocol_status', $protocol_status);
        $protocolObj->setVar('protocol_success', $protocol_success);
        $protocolObj->setVar('protocol_submitter', $senderUid);
        $protocolObj->setVar('protocol_created', time());

        if ($helper->getHandler('Protocol')->insert($protocolObj)) {
            return true;
        }
        return $protocolObj->getHtmlErrors();
    }
    return null;
}

function getActioncode ($mailinglist_id = 0) {
    $helper = XoopsModules\Xnewsletter\Helper::getInstance();

    // get mailinglist
    $mailinglistObj          = $helper->getHandler('Mailinglist')->get($mailinglist_id);
    $mailinglist_listname    = $mailinglistObj->getVar('mailinglist_listname');
    $mailinglist_system      = (int)$mailinglistObj->getVar('mailinglist_system');
    $mailinglist_target      = $mailinglistObj->getVar('mailinglist_target');
    $mailinglist_pwd         = $mailinglistObj->getVar('mailinglist_pwd');

    if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL) {

        $action_code = $mailinglist_target;
        if (substr($action_code, -1) !== '/') {
            $action_code .= '/';
        }
        $action_code .= 'mailman/admin/';
        $action_code .= $mailinglist_listname;
        $action_code .= '/members/list?adminpw=' .  $mailinglist_pwd;

        return $action_code;
    }
    return null;
}


1			<?php
2			/**
3			* ****************************************************************************
4			* - A Project by Developers TEAM For Xoops - ( https://xoops.org )
5			* ****************************************************************************
6			* XNEWSLETTER - MODULE FOR XOOPS
7			* Copyright (c) 2007 - 2012
8			* Goffy ( wedega.com )
9			*
10			* You may not change or alter any portion of this comment or credits
11			* of supporting developers from this source code or any supporting
12			* source code which is considered copyrighted (c) material of the
13			* original comment or credit authors.
14			*
15			* This program is distributed in the hope that it will be useful,
16			* but WITHOUT ANY WARRANTY; without even the implied warranty of
17			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18			* GNU General Public License for more details.
19			* ---------------------------------------------------------------------------
20			* @copyright Goffy ( wedega.com )
21			* @license GNU General Public License 2.0
22			* @package xnewsletter
23			* @author Goffy ( [email protected] )
24			*
25			* Version : 1 Thu 2012/12/06 12:57:01 : Exp $
26			* ****************************************************************************
27			*/
28
29			use XoopsModules\Xnewsletter;
30
31			// defined("XOOPS_ROOT_PATH") \|\| die("XOOPS root path not defined");
32			require_once __DIR__ . '/common.php';
33
34			/**
35			* @param int $type
36			* @param int $subscr_id
37			* @param $mailinglist_id
38			*
39			* @return bool\|null
40			*/
41			function subscribingMLHandler($type, $subscr_id, $mailinglist_id)
42			{
43			global $xoopsUser, $xoopsConfig;
44			$helper = XoopsModules\Xnewsletter\Helper::getInstance();
45
46			// get subscriber
47			$subscrObj = $helper->getHandler('Subscr')->get($subscr_id);
48			$subscr_email = $subscrObj->getVar('subscr_email');
49
50			// get mailinglist
51			$mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglist_id);
52			$mailinglist_listname = $mailinglistObj->getVar('mailinglist_listname');
53			$mailinglist_email = $mailinglistObj->getVar('mailinglist_email');
54			$mailinglist_subscribe = $mailinglistObj->getVar('mailinglist_subscribe');
55			$mailinglist_unsubscribe = $mailinglistObj->getVar('mailinglist_unsubscribe');
56			$mailinglist_system = (int)$mailinglistObj->getVar('mailinglist_system');
57			$mailinglist_target = $mailinglistObj->getVar('mailinglist_target');
58			$mailinglist_pwd = $mailinglistObj->getVar('mailinglist_pwd');
59			$mailinglist_notifyowner = $mailinglistObj->getVar('mailinglist_notifyowner');
60
61			$senderUid = (is_object($xoopsUser) && isset($xoopsUser)) ? $xoopsUser->uid() : 0;
62
63			if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_DEFAULT_VAL) {
64			// this should not happen
65			$protocolObj = $helper->getHandler('Protocol')->create();
66			$protocolObj->setVar('protocol_letter_id', 0);
67			$protocolObj->setVar('protocol_subscriber_id', $subscr_id);
68			$protocolObj->setVar('protocol_status', 'Error adding mailing list: invalid mailing list type');
69			$protocolObj->setVar('protocol_success', false);
70			$protocolObj->setVar('protocol_submitter', $senderUid);
71			$protocolObj->setVar('protocol_created', time());
72
73			if ($helper->getHandler('Protocol')->insert($protocolObj)) {
74			return true;
75			}
76			return $protocolObj->getHtmlErrors();
77			}
78			if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_MAJORDOMO_VAL) {
79
80			if (_XNEWSLETTER_MAILINGLIST_SUBSCRIBE == $type) {
81			$action_code = $mailinglist_subscribe;
82			} else {
83			$action_code = $mailinglist_unsubscribe;
84			}
85			$action_code = str_replace('{email}', $subscr_email, $action_code);
86			$action_code = str_replace('{nameofmylist}', $mailinglist_listname, $action_code);
87
88			require_once XOOPS_ROOT_PATH . '/class/mail/phpmailer/class.phpmailer.php';
89			require_once XOOPS_ROOT_PATH . '/class/mail/phpmailer/class.pop3.php';
90			require_once XOOPS_ROOT_PATH . '/class/mail/phpmailer/class.smtp.php';
91
92			try {
93			$xoopsMailer = xoops_getMailer();
94			$xoopsMailer->reset();
95			//$xoopsMailer->setTemplateDir();
96			$xoopsMailer->useMail();
97			$xoopsMailer->setHTML(false);
98			//$xoopsMailer->setTemplate('activate.tpl');
99			$xoopsMailer->setToEmails($mailinglist_email);
100			if (isset($xoopsConfig['adminmail'])) {
101			$xoopsMailer->setFromEmail($xoopsConfig['adminmail']);
102			}
103			if (isset($xoopsConfig['sitename'])) {
104			$xoopsMailer->setFromName($xoopsConfig['sitename']);
105			}
106			//$xoopsMailer->setSubject($subject);
107			$xoopsMailer->setBody($action_code);
108			$xoopsMailer->send();
109
110			$protocol_status = str_replace('%a', $action_code, _AM_XNEWSLETTER_SEND_SUCCESS_ML_DETAIL);
111			$xoopsMailer->reset();
112			$protocol_success = true;
113			} catch (\Exception $e) {
114			$protocol_status = _AM_XNEWSLETTER_SEND_ERROR_PHPMAILER . $xoopsMailer->getErrors(); //error messages
115			$protocol_success = false;
116			$helper->addLog($e);
117			}
118
119			//create item in protocol for this email
120			$text_clean = ['<strong>', '</strong>', '<br/>', '<br>'];
121			$protocol_status = str_replace($text_clean, '', $protocol_status);
122
123			$protocolObj = $helper->getHandler('Protocol')->create();
124			$protocolObj->setVar('protocol_letter_id', 0);
125			$protocolObj->setVar('protocol_subscriber_id', $subscr_id);
126			$protocolObj->setVar('protocol_status', $protocol_status);
127			$protocolObj->setVar('protocol_success', $protocol_success);
128			$protocolObj->setVar('protocol_submitter', $senderUid);
129			$protocolObj->setVar('protocol_created', time());
130
131			if ($helper->getHandler('Protocol')->insert($protocolObj)) {
132			return true;
133			}
134			return $protocolObj->getHtmlErrors();
135			}
136
137			if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL) {
138
139			$action_code = $mailinglist_target;
140			if (substr($action_code, -1) !== '/') {
141			$action_code .= '/';
142			}
143			$action_code .= 'mailman/admin/';
144			$action_code .= $mailinglist_listname;
145			$action_code .= '/members/';
146
147			if (_XNEWSLETTER_MAILINGLIST_SUBSCRIBE == $type) {
148			$action_code .= 'add?subscribe_or_invite=0&send_welcome_msg_to_this_batch=0&notification_to_list_owner=' . $mailinglist_notifyowner;
149			$action_code .= '&subscribees_upload=';
150			} else {
151			$action_code .= 'remove?send_unsub_ack_to_this_batch=0&send_unsub_notifications_to_list_owner=' . $mailinglist_notifyowner;
152			$action_code .= '&unsubscribees_upload=';
153			}
154			$action_code .= $subscr_email;
155			$action_code .= '&adminpw=' . $mailinglist_pwd;
156			//echo "action_code:".$action_code;
157
158			try {
159			$req = curl_init();
160			curl_setopt($req, CURLOPT_URL, $action_code);
161			curl_setopt($req, CURLOPT_RETURNTRANSFER, true);
162
163			$res_curl = curl_exec($req);
			0 ignored issues – show Unused Code introduced 2020-01-16 20:28 UTC by Report Bug Copy Issue Report `$res_curl` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
164
165			if(!curl_errno($req)){
166			$status = (int)curl_getinfo($req, CURLINFO_HTTP_CODE);
167			if ($status === 200) {
168			$protocol_status = str_replace('%a', $subscr_email, _AM_XNEWSLETTER_SEND_SUCCESS_ML_DETAIL);
169			$protocol_status = str_replace('%m', $mailinglist_listname, $protocol_status);
170			$protocol_success = true;
171			} else {
172			$protocol_success = false;
173			$protocol_status = 'Curl error: ' . curl_error($req);
174			}
175			} else {
176			$protocol_success = false;
177			$protocol_status = 'Curl error: ' . curl_error($req);
178			}
179			} catch (\Exception $e) {
180			$protocol_status = _AM_XNEWSLETTER_SEND_ERROR_PHPMAILER; //error messages
181			$protocol_success = false;
182			$helper->addLog($e);
183			}
184			curl_close($req);
185			//create item in protocol for this email
186			$text_clean = ['<strong>', '</strong>', '<br/>', '<br>'];
187			$protocol_status = str_replace($text_clean, '', $protocol_status);
188
189			$protocolObj = $helper->getHandler('Protocol')->create();
190			$protocolObj->setVar('protocol_letter_id', 0);
191			$protocolObj->setVar('protocol_subscriber_id', $subscr_id);
192			$protocolObj->setVar('protocol_status', $protocol_status);
193			$protocolObj->setVar('protocol_success', $protocol_success);
194			$protocolObj->setVar('protocol_submitter', $senderUid);
195			$protocolObj->setVar('protocol_created', time());
196
197			if ($helper->getHandler('Protocol')->insert($protocolObj)) {
198			return true;
199			}
200			return $protocolObj->getHtmlErrors();
201			}
202			return null;
203			}
204
205			function getActioncode ($mailinglist_id = 0) {
206			$helper = XoopsModules\Xnewsletter\Helper::getInstance();
207
208			// get mailinglist
209			$mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglist_id);
210			$mailinglist_listname = $mailinglistObj->getVar('mailinglist_listname');
211			$mailinglist_system = (int)$mailinglistObj->getVar('mailinglist_system');
212			$mailinglist_target = $mailinglistObj->getVar('mailinglist_target');
213			$mailinglist_pwd = $mailinglistObj->getVar('mailinglist_pwd');
214
215			if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL) {
216
217			$action_code = $mailinglist_target;
218			if (substr($action_code, -1) !== '/') {
219			$action_code .= '/';
220			}
221			$action_code .= 'mailman/admin/';
222			$action_code .= $mailinglist_listname;
223			$action_code .= '/members/list?adminpw=' . $mailinglist_pwd;
224
225			return $action_code;
226			}
227			return null;
228			}
229

XoopsModules25x / xnewsletter

Push — master ( 819fc9...f42eea )

mailinglist.php ➔ getActioncode() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like