onupdate.php ➔ xoops_module_update_xnewsletter_130()

Complexity

Conditions	10
Paths	192

Size

Total Lines

113

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function xoops_module_update_xnewsletter_130()
{
    // change module dirname to lowercase
    $path    = dirname(__DIR__);
    $dirname = basename(dirname(__DIR__));
    rename($path, mb_strtolower($dirname));
    // update module dirname field in database to lowercase
    global $xoopsDB;
    $sql    = "UPDATE `{$xoopsDB->prefix('modules')}` SET `dirname` = '" . mb_strtolower($dirname) . "'";
    $sql    .= " WHERE LOWER(`dirname`) = '" . mb_strtolower($dirname) . "';";
    $result = $xoopsDB->queryF($sql);
    if (!$result) {
        echo '<br>' . _MI_XNEWSLETTER_UPGRADEFAILED . ": UPDATE 'modules' SET `dirname` = '" . mb_strtolower($dirname) . "'";
    }

    // reverse 'mod_' prefix on tables
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_accounts');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_attachment');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_bmh');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_cat');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_catsubscr');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_import');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_letter');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_mailinglist');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_protocol');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_subscr');
    xoops_module_update_xnewsletter_rename_mod_table('xnewsletter_task');
    $sql = sprintf('DROP TABLE IF EXISTS `' . $xoopsDB->prefix('xnewsletter_template') . '`');

$sql is not used, you could remove the assignment.

    // create 'xnewsletter_template' table
    global $xoopsDB;
    $sql    = sprintf('DROP TABLE IF EXISTS `' . $xoopsDB->prefix('xnewsletter_template') . '`');
    $result = $xoopsDB->queryF($sql);
    if (!$result) {
        echo '<br>' . _AM_XNEWSLETTER_UPGRADEFAILED . ": 'DROP TABLE 'xnewsletter_template'";
    }

    $sql    = '
        CREATE TABLE `' . $xoopsDB->prefix('xnewsletter_template') . "` (
        `template_id` INT (8)   NOT NULL  AUTO_INCREMENT,
        `template_title` VARCHAR (100)   NOT NULL DEFAULT '',
        `template_description` TEXT   NOT NULL DEFAULT '',
        `template_content` TEXT   NOT NULL DEFAULT '',
        `template_submitter` INT (8)   NOT NULL DEFAULT '0',
        `template_created` INT (8)   NOT NULL DEFAULT '0',
        PRIMARY KEY (`template_id`)
        ) ENGINE=MyISAM;";
    $result = $xoopsDB->queryF($sql);
    if (!$result) {
        echo '<br>' . _MI_XNEWSLETTER_UPGRADEFAILED . ": CREATE TABLE 'xnewsletter_template'";
    }

    // add fields to 'xnewsletter_cat' table
    global $xoopsDB;
    $sql    = 'ALTER TABLE `' . $xoopsDB->prefix('xnewsletter_cat') . '`';
    $sql    .= " ADD COLUMN `dohtml` tinyint(1) NOT NULL default '0',";
    $sql    .= " ADD COLUMN `dosmiley` tinyint(1) NOT NULL default '1',";
    $sql    .= " ADD COLUMN `doxcode` tinyint(1) NOT NULL default '1',";
    $sql    .= " ADD COLUMN `doimage` tinyint(1) NOT NULL default '1',";
    $sql    .= " ADD COLUMN `dobr` tinyint(1) NOT NULL default '1';";
    $result = $xoopsDB->queryF($sql);
    if (!$result) {
        echo '<br>' . _MI_XNEWSLETTER_UPGRADEFAILED . ": ALTER TABLE 'xnewsletter_cat' ADD";
    }

    // add fields to 'xnewsletter_letter' table
    global $xoopsDB;
    $sql    = 'ALTER TABLE `' . $xoopsDB->prefix('xnewsletter_letter') . '`';
    $sql    .= " ADD COLUMN `letter_sender` int(8) NOT NULL default '0',";
    $sql    .= " ADD COLUMN `letter_sent` int(10) NOT NULL default '0';";
    $result = $xoopsDB->queryF($sql);
    if (!$result) {
        echo '<br>' . _MI_XNEWSLETTER_UPGRADEFAILED . ": ALTER TABLE 'xnewsletter_letter' ADD";
    }

    // add fields to 'xnewsletter_attachment' table
    global $xoopsDB;
    $sql    = 'ALTER TABLE `' . $xoopsDB->prefix('xnewsletter_attachment') . '`';
    $sql    .= " ADD COLUMN `attachment_size` int(8) NOT NULL default '0',";
    $sql    .= " ADD COLUMN `attachment_mode` int(8) NOT NULL default '0';";
    $result = $xoopsDB->queryF($sql);
    if (!$result) {
        echo '<br>' . _MI_XNEWSLETTER_UPGRADEFAILED . ": ALTER TABLE 'xnewsletter_attachment' ADD";
    }

    // delete old html template files
    $templateDirectory = XOOPS_ROOT_PATH . '/modules/' . $dirname . '/templates/';
    $template_list     = array_diff(scandir($templateDirectory, SCANDIR_SORT_NONE), ['..', '.']);
    foreach ($template_list as $k => $v) {
        $fileinfo = new \SplFileInfo($templateDirectory . $v);
        if ('html' === $fileinfo->getExtension() && 'index.html' !== $fileinfo->getFilename()) {
            @unlink($templateDirectory . $v);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }
    }
    // Load class XoopsFile
    xoops_load('xoopsfile');

    //delete /images directory
    $imagesDirectory = XOOPS_ROOT_PATH . '/modules/' . $dirname . '/images/';
    $folderHandler   = XoopsFile::getHandler('folder', $imagesDirectory);
    $folderHandler->delete($imagesDirectory);

    //delete /templates/style.css file
    $cssFile       = XOOPS_ROOT_PATH . '/modules/' . $dirname . '/templates/style.css';
    $folderHandler = XoopsFile::getHandler('file', $cssFile);
    $folderHandler->delete($cssFile);

    //delete .html entries from the tpl table
    $sql = 'DELETE FROM ' . $GLOBALS['xoopsDB']->prefix('tplfile') . " WHERE LOWER(`tpl_module`) = '" . mb_strtolower($dirname) . "' AND `tpl_file` LIKE '%.html%'";
    $GLOBALS['xoopsDB']->queryF($sql);

    return true;
}