View GitHub Repository xnewsletter

Schedule Inspection
Subscribe

Code Duplication    Length = 7-7 lines in 2 locations

include/onupdate.php 2 locations

@@ 73-79 (lines=7) @@
70 

                                

                                                            

                                    71
                                    
                                    
    $helper = \XoopsModules\Xnewsletter\Helper::getInstance();

                                

                                                            

                                    72
                                    
                                    
    $subscrAll = $helper->getHandler('Subscr')->getAll();

                                

                                                            

                                    73
                                    
                                    
    foreach ($subscrAll as $subscr_id => $subscrObj) {

                                

                                                            

                                    74
                                    
                                    
        if ($subscrObj->getVar('subscr_actkey') == '') {

                                

                                                            

                                    75
                                    
                                    
            $subscrObj->setVar('subscr_actkey', xoops_makepass());

                                

                                                            

                                    76
                                    
                                    
            $helper->getHandler('Subscr')->insert($subscrObj, true);

                                

                                                            

                                    77
                                    
                                    
        }

                                

                                                            

                                    78
                                    
                                    
        unset($subscrObj);

                                

                                                            

                                    79
                                    
                                    
    }

                                

                                                            

                                    80
                                    
                                    

                                

                                                            

                                    81
                                    
                                    
    return true;

                                

                                                            

                                    82
                                    
                                    
}

                                

                                                                                

                                
                                
                                    @@ 92-98 (lines=7) @@
                                
                            


                                                            

                                    89
                                    
                                    

                                

                                                            

                                    90
                                    
                                    
    $helper = \XoopsModules\Xnewsletter\Helper::getInstance();

                                

                                                            

                                    91
                                    
                                    
    $subscrAll = $helper->getHandler('Subscr')->getAll();

                                

                                                            

                                    92
                                    
                                    
    foreach ($subscrAll as $subscr_id => $subscrObj) {

                                

                                                            

                                    93
                                    
                                    
        if ($subscrObj->getVar('subscr_actkey') == '') {

                                

                                                            

                                    94
                                    
                                    
            $subscrObj->setVar('subscr_actkey', xoops_makepass());

                                

                                                            

                                    95
                                    
                                    
            $helper->getHandler('Subscr')->insert($subscrObj, true);

                                

                                                            

                                    96
                                    
                                    
        }

                                

                                                            

                                    97
                                    
                                    
        unset($subscrObj);

                                

                                                            

                                    98
                                    
                                    
    }

                                

                                                            

                                    99
                                    
                                    
    

                                

                                                            

                                    100
                                    
                                    
    $sql    = 'ALTER TABLE `' . $xoopsDB->prefix('xnewsletter_letter') . '`';

                                

                                                            

                                    101
                                    
                                    
    $sql    .= " ADD COLUMN `letter_templateid` int(8) NOT NULL default '1' AFTER `letter_content`;";