Issues in core.php - New Issues - Inspection of "Merge pull request #7 from mambax7/master" - XoopsModules25x/xlanguage - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 98eeb4...22887c )

by Michael

created 2017-09-03 01:06 UTC

preloads/core.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Extended Language
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         http://www.gnu.org/licenses/gpl-2.0.html GNU Public License
 * @package         xlanguage
 * @author          trabis <[email protected]>
 */

// defined('XOOPS_ROOT_PATH') || exit('Restricted access.');


/**
 * Xlanguage core preloads
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         http://www.gnu.org/licenses/gpl-2.0.html GNU Public License
 * @author          trabis <[email protected]>
 */
class XlanguageCorePreload extends XoopsPreloadItem
{
    /**
     * @param $args
     */
    public static function eventCoreIncludeCommonLanguage($args)
    {
        global $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}
        require_once __DIR__ . '/../api.php';
    }
}


Push — master ( 98eeb4...22887c )

preloads/core.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* Extended Language
4			*
5			* You may not change or alter any portion of this comment or credits
6			* of supporting developers from this source code or any supporting source code
7			* which is considered copyrighted (c) material of the original comment or credit authors.
8			* This program is distributed in the hope that it will be useful,
9			* but WITHOUT ANY WARRANTY; without even the implied warranty of
10			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11			*
12			* @copyright XOOPS Project (https://xoops.org)
13			* @license http://www.gnu.org/licenses/gpl-2.0.html GNU Public License
14			* @package xlanguage
15			* @author trabis <[email protected]>
16			*/
17
18			// defined('XOOPS_ROOT_PATH') \|\| exit('Restricted access.');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-09-03 01:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
19
20			/**
21			* Xlanguage core preloads
22			*
23			* @copyright XOOPS Project (https://xoops.org)
24			* @license http://www.gnu.org/licenses/gpl-2.0.html GNU Public License
25			* @author trabis <[email protected]>
26			*/
27			class XlanguageCorePreload extends XoopsPreloadItem
28			{
29			/**
30			* @param $args
31			*/
32			public static function eventCoreIncludeCommonLanguage($args)
33			{
34			global $xoopsConfig;
			0 ignored issues – show Compatibility Best Practice introduced 2017-08-04 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
35			require_once __DIR__ . '/../api.php';
36			}
37			}
38

XoopsModules25x / xlanguage

Push — master ( 98eeb4...22887c )

preloads/core.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like