functions.php ➔ xlanguage_ml() - Code Metrics - Inspection of "Merge pull request #7 from mambax7/master" - XoopsModules25x/xlanguage - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 98eeb4...22887c )

by Michael

created 2017-09-03 01:06 UTC

functions.php ➔ xlanguage_ml() C

↳ Parent: Project

Complexity

Conditions	10
Paths	50

Size

Total Lines	60
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	34
nc	50
nop	1
dl	0
loc	60
rs	6.5333
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
/**
 * xLanguage module (eXtensible Language Management For XOOPS)
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright    XOOPS Project (https://xoops.org)
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU Public License}
 * @package      xlanguage
 * @since        2.0
 * @author       D.J.(phppp) [email protected]
 * @param $value
 * @param $out_charset
 * @param $in_charset
 * @return array|string
 */

function xlanguage_convert_encoding($value, $out_charset, $in_charset)
{
    if (is_array($value)) {
        foreach ($value as $key => $val) {
            $value[$key] = xlanguage_convert_encoding($val, $out_charset, $in_charset);
        }
    } else {
        $value = xlanguage_convert_item($value, $out_charset, $in_charset);
    }

    return $value;
}

/**
 * @param $value
 * @param $out_charset
 * @param $in_charset
 * @return string
 */
function xlanguage_convert_item($value, $out_charset, $in_charset)
{
    if (strtolower($in_charset) == strtolower($out_charset)) {
        return $value;
    }
    $xconvHandler = @xoops_getModuleHandler('xconv', 'xconv', true);
    if (is_object($xconvHandler) && $converted_value = @$xconvHandler->convert_encoding($value, $out_charset, $in_charset)) {
        return $converted_value;
    }
    if (XOOPS_USE_MULTIBYTES && function_exists('mb_convert_encoding')) {
        $converted_value = @mb_convert_encoding($value, $out_charset, $in_charset);
    } elseif (function_exists('iconv')) {
        $converted_value = @iconv($in_charset, $out_charset, $value);
    }
    $value = empty($converted_value) ? $value : $converted_value;

    return $value;
}

/**
 * @return mixed
 */
function xlanguage_createConfig()
{
    /** @var \XlanguageLanguageHandler $xlanguageHandler */
    $xlanguageHandler = xoops_getModuleHandler('language', 'xlanguage');

    return $xlanguageHandler->createConfig();
}

/**
 * @return mixed
 */
function xlanguage_loadConfig()
{
    /** @var \XlanguageLanguageHandler $xlanguageHandler */
    $xlanguageHandler = xoops_getModuleHandler('language', 'xlanguage');
    $config       = $xlanguageHandler->loadFileConfig();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

    return $config;
}

/**
 * Analyzes some PHP environment variables to find the most probable language
 * that should be used
 *
 * @param  string $str
 * @param  string $envType
 * @return int|string
 * @internal param $string $ string to analyze
 * @internal param $integer $ type of the PHP environment variable which value is $str
 *
 * @global        array    the list of available translations
 * @global        string   the retained translation keyword
 * @access   private
 */
function xlanguage_lang_detect($str = '', $envType = '')
{
    global $available_languages;
function myFunction($a, $b) {
    // Do something
}
    $lang = '';

    if (!empty($available_languages)) {
        foreach ($available_languages as $key => $value) {
            // $envType =  1 for the 'HTTP_ACCEPT_LANGUAGE' environment variable,
            //             2 for the 'HTTP_USER_AGENT' one
            $expr = $value[0];
            if (strpos($expr, '[-_]') === false) {
                $expr = str_replace('|', '([-_][[:alpha:]]{2,3})?|', $expr);
            }
            //        if (($envType == 1 && eregi('^(' . $expr . ')(;q=[0-9]\\.[0-9])?$', $str))

            //            || ($envType == 2 && eregi('(\(|\[|;[[:space:]])(' . $expr . ')(;|\]|\))', $str))) {

            if (($envType == 1 && preg_match('#^(' . $expr . ')(;q=[0-9]\\.[0-9])?$#i', $str)) || ($envType == 2 && preg_match('#(\(|\[|;[[:space:]])(' . $expr . ')(;|\]|\))#i', $str))) {
                $lang = $key;
                //if($lang != 'en')

                break;
            }
        }
    }

    return $lang;
}

/**
 * @return string
 */
function xlanguage_detectLang()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $available_languages, $_SERVER;
function myFunction($a, $b) {
    // Do something
}

    if (!empty($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
        $HTTP_ACCEPT_LANGUAGE = $_SERVER['HTTP_ACCEPT_LANGUAGE'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    if (!empty($_SERVER['HTTP_USER_AGENT'])) {
        $HTTP_USER_AGENT = $_SERVER['HTTP_USER_AGENT'];
    }

    $lang       = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $xoops_lang = '';
    // 1. try to findout user's language by checking its HTTP_ACCEPT_LANGUAGE variable

    //    if (empty($lang) && !empty($HTTP_ACCEPT_LANGUAGE)) {

    //        $accepted    = explode(',', $HTTP_ACCEPT_LANGUAGE);

    //        $acceptedCnt = count($accepted);

    //        reset($accepted);

    //        for ($i = 0; $i < $acceptedCnt; ++$i) {

    //            $lang = xlanguage_lang_detect($accepted[$i], 1);

    //            if (strncasecmp($lang, 'en', 2)) {

    //                break;
    //            }
    //        }
    //    }

    //This returns the most preferred langauage "q=1"
    $lang = getPreferredLanguage();

    // 2. if not found in HTTP_ACCEPT_LANGUAGE, try to find user's language by checking its HTTP_USER_AGENT variable
    if (empty($lang) && !empty($HTTP_USER_AGENT)) {
        $lang = xlanguage_lang_detect($HTTP_USER_AGENT, 2);
    }
    // 3. If we catch a valid language, configure it
    if (!empty($lang)) {
        $xoops_lang = $available_languages[$lang][1];
    }

    return $xoops_lang;
}

/**
 * @param $output
 * @return array|mixed|string
 */
function xlanguage_encoding($output)
{
    global $xlanguage;
function myFunction($a, $b) {
    // Do something
}
    $output = xlanguage_ml($output);
    // escape XML doc
    if (preg_match("/^\<\?[\s]?xml[\s]+version=([\"'])[^\>]+\\1[\s]+encoding=([\"'])[^\>]+\\2[\s]?\?\>/i", $output)) {
        return $output;
    }
    $in_charset  = $xlanguage['charset_base'];
    $out_charset = $xlanguage['charset'];

    $output = xlanguage_convert_encoding($output, $out_charset, $in_charset);
    return $output;
}

/**
 * @param $s
 * @return mixed
 */
function xlanguage_ml($s)
{
    global $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}
    global $xlanguage_langs;
function myFunction($a, $b) {
    // Do something
}
    if (!isset($xlanguage_langs)) {

        /** @var \XlanguageLanguageHandler $xlanguageHandler */
        $xlanguageHandler = xoops_getModuleHandler('language', 'xlanguage');
        $langs            = $xlanguageHandler->getAll(true);
        //        $langs = $GLOBALS['xlanguageHandler']->getAll(true); //mb

        foreach (array_keys($langs) as $_lang) {
            $xlanguage_langs[$_lang] = $langs[$_lang]->getVar('lang_code');
        }
        unset($langs);
    }
    if (empty($xlanguage_langs) || count($xlanguage_langs) == 0) {
        return $s;
    }

    // escape brackets inside of <code>...</code>
    $patterns[] = '/(\<code>.*\<\/code>)/isU';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

    // escape brackets inside of <input type="..." value="...">
    $patterns[] = '/(\<input\b(?![^\>]*\btype=([\'"]?)(submit|image|reset|button))[^\>]*\>)/isU';

    // escape brackets inside of <textarea></textarea>
    $patterns[] = '/(\<textarea\b[^>]*>[^\<]*\<\/textarea>)/isU';

    $s = preg_replace_callback($patterns, 'xlanguage_ml_escape_bracket', $s);

    // create the pattern between language tags
    $pqhtmltags  = explode(',', preg_quote(XLANGUAGE_TAGS_RESERVED, '/'));
    $mid_pattern = '(?:(?!(' . implode('|', $pqhtmltags) . ')).)*';

    $patterns = array();
    $replaces = array();
    /* */
    if (isset($xlanguage_langs[$xoopsConfig['language']])) {
        $lang       = $xlanguage_langs[$xoopsConfig['language']];
        $patterns[] = '/(\[([^\]]*\|)?' . preg_quote($lang) . '(\|[^\]]*)?\])(' . $mid_pattern . ')(\[\/([^\]]*\|)?' . preg_quote($lang) . '(\|[^\]]*)?\])/isU';
        $replaces[] = '$4';
    }
    /* */
    foreach (array_keys($xlanguage_langs) as $_lang) {
        if ($_lang == @$xoopsConfig['language']) {
            continue;
        }
        $name       = $xlanguage_langs[$_lang];
        $patterns[] = '/(\[([^\]]*\|)?' . preg_quote($name) . '(\|[^\]]*)?\])(' . $mid_pattern . ')(\[\/([^\]]*\|)?' . preg_quote($name) . '(\|[^\]]*)?(\]\<br[\s]?[\/]?\>|\]))/isU';
        $replaces[] = '';
    }
    if (!empty($xoopsConfig['language'])) {
        $s = preg_replace('/\[[\/]?[\|]?' . preg_quote($xoopsConfig['language']) . '[\|]?\](\<br \/\>)?/i', '', $s);
    }
    if (count($replaces) > 0) {
        $s = preg_replace($patterns, $replaces, $s);
    }

    return $s;
}

/**
 * @param $matches
 * @return mixed
 */
function xlanguage_ml_escape_bracket($matches)
{
    global $xlanguage_langs;
function myFunction($a, $b) {
    // Do something
}
    $ret = $matches[1];
    if (!empty($xlanguage_langs)) {
        $pattern = '/(\[([\/])?(' . implode('|', array_map('preg_quote', array_values($xlanguage_langs))) . ')([\|\]]))/isU';
        $ret     = preg_replace($pattern, "&#91;\\2\\3\\4", $ret);
    }

    return $ret;
}

/**
 * @param  null $options
 * @return bool
 */
function xlanguage_select_show($options = null)
{
    require_once XOOPS_ROOT_PATH . '/modules/xlanguage/blocks/xlanguage_blocks.php';
    if (empty($options)) {
        $options[0] = 'images'; // display style: image, text, select
        $options[1] = ' '; // delimitor
        $options[2] = 5; // items per line
    }

    $block        = b_xlanguage_select_show($options);
    $block['tag'] = 'xlanguage';

    $content = '';
    $i       = 1;
    if (!empty($block['display'])) { //mb
        if (in_array($block['display'], array('images', 'text'))) {
            foreach ($block['languages'] as $name => $lang) {
                $content .= '<a href="' . $block['url'] . $lang['name'] . '" title="' . $lang['desc'] . '">';
                if ($block['display'] === 'images') {
                    $content .= '<img src="' . $lang['image'] . '" alt="' . $lang['desc'] . '"';
                    if ($block['selected'] != $lang['name']) {
                        $content .= ' style="MozOpacity: .8; opacity: .8; filter:Alpha(opacity=80);"';
                    }
                    $content .= '>';
                } else {
                    $content .= $lang['desc'];
                }
                $content .= '</a>';
                if ((++$i % $block['number']) == 0) {
                    $content .= '<br>';
                }
            }
        } else {
            $content .= '<select name="' . $block['tag'] . '"
                onChange="if (this.options[this.selectedIndex].value.length >0) { window.document.location=this.options[this.selectedIndex].value;}"
                >';
            if (!empty($block['languages'])) { //mb
                foreach ($block['languages'] as $name => $lang) {

                    $content .= '<option value="' . $block['url'] . $lang['name'] . '"';
                    if ($block['selected'] == $lang['name']) {
                        $content .= ' selected ';
                    }
                    $content .= '>' . $lang['desc'] . '</option>';
                }
            }
            $content .= '</select>';
        }
    }

    define('XLANGUAGE_SWITCH_CODE', $content);

    return true;
}

/**
 * @return int|string
 */
function getPreferredLanguage()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    $langs = array();
    if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
        // break up string into pieces (languages and q factors)
        preg_match_all('/([a-z]{1,8}(-[a-z]{1,8})?)\s*(;\s*q\s*=\s*(1|0\.\d+))?/i', $_SERVER['HTTP_ACCEPT_LANGUAGE'], $lang_parse);
        if (count($lang_parse[1])) {
            // create a list like "en" => 0.8
            $langs = array_combine($lang_parse[1], $lang_parse[4]);
            // set default to 1 for any without q factor
            foreach ($langs as $lang => $val) {
                if ($val === '') {
                    $langs[$lang] = 1;
                }
            }
            // sort list based on value
            arsort($langs, SORT_NUMERIC);
        }
    }
    //extract most important (first)
    foreach ($langs as $lang => $val) {
        break;
    }
    //if complex language simplify it
    if (strstr($lang, '-')) {
        $tmp  = explode('-', $lang);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $lang = $tmp[0];
    }

    return $lang;
}


Push — master ( 98eeb4...22887c )

functions.php ➔ xlanguage_ml() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1			<?php
2			/**
3			* xLanguage module (eXtensible Language Management For XOOPS)
4			*
5			* You may not change or alter any portion of this comment or credits
6			* of supporting developers from this source code or any supporting source code
7			* which is considered copyrighted (c) material of the original comment or credit authors.
8			* This program is distributed in the hope that it will be useful,
9			* but WITHOUT ANY WARRANTY; without even the implied warranty of
10			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11			*
12			* @copyright XOOPS Project (https://xoops.org)
13			* @license {@link http://www.gnu.org/licenses/gpl-2.0.html GNU Public License}
14			* @package xlanguage
15			* @since 2.0
16			* @author D.J.(phppp) [email protected]
17			* @param $value
18			* @param $out_charset
19			* @param $in_charset
20			* @return array\|string
21			*/
22
23			function xlanguage_convert_encoding($value, $out_charset, $in_charset)
24			{
25			if (is_array($value)) {
26			foreach ($value as $key => $val) {
27			$value[$key] = xlanguage_convert_encoding($val, $out_charset, $in_charset);
28			}
29			} else {
30			$value = xlanguage_convert_item($value, $out_charset, $in_charset);
31			}
32
33			return $value;
34			}
35
36			/**
37			* @param $value
38			* @param $out_charset
39			* @param $in_charset
40			* @return string

XoopsModules25x / xlanguage

Push — master ( 98eeb4...22887c )

functions.php ➔ xlanguage_ml() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Duplication Side-by-Side

Filter issues like