Xlanguage

Complexity

Total Complexity

1

Size/Duplication

Total Lines	13
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1

<?php
/**
 * xLanguage module (eXtensible Language Management For XOOPS)
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright    XOOPS Project (https://xoops.org)
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU Public License}
 * @package      xlanguage
 * @since        2.0
 * @author       D.J.(phppp) php_pp@hotmail.com
 **/

//include_once(XOOPS_ROOT_PATH."/class/xoopslists.php");

66% of this comment could be valid code. Did you maybe forget this after debugging?

//include_once(XOOPS_ROOT_PATH.'/modules/xlanguage/include/vars.php');
//include_once(XOOPS_ROOT_PATH.'/modules/xlanguage/include/functions.php');

/**
 * Class Blanguage
 */
class Blanguage extends XoopsObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public $isBase;

    /**
     * Blanguage constructor.
     */
    public function __construct()
    {
        $this->db    = XoopsDatabaseFactory::getDatabaseConnection();
        $this->table = $this->db->prefix('xlanguage_base');
        $this->initVar('lang_id', XOBJ_DTYPE_INT);
        $this->initVar('weight', XOBJ_DTYPE_INT);
        $this->initVar('lang_name', XOBJ_DTYPE_TXTBOX);
        $this->initVar('lang_desc', XOBJ_DTYPE_TXTBOX);
        $this->initVar('lang_code', XOBJ_DTYPE_TXTBOX);
        $this->initVar('lang_charset', XOBJ_DTYPE_TXTBOX);
        $this->initVar('lang_image', XOBJ_DTYPE_TXTBOX);
    }

    /**
     * @return bool
     */
    public function prepareVars()
    {
        foreach ($this->vars as $k => $v) {
            $cleanv = $this->cleanVars[$k];
            switch ($v['data_type']) {
                case XOBJ_DTYPE_TXTBOX:
                case XOBJ_DTYPE_TXTAREA:
                case XOBJ_DTYPE_SOURCE:
                case XOBJ_DTYPE_EMAIL:
                    $cleanv = $v['changed'] ? $cleanv : '';
                    if (!isset($v['not_gpc']) || !$v['not_gpc']) {
                        $cleanv = $this->db->quoteString($cleanv);
                    }
                    break;
                case XOBJ_DTYPE_INT:
                    $cleanv = $v['changed'] ? (int)$cleanv : 0;
                    break;
                case XOBJ_DTYPE_ARRAY:
                    $cleanv = $v['changed'] ? $cleanv : serialize(array());
                    break;
                case XOBJ_DTYPE_STIME:
                case XOBJ_DTYPE_MTIME:
                case XOBJ_DTYPE_LTIME:
                    $cleanv = $v['changed'] ? $cleanv : 0;
                    break;

                default:
                    break;
            }
            $this->cleanVars[$k] =& $cleanv;
            unset($cleanv);
        }

        return true;
    }

    public function setBase()
    {
        $this->isBase = true;
    }

    /**
     * @return mixed
     */
    public function hasBase()
    {
        return $this->isBase;
    }
}

/**
 * Class Xlanguage
 */
class Xlanguage extends Blanguage

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * Xlanguage constructor.
     */
    public function __construct()
    {
        parent::__construct();
        $this->table = $this->db->prefix('xlanguage_ext');
        $this->initVar('lang_base', XOBJ_DTYPE_TXTBOX);
        $this->isBase = false;
    }
}

/**
 * Class XlanguageLanguageHandler
 */
class XlanguageLanguageHandler extends XoopsObjectHandler

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public $cached_config;

    public function loadConfig()
    {
        $this->cached_config = $this->loadFileConfig();

Are you sure the assignment to $this->cached_config is correct as $this->loadFileConfig() (which targets XlanguageLanguageHandler::loadFileConfig()) seems to always return null.

    }

    /**
     * @param int  $id
     * @param bool $isBase
     *
     * @return Blanguage|null|Xlanguage
     */
    public function get($id, $isBase = true)
    {
        $lang = null;
        $id   = (int)$id;
        if (!$id) {
            return $lang;
        }
        $prefix = $isBase ? 'xlanguage_base' : 'xlanguage_ext';
        if (isset($this->cached_config[$prefix][$id])) {
            $array = $this->cached_config[$prefix][$id];
        } else {
            $sql   = 'SELECT * FROM ' . $this->db->prefix($prefix) . ' WHERE lang_id=' . $id;
            $array = $this->db->fetchArray($this->db->query($sql));
        }
        if (!is_array($array) || count($array) == 0) {
            return $lang;
        }
        $lang = $this->create(false, $isBase);
        $lang->assignVars($array);
        if ($isBase) {
            $lang->isBase = true;
        }

        return $lang;
    }

    /**
     * @param $name
     *
     * @return Blanguage|null|Xlanguage
     */
    public function getByName($name)
    {
        $lang = null;
        if (empty($name) || preg_match("/[^a-zA-Z0-9\_\-]/", $name)) {
            return $lang;
        }
        $isBase = false;
        if (isset($this->cached_config['xlanguage_base'][$name])) {
            $array  = $this->cached_config['xlanguage_base'][$name];
            $isBase = true;
        } elseif (isset($this->cached_config['xlanguage_ext'][$name])) {
            $array = $this->cached_config['xlanguage_ext'][$name];
        } elseif (!isset($this->cached_config)) {
            $sql    = 'SELECT * FROM ' . $this->db->prefix('xlanguage_base') . ' WHERE lang_name=\'' . $name . '\'';
            $result = $this->db->query($sql);
            $array  = $this->db->fetchArray($result);
            if (!is_array($array) || count($array) == 0) {
                $sql    = 'SELECT * FROM ' . $this->db->prefix('xlanguage_ext') . ' WHERE lang_name=\'' . $name . '\'';
                $result = $this->db->query($sql);
                $array  = $this->db->fetchArray($result);
                if (!is_array($array) || count($array) == 0) {
                    return $lang;
                }
            } else {
                $isBase = true;
            }
        }
        if (empty($array)) {
            return $lang;
        }
        $lang = $this->create(false, $isBase);
        $lang->assignVars($array);
        if (!isset($array['lang_base'])) {
            $lang->isBase = true;
        }

        return $lang;
    }

    /**
     * @param bool $isBase
     *
     * @return array
     */
    public function getAll($isBase = true)
    {
        $prefix = $isBase ? 'xlanguage_base' : 'xlanguage_ext';
        $ret    = array();
        if (isset($this->cached_config[$prefix])) {
            $array = $this->cached_config[$prefix];
            foreach ($array as $lang_name => $myrow) {
                $lang = $this->create(false, $isBase);
                $lang->assignVars($myrow);
                $ret[$myrow['lang_name']] =& $lang;
                unset($lang);
            }
        } elseif (!isset($this->cached_config)) {
            $sql    = 'SELECT * FROM ' . $this->db->prefix($prefix);
            $result = $this->db->query($sql);
            while ($myrow = $this->db->fetchArray($result)) {
                $lang = $this->create(false, $isBase);
                $lang->assignVars($myrow);
                $ret[$myrow['lang_name']] =& $lang;
                unset($lang);
            }
        }

        return $ret;
    }

    /**
     * @return array
     */
    public function getAllList()
    {
        $baseArray = $this->getAll();

        $extArray = $this->getAll(false);
        $ret      = array();
        if (is_array($baseArray) && count($baseArray) > 0) {
            foreach ($baseArray as $base) {
                $ret[$base->getVar('lang_name')]['base'] = $base;
                unset($base);
            }
        }
        if (is_array($extArray) && count($extArray) > 0) {
            foreach ($extArray as $ext) {
                $ret[$ext->getVar('lang_base')]['ext'][] = $ext;
                unset($ext);
            }
        }

        return $ret;
    }

    /**
     * @param bool $isNew
     * @param bool $isBase
     *
     * @return Blanguage|Xlanguage
     */
    public function create($isNew = true, $isBase = true)
    {
        if ($isBase) {
            $lang         = new Blanguage();
            $lang->isBase = true;
        } else {
            $lang = new Xlanguage();
        }
        if ($isNew) {
            $lang->setNew();
        }

        return $lang;
    }

    /**
     * @param  XoopsObject $object
     * @return bool
     * @internal param object $lang
     *
     */
    public function insert(XoopsObject $object)//insert(&$lang)
    {
        $lang = $object;
        if (!$lang->isDirty()) {
            return true;
        }
        if (!$lang->cleanVars()) {
            return false;
        }
        $lang->prepareVars();
        foreach ($lang->cleanVars as $k => $v) {
            ${$k} = $v;
        }

        if ($lang->isNew()) {
            $var_array = array(
                'lang_id',
                'weight',
                'lang_name',
                'lang_desc',
                'lang_code',
                'lang_charset',
                'lang_image',
                'lang_base'
            );
            if ($lang->isBase) {

This code seems to be duplicated across your project.

                $var_array = array(
                    'lang_id',
                    'weight',
                    'lang_name',
                    'lang_desc',
                    'lang_code',
                    'lang_charset',
                    'lang_image'
                );
            }
            $lang_id = $this->db->genId($lang->table . '_lang_id_seq');
            foreach ($var_array as $var) {
                $val_array[] = ${$var};

$val_array was never initialized. Although not strictly required by PHP, it is generally a good practice to add $val_array = array(); before regardless.

            }
            $sql = 'INSERT INTO ' . $lang->table . ' (' . implode(',', $var_array) . ') VALUES (' . implode(',', $val_array) . ')';

The variable $val_array does not seem to be defined for all execution paths leading up to this point.

            if (!$result = $this->db->queryF($sql)) {

This code seems to be duplicated across your project.

                xoops_error('Insert language error:' . $sql);

                return false;
            }
            if ($lang_id == 0) {
                $lang_id = $this->db->getInsertId();
            }
            $lang->setVar('lang_id', $lang_id);
        } else {
            $var_array = array(
                'weight',
                'lang_name',
                'lang_desc',
                'lang_code',
                'lang_charset',
                'lang_image',
                'lang_base'
            );
            if ($lang->isBase) {

This code seems to be duplicated across your project.

                $var_array = array('weight', 'lang_name', 'lang_desc', 'lang_code', 'lang_charset', 'lang_image');
            }
            $set_array = array();
            foreach ($var_array as $var) {
                $set_array[] = "$var = " . ${$var};
            }
            $set_string = implode(',', $set_array);
            $sql        = 'UPDATE ' . $lang->table . ' SET ' . $set_string . ' WHERE lang_id = ' . $lang->getVar('lang_id');
            if (!$result = $this->db->queryF($sql)) {

This code seems to be duplicated across your project.

                xoops_error('update language error:' . $sql);

                return false;
            }
        }
        $this->createConfig();

        return $lang->getVar('lang_id');
    }

    /**
     * @param  XoopsObject $lang
     * @return bool
     * @internal param object $lang
     *
     */
    public function delete(XoopsObject $lang)//delete(&$lang)
    {
        if (!is_object($lang) || !$lang->getVar('lang_id')) {
            return true;
        }
        $sql = 'DELETE FROM ' . $lang->table . ' WHERE lang_id= ' . $lang->getVar('lang_id');
        if (!$result = $this->db->query($sql)) {
            return false;
        }
        $this->createConfig();

        return true;
    }

    /**
     * @return array
     */
    public function getXoopsLangList()
    {
        return XoopsLists::getLangList();
    }

    /**
     * @return bool
     */
    public function createConfig()
    {
        $file_config = XLANGUAGE_CONFIG_FILE;
        @unlink($file_config);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        if (!$fp = fopen($file_config, 'w')) {
            echo '<br> the config file can not be created: ' . $file_config;

            return false;
        }

        $file_content = '<?php';
        unset($this->cached_config);
        $baseArray = $this->getAll();
        if (is_array($baseArray) && count($baseArray) > 0) {
            $file_content .= "\n    \$" . XLANGUAGE_CONFIG_VAR . "['xlanguage_base'] = array(";
            foreach ($baseArray as $lang) {
                $file_content .= "\n        \"" . $lang->getVar('lang_name') . '"=>array(';
                $file_content .= "\n            \"lang_id\"=>" . $lang->getVar('lang_id') . ',';
                $file_content .= "\n            \"weight\"=>" . $lang->getVar('weight') . ',';
                $file_content .= "\n            \"lang_name\"=>\"" . $lang->getVar('lang_name') . '",';
                $file_content .= "\n            \"lang_desc\"=>\"" . $lang->getVar('lang_desc') . '",';
                $file_content .= "\n            \"lang_code\"=>\"" . $lang->getVar('lang_code') . '",';
                $file_content .= "\n            \"lang_charset\"=>\"" . $lang->getVar('lang_charset') . '",';
                $file_content .= "\n            \"lang_image\"=>\"" . $lang->getVar('lang_image') . '"';
                $file_content .= "\n        ),";
            }
            $file_content .= "\n    );";
        }

        $extArray = $this->getAll(false);
        if (is_array($extArray) && count($extArray) > 0) {
            $file_content .= "\n    \$" . XLANGUAGE_CONFIG_VAR . "['xlanguage_ext'] = array(";
            foreach ($extArray as $lang) {
                $file_content .= "\n        \"" . $lang->getVar('lang_name') . '"=>array(';
                $file_content .= "\n            \"lang_id\"=>" . $lang->getVar('lang_id') . ',';
                $file_content .= "\n            \"weight\"=>" . $lang->getVar('weight') . ',';
                $file_content .= "\n            \"lang_name\"=>\"" . $lang->getVar('lang_name') . '",';
                $file_content .= "\n            \"lang_desc\"=>\"" . $lang->getVar('lang_desc') . '",';
                $file_content .= "\n            \"lang_code\"=>\"" . $lang->getVar('lang_code') . '",';
                $file_content .= "\n            \"lang_charset\"=>\"" . $lang->getVar('lang_charset') . '",';
                $file_content .= "\n            \"lang_image\"=>\"" . $lang->getVar('lang_image') . '",';
                $file_content .= "\n            \"lang_base\"=>\"" . $lang->getVar('lang_base') . '"';
                $file_content .= "\n        ),";
            }
            $file_content .= "\n    );";
        }

        $file_content .= "\n?>";
        fwrite($fp, $file_content);
        fclose($fp);

        return true;
    }

    /**
     * @return null
     */
    public function loadFileConfig()
    {
        $file_config = XLANGUAGE_CONFIG_FILE;
        if (!file_exists($file_config)) {
            $this->createConfig();
        }
        if (!is_readable($file_config)) {
            $config = null;

            return $config;
        } else {
            include $file_config;
            if (isset(${XLANGUAGE_CONFIG_VAR})) {
                return ${XLANGUAGE_CONFIG_VAR};
            } else {
                return false;
            }
        }
    }
}