This project does not seem to handle request data directly as such no vulnerable execution paths were found.
include
, or for example
via PHP's auto-loading mechanism.
1 | <?php declare(strict_types=1); |
||||||
2 | |||||||
3 | namespace XoopsModules\Xhttperror\Common; |
||||||
4 | |||||||
5 | /* |
||||||
6 | You may not change or alter any portion of this comment or credits |
||||||
7 | of supporting developers from this source code or any supporting source code |
||||||
8 | which is considered copyrighted (c) material of the original comment or credit authors. |
||||||
9 | |||||||
10 | This program is distributed in the hope that it will be useful, |
||||||
11 | but WITHOUT ANY WARRANTY; without even the implied warranty of |
||||||
12 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. |
||||||
13 | */ |
||||||
14 | |||||||
15 | /** |
||||||
16 | * @copyright XOOPS Project (https://xoops.org) |
||||||
17 | * @license http://www.fsf.org/copyleft/gpl.html GNU public license |
||||||
18 | * @author mamba <[email protected]> |
||||||
19 | */ |
||||||
20 | trait VersionChecks |
||||||
21 | { |
||||||
22 | /** |
||||||
23 | * Verifies XOOPS version meets minimum requirements for this module |
||||||
24 | * @static |
||||||
25 | * @param \XoopsModule|null $module |
||||||
26 | * |
||||||
27 | * @param null|string $requiredVer |
||||||
28 | * @return bool true if meets requirements, false if not |
||||||
29 | */ |
||||||
30 | public static function checkVerXoops(\XoopsModule $module = null, $requiredVer = null) |
||||||
31 | { |
||||||
32 | $moduleDirName = \basename(\dirname(__DIR__, 2)); |
||||||
33 | $moduleDirNameUpper = mb_strtoupper($moduleDirName); |
||||||
34 | if (null === $module) { |
||||||
35 | $module = \XoopsModule::getByDirname($moduleDirName); |
||||||
36 | } |
||||||
37 | xoops_loadLanguage('admin', $moduleDirName); |
||||||
38 | xoops_loadLanguage('common', $moduleDirName); |
||||||
39 | |||||||
40 | //check for minimum XOOPS version |
||||||
41 | $currentVer = mb_substr(XOOPS_VERSION, 6); // get the numeric part of string |
||||||
42 | if (null === $requiredVer) { |
||||||
43 | $requiredVer = '' . $module->getInfo('min_xoops'); //making sure it's a string |
||||||
0 ignored issues
–
show
Bug
introduced
by
Loading history...
|
|||||||
44 | } |
||||||
45 | $success = true; |
||||||
46 | |||||||
47 | if (version_compare($currentVer, $requiredVer, '<')) { |
||||||
48 | $success = false; |
||||||
49 | $module->setErrors(sprintf(constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_XOOPS'), $requiredVer, $currentVer)); |
||||||
50 | } |
||||||
51 | |||||||
52 | return $success; |
||||||
53 | } |
||||||
54 | |||||||
55 | /** |
||||||
56 | * Verifies PHP version meets minimum requirements for this module |
||||||
57 | * @static |
||||||
58 | * |
||||||
59 | * @return bool true if meets requirements, false if not |
||||||
60 | */ |
||||||
61 | public static function checkVerPhp(\XoopsModule $module = null) |
||||||
62 | { |
||||||
63 | $moduleDirName = \basename(\dirname(__DIR__, 2)); |
||||||
64 | $moduleDirNameUpper = mb_strtoupper($moduleDirName); |
||||||
65 | if (null === $module) { |
||||||
66 | $module = \XoopsModule::getByDirname($moduleDirName); |
||||||
67 | } |
||||||
68 | xoops_loadLanguage('admin', $moduleDirName); |
||||||
69 | xoops_loadLanguage('common', $moduleDirName); |
||||||
70 | |||||||
71 | // check for minimum PHP version |
||||||
72 | $success = true; |
||||||
73 | |||||||
74 | $verNum = PHP_VERSION; |
||||||
75 | $reqVer = &$module->getInfo('min_php'); |
||||||
76 | |||||||
77 | if (false !== $reqVer && '' !== $reqVer) { |
||||||
78 | if (version_compare($verNum, $reqVer, '<')) { |
||||||
0 ignored issues
–
show
It seems like
$reqVer can also be of type array ; however, parameter $version2 of version_compare() does only seem to accept string , maybe add an additional type check?
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
Loading history...
|
|||||||
79 | $module->setErrors(sprintf(constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_PHP'), $reqVer, $verNum)); |
||||||
0 ignored issues
–
show
It seems like
$reqVer can also be of type array ; however, parameter $values of sprintf() does only seem to accept double|integer|string , maybe add an additional type check?
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
Loading history...
|
|||||||
80 | $success = false; |
||||||
81 | } |
||||||
82 | } |
||||||
83 | |||||||
84 | return $success; |
||||||
85 | } |
||||||
86 | |||||||
87 | /** |
||||||
88 | * compares current module version with latest GitHub release |
||||||
89 | * @static |
||||||
90 | * @param \Xmf\Module\Helper $helper |
||||||
91 | * @param string|null $source |
||||||
92 | * @param string|null $default |
||||||
93 | * |
||||||
94 | * @return string|array info about the latest module version, if newer |
||||||
95 | */ |
||||||
96 | |||||||
97 | public static function checkVerModule($helper, $source = 'github', $default = 'master') |
||||||
98 | { |
||||||
99 | $moduleDirName = \basename(\dirname(__DIR__, 2)); |
||||||
100 | $moduleDirNameUpper = mb_strtoupper($moduleDirName); |
||||||
101 | $update = ''; |
||||||
102 | $repository = 'XoopsModules25x/' . $moduleDirName; |
||||||
103 | // $repository = 'XoopsModules25x/publisher'; //for testing only |
||||||
104 | $ret = ''; |
||||||
105 | $infoReleasesUrl = "https://api.github.com/repos/$repository/releases"; |
||||||
106 | if ('github' === $source) { |
||||||
107 | if (function_exists('curl_init') && false !== ($curlHandle = curl_init())) { |
||||||
108 | curl_setopt($curlHandle, CURLOPT_URL, $infoReleasesUrl); |
||||||
109 | curl_setopt($curlHandle, CURLOPT_RETURNTRANSFER, true); |
||||||
110 | curl_setopt($curlHandle, CURLOPT_SSL_VERIFYPEER, true); //TODO: how to avoid an error when 'Peer's Certificate issuer is not recognized' |
||||||
111 | curl_setopt($curlHandle, CURLOPT_HTTPHEADER, ["User-Agent:Publisher\r\n"]); |
||||||
112 | $curlReturn = curl_exec($curlHandle); |
||||||
113 | if (false === $curlReturn) { |
||||||
114 | trigger_error(curl_error($curlHandle)); |
||||||
115 | } elseif (false !== mb_strpos($curlReturn, 'Not Found')) { |
||||||
0 ignored issues
–
show
It seems like
$curlReturn can also be of type true ; however, parameter $haystack of mb_strpos() does only seem to accept string , maybe add an additional type check?
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
Loading history...
|
|||||||
116 | trigger_error('Repository Not Found: ' . $infoReleasesUrl); |
||||||
117 | } else { |
||||||
118 | $file = json_decode($curlReturn, false); |
||||||
0 ignored issues
–
show
It seems like
$curlReturn can also be of type true ; however, parameter $json of json_decode() does only seem to accept string , maybe add an additional type check?
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
Loading history...
|
|||||||
119 | $latestVersionLink = sprintf("https://github.com/$repository/archive/%s.zip", $file ? reset($file)->tag_name : $default); |
||||||
120 | $latestVersion = $file[0]->tag_name; |
||||||
121 | $prerelease = $file[0]->prerelease; |
||||||
122 | if ('master' !== $latestVersionLink) { |
||||||
123 | $update = constant('CO_' . $moduleDirNameUpper . '_' . 'NEW_VERSION') . $latestVersion; |
||||||
124 | } |
||||||
125 | //"PHP-standardized" version |
||||||
126 | $latestVersion = mb_strtolower($latestVersion); |
||||||
127 | if (false !== mb_strpos($latestVersion, 'final')) { |
||||||
128 | $latestVersion = str_replace('_', '', mb_strtolower($latestVersion)); |
||||||
129 | $latestVersion = str_replace('final', '', mb_strtolower($latestVersion)); |
||||||
130 | } |
||||||
131 | $moduleVersion = ($helper->getModule()->getInfo('version') . '_' . $helper->getModule()->getInfo('module_status')); |
||||||
0 ignored issues
–
show
Are you sure
$helper->getModule()->getInfo('version') of type array|string can be used in concatenation ?
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
Loading history...
Are you sure
$helper->getModule()->getInfo('module_status') of type array|string can be used in concatenation ?
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
Loading history...
|
|||||||
132 | //"PHP-standardized" version |
||||||
133 | $moduleVersion = str_replace(' ', '', mb_strtolower($moduleVersion)); |
||||||
134 | // $moduleVersion = '1.0'; //for testing only |
||||||
135 | // $moduleDirName = 'publisher'; //for testing only |
||||||
136 | if (!$prerelease && version_compare($moduleVersion, $latestVersion, '<')) { |
||||||
137 | $ret = []; |
||||||
138 | $ret[] = $update; |
||||||
139 | $ret[] = $latestVersionLink; |
||||||
140 | } |
||||||
141 | } |
||||||
142 | curl_close($curlHandle); |
||||||
143 | } |
||||||
144 | } |
||||||
145 | return $ret; |
||||||
146 | } |
||||||
147 | } |
||||||
148 |