XoopsModules\Xhttperror\Error::getForm()

Complexity

Conditions	5
Paths	16

Size

Total Lines	101
Code Lines	69

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function getForm($action = false)
    {
        global $xoopsDB, $xoopsModule, $xoopsModuleConfig;

        if (false === $action) {
            $action = $_SERVER['REQUEST_URI'];
        }
        $title = $this->isNew() ? \sprintf(\_AM_XHTTPERR_ERROR_ADD) : \sprintf(\_AM_XHTTPERR_ERROR_EDIT);

        require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

        $formObj = new \XoopsThemeForm($title, 'form_error', $action, 'post', true);
        $formObj->setExtra('enctype="multipart/form-data"');

        // Title
        $errorTitle = new \XoopsFormText(\_AM_XHTTPERR_ERROR_TITLE, 'error_title', 40, 255, $this->getVar('error_title'));

It seems like $this->getVar('error_title') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

        $errorTitle->setDescription(\_AM_XHTTPERR_ERROR_TITLE_DESC);
        $formObj->addElement($errorTitle, true);
        unset($errorTitle);
        // Error number
        if ($this->isNew()) {
            $errorStatuscode = new \XoopsFormText(\_AM_XHTTPERR_ERROR_STATUSCODE, 'error_statuscode', 3, 3, $this->getVar('error_statuscode'));
        } else {
            $errorStatuscode = new \XoopsFormLabel(\_AM_XHTTPERR_ERROR_STATUSCODE, $this->getVar('error_statuscode'));

It seems like $this->getVar('error_statuscode') can also be of type array and array; however, parameter $value of XoopsFormLabel::__construct() does only seem to accept string, maybe add an additional type check?

        }
        $formObj->addElement($errorStatuscode, true);
        unset($errorStatuscode);
        // Text
        $editor_configs           = [];
        $editor_configs['name']   = 'error_text';
        $editor_configs['value']  = $this->getVar('error_text', 'e');
        $editor_configs['rows']   = 10;
        $editor_configs['cols']   = 50;
        $editor_configs['width']  = '100%';
        $editor_configs['height'] = '100px';
        $editor_configs['editor'] = $GLOBALS['xoopsModuleConfig']['text_editor'];
        $errorText                = new \XoopsFormEditor(\_AM_XHTTPERR_ERROR_TEXT, 'error_text', $editor_configs);
        $errorText->setDescription(\_AM_XHTTPERR_ERROR_TEXT_DESC);
        $formObj->addElement($errorText);
        // Text options
        $errorTextOptions = new \XoopsFormElementTray(\_AM_XHTTPERR_ERROR_TEXT_OPTIONS, '|', '');
        $errorTextOptions->addElement(new \XoopsFormRadioYN(\_AM_XHTTPERR_ERROR_TEXT_HTML, 'error_text_html', $this->getVar('error_text_html'), _YES, _NO));

It seems like $this->getVar('error_text_html') can also be of type array and array; however, parameter $value of XoopsFormRadioYN::__construct() does only seem to accept string, maybe add an additional type check?

        $errorTextOptions->addElement(new \XoopsFormRadioYN(\_AM_XHTTPERR_ERROR_TEXT_SMILEY, 'error_text_smiley', $this->getVar('error_text_smiley'), _YES, _NO));
        $errorTextOptions->addElement(new \XoopsFormRadioYN(\_AM_XHTTPERR_ERROR_TEXT_BREAKS, 'error_text_breaks', $this->getVar('error_text_breaks'), _YES, _NO));
        $errorTextOptions->setDescription(\_AM_XHTTPERR_ERROR_TEXT_OPTIONS_DESC);
        $formObj->addElement($errorTextOptions);
        unset($errorTextOptions);
        // Showme
        $errorShowme = new \XoopsFormRadioYN(\_AM_XHTTPERR_ERROR_STATUS, 'error_showme', $this->getVar('error_showme'), _YES, _NO);
        $errorShowme->setDescription(\_AM_XHTTPERR_ERROR_STATUS_DESC);
        $formObj->addElement($errorShowme);
        unset($errorShowme);

        $formObj->addElement(new \XoopsFormLabel(_AM_XHTTPERR_ERROR_REDIRECT_OPTIONS, '', ''));
        // Redirect
        $errorRedirect = new \XoopsFormSelect(\_AM_XHTTPERR_ERROR_REDIRECT, 'error_redirect', $this->getVar('error_redirect'), 1, false);
        $errorRedirect->addOption(\XHTTPERR_REDIRECT_NO, \_AM_XHTTPERR_ERROR_REDIRECT_OPTION_NO);
        $errorRedirect->addOption(\XHTTPERR_REDIRECT_URI, \_AM_XHTTPERR_ERROR_REDIRECT_OPTION_URI);
        $errorRedirect->addOption(\XHTTPERR_REDIRECT_PREVIOUS, \_AM_XHTTPERR_ERROR_REDIRECT_OPTION_PREVIOUS);
        //$errorRedirect = new \XoopsFormRadioYN(, _YES, _NO);
        $errorRedirect->setDescription(\_AM_XHTTPERR_ERROR_REDIRECT_DESC);
        $formObj->addElement($errorRedirect);
        unset($errorRedirect);
        // Redirect time
        $errorRedirectTime = new \XoopsFormText(\_AM_XHTTPERR_ERROR_REDIRECT_TIME, 'error_redirect_time', 2, 2, $this->getVar('error_redirect_time'));
        $errorRedirectTime->setDescription(\_AM_XHTTPERR_ERROR_REDIRECT_TIME_DESC);
        $formObj->addElement($errorRedirectTime);
        unset($errorRedirectTime);
        /* IN PROGRESS
        // Redirect message
            $errorRedirectMessage = new \XoopsFormText(_AM_XHTTPERR_ERROR_REDIRECT_MESSAGE, 'error_redirect_message', 40, 255, $this->getVar('error_redirect_message'));
            $errorRedirectMessage->setDescription(_AM_XHTTPERR_ERROR_REDIRECT_MESSAGE_DESC);
        $formObj->addElement($errorRedirectMessage, true);
        unset($errorRedirectMessage);
        */
        // Redirect uri
        $errorRedirectUri = new \XoopsFormText(\_AM_XHTTPERR_ERROR_REDIRECT_URI, 'error_redirect_uri', 40, 255, $this->getVar('error_redirect_uri'));
        $errorRedirectUri->setDescription(\_AM_XHTTPERR_ERROR_REDIRECT_URI_DESC);
        $formObj->addElement($errorRedirectUri);
        unset($errorRedirectUri);

        // Captcha
        \xoops_load('xoopscaptcha');
        $formObj->addElement(new \XoopsFormCaptcha(), true);
        // Hidden Fields
        $formObj->addElement(new \XoopsFormHidden('op', 'save_error'));
        if ($this->isNew()) {
            // NOP
        } else {
            $formObj->addElement(new \XoopsFormHidden('error_id', $this->getVar('error_id')));

It seems like $this->getVar('error_id') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

        }
        // Submit button
        $buttonTray = new \XoopsFormElementTray(\_AM_XHTTPERR_ACTION, '', '');
        $buttonTray->addElement(new \XoopsFormButton('', 'submit', _SUBMIT, 'submit'));
        $buttonTray->addElement(new \XoopsFormButton('', 'reset', _RESET, 'reset'));
        $cancel_button = new \XoopsFormButton('', 'cancel', _CANCEL, 'button');
        $cancel_button->setExtra("onclick='javascript:history.back();'");
        $buttonTray->addElement($cancel_button);
        $formObj->addElement($buttonTray);

        return $formObj;
    }