index.php ➔ userviewall_display()

Complexity

Conditions	19
Paths	12288

Size

Total Lines	173
Code Lines	112

Duplication

Lines	23
Ratio	13.29 %

Importance

Changes

0

<?php
function userviewall_display()

userviewall_display uses the super-global variable $_REQUEST which is generally not recommended.

{
    global $xoopsOption, $xoopsTpl, $xoopsConfig, $xoopsUser, $xoopsLogger, $xoopsUserIsAdmin;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    global $xhelp_module_header, $sort, $order, $sort_order, $limit, $start, $state_opt, $state;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    $xoopsOption['template_main'] = 'xhelp_user_viewall.html';    // Set template
    require(XOOPS_ROOT_PATH.'/header.php');                     // Include the page header

    //Sanity Check: sort column valid
    $sort_columns = array('id' => 'DESC', 'priority' => 'DESC', 'elapsed' => 'ASC', 'lastupdate' => 'ASC', 'status' => 'ASC', 'subject' => 'ASC' , 'department' => 'ASC', 'ownership' => 'ASC', 'uid' => 'ASC');
    $sort  = array_key_exists($sort, $sort_columns) ? $sort : 'id';
    $order = @$_REQUEST['order'];
    $order = (in_array(strtoupper($order), $sort_order) ? $order : $sort_columns[$sort]);
    $uid   = $xoopsUser->getVar('uid');

    $hDepartments =& xhelpGetHandler('department');
    $hTickets      =& xhelpGetHandler('ticket');
    $hStaff       =& xhelpGetHandler('staff');

    $dept     = intval(isset($_REQUEST['dept']) ? $_REQUEST['dept'] : 0);
    $status   = intval(isset($_REQUEST['status']) ? $_REQUEST['status'] : -1);
    $state    = intval(isset($_REQUEST['state']) ? $_REQUEST['state'] : -1);
    $depts    =& $hDepartments->getObjects(null, true);

    if ($limit == 0) {
        $limit = 10;
    } elseif ($limit == -1) {
        $limit = 0;
    }

    //Prepare Database Query and Querystring
    $crit     = new CriteriaCompo(new Criteria ('uid', $uid));
    $qs       = array('op' => 'userViewAll', //Common Query String Values
                    'start' => $start,
                    'limit' => $limit);

    if ($dept) {
        $qs['dept'] = $dept;
        $crit->add(new Criteria('department', $dept, '=', 't'));
    }
    if ($status != -1) {
        $qs['status'] = $status;
        $crit->add(new Criteria('status', $status, '=', 't'));
    }

    if($state != -1){
        $qs['state'] = $state;
        $crit->add(new Criteria('state', $state, '=', 's'));
    }

    $crit->setLimit($limit);
    $crit->setStart($start);
    $crit->setSort($sort);
    $crit->setOrder($order);

    //Setup Column Sorting Vars
    $tpl_cols = array();
    foreach ($sort_columns as $col => $initsort) {
        $col_qs = array('sort' => $col);
        //Check if we need to sort by current column
        if ($sort == $col) {
            $col_qs['order'] = ($order == $sort_order[0] ? $sort_order[1]: $sort_order[0]);
            $col_sortby = true;
        } else {
            $col_qs['order'] = $initsort;
            $col_sortby = false;
        }
        $tpl_cols[$col] = array('url'=>xhelpMakeURI(basename(__FILE__), array_merge($qs, $col_qs)),
                        'urltitle' => _XHELP_TEXT_SORT_TICKETS,
                        'sortby' => $col_sortby,
                        'sortdir' => strtolower($col_qs['order']));
    }

    $xoopsTpl->assign('xhelp_cols', $tpl_cols);
    $staffCount =& $hStaff->getObjects();
    if(count($staffCount) == 0){
        $xoopsTpl->assign('xhelp_noStaff', true);
    }

    $userTickets =& $hTickets->getObjects($crit);
    foreach($userTickets as $ticket){
        $aUserTickets[] = array('id'=>$ticket->getVar('id'),

$aUserTickets was never initialized. Although not strictly required by PHP, it is generally a good practice to add $aUserTickets = array(); before regardless.

                        'uid'=>$ticket->getVar('uid'),
                        'subject'       => xoops_substr($ticket->getVar('subject'),0,35),
                        'full_subject'  => $ticket->getVar('subject'),
                        'status'=>xhelpGetStatus($ticket->getVar('status')),
                        'department'=>_safeDepartmentName($depts[$ticket->getVar('department')]),
                        'departmentid'=> $ticket->getVar('department'),
                        'departmenturl'=>xhelpMakeURI(basename(__FILE__), array('op' => 'userViewAll', 'dept'=> $ticket->getVar('department'))),
                        'priority'=>$ticket->getVar('priority'),
                        'posted'=>$ticket->posted(),
                        'elapsed'=>$ticket->elapsed());
    }
    $has_userTickets = count($userTickets) > 0;
    if($has_userTickets){
        $xoopsTpl->assign('xhelp_userTickets', $aUserTickets);

The variable $aUserTickets does not seem to be defined for all execution paths leading up to this point.

    } else {
        $xoopsTpl->assign('xhelp_userTickets', 0);
    }

    $javascript = "<script type=\"text/javascript\" src=\"". XHELP_BASE_URL ."/include/functions.js\"></script>
<script type=\"text/javascript\" src='".XHELP_SCRIPT_URL."/changeSelectedState.php?client'></script>
<script type=\"text/javascript\">
<!--
function states_onchange()
{
    state = xoopsGetElementById('state');
    var sH = new xhelpweblib(stateHandler);
    sH.statusesbystate(state.value);
}

var stateHandler = {
    statusesbystate: function(result){
        var statuses = gE('status');
        xhelpFillSelect(statuses, result);
    }
}

function window_onload()
{
    xhelpDOMAddEvent(xoopsGetElementById('state'), 'change', states_onchange, true);
}

window.setTimeout('window_onload()', 1500);
//-->
</script>";

    $xoopsTpl->assign('xhelp_baseURL', XHELP_BASE_URL);
    $xoopsTpl->assign('xhelp_has_userTickets', $has_userTickets);
    $xoopsTpl->assign('xhelp_viewAll', true);
    $xoopsTpl->assign('xhelp_priorities', array(5, 4, 3, 2, 1));
    $xoopsTpl->assign('xhelp_priorities_desc', array('5' => _XHELP_PRIORITY5, '4' => _XHELP_PRIORITY4,'3' => _XHELP_PRIORITY3, '2' => _XHELP_PRIORITY2, '1' => _XHELP_PRIORITY1));
    $xoopsTpl->assign('xhelp_imagePath', XHELP_IMAGE_URL .'/');
    $xoopsTpl->assign('xoops_module_header',$javascript.$xhelp_module_header);
    $xoopsTpl->assign('xhelp_limit_options', array(-1 => _XHELP_TEXT_SELECT_ALL, 10 => '10', 15 => '15', 20 => '20', 30 => '30'));
    $xoopsTpl->assign('xhelp_filter', array('department' => $dept,
            'status' => $status,
            'limit' => $limit,
            'start' => $start,
            'sort' => $sort,
            'order' => $order,
            'state' => $state));
    $xoopsTpl->append('xhelp_department_values', 0);
    $xoopsTpl->append('xhelp_department_options', _XHELP_TEXT_SELECT_ALL);

    //$depts = getVisibleDepartments($depts);
    $hMembership =& xhelpGetHandler('membership');
    $depts =& $hMembership->getVisibleDepartments($xoopsUser->getVar('uid'));
    foreach($depts as $xhelp_id=>$obj) {
        $xoopsTpl->append('xhelp_department_values', $xhelp_id);
        $xoopsTpl->append('xhelp_department_options', $obj->getVar('department'));
    }

    $hStatus =& xhelpGetHandler('status');
    $crit = new Criteria('', '');
    $crit->setSort('description');
    $crit->setOrder('ASC');
    $statuses =& $hStatus->getObjects($crit);

    $xoopsTpl->append('xhelp_status_options', _XHELP_TEXT_SELECT_ALL);
    $xoopsTpl->append('xhelp_status_values', -1);
    foreach($statuses as $status){
        $xoopsTpl->append('xhelp_status_options', $status->getVar('description'));
        $xoopsTpl->append('xhelp_status_values', $status->getVar('id'));
    }

    $xoopsTpl->assign('xhelp_department_current', $dept);
    $xoopsTpl->assign('xhelp_status_current', $status);
    $xoopsTpl->assign('xhelp_state_options', array_keys($state_opt));
    $xoopsTpl->assign('xhelp_state_values', array_values($state_opt));

    require(XOOPS_ROOT_PATH.'/footer.php');
}