staff.php ➔ customDept() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/xhelp - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 26776f...d9604e )

by Michael
created 2016-06-01 04:10 UTC
staff.php ➔ customDept() F

↳ Parent: Project
Complexity

Conditions	40
Paths	1312
Size

Total Lines	184
Code Lines	124
Duplication

Lines	26
Ratio	14.13 %
Importance

Changes
Metric	Value
cc	40
eloc	124
nc	1312
nop	0
dl	26
loc	184
rs	2
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

//$Id: staff.php,v 1.23 2005/11/30 15:58:08 eric_juden Exp $
include('../../../include/cp_header.php');
include_once('admin_header.php');
include_once(XHELP_CLASS_PATH.'/xhelpPageNav.php');

global $xoopsModule, $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
$module_id = $xoopsModule->getVar('mid');
$displayName =& $xoopsModuleConfig['xhelp_displayName'];    // Determines if username or real name is displayed

$aLimitByS = array('10' => 10, '15' => 15, '20' => 20, '25' => 25, '50' => 50, '100' => 100);
$aLimitByD = array('1' => 1, '2' => 2, '3' => 3, '4' => 4, '5' => 5, '10' => 10);

$op = 'default';

if ( isset( $_REQUEST['op'] ) )
{
    $op = $_REQUEST['op'];
}

switch ( $op )
{
    case "addRole":
        addRole();
        break;

    case "clearOrphanedStaff":
        clearOrphanedStaff();
        break;

    case "clearRoles":
        clearRoles();
        break;

    case "customDept":
        customDept();
        break;

    case "editRole":
        editRole();
        break;

    case "editStaff":
        editStaff();
        break;

    case "manageStaff":
        manageStaff();
        break;

    default:
        header("Location: ".XHELP_BASE_URL."/admin/index.php");
        break;
}

function addRole()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    require_once(XHELP_CLASS_PATH.'/session.php');
    $_xhelpSession = new Session();
    if(!isset($_POST['add'])){
        // Set array of security items
        $tasks = array(XHELP_SEC_TICKET_ADD         => _AM_XHELP_SEC_TEXT_TICKET_ADD,
        XHELP_SEC_TICKET_EDIT        => _AM_XHELP_SEC_TEXT_TICKET_EDIT,
        XHELP_SEC_TICKET_DELETE      => _AM_XHELP_SEC_TEXT_TICKET_DELETE,
        XHELP_SEC_TICKET_MERGE       => _AM_XHELP_SEC_TEXT_TICKET_MERGE,
        XHELP_SEC_TICKET_OWNERSHIP   => _AM_XHELP_SEC_TEXT_TICKET_OWNERSHIP,
        XHELP_SEC_TICKET_STATUS      => _AM_XHELP_SEC_TEXT_TICKET_STATUS,
        XHELP_SEC_TICKET_PRIORITY    => _AM_XHELP_SEC_TEXT_TICKET_PRIORITY,
        XHELP_SEC_TICKET_LOGUSER     => _AM_XHELP_SEC_TEXT_TICKET_LOGUSER,
        XHELP_SEC_RESPONSE_ADD       => _AM_XHELP_SEC_TEXT_RESPONSE_ADD,
        XHELP_SEC_RESPONSE_EDIT      => _AM_XHELP_SEC_TEXT_RESPONSE_EDIT,
        XHELP_SEC_FILE_DELETE        => _AM_XHELP_SEC_TEXT_FILE_DELETE,
        XHELP_SEC_FAQ_ADD            => _AM_XHELP_SEC_TEXT_FAQ_ADD,
        XHELP_SEC_TICKET_TAKE_OWNERSHIP  => _AM_XHELP_SEC_TEXT_TICKET_TAKE_OWNERSHIP);
        xoops_cp_header();
        //echo $oAdminButton->renderButtons('manStaff');
        $indexAdmin = new ModuleAdmin();
        echo $indexAdmin->addNavigation('staff.php?op=addRole');

        echo '<script type="text/javascript" src="'.XOOPS_URL.'/modules/xhelp/include/functions.js"></script>';
        echo "<form action='staff.php?op=addRole' method='post'>";
        echo "<table width='100%' cellspacing='1' class='outer'>";
        echo "<tr><th colspan='2'>"._AM_XHELP_TEXT_CREATE_ROLE."</th></tr>";
        echo "<tr><td class='head'>"._AM_XHELP_TEXT_NAME."</td>
                  <td class='even'><input type='text' name='roleName' maxlength='35' value='' class='formButton'></td>
              </tr>";
        echo "<tr><td class='head'>"._AM_XHELP_TEXT_DESCRIPTION."</td>
                  <td class='even'><textarea name='roleDescription' class='formButton'></textarea></td>
              </tr>";
        echo "<tr><td class='head'>"._AM_XHELP_TEXT_PERMISSIONS."</td>
                  <td class='even'>
                     <table border='0'>
                     <tr><td>";
        foreach($tasks as $bit_value => $task){
            echo "<tr><td><input type='checkbox' name='tasks[]' value='". pow(2,$bit_value) ."' />".$task."</td></tr>";
        }
        echo "<tr><td><input type='checkbox' name='allTasks' value='0' onclick='selectAll(this.form,\"tasks[]\",this.checked);' /><b>"._AM_XHELP_TEXT_SELECT_ALL."</b></td></tr>";
        echo "</table>
                  </td>
              </tr>";
        echo "<tr>
                  <td colspan='2' class='foot'>
                      <input type='submit' name='add' value='". _AM_XHELP_BUTTON_CREATE_ROLE ."' class='formButton'>
                      <input type='button' name='cancel' value='"._AM_XHELP_BUTTON_CANCEL."' onclick='history.go(-1)' class='formButton' />
                  </td>
              </tr>";
        echo "</table></form>";
        include_once "admin_footer.php";
    } else {
        $hRole =& xhelpGetHandler('role');

        $role =& $hRole->create();
        $role->setVar('name', $_POST['roleName']);
        $role->setVar('description', $_POST['roleDescription']);
        if(isset($_POST['tasks'])){
            $tasksValue = array_sum($_POST['tasks']);
        } else {
            $tasksValue = 0;
        }
        $role->setVar('tasks', $tasksValue);

        $lastPage = $_xhelpSession->get("xhelp_return_op");

        if($hRole->insert($role)){
            $message = _AM_XHELP_MESSAGE_ROLE_INSERT;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            header("Location: ".XHELP_ADMIN_URL."/staff.php?op=$lastPage");
        } else {
            $message = _AM_XHELP_MESSAGE_ROLE_INSERT_ERROR;
            redirect_header(XHELP_ADMIN_URL."/staff.php?op=$lastPage", 3, $message);
        }
    }
}

function clearOrphanedStaff()
{
    $hMember =& xoops_gethandler('member');
    $hStaff =& xhelpGetHandler('staff');
    $users =& $hMember->getUserList();
    $staff =& $hStaff->getObjects();

    $aUsers = array();
    foreach($staff as $stf){
        $staff_uid = $stf->getVar('uid');
        if(!array_key_exists($staff_uid, $users)){
            $aUsers[$staff_uid] = $staff_uid;
        }
    }

    $crit = new Criteria('uid', "(". implode($aUsers, ',') .")", "IN");
    $ret = $hStaff->deleteAll($crit);

    if($ret){
        header("Location: ".XHELP_ADMIN_URL."/staff.php?op=manageStaff");
    } else {
        redirect_header(XHELP_ADMIN_URL."/staff.php?op=manageStaff", 3, _AM_XHELP_MSG_CLEAR_ORPHANED_ERR);
    }
}

function clearRoles()
{
    require_once(XHELP_CLASS_PATH.'/session.php');
    $_xhelpSession = new Session();

    $hDept =& xhelpGetHandler('department');
    $depts =& $hDept->getObjects();

    foreach($depts as $dept){
        $deptid = $dept->getVar('id');
        if($deptRoles = $_xhelpSession->get("xhelp_dept_$deptid")){
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $_xhelpSession->del("xhelp_dept_$deptid");
        }
    }

    if(!$returnPage =& $_xhelpSession->get("xhelp_return_page")){
        $returnPage = false;
    }

    $_xhelpSession->del("xhelp_return_page");
    $_xhelpSession->del("xhelp_mainRoles");
    $_xhelpSession->del("xhelp_mainDepts");
    $_xhelpSession->del("xhelp_return_op");

    if(!$returnPage){
        header("Location: ".XHELP_ADMIN_URL."/staff.php?op=manageStaff");
    } else {
        header("Location: ".XHELP_ADMIN_URL."/$returnPage");
    }
    exit();

}

function customDept()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    require_once(XHELP_CLASS_PATH.'/session.php');
    $_xhelpSession = new Session();
    global $xoopsUser, $displayName;
function myFunction($a, $b) {
    // Do something
}

    $lastPage = $_xhelpSession->get("xhelp_return_op");

    if(isset($_REQUEST['uid'])){
        $uid = intval($_REQUEST['uid']);
    } else {
        $uid = 0;
    }
    if($uid == 0){
        redirect_header(XHELP_ADMIN_URL."/staff.php?op=$lastPage", 3, _AM_XHELP_MSG_NEED_UID);
    }
    if(isset($_REQUEST['deptid'])){
        $deptid = intval($_REQUEST['deptid']);
    }

    if(!isset($_POST['submit'])){
        if(isset($_POST['addRole'])){

            $_xhelpSession->set("xhelp_return_op2", $lastPage);
            $_xhelpSession->set("xhelp_return_op", substr(strstr($_SERVER['REQUEST_URI'], 'op='), 3));
            header("Location: ".XHELP_ADMIN_URL."/staff.php?op=addRole");
        }

        if(isset($_GET['xhelp_role'])){
            $aRoles = explode(",", $_GET['xhelp_role']);
            foreach($aRoles as $role){
                $role = intval($role);
            }
            $_xhelpSession->set("xhelp_mainRoles", $aRoles);    // Store roles from the manage staff page
        }

        if(isset($_GET['xhelp_depts'])){
            $aDepts = explode(",", $_GET['xhelp_depts']);
            foreach($aDepts as $dept){
                $dept = intval($dept);
            }
            $_xhelpSession->set("xhelp_mainDepts", $aDepts);    // Store depts from the manage staff page
        }

        $hDept =& xhelpGetHandler('department');
        $hRole =& xhelpGetHandler('role');

        $dept =& $hDept->get($deptid);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        $crit = new Criteria('', '');
        $crit->setOrder('ASC');
        $crit->setSort('name');
        $roles =& $hRole->getObjects($crit);

        $lastPage = $_xhelpSession->get("xhelp_return_op");
        xoops_cp_header();

        echo '<script type="text/javascript" src="'.XOOPS_URL.'/modules/xhelp/include/functions.js"></script>';
        echo "<form action='staff.php?op=customDept&amp;deptid=".$deptid."&amp;uid=".$uid."' method='post'>";
        echo "<table width='100%' cellspacing='1' class='outer'>";
        echo "<tr><th colspan='2'>"._AM_XHELP_TEXT_DEPT_PERMS."</th></tr>";
        echo "<tr><td class='head' width='20%'>"._AM_XHELP_TEXT_USER."</td>
                  <td class='even'>".xhelpGetUsername($uid, $displayName)."</td></tr>";
        echo "<tr><td class='head'>"._AM_XHELP_TEXT_DEPARTMENT."</td>
                  <td class='even'>".$dept->getVar('department')."</td></tr>";
        echo "<tr><td class='head'>". _AM_XHELP_TEXT_ROLES ."</td>
                  <td class='even'><table width='75%'>";

        $bFound = false;
        if($storedRoles =& $_xhelpSession->get("xhelp_dept_$deptid")){    // If editing previously customized dept
            foreach ($roles as $role){
                if($storedRoles['roles'] != -1){
                    foreach($storedRoles['roles'] as $storedRole){
                        if($role->getVar('id') == $storedRole){
                            $bFound = true;
                            break;
                        } else {
                            $bFound = false;
                        }
                    }
                }
                if($bFound){
                    echo "<tr><td><input type='checkbox' name='roles[]' checked='checked' value='". $role->getVar('id')."' /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                } else {
                    echo "<tr><td><input type='checkbox' name='roles[]' value='". $role->getVar('id')."' /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                }
            }
        } elseif($mainRoles = $_xhelpSession->get("xhelp_mainRoles")){    // If roles set on manage staff page
            foreach($roles as $role){
                if(!in_array($role->getVar('id'), $mainRoles)){
                    echo "<tr><td><input type='checkbox' name='roles[]' value='". $role->getVar('id')."' /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                } else {
                    echo "<tr><td><input type='checkbox' name='roles[]' value='". $role->getVar('id')."' checked='checked' /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                }
            }
        } elseif($lastPage == "editStaff" && (!$storedRoles =& $_xhelpSession->get("xhelp_dept_$deptid"))){
            $hStaff =& xhelpGetHandler('staff');
            $myRoles =& $hStaff->getRolesByDept($uid, $deptid);

            $bFound = false;
            foreach($roles as $role){
                if(!empty($myRoles)){
                    foreach($myRoles as $myRole){
                        if($role->getVar('id') == $myRole->getVar('roleid')){
                            $bFound = true;
                            break;
                        } else {
                            $bFound = false;
                        }
                    }
                }
                if($bFound){
                    echo "<tr><td><input type='checkbox' name='roles[]' checked='checked' value='". $role->getVar('id')."' /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                } else {
                    echo "<tr><td><input type='checkbox' name='roles[]' value='". $role->getVar('id')."' /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                }
            }
        } else {
            foreach($roles as $role){     // If no roles set
                echo "<tr><td><input type='checkbox' name='roles[]' value='". $role->getVar('id')."' /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
            }
        }
        echo "<tr><td><input type='checkbox' name='checkallRoles' value='0' onclick='selectAll(this.form,\"roles[]\",this.checked);' /><b>"._AM_XHELP_TEXT_SELECT_ALL."</b></td></tr>";
        echo "</table></td></tr>";
        echo "<tr><td colspan='2' class='foot'>
                      <input type='submit' name='submit' value='". _AM_XHELP_BUTTON_UPDATE ."' class='formButton' />
                      <input type='submit' name='addRole' value='". _AM_XHELP_BUTTON_CREATE_ROLE ."' class='formButton' />
                      <input type='button' name='cancel' value='"._AM_XHELP_BUTTON_CANCEL."' onclick='history.go(-1)' class='formButton' />
                  </td>
              </tr>";
        echo "</table>";
        include_once "admin_footer.php";
    } else {
        $hRole =& xhelpGetHandler('role');

        if(!empty($_POST['roles'])){
            foreach($_POST['roles'] as $role){
                $thisRole =& $hRole->get($role);
                $aRoleNames[] = $thisRole->getVar('name');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        }

        $_xhelpSession->set("xhelp_dept_$deptid",       // Store roles for customized dept
        array('id' => $deptid,
                                  'roles' => ((!empty($_POST['roles'])) ? $_POST['roles']: -1),
                                  'roleNames' => ((!empty($aRoleNames)) ? $aRoleNames : -1)
        ));

        $xhelp_has_deptRoles = false;
        if($hasRoles = $_xhelpSession->get("xhelp_dept_$deptid")){
            $xhelp_has_deptRoles = true;
            if($hasRoles['roles'] == -1){                   // No perms for this dept
                //$_xhelpSession->del("xhelp_dept_$deptid");  // Delete custom roles for dept
                $xhelp_has_deptRoles = false;
            }
        }

        if($mainDepts = $_xhelpSession->get("xhelp_mainDepts")){
            if($xhelp_has_deptRoles){           // If dept has roles
                if(!in_array($deptid, $mainDepts)){     // Does dept already exist in array?
                    array_push($mainDepts, $deptid);    // Add dept to array
                    $_xhelpSession->set("xhelp_mainDepts", $mainDepts); // Set session with new dept value
                }
            } else {
                // Unset element in array with current dept value
                foreach($mainDepts as $dept){
                    if($dept == $deptid){
                        unset($dept);
                    }
                }
                $_xhelpSession->set("xhelp_mainDepts",$mainDepts);
            }
        } else {                        // If mainDepts is not set
            if($xhelp_has_deptRoles){   // If dept has any roles
                $_xhelpSession->set("xhelp_mainDepts", array($deptid));
            }
        }

        if(!$lastPage = $_xhelpSession->get("xhelp_return_op2")){
            $lastPage = $_xhelpSession->get("xhelp_return_op");
        }
        header("Location: ".XHELP_ADMIN_URL."/staff.php?op=$lastPage&uid=$uid");
    }
}

function deleteRole($xhelp_id, $return_op)
{

    $xhelp_id = intval($xhelp_id);

    $hRole =& xhelpGetHandler('role');
    $role =& $hRole->get($xhelp_id);

    if($hRole->delete($role, true)){
        $message = _AM_XHELP_MESSAGE_ROLE_DELETE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        header("Location: ".XHELP_ADMIN_URL."/staff.php?op=$return_op");
    } else {
        $message = _AM_XHELP_MESSAGE_ROLE_DELETE_ERROR;
        redirect_header(XHELP_ADMIN_URL."/staff.php?op=$return_op", 3, $message);
    }
}

function editRole()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    require_once(XHELP_CLASS_PATH.'/session.php');
    $_xhelpSession = new Session();

    $lastPage = $_xhelpSession->get("xhelp_return_op");

    if(isset($_REQUEST['id'])){
        $xhelp_id = intval($_REQUEST['id']);
    }

    if(isset($_REQUEST['uid'])){
        $uid = intval($_REQUEST['uid']);
    } else {
        $uid = 0;
    }

    $hRole =& xhelpGetHandler('role');
    $role =& $hRole->get($xhelp_id);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

    if(isset($_POST['deleteRole'])){
        deleteRole($xhelp_id, "manageStaff");
        exit();

    }

    if(!isset($_POST['edit'])){
        $_xhelpSession->set("xhelp_return_op2", $lastPage);
        $_xhelpSession->set("xhelp_return_op", substr(strstr($_SERVER['REQUEST_URI'], 'op='), 3));

        // Set array of security items
        $tasks = array(XHELP_SEC_TICKET_ADD             => _AM_XHELP_SEC_TEXT_TICKET_ADD,
        XHELP_SEC_TICKET_EDIT            => _AM_XHELP_SEC_TEXT_TICKET_EDIT,
        XHELP_SEC_TICKET_DELETE          => _AM_XHELP_SEC_TEXT_TICKET_DELETE,
        XHELP_SEC_TICKET_OWNERSHIP       => _AM_XHELP_SEC_TEXT_TICKET_OWNERSHIP,
        XHELP_SEC_TICKET_STATUS          => _AM_XHELP_SEC_TEXT_TICKET_STATUS,
        XHELP_SEC_TICKET_PRIORITY        => _AM_XHELP_SEC_TEXT_TICKET_PRIORITY,
        XHELP_SEC_TICKET_LOGUSER         => _AM_XHELP_SEC_TEXT_TICKET_LOGUSER,
        XHELP_SEC_RESPONSE_ADD           => _AM_XHELP_SEC_TEXT_RESPONSE_ADD,
        XHELP_SEC_RESPONSE_EDIT          => _AM_XHELP_SEC_TEXT_RESPONSE_EDIT,
        XHELP_SEC_TICKET_MERGE           => _AM_XHELP_SEC_TEXT_TICKET_MERGE,
        XHELP_SEC_FILE_DELETE            => _AM_XHELP_SEC_TEXT_FILE_DELETE,
        XHELP_SEC_FAQ_ADD                => _AM_XHELP_SEC_TEXT_FAQ_ADD,
        XHELP_SEC_TICKET_TAKE_OWNERSHIP  => _AM_XHELP_SEC_TEXT_TICKET_TAKE_OWNERSHIP);
        xoops_cp_header();
        //echo $oAdminButton->renderButtons('manStaff');
        $indexAdmin = new ModuleAdmin();
        echo $indexAdmin->addNavigation('staff.php?op=editRole');

        echo '<script type="text/javascript" src="'.XOOPS_URL.'/modules/xhelp/include/functions.js"></script>';
        echo "<form action='staff.php?op=editRole&amp;id=".$xhelp_id."&amp;uid=".$uid."' method='post'>";
        echo "<table width='100%' cellspacing='1' class='outer'>";
        echo "<tr><th colspan='2'>"._AM_XHELP_TEXT_EDIT_ROLE."</th></tr>";
        echo "<tr><td class='head'>"._AM_XHELP_TEXT_NAME."</td>
                  <td class='even'><input type='text' name='roleName' maxlength='35' value='".$role->getVar('name')."' class='formButton'></td>
              </tr>";
        echo "<tr><td class='head'>"._AM_XHELP_TEXT_DESCRIPTION."</td>
                  <td class='even'><textarea name='roleDescription' class='formButton'>".$role->getVar('description')."</textarea></td>
              </tr>";
        echo "<tr><td class='head'>"._AM_XHELP_TEXT_PERMISSIONS."</td>
                  <td class='even'>
                     <table border='0'>
                     <tr><td>";
        foreach($tasks as $bit_value => $task){
            if(($role->getVar('tasks') & pow(2, $bit_value)) > 0){
                echo "<tr><td><input type='checkbox' name='tasks[]' value='". pow(2,$bit_value) ."' checked='checked' />".$task."</td></tr>";
            } else {
                echo "<tr><td><input type='checkbox' name='tasks[]' value='". pow(2,$bit_value) ."' />".$task."</td></tr>";
            }
        }
        echo "<tr><td><input type='checkbox' name='allTasks' value='0' onclick='selectAll(this.form,\"tasks[]\",this.checked);' /><b>"._AM_XHELP_TEXT_SELECT_ALL."</b></td></tr>";
        echo "</table>
                  </td>
              </tr>";
        echo "<tr>
                  <td colspan='2' class='foot'>
                      <input type='submit' name='edit' value='". _AM_XHELP_BUTTON_UPDATE ."' class='formButton' />
                      <input type='button' name='cancel' value='"._AM_XHELP_BUTTON_CANCEL."' onclick='history.go(-1)' class='formButton' />
                      <input type='submit' name='deleteRole' value='"._AM_XHELP_BUTTON_DELETE."' class='formButton' />
                      
                  </td>
              </tr>";
        echo "</table></form>";
        include_once "admin_footer.php";
    } else {
        $role->setVar('name', $_POST['roleName']);
        $role->setVar('description', $_POST['roleDescription']);
        if(isset($_POST['tasks'])){
            $tasksValue = array_sum($_POST['tasks']);
        } else {
            $tasksValue = 0;
        }
        $role->setVar('tasks', $tasksValue);

        if(!$lastPage = $_xhelpSession->get("xhelp_return_op2")){
            $lastPage = $_xhelpSession->get("xhelp_return_op");
        }

        if($hRole->insert($role)){
            xhelpResetStaffUpdatedTime();

            $message = _AM_XHELP_MESSAGE_ROLE_UPDATE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            header("Location: ".XHELP_ADMIN_URL."/staff.php?op=$lastPage&uid=$uid");
        } else {
            $message = _AM_XHELP_MESSAGE_ROLE_UPDATE_ERROR;
            redirect_header(XHELP_ADMIN_URL."/staff.php?op=$lastPage&uid=$uid", 3, $message);
        }
    }
}

function editStaff()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $_POST, $_GET, $xoopsModule, $xoopsUser, $displayName;
function myFunction($a, $b) {
    // Do something
}
    require_once(XHELP_CLASS_PATH.'/session.php');
    $_xhelpSession = new Session();

    if (isset($_REQUEST['uid']))
    {
        $uid = $_REQUEST['uid'];
    }
    /*
     if(isset($_REQUEST['user'])){       // Remove me
     $uid = $_REQUEST['user'];
     }
     */
    if(isset($_POST['clearRoles'])){
        header("Location: ".XHELP_ADMIN_URL."/staff.php?op=clearRoles");
        exit();

    }

    $_xhelpSession->set("xhelp_return_op", "editStaff");

    if(!isset($_POST['updateStaff'])){
        //xoops_cp_header();
        $member_handler =& xoops_gethandler('member');          // Get member handler
        $member =& $member_handler->getUser($uid);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        $hRoles =& xhelpGetHandler('role');
        $crit = new Criteria('', '');
        $crit->setOrder('ASC');
        $crit->setSort('name');
        $roles =& $hRoles->getObjects($crit, true);

        $hDepartments  =& xhelpGetHandler('department');    // Get department handler
        $crit = new Criteria('','');
        $crit->setSort('department');
        $crit->setOrder('ASC');
        $total = $hDepartments->getCount($crit);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $departmentInfo =& $hDepartments->getObjects($crit);

        $hStaff =& xhelpGetHandler('staff');       // Get staff handler
        $staff =& $hStaff->getByUid($uid);
        $hMembership =& xhelpGetHandler('membership');
        $staffDepts = $hMembership->membershipByStaff($uid);
        $staffroles = $staff->getAllRoleRights();
        $global_roles = (isset($staffroles[0]['roles']) ? array_keys($staffroles[0]['roles']) : array());  //Get all Global Roles

        $xhelp_depts = array();
        foreach($staffDepts as $myDept){
            $deptid = $myDept->getVar('id');
            if($deptid != 0){
                $xhelp_depts[] = $deptid;
            }
        }
        $xhelp_depts = implode(',', $xhelp_depts);

        //$myRoles =& $hStaff->getRoles($staff->getVar('uid'));
        xoops_cp_header();
        //echo $oAdminButton->renderButtons('manStaff');
        $indexAdmin = new ModuleAdmin();
        echo $indexAdmin->addNavigation('staff.php?op=editStaff');

        echo '<script type="text/javascript" src="'.XOOPS_URL.'/modules/xhelp/include/functions.js"></script>';
        echo "<form name='frmEditStaff' method='post' action='staff.php?op=editStaff&amp;uid=".$uid."'>";
        echo "<table width='100%' border='0' cellspacing='1' class='outer'>
              <tr><th colspan='2'><label>"._AM_XHELP_EDIT_STAFF ."</label></th></tr>";
        echo "<tr><td class='head' width='20%'>". _AM_XHELP_TEXT_USER ."</td>
                  <td class='even'>". xhelpGetUsername($member, $displayName);
        echo "</td></tr>";
        echo "<tr><td class='head'>". _AM_XHELP_TEXT_ROLES ."</td>
                  <td class='even'><table width='75%'>";

        foreach($roles as $role){
            $roleid = $role->getVar('id');
            if (in_array($roleid, $global_roles)) {
                echo "<tr><td><input type='checkbox' name='roles[]' checked='checked' value='". $role->getVar('id')."' onclick=\"xhelpRoleCustOnClick('frmEditStaff', 'roles[]', 'xhelp_role', '&amp;', 'xhelp_dept_cust');\" /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
            } else {
                if($mainRoles = $_xhelpSession->get("xhelp_mainRoles")){
                    if(in_array($roleid, $mainRoles)){
                        echo "<tr><td><input type='checkbox' name='roles[]' checked='checked' value='". $role->getVar('id')."' onclick=\"xhelpRoleCustOnClick('frmEditStaff', 'roles[]', 'xhelp_role', '&amp;', 'xhelp_dept_cust');\" /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                    } else {
                        echo "<tr><td><input type='checkbox' name='roles[]'  value='". $role->getVar('id')."' onclick=\"xhelpRoleCustOnClick('frmEditStaff', 'roles[]', 'xhelp_role', '&amp;', 'xhelp_dept_cust');\" /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                    }
                } else {
                    echo "<tr><td><input type='checkbox' name='roles[]'  value='". $role->getVar('id')."' onclick=\"xhelpRoleCustOnClick('frmEditStaff', 'roles[]', 'xhelp_role', '&amp;', 'xhelp_dept_cust');\" /><a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $uid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                }
            }
        }
        echo "<tr><td><input type='checkbox' name='checkallRoles' value='0' onclick='selectAll(this.form,\"roles[]\",this.checked); xhelpRoleCustOnClick(\"frmEditStaff\", \"roles[]\", \"xhelp_role\", \"&amp;\", \"xhelp_dept_cust\");' /><b>"._AM_XHELP_TEXT_SELECT_ALL."</b></td></tr>";
        echo "</table></td></tr>";
        echo "<tr><td class='head'>". _AM_XHELP_TEXT_DEPARTMENTS ."</td>
                  <td class='even'><table width='75%'>";
         
        // This block is used to append custom role names to each department
        foreach($departmentInfo as $dept) {
            $deptid   = $dept->getVar('id');
            $deptname = $dept->getVar('department');
            $inDept   = false;  //Is the user a member of the dept
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $deptroleids   = '';
            $deptrolenames = '';

            if ($sess_roles = $_xhelpSession->get("xhelp_dept_$deptid")) {  //Customized roles stored in session?
                if ($sess_roles['roles'] != -1) {                           //Is the user assigned to any roles in the dept?
                    $inDept = true;
                    foreach($sess_roles['roles'] as $roleid){   // Check if customized roles match global roles
                        if(in_array($roleid, $global_roles)){   // If found role in global roles
                            $deptroleids[] = $roleid;           // Add role to array of checked roles
                        }
                    }
                    $deptroleids = implode(',', $sess_roles['roles']);  // Put all roles into 1 string separated by a ','

                    //An empty string means dept roles match global roles
                    if (strlen($deptroleids) > 0) { //Customized Roles
                        $deptrolenames = implode(', ', $sess_roles['roleNames']);
                    }
                } else {                                //Not a member of the dept
                    $inDept = false;
                }
            } elseif (isset($staffroles[$deptid])) {    //User has assigned dept roles
                $inDept = true;

                if ($staffroles[$deptid]['roles'] == $staffroles[0]['roles']) { // If global roles same as dept roles
                    $deptrolenames = '';
                    $deptroleids   = array();
                    foreach($staffroles[$deptid]['roles'] as $roleid=>$tasks){
                        if(isset($roles[$roleid])){
                            $deptroleids[] = $roleid;
                        }
                    }
                    $deptroleids = implode(',', $deptroleids);
                } else {
                    $deptrolenames = array();
                    $deptroleids   = array();
                    foreach($staffroles[$deptid]['roles'] as $roleid=>$tasks) {
                        if (isset($roles[$roleid])) {
                            $deptroleids[]   = $roleid;
                            $deptrolenames[] = $roles[$roleid]->getVar('name');
                        }
                    }
                    $deptrolenames = implode(', ', $deptrolenames);
                    $deptroleids   = implode(',', $deptroleids);
                }
            } else {        //Not a member of the dept
                $deptroleids = array();
                foreach($staffroles[0]['roles'] as $roleid=>$tasks){
                    if(isset($roles[$roleid])){
                        $deptroleids[] = $roleid;
                    }
                }
                $deptroleids = implode(',', $deptroleids);
                $deptrolenames = '';

                $inDept = false;
            }

            //Should element be checked?
            $checked = ($inDept ? "checked='checked'" : '');

            printf("<tr><td><input type='checkbox' name='departments[]' value='%u' %s onclick=\"xhelpRoleCustOnClick('frmEditStaff', 'departments[]', 'xhelp_depts', '&amp;', 'xhelp_dept_cust');\" />%s [<a href='staff.php?op=customDept&amp;deptid=%u&amp;uid=%u&amp;xhelp_role=%s&amp;xhelp_depts=%s' class='xhelp_dept_cust'>Customize</a>] <i>%s</i><input type='hidden' name='custrole[%u]' value='%s' /></td></tr>", $deptid, $checked, $deptname, $deptid, $uid, $deptroleids, $xhelp_depts, $deptrolenames, $deptid, $deptroleids);
        }
        echo "<tr><td>
                  <input type='checkbox' name='checkAll' value='0' onclick='selectAll(this.form,\"departments[]\", this.checked);xhelpRoleCustOnClick(\"frmEditStaff\", \"departments[]\", \"xhelp_depts\", \"&amp;\", \"xhelp_dept_cust\");' /><b>"._AM_XHELP_TEXT_SELECT_ALL."</b></td></tr>";
        echo "<tr><td>";
        echo "</td></tr>";
        echo "</table>";
        echo "</td></tr>";
        echo "<tr><td colspan='2' class='foot'>
                  <input type='hidden' name='uid' value='".$uid."' />
                  <input type='submit' name='updateStaff' value='". _AM_XHELP_BUTTON_UPDATESTAFF ."' />
                  <input type='button' name='cancel' value='"._AM_XHELP_BUTTON_CANCEL."' onclick='history.go(-1)' class='formButton' />
              </td></tr>";
        echo "</table></form>";

        include_once "admin_footer.php";
    } else {
        $uid       = intval($_POST['uid']);
        $depts     = $_POST['departments'];
        $roles     = $_POST['roles'];
        $custroles = $_POST['custrole'];
         
        $hStaff      =& xhelpGetHandler('staff');
        $hMembership =& xhelpGetHandler('membership');

        //Remove existing dept membership
        if(!$hMembership->clearStaffMembership($uid)){
            $message = _XHELP_MESSAGE_EDITSTAFF_NOCLEAR_ERROR;
            redirect_header(XHELP_ADMIN_URL.'/staff.php?op=manageStaff', 3, $message);
        }

        //Add staff member to selected depts
        if($hMembership->addDeptToStaff($depts, $uid)){
            $message = _XHELP_MESSAGE_EDITSTAFF;
        } else {
            $message = _XHELP_MESSAGE_EDITSTAFF_ERROR;
        }

        //Clear Existing Staff Role Permissions
        $removedRoles = $hStaff->removeStaffRoles($uid);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //Add Global Role Permissions
        foreach($roles as $role){
            $hStaff->addStaffRole($uid, $role, 0);
        }

        //Add Department Specific Roles
        foreach($depts as $dept){
            if (strlen($custroles[$dept]) > 0) {
                $dept_roles = explode(',', $custroles[$dept]);
            } else {
                $dept_roles = $roles;
            }

            foreach ($dept_roles as $role) {
                $hStaff->addStaffRole($uid, $role, $dept);
            }
        }

        $staff =& $hStaff->getByUid($uid);
        $staff->setVar('permTimestamp', time());
        if(!$hStaff->insert($staff)){
            $message = _XHELP_MESSAGE_EDITSTAFF;
        }
         
        redirect_header(XHELP_ADMIN_URL.'/staff.php?op=clearRoles', 3, $message);
    }//end if
}//end function

function manageStaff()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsModule, $xoopsUser, $displayName, $aLimitByS, $aLimitByD;
function myFunction($a, $b) {
    // Do something
}
    require_once(XHELP_CLASS_PATH.'/session.php');
    $_xhelpSession = new Session();
    $_xhelpSession->del("xhelp_return_page");

    $start = $limit = 0;
    $dstart = $dlimit = 0;
    $staff_search = false;
    $dept_search = false;

    if(isset($_POST['addRole'])){
        header("Location: ".XHELP_ADMIN_URL."/staff.php?op=addRole");
        exit();

    }
    if(isset($_POST['clearRoles'])){
        header("Location: ".XHELP_ADMIN_URL."/staff.php?op=clearRoles");
        exit();

    }

    if (isset($_REQUEST['limit'])) {
        $limit = intval($_REQUEST['limit']);
    }

    if (isset($_REQUEST['start'])) {
        $start = intval($_REQUEST['start']);
    }
    if(isset($_REQUEST['staff_search'])) {
        $staff_search = $_REQUEST['staff_search'];
    }

    if(isset($_REQUEST['dept_search'])) {
        $dept_search = $_REQUEST['dept_search'];
    }

    if (!$limit) {
        $limit = 20;
    }

    if (isset($_REQUEST['dlimit'])) {
        $dlimit = intval($_REQUEST['dlimit']);
    }

    if (isset($_REQUEST['dstart'])) {
        $dstart = intval($_REQUEST['dstart']);
    }

    if (!$dlimit) {
        $dlimit = 10;
    }

    $_xhelpSession->set("xhelp_return_op", "manageStaff");

    if(!isset($_POST['addStaff'])){

        $member_handler =& xoops_gethandler('member');          // Get member handler
        $hStaff         =& xhelpGetHandler('staff');       // Get staff handler
        $hDepartments  =& xhelpGetHandler('department');    // Get department handler
        $hRoles =& xhelpGetHandler('role');

        //Get List of depts in system
        $crit = new Criteria('','');
        $crit->setSort('department');
        $crit->setOrder('ASC');

        $dept_count = $hDepartments->getCount($crit);
        $dept_obj   =& $hDepartments->getObjects($crit);
        xoops_cp_header();
        //echo $oAdminButton->renderButtons('manStaff');
        $indexAdmin = new ModuleAdmin();
        echo $indexAdmin->addNavigation('staff.php?op=manageStaff');

        if(isset($_GET['uid'])){
            $userid = intval($_GET['uid']);
            $uname = $xoopsUser->getUnameFromId($userid);
        } else {
            $userid = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $uname = '';
        }

        if ($dept_count > 0) {
            $userid = (isset($_GET['uid']) ? intval($_GET['uid']) : 0);

            //Get List of staff members
            $crit = new Criteria('', '');
            $crit->setStart($start);
            $crit->setLimit($limit);

            $staff_obj   =& $hStaff->getObjects($crit);
            $staff_count = $hStaff->getCount($crit);
            $user_count = $member_handler->getUserCount();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $nav = new xhelpPageNav($staff_count, $limit, $start, 'start', "op=manageStaff&amp;limit=$limit");

            //Get List of Staff Roles
            $crit = new Criteria('', '');
            $crit->setOrder('ASC');
            $crit->setSort('name');
            $roles =& $hRoles->getObjects($crit);

            echo '<script type="text/javascript" src="'.XOOPS_URL.'/modules/xhelp/include/functions.js"></script>';
            echo "<form method='post' id='manageStaff' name='manageStaff' action='staff.php?op=manageStaff'>";
            echo "<table width='100%' cellspacing='1' class='outer'>
                  <tr><th colspan='2'>"._AM_XHELP_ADD_STAFF."</th></tr>";

            echo "<tr><td class='head' width='20%'>". _AM_XHELP_TEXT_USER ."</td>
                      <td class='even'>
                          <input type='text' id='fullname' name='fullname' class='formButton' value='".$uname."' disabled='disabled' style='background-color:#E1E1E1;' onchange=\"window.location='staff.php?op=manageStaff&amp;uid='+user_id.value;\" />
                          <input type='hidden' id='user_id' name='user_id' class='formButton' value='".$userid."' />";
            echo "&nbsp;<a href=\"javascript:openWithSelfMain('".XHELP_BASE_URL."/lookup.php?admin=1', 'lookup',400, 300);\" title='"._AM_XHELP_TEXT_FIND_USERS."'>"._AM_XHELP_TEXT_FIND_USERS."</a>
                      </td>
                  </tr>";

            echo "</td></tr>";
            echo "<tr><td class='head' width='20%'>". _AM_XHELP_TEXT_ROLES ."</td>
                      <td class='even'><table width='75%'>";
            if($mainRoles = $_xhelpSession->get("xhelp_mainRoles")){
                foreach($roles as $role){
                    if(!in_array($role->getVar('id'), $mainRoles)){
                        echo "<tr><td><input type='checkbox' name='roles[]' value='". $role->getVar('id')."' onclick=\"xhelpRoleCustOnClick('manageStaff', 'roles[]', 'xhelp_role', '&amp;', 'xhelp_dept_cust');\" />
                              <a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $userid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                    } else {
                        echo "<tr><td><input type='checkbox' name='roles[]' value='". $role->getVar('id')."' checked='checked' onclick=\"xhelpRoleCustOnClick('manageStaff', 'roles[]', 'xhelp_role', '&amp;', 'xhelp_dept_cust');\" />
                              <a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $userid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                    }
                }
            } else {
                foreach($roles as $role){
                    echo "<tr><td><input type='checkbox' name='roles[]' value='". $role->getVar('id')."' onclick=\"xhelpRoleCustOnClick('manageStaff', 'roles[]', 'xhelp_role', '&amp;', 'xhelp_dept_cust');\" />
                          <a href='staff.php?op=editRole&amp;id=".$role->getVar('id')."&amp;uid=". $userid ."'>". $role->getVar('name') ."</a> - ". $role->getVar('description')."</td></tr>";
                }
            }
            echo "<tr><td><input type='checkbox' name='checkallRoles' value='0' onclick='selectAll(this.form,\"roles[]\",this.checked); xhelpRoleCustOnClick(\"manageStaff\", \"roles[]\", \"xhelp_role\", \"&amp;\", \"xhelp_dept_cust\");' /><b>"._AM_XHELP_TEXT_SELECT_ALL."</b></td></tr>";
            echo "</table></td></tr>";
            echo "<tr><td class='head' width='20%'>". _AM_XHELP_TEXT_DEPARTMENTS ."</td>
                  <td class='even' width='50%'><table width='75%'>";
            if($mainDepts =& $_xhelpSession->get("xhelp_mainDepts")){
                foreach($dept_obj as $dept){
                    $deptid = $dept->getVar('id');
                    $aDept = $_xhelpSession->get("xhelp_dept_$deptid");
                    $aDeptRoles = $aDept['roleNames'];
                    if(!empty($aDeptRoles) && is_array($aDeptRoles)){
                        $deptRoles = implode(", ", $aDeptRoles);
                    } else {
                        $deptRoles = '';
                    }
                    if(!in_array($dept->getVar('id'), $mainDepts)){
                        echo "<tr><td>
                              <input type='checkbox' name='departments[]' value='".$dept->getVar('id')."' onclick=\"xhelpRoleCustOnClick('manageStaff', 'departments[]', 'xhelp_depts', '&amp;', 'xhelp_dept_cust');\" />
                              ".$dept->getVar('department')." [<a href='staff.php?op=customDept&amp;deptid=".$dept->getVar('id')."&amp;uid=".$userid."' class='xhelp_dept_cust'>". _AM_XHELP_TEXT_CUSTOMIZE ."</a>] <i>". $deptRoles ."</i>
                              </td></tr>";
                    } else {
                        echo "<tr><td>
                              <input type='checkbox' name='departments[]' checked='checked' value='".$dept->getVar('id')."' onclick=\"xhelpRoleCustOnClick('manageStaff', 'departments[]', 'xhelp_depts', '&amp;', 'xhelp_dept_cust');\" />
                              ".$dept->getVar('department')." [<a href='staff.php?op=customDept&amp;deptid=".$dept->getVar('id')."&amp;uid=".$userid."' class='xhelp_dept_cust'>". _AM_XHELP_TEXT_CUSTOMIZE ."</a>] <i>". $deptRoles ."</i>
                              </td></tr>";
                    }
                }
            } else {
                foreach($dept_obj as $dept){
                    $deptid = $dept->getVar('id');
                    $aDept = $_xhelpSession->get("xhelp_dept_$deptid");
                    $aDeptRoles = $aDept['roleNames'];
                    if(!empty($aDeptRoles)){
                        $deptRoles = implode(", ", $aDeptRoles);
                    } else {
                        $deptRoles = '';
                    }
                    echo "<tr><td>
                          <input type='checkbox' name='departments[]' value='".$dept->getVar('id')."' onclick=\"xhelpRoleCustOnClick('manageStaff', 'departments[]', 'xhelp_depts', '&amp;', 'xhelp_dept_cust');\" />
                          ".$dept->getVar('department')." [<a href='staff.php?op=customDept&amp;deptid=".$dept->getVar('id')."&amp;uid=".$userid."' class='xhelp_dept_cust'>". _AM_XHELP_TEXT_CUSTOMIZE ."</a>] <i>". $deptRoles ."</i>
                          </td></tr>";
                }
            }
            echo "<tr><td><input type='checkbox' name='checkallDepts' value='0' onclick='selectAll(this.form,\"departments[]\",this.checked);xhelpRoleCustOnClick(\"manageStaff\", \"departments[]\", \"xhelp_depts\", \"&amp;\", \"xhelp_dept_cust\");' /><b>"._AM_XHELP_TEXT_SELECT_ALL."</b></td></tr>";
            echo "</table></td></tr>";
            echo "<tr><td colspan='2' class='foot'>
                  <input type='submit' name='addStaff' value='". _AM_XHELP_BUTTON_ADDSTAFF ."' />
                  <input type='submit' name='addRole' value='". _AM_XHELP_BUTTON_CREATE_ROLE ."' class='formButton' />
                  <input type='submit' name='clearRoles' value='"._AM_XHELP_BUTTON_CLEAR_PERMS."' class='formButton' />
                  </td></tr>";
            echo "</table></form>";

            echo "<form method='post' id='cleanStaff' name='cleanStaff' action='staff.php?op=clearOrphanedStaff'>";
            echo "<table width='100%' cellspacing='1' class='outer'>
                  <tr><th colspan='2'>"._AM_XHELP_TEXT_MAINTENANCE."</th></tr>";
            echo "<tr><td class='head' width='40%'>"._AM_XHELP_TEXT_ORPHANED."</td>
                      <td class='even'><input type='submit' name='cleanStaff' value='"._AM_XHELP_BUTTON_SUBMIT."' /></td>
                  </tr>";
            echo "</table></form>";

            if($staff_count > 0){
                //Get User Information for each staff member
                $staff_uids = array();
                foreach($staff_obj as $obj) {
                    $staff_uids[] = $obj->getVar('uid');
                }
                if($staff_search == false){
                    $crit = new Criteria('uid', '('.implode(',', $staff_uids).')', 'IN');
                } else {
                    $crit = new CriteriaCompo(new Criteria('uname',"%$staff_search%",'LIKE'), 'OR');
                    $crit->add(new Criteria('name',"%$staff_search%",'LIKE'), 'OR');
                    $crit->add(new Criteria('email',"%$staff_search%",'LIKE'), 'OR');
                }
                $staff_users = $member_handler->getUsers($crit);
                 
                if($dept_search == false){
                    $crit = new Criteria('', '');
                } else {
                    $crit = new Criteria('department', "%$dept_search%", 'LIKE');
                }
                $crit->setStart($dstart);
                $crit->setLimit($dlimit);

                $allDepts = $hDepartments->getObjects($crit, true);
                $dnav = new xhelpPageNav($hDepartments->getCount($crit), $dlimit, $dstart, 'dstart', "op=manageStaff&amp;start=$start&amp;limit=$limit&amp;dlimit=$dlimit", "tblManageStaff");

                echo "<form action='". XHELP_ADMIN_URL."/staff.php?op=manageStaff' style='margin:0; padding:0;' method='post'>";
                echo "<table width='100%' cellspacing='1' class='outer'>";
                echo "<tr><td align='right'>"._AM_XHELP_TEXT_STAFF .": "._AM_XHELP_BUTTON_SEARCH." <input type='text' name='staff_search' value='$staff_search' />
                          "._AM_XHELP_TEXT_NUMBER_PER_PAGE."<select name='limit'>";
                foreach($aLimitByS as $value=>$text){
                    ($limit == $value) ? $selected = "selected='selected'" : $selected = '';
                    echo "<option value='$value' $selected>$text</option>";
                }
                echo "</select>
                            &nbsp;&nbsp;&nbsp;
                            "._AM_XHELP_TEXT_DEPARTMENTS.": "._AM_XHELP_BUTTON_SEARCH."
                              <input type='text' name='dept_search' value='$dept_search' />
                            "._AM_XHELP_TEXT_NUMBER_PER_PAGE."
                              <select name='dlimit'>";
                foreach($aLimitByD as $value=>$text){
                    ($dlimit == $value) ? $selected = "selected='selected'" : $selected = '';
                    echo "<option value='$value' $selected>$text</option>";
                }
                echo "</select>
                            &nbsp;&nbsp;
                              <input type='submit' name='staff_select' id='staff_select' value='"._AM_XHELP_BUTTON_SUBMIT."' />
                          </td>
                      </tr>";
                echo "</table></form>";

                echo "<table width='100%' cellspacing='1' class='outer' id='tblManageStaff'>
                      <tr><th colspan='".(3+count($allDepts))."'><label>". _AM_XHELP_MANAGE_STAFF ."</label></th></tr>";
                echo "<tr class='head'><td rowspan='2'>"._AM_XHELP_TEXT_ID."</td><td rowspan='2'>"._AM_XHELP_TEXT_USER."</td><td colspan='".count($allDepts)."'>"._AM_XHELP_TEXT_DEPARTMENTS." ".$dnav->renderNav()."</td><td rowspan='2'>"._AM_XHELP_TEXT_ACTIONS."</td></tr>";
                echo "<tr class='head'>";
                foreach ($allDepts as $thisdept) echo "<td>".$thisdept->getVar('department')."</td>";
                echo "</tr>";
                $hMembership =& xhelpGetHandler('membership');
                $hStaffRole =& xhelpGetHandler('staffRole');
                foreach($staff_users as $staff){
                    $departments = $hMembership->membershipByStaff($staff->getVar('uid'), true);
                    echo "<tr class='even'><td>".$staff->getVar('uid')."</td><td>".$staff->getVar('uname')."</td>";
                    foreach ($allDepts as $thisdept) {
                        echo "<td><img src='".XOOPS_URL."/modules/xhelp/images/";
                        echo (array_key_exists($thisdept->getVar('id'), $departments)) ? "on" : "off";
                        echo ".png' /></td>";
                    }
                    echo "<td><a href='staff.php?op=editStaff&amp;uid=".$staff->getVar('uid')."'><img src='".XOOPS_URL."/modules/xhelp/images/button_edit.png' title='"._AM_XHELP_TEXT_EDIT."' name='editStaff' /></a>&nbsp;
                              <a href='delete.php?deleteStaff=1&amp;uid=".$staff->getVar('uid')."'><img src='".XOOPS_URL."/modules/xhelp/images/button_delete.png' title='"._AM_XHELP_TEXT_DELETE."' name='deleteStaff' /></a>
                          </td></tr>";
                }
                echo "</table><br />";
                echo "<div id='staff_nav'>".$nav->renderNav()."</div>";
            }
        } else {
            echo "<div id='readOnly' class='errorMsg'>";
            echo _AM_XHELP_TEXT_MAKE_DEPTS;
            echo "</div>";
            echo "<br /><a href='department.php?op=manageDepartments'>". _AM_XHELP_LINK_ADD_DEPT ."</a>";
        }

        include_once "admin_footer.php";
    } else {
        $uid = $_POST['user_id'];
        $depts = $_POST['departments'];
        $roles = $_POST['roles'];
        //$selectAll = $_POST['selectall'];

        $hStaff =& xhelpGetHandler('staff');

        if(!isset($uid) || $uid == ''){
            redirect_header(XHELP_ADMIN_URL.'/staff.php?op=manageStaff', 3, _AM_XHELP_STAFF_ERROR_USERS);
        }
        if (!isset($depts)) {
            redirect_header(XHELP_ADMIN_URL.'/staff.php?op=manageStaff', 3, _AM_XHELP_STAFF_ERROR_DEPTARTMENTS);
        }
        if (!isset($roles)) {
            redirect_header(XHELP_ADMIN_URL.'/staff.php?op=manageStaff', 3, _AM_XHELP_STAFF_ERROR_ROLES);
        }
        if($hStaff->isStaff($uid)){
            redirect_header(XHELP_ADMIN_URL.'/staff.php?op=manageStaff', 3, _AM_XHELP_STAFF_EXISTS);
        }

        $member_handler =& xoops_gethandler('member');          // Get member handler
        $newUser =& $member_handler->getUser($uid);

        $email = $newUser->getVar('email');
        if($hStaff->addStaff($uid, $email)){    // $selectAll
            $message = _XHELP_MESSAGE_ADDSTAFF;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $hMembership =& xhelpGetHandler('membership');

            //Set Department Membership
            if($hMembership->addDeptToStaff($depts, $uid)){
                $message = _XHELP_MESSAGE_ADDSTAFF;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            } else {
                $message = _XHELP_MESSAGE_ADDSTAFF_ERROR;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            }

            //Set Global Roles
            foreach($roles as $role){
                $hStaff->addStaffRole($uid, $role, 0);
            }

            //Set Department Roles
            foreach($depts as $dept){
                if($custRoles = $_xhelpSession->get("xhelp_dept_$dept")){
                    if($custRoles['roles'] != -1){
                        foreach($custRoles['roles'] as $role){
                            $hStaff->addStaffRole($uid, $role, $dept);
                        }
                    } else {
                        // If dept still checked, but no custom depts, give global roles to dept
                        foreach($roles as $role){
                            $hStaff->addStaffRole($uid, $role, $dept);
                        }
                    }
                } else {
                    foreach($roles as $role){
                        $hStaff->addStaffRole($uid, $role, $dept);
                    }
                }
            }
            $hTicketList =& xhelpGetHandler('ticketList');
            $hasTicketLists = $hTicketList->createStaffGlobalLists($uid);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            header("Location: ".XHELP_ADMIN_URL."/staff.php?op=clearRoles");
        } else {
            $message = _XHELP_MESSAGE_ADDSTAFF_ERROR;
            redirect_header(XHELP_ADMIN_URL.'/staff.php?op=clearRoles', 3, $message);
        }
    }//end if
}

Push — master ( 26776f...d9604e )

staff.php ➔ customDept() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

XoopsModules25x / xhelp

Push — master ( 26776f...d9604e )

staff.php ➔ customDept() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
