main.php ➔ xhelp_default() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/xhelp - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 26776f...d9604e )

by Michael
created 2016-06-01 04:10 UTC
main.php ➔ xhelp_default() D

↳ Parent: Project
Complexity

Conditions	13
Paths	36
Size

Total Lines	146
Code Lines	117
Duplication

Lines	10
Ratio	6.85 %
Importance

Changes
Metric	Value
cc	13
eloc	117
nc	36
nop	0
dl	10
loc	146
rs	4.9922
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

//$Id: index.php,v 1.144 2005/11/29 17:48:12 ackbarr Exp $
include('../../../include/cp_header.php');
include_once('admin_header.php');
include_once(XOOPS_ROOT_PATH . '/class/pagenav.php');
define('MAX_STAFF_RESPONSETIME', 5);
define('MAX_STAFF_CALLSCLOSED', 5);

global $HTTP_GET_VARS, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
$module_id = $xoopsModule->getVar('mid');

$op = 'default';

if ( isset( $_REQUEST['op'] ) )
{
    $op = $_REQUEST['op'];
}

switch ( $op )
{
    case "about":
        about();
        break;

    case "mailEvents":
        mailEvents();
        break;

    case "searchMailEvents":
        searchMailEvents();
        break;

    case "blocks":
        require 'myblocksadmin.php';
        break;

    case "createdir":
        createdir();
        break;

    case "setperm":
        setperm();
        break;

    case "manageFields":
        manageFields();
        break;
         
    default:
        xhelp_default();
        break;
}

function modifyTicketFields()
{
    //xoops_cp_header();
    //echo "not created yet";
    xoops_cp_footer();
}

function displayEvents($mailEvents, $mailboxes)
{
    echo "<table width='100%' cellspacing='1' class='outer'>";
    if(count($mailEvents) > 0){
        echo "<tr><th colspan='4'>"._AM_XHELP_TEXT_MAIL_EVENTS."</th></tr>";
        echo "<tr class='head'><td>"._AM_XHELP_TEXT_MAILBOX."</td>
                              <td>"._AM_XHELP_TEXT_EVENT_CLASS."</td>
                              <td>"._AM_XHELP_TEXT_DESCRIPTION."</td>
                              <td>"._AM_XHELP_TEXT_TIME."</td>
             </tr>";

        $class = 'odd';
        foreach($mailEvents as $event){
            echo "<tr class='". $class ."'><td>".$mailboxes[$event->getVar('mbox_id')]->getVar('emailaddress')."</td>
                      <td>".xhelpGetEventClass($event->getVar('event_class'))."</td>
                      <td>".$event->getVar('event_desc')."</td>
                      <td>".$event->posted()."</td>
                  </tr>";
            $class = ($class == 'odd') ? 'even' : 'odd';
        }

    } else {
        echo "<tr><th>"._AM_XHELP_TEXT_MAIL_EVENTS."</th></tr>";
        echo "<tr><td class='odd'>"._AM_XHELP_NO_EVENTS."</td></tr>";
    }
    echo "</table><br />";
    echo "<a href='index.php?op=searchMailEvents'>"._AM_XHELP_SEARCH_EVENTS."</a>";
}

function mailEvents()
{
    // Will display the last 50 mail events
    $hMailEvent =& xhelpGetHandler('mailEvent');
    $hDeptMbox =& xhelpGetHandler('departmentMailBox');
    $mailboxes =& $hDeptMbox->getObjects(null, true);

    $crit = new Criteria('', '');
    $crit->setLimit(50);
    $crit->setOrder('DESC');
    $crit->setSort('posted');
    $mailEvents =& $hMailEvent->getObjects($crit);

    xoops_cp_header();
    //echo $oAdminButton->renderButtons('mailEvents');
    $indexAdmin = new ModuleAdmin();
    echo $indexAdmin->addNavigation('main.php');

    displayEvents($mailEvents, $mailboxes);

    include_once "admin_footer.php";
}

function searchMailEvents()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    xoops_cp_header();
    //echo $oAdminButton->renderButtons('mailEvents');
    $indexAdmin = new ModuleAdmin();
    echo $indexAdmin->addNavigation('main.php');

    if(!isset($_POST['searchEvents'])){

        $stylePath = include_once XHELP_INCLUDE_PATH.'/calendar/calendarjs.php';
        echo '<link rel="stylesheet" type="text/css" media="all" href="'.$stylePath.'" /><!--[if gte IE 5.5000]><script src="iepngfix.js" language="JavaScript" type="text/javascript"></script><![endif]-->';

        echo "<form method='post' action='".XHELP_ADMIN_URL."/index.php?op=searchMailEvents'>";

        echo "<table width='100%' cellspacing='1' class='outer'>";
        echo "<tr><th colspan='2'>"._AM_XHELP_SEARCH_EVENTS."</th></tr>";
        echo "<tr><td width='20%' class='head'>"._AM_XHELP_TEXT_MAILBOX."</td>
                  <td class='even'><input type='text' size='55' name='email' class='formButton'></td></tr>";
        echo "<tr><td class='head'>"._AM_XHELP_TEXT_DESCRIPTION."</td>
                  <td class='even'><input type='text' size='55' name='description' class='formButton'></td></tr>";
        echo "<tr><td class='head'>"._AM_XHELP_SEARCH_BEGINEGINDATE."</td>
                  <td class='even'><input type='text' name='begin_date' id='begin_date' size='10' maxlength='10' value='".formatTimestamp(time(), 'mysql')."' />
                                  <a href='' onclick='return showCalendar(\"begin_date\");'><img src='".XHELP_IMAGE_URL."/calendar.png' alt='Calendar image' name='calendar' style='vertical-align:bottom;border:0;background:transparent' /></a>&nbsp;";
        xhelpDrawHourSelect("begin_hour", 12);
        xhelpDrawMinuteSelect("begin_minute");
        xhelpDrawModeSelect("begin_mode");
        echo "<tr><td class='head'>"._AM_XHELP_SEARCH_ENDDATE."</td>
                  <td class='even'><input type='text' name='end_date' id='end_date' size='10' maxlength='10' value='".formatTimestamp(time(), 'mysql')."' />
                                  <a href='' onclick='return showCalendar(\"end_date\");'><img src='".XHELP_IMAGE_URL."/calendar.png' alt='Calendar image' name='calendar' style='vertical-align:bottom;border:0;background:transparent' /></a>&nbsp;";
        xhelpDrawHourSelect("end_hour", 12);
        xhelpDrawMinuteSelect("end_minute");
        xhelpDrawModeSelect("end_mode");
        echo "<tr><td class='foot' colspan='2'><input type='submit' name='searchEvents' value='"._AM_XHELP_BUTTON_SEARCH."' /></td></tr>";
        echo "</table>";
        echo "</form>";

        include_once "admin_footer.php";
    } else {
        $hMailEvent =& xhelpGetHandler('mailEvent');
        $hDeptMbox =& xhelpGetHandler('departmentMailBox');
        $mailboxes =& $hDeptMbox->getObjects(null, true);

        $begin_date = explode( '-', $_POST['begin_date']);
        $end_date = explode('-', $_POST['end_date']);
        $begin_hour = xhelpChangeHour($_POST['begin_mode'], $_POST['begin_hour']);
        $end_hour = xhelpChangeHour($_POST['end_mode'], $_POST['end_hour']);

        // Get timestamps to search by
        $begin_time = mktime($begin_hour, $_POST['begin_minute'], 0, $begin_date[1], $begin_date[2], $begin_date[0]);
        $end_time = mktime($end_hour, $_POST['end_minute'], 0, $end_date[1], $end_date[2], $end_date[0]);

        $crit = new CriteriaCompo(new Criteria('posted', $begin_time, '>='));
        $crit->add(new Criteria('posted', $end_time, '<='));
        if($_POST['email'] != ''){
            $email = $_POST['email'];
            $crit->add(new Criteria('emailaddress', "%$email%", "LIKE", "d"));
        }
        if($_POST['description'] != ''){
            $description = $_POST['description'];
            $crit->add(new Criteria('event_desc', "%$description%", "LIKE"));
        }
        $crit->setOrder('DESC');
        $crit->setSort('posted');
        if(isset($email)){
            $mailEvents =& $hMailEvent->getObjectsJoin($crit);
        } else {
            $mailEvents =& $hMailEvent->getObjects($crit);
        }

        displayEvents($mailEvents, $mailboxes);

        include_once "admin_footer.php";
    }
}

/**
 * changes hour to am/pm
 *
 * @param int $mode, 1-am, 2-pm
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
 * @param int $hour hour of the day
 *
 * @return hour in 24 hour mode

 */
function xhelpChangeHour($mode, $hour)
{
    $mode = intval($mode);
    $hour = intval($hour);

    if($mode == 2){
        $hour = $hour + 12;

        return $hour;
    }

    return $hour;
}

function xhelpDrawHourSelect($name, $lSelect="-1")
{
    echo "<select name='".$name."'>";
    for($i = 1; $i <= 12; $i++){
        if($lSelect == $i){
            $selected = "selected='selected'";
        } else {
            $selected = '';
        }
        echo "<option value='".$i."'".$selected.">".$i."</option>";
    }
    echo "</select>";
}

function xhelpDrawMinuteSelect($name)
{
    $lSum = 0;

    echo "<select name='".$name."'>";
    for($i = 0; $lSum <= 50; $i++){
        if($i == 0){
            echo "<option value='00' selected='selected'>00</option>";
        } else {
            $lSum = $lSum + 5;
            echo "<option value='".$lSum."'>".$lSum."</option>";
        }
    }
    echo "</select>";
}

function xhelpDrawModeSelect($name, $sSelect='AM')
{
    echo "<select name='".$name."'>";
    if($sSelect == 'AM'){
        echo "<option value='1' selected='selected'>AM</option>";
        echo "<option value='2'>PM</option>";
    } else {
        echo "<option value='1'>AM</option>";
        echo "<option value='2' selected='selected'>PM</option>";
    }
}

function xhelp_default()
{
    global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
    xoops_cp_header();
    //echo $oAdminButton->renderButtons('index');
    $indexAdmin = new ModuleAdmin();
    echo $indexAdmin->addNavigation('main.php');

    $displayName =& $xoopsModuleConfig['xhelp_displayName'];    // Determines if username or real name is displayed

    $stylePath = XHELP_BASE_URL.'/styles/xhelp.css';
    echo '<link rel="stylesheet" type="text/css" media="all" href="'.$stylePath.'" /><!--[if gte IE 5.5000]><script src="iepngfix.js" language="JavaScript" type="text/javascript"></script><![endif]-->';

    global $xoopsUser, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $hTickets =& xhelpGetHandler('ticket');
    $hStatus =& xhelpGetHandler('status');

    $crit = new Criteria('', '');
    $crit->setSort('description');
    $crit->setOrder('ASC');
    $statuses =& $hStatus->getObjects($crit);
    $table_class = array('odd', 'even');
    echo "<table border='0' width='100%'>";
    echo "<tr><td width='50%' valign='top'>";
    echo "<div id='ticketInfo'>";
    echo "<table border='0' width='95%' cellspacing='1' class='outer'>
          <tr><th colspan='2'>". _AM_XHELP_TEXT_TICKET_INFO ."</th></tr>";
    $class = "odd";
    $totalTickets = 0;
    foreach($statuses as $status){
        $crit = new Criteria('status', $status->getVar('id'));
        $numTickets =& $hTickets->getCount($crit);
        $totalTickets += $numTickets;

        echo "<tr class='".$class."'><td>".$status->getVar('description')."</td><td>".$numTickets."</td></tr>";
        if($class == "odd"){
            $class = "even";
        } else {
            $class = "odd";
        }
    }
    echo "<tr class='foot'><td>"._AM_XHELP_TEXT_TOTAL_TICKETS."</td><td>".$totalTickets."</td></tr>";
    echo "</table></div><br />";

    $hStaff =& xhelpGetHandler('staff');
    $hResponses =& xhelpGetHandler('responses');
    echo "</td><td valign='top'>";    // Outer table
    echo "<div id='timeSpent'>";    // Start inner top-left cell
    echo "<table border='0' width='100%' cellspacing='1' class='outer'>
          <tr><th colspan='2'>". _AM_XHELP_TEXT_RESPONSE_TIME ."</th></tr>";

    $sql = sprintf('SELECT u.uid, u.uname, u.name, (s.responseTime / s.ticketsResponded) as AvgResponseTime FROM %s u INNER JOIN %s s ON u.uid = s.uid WHERE ticketsResponded > 0 ORDER BY AvgResponseTime', $xoopsDB->prefix('users'), $xoopsDB->prefix('xhelp_staff'));
    $ret = $xoopsDB->query($sql, MAX_STAFF_RESPONSETIME);
    $i = 0;
    while (list($uid, $uname, $name, $avgResponseTime) = $xoopsDB->fetchRow($ret)) {
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        $class = $table_class[$i % 2];
        echo "<tr class='$class'><td>". xhelpGetDisplayName($displayName, $name,$uname) ."</td><td align='right'>". xhelpFormatTime($avgResponseTime) ."</td></tr>";
        $i++;
    }
    echo "</table></div><br />"; // End inner top-left cell
    echo "</td></tr><tr><td valign='top'>"; // End first, start second cell

    //Get Calls Closed block
    $sql = sprintf('SELECT SUM(callsClosed) FROM %s', $xoopsDB->prefix('xhelp_staff'));
    $ret = $xoopsDB->query($sql);
    if (list($totalStaffClosed) = $xoopsDB->fetchRow($ret)) {
        if ($totalStaffClosed) {
            $sql = sprintf('SELECT u.uid, u.uname, u.name, s.callsClosed FROM %s u INNER JOIN %s s ON u.uid = s.uid WHERE s.callsClosed > 0 ORDER BY s.callsClosed DESC', $xoopsDB->prefix('users'), $xoopsDB->prefix('xhelp_staff'));
            $ret = $xoopsDB->query($sql, MAX_STAFF_CALLSCLOSED);
            echo "<div id='callsClosed'>";
            echo "<table border='0' width='95%' cellspacing='1' class='outer'>
                  <tr><th colspan='2'>". _AM_XHELP_TEXT_TOP_CLOSERS ."</th></tr>";
            $i = 0;
            while (list($uid, $uname, $name, $callsClosed) = $xoopsDB->fetchRow($ret)) {
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
                $class = $table_class[$i % 2];
                echo "<tr class='$class'><td>". xhelpGetDisplayName($displayName, $name,$uname) ."</td><td align='right'>". $callsClosed. ' ('.round(($callsClosed/$totalStaffClosed)*100, 2) ."%)</td></tr>";
                $i++;
            }
            echo "</table></div><br />"; // End inner table top row
            echo "</td><td valign='top'>"; // End top row of outer table

            $sql = sprintf('SELECT u.uid, u.uname, u.name, (s.responseTime / s.ticketsResponded) as AvgResponseTime FROM %s u INNER JOIN %s s ON u.uid = s.uid WHERE ticketsResponded > 0 ORDER BY AvgResponseTime DESC', $xoopsDB->prefix('users'), $xoopsDB->prefix('xhelp_staff'));
            $ret = $xoopsDB->query($sql, MAX_STAFF_RESPONSETIME);
            echo "<div id='leastCallsClosed'>";
            echo "<table border='0' width='100%' cellspacing='1' class='outer'>
                  <tr><th colspan='2'>". _AM_XHELP_TEXT_RESPONSE_TIME_SLOW ."</th></tr>";
            $i = 0;
            while (list($uid, $uname, $name, $avgResponseTime) = $xoopsDB->fetchRow($ret)) {
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
                $class = $table_class[$i % 2];
                echo "<tr class='$class'><td>". xhelpGetDisplayName($displayName, $name,$uname) ."</td><td align='right'>". xhelpFormatTime($avgResponseTime) ."</td></tr>";
                $i++;
            }
            echo "</table></div>";  // End first cell, second row of inner table
        }
    }
    echo "</td></tr></table><br />";   // End second cell, second row of inner table

    $crit = new Criteria('state', '2', '<>', 's');
    $crit->setSort('priority');
    $crit->setOrder('ASC');
    $crit->setLimit(10);
    $highPriority =& $hTickets->getObjects($crit);
    $has_highPriority = (count($highPriority) > 0);
    if($has_highPriority){
        echo "<div id='highPriority'>";
        echo "<table border='0' width='100%' cellspacing='1' class='outer'>
              <tr><th colspan='8'>". _AM_XHELP_TEXT_HIGH_PRIORITY ."</th></tr>";
        echo "<tr class='head'><td>". _AM_XHELP_TEXT_PRIORITY ."</td><td>". _AM_XHELP_TEXT_ELAPSED ."</td><td>". _AM_XHELP_TEXT_STATUS ."</td><td>". _AM_XHELP_TEXT_SUBJECT ."</td><td>". _AM_XHELP_TEXT_DEPARTMENT ."</td><td>". _AM_XHELP_TEXT_OWNER ."</td><td>". _AM_XHELP_TEXT_LAST_UPDATED ."</td><td>". _AM_XHELP_TEXT_LOGGED_BY ."</td></tr>";
        $i = 0;
        foreach($highPriority as $ticket){
            if($ticket->isOverdue()){
                $class = $table_class[$i % 2] . " overdue";
            } else {
                $class = $table_class[$i % 2];
            }
            $priority_url = "<img src='".XHELP_IMAGE_URL."/priority". $ticket->getVar('priority') .".png' alt='". $ticket->getVar('priority') ."' />";
            $subject_url = sprintf("<a href='".XHELP_BASE_URL."/ticket.php?id=". $ticket->getVar('id') ."' target='_BLANK'>%s</a>", $ticket->getVar('subject'));
            if($dept = $ticket->getDepartment()){
                $dept_url = sprintf("<a href='".XHELP_BASE_URL."/index.php?op=staffViewAll&amp;dept=". $dept->getVar('id') ."' target='_BLANK'>%s</a>", $dept->getVar('department'));
            } else {
                $dept_url = _AM_XHELP_TEXT_NO_DEPT;
            }
            if($ticket->getVar('ownership') <> 0){
                $owner_url = sprintf("<a href='".XOOPS_URL."/userinfo.php?uid=". $ticket->getVar('uid') ."' target='_BLANK'>%s</a>", xhelpGetUsername($ticket->getVar('ownership'), $displayName));
            } else {
                $owner_url = _AM_XHELP_TEXT_NO_OWNER;
            }
            $user_url = sprintf("<a href='".XOOPS_URL."/userinfo.php?uid=". $ticket->getVar('uid') ."' target='_BLANK'>%s</a>", xhelpGetUsername($ticket->getVar('uid'), $displayName));
            echo "<tr class='$class'><td>". $priority_url ."</td>
                         <td>". $ticket->elapsed() ."</td>
                         <td>". xhelpGetStatus($ticket->getVar('status')) ."</td>
                         <td>". $subject_url ."</td>
                         <td>". $dept_url ."</td>
                         <td>". $owner_url ." </td>
                         <td>". $ticket->lastUpdated() ."</td>
                         <td>". $user_url ."</td>
                     </tr>";
            $i++;
        }
        echo "</table></div>";
    }

    pathConfiguration();

    include_once "admin_footer.php";
}

function pathConfiguration()
{
    global $xoopsModule, $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}

    // Upload and Images Folders

    $paths = array();
    $paths[_AM_XHELP_PATH_TICKETATTACH] = XHELP_UPLOAD_PATH;
    $paths[_AM_XHELP_PATH_EMAILTPL] = XHELP_BASE_PATH."/language/{$xoopsConfig['language']}";

    echo "<h3>"._AM_XHELP_PATH_CONFIG."</h3>";
    echo "<table width='100%' class='outer' cellspacing='1' cellpadding='3' border='0' ><tr>";
    echo "<td class='bg3'><b>" . _AM_XHELP_TEXT_DESCRIPTION . "</b></td>";
    echo "<td class='bg3'><b>" . _AM_XHELP_TEXT_PATH . "</b></td>";
    echo "<td class='bg3' align='center'><b>" . _AM_XHELP_TEXT_STATUS . "</b></td></tr>";

    foreach($paths as $desc=>$path) {
        echo "<tr><td class='odd'>$desc</td>";
        echo "<td class='odd'>$path</td>";
        echo "<td class='even' style='text-align: center;'>" . xhelp_admin_getPathStatus($path) . "</td></tr>";
    }

    echo "</table>";
    echo "<br />";

    echo "</div>";
}

function about()
{

    xoops_cp_header();
    //echo $oAdminButton->renderButtons();
    $indexAdmin = new ModuleAdmin();
    echo $indexAdmin->addNavigation('main.php');

    require_once(XHELP_ADMIN_PATH."/about.php");
}

function createdir()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    $path = $_GET['path'];
    $res = xhelp_admin_mkdir($path);

    $msg = ($res)?_AM_XHELP_PATH_CREATED:_AM_XHELP_PATH_NOTCREATED;
    redirect_header(XHELP_ADMIN_URL.'/index.php', 2, $msg . ': ' . $path);
    exit();

}

function setperm()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    $path = $_GET['path'];
    $res = xhelp_admin_chmod($path, 0777);
    $msg = ($res ? _AM_XHELP_PATH_PERMSET : _AM_XHELP_PATH_NOTPERMSET);
    redirect_header(XHELP_ADMIN_URL.'/index.php', 2, $msg . ': ' . $path);
    exit();

}

Push — master ( 26776f...d9604e )

main.php ➔ xhelp_default() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

XoopsModules25x / xhelp

Push — master ( 26776f...d9604e )

main.php ➔ xhelp_default() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
