addTicket.php ➔ _saveTicket() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/xhelp - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 26776f...d9604e )

by Michael
created 2016-06-01 04:10 UTC
addTicket.php ➔ _saveTicket() B

↳ Parent: Project
Complexity

Conditions	5
Paths	4
Size

Total Lines	27
Code Lines	20
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	5
eloc	20
nc	4
nop	1
dl	0
loc	27
rs	8.439
c	0
b	0
f	0
<?php

//$Id: addTicket.php,v 1.88 2006/01/03 20:40:33 eric_juden Exp $
if(isset($_GET['deptid'])){
    $dept_id = intval($_GET['deptid']);
}

if(isset($_GET['view_id'])){
    $view_id = intval($_GET['view_id']);
    setCookie("xhelp_logMode", $view_id,time()+60*60*24*30);
    if(isset($dept_id)){
        header("Location: addTicket.php&deptid=$dept_id");
    } else {
        header("Location: addTicket.php");
    }
} else {
    if(!isset($_COOKIE['xhelp_logMode'])){
        setCookie("xhelp_logMode", 1, time()+60*60*24*30);
    } else {
        setCookie("xhelp_logMode", $_COOKIE['xhelp_logMode'], time()+60*60*24*30);
    }
}

require_once('header.php');
require_once(XHELP_INCLUDE_PATH.'/events.php');

/* $_eventsrv->advise('new_ticket', xhelp_notificationService::singleton());
 $_eventsrv->advise('new_ticket', xhelp_logService::singleton());
 $_eventsrv->advise('new_ticket', xhelp_cacheService::singleton());
 $_eventsrv->advise('new_response', xhelp_logService::singleton());
 $_eventsrv->advise('new_response', xhelp_notificationService::singleton());
 $_eventsrv->advise('update_owner', xhelp_notificationService::singleton());
 $_eventsrv->advise('update_owner', xhelp_logService::singleton()); */

$hTicket =& xhelpGetHandler('ticket');
$hStaff =& xhelpGetHandler('staff');
$hGroupPerm =& xoops_gethandler('groupperm');
$hMember =& xoops_gethandler('member');
$hMembership =& xhelpGetHandler('membership');
$hFieldDept =& xhelpGetHandler('ticketFieldDepartment');

$module_id = $xoopsModule->getVar('mid');

if($xoopsUser){
    if(!isset($dept_id)){
        $dept_id = xhelpGetMeta("default_department");
    }

    if(isset($_GET['saveTicket']) && $_GET['saveTicket'] == 1){
        _saveTicket();
    }

    if(!isset($_POST['addTicket'])){                           // Initial load of page
        $xoopsOption['template_main'] = 'xhelp_addTicket.html';             // Always set main template before including the header
        include(XOOPS_ROOT_PATH . '/header.php');

        $hDepartments  =& xhelpGetHandler('department');    // Department handler
        $crit = new Criteria('','');
        $crit->setSort('department');
        $departments =& $hDepartments->getObjects($crit);
        if(count($departments) == 0){
            $message = _XHELP_MESSAGE_NO_DEPTS;
            redirect_header(XHELP_BASE_URL."/index.php", 3, $message);
        }
        $aDept = array();
        $myGroups =& $hMember->getGroupsByUser($xoopsUser->getVar('uid'));
        if(($xhelp_isStaff) && ($xoopsModuleConfig['xhelp_deptVisibility'] == 0)){     // If staff are not applied
            foreach($departments as $dept){
                $deptid = $dept->getVar('id');
                $aDept[] = array('id'=>$deptid,
                                 'department'=>$dept->getVar('department'));
            }
        } else {
            foreach($departments as $dept){
                $deptid = $dept->getVar('id');
                foreach($myGroups as $group){   // Check for user to be in multiple groups
                    if($hGroupPerm->checkRight(_XHELP_GROUP_PERM_DEPT, $deptid, $group, $module_id)){
                        //Assign the first value to $dept_id incase the default department property not set
                        if ($dept_id == null) {
                            $dept_id = $deptid;
                        }
                        $aDept[] = array('id'=>$deptid,
                                         'department'=>$dept->getVar('department'));
                        break;
                    }
                }
            }
        }

        // User Dept visibility check
        if(empty($aDept)){
            $message = _XHELP_MESSAGE_NO_DEPTS;
            redirect_header(XHELP_BASE_URL."/index.php", 3, $message);
        }

        $xoopsTpl->assign('xhelp_isUser', true);

        if($xhelp_isStaff){
            $checkStaff =& $hStaff->getByUid($xoopsUser->getVar('uid'));
            if(!$hasRights = $checkStaff->checkRoleRights(XHELP_SEC_TICKET_ADD)){
                $message = _XHELP_MESSAGE_NO_ADD_TICKET;
                redirect_header(XHELP_BASE_URL."/index.php", 3, $message);
            }
            unset($checkStaff);

            if($hasRights = $xhelp_staff->checkRoleRights(XHELP_SEC_TICKET_OWNERSHIP, $dept_id)){
                $staff =& $hMembership->xoopsUsersByDept($dept_id);

                $aOwnership = array();
                $aOwnership[0] = _XHELP_NO_OWNER;
                foreach($staff as $stf){
                    $aOwnership[$stf->getVar('uid')] = $stf->getVar('uname');
                }
                $xoopsTpl->assign('xhelp_aOwnership', $aOwnership);
            } else {
                $xoopsTpl->assign('xhelp_aOwnership', false);
            }
        }

        $has_mimes = false;
        if($xoopsModuleConfig['xhelp_allowUpload']){
            // Get available mimetypes for file uploading
            $hMime =& xhelpGetHandler('mimetype');
            $xhelp =& xhelpGetModule();
            $mid = $xhelp->getVar('mid');
            if(!$xhelp_isStaff){
                $crit = new Criteria('mime_user', 1);
            } else {
                $crit = new Criteria('mime_admin', 1);
            }
            $mimetypes =& $hMime->getObjects($crit);
            $mimes = '';
            foreach($mimetypes as $mime){
                if($mimes == ''){
                    $mimes = $mime->getVar('mime_ext');
                } else {
                    $mimes .= ", " . $mime->getVar('mime_ext');
                }
            }
            $xoopsTpl->assign('xhelp_mimetypes', $mimes);
        }

        $xoopsTpl->assign('xhelp_has_logUser', false);
        if($xhelp_isStaff){
            $checkStaff =& $hStaff->getByUid($xoopsUser->getVar('uid'));
            if($hasRights = $checkStaff->checkRoleRights(XHELP_SEC_TICKET_LOGUSER)){
                $xoopsTpl->assign('xhelp_has_logUser', true);
            }
            unset($checkStaff);
        }

        // Get current dept's custom fields
        $fields =& $hFieldDept->fieldsByDepartment($dept_id, true);

        if (!$savedFields =& $_xhelpSession->get('xhelp_custFields')) {
            $savedFields = array();
        }

        $aFields = array();
        foreach($fields as $field){
            $values = $field->getVar('fieldvalues');
            if ($field->getVar('controltype') == XHELP_CONTROL_YESNO) {
                $values = array(1 => _YES, 0 => _NO);
            }

            // Check for values already submitted, and fill those values in
            if(array_key_exists($field->getVar('fieldname'), $savedFields)){
                $defaultValue = $savedFields[$field->getVar('fieldname')];
            } else {
                $defaultValue = $field->getVar('defaultvalue');
            }

            $aFields[$field->getVar('id')] =
            array('name' => $field->getVar('name'),
                      'desc' => $field->getVar('description'),
                      'fieldname' => $field->getVar('fieldname'),
                      'defaultvalue' => $defaultValue,
                      'controltype' => $field->getVar('controltype'),
                      'required' => $field->getVar('required'),
                      'fieldlength' => ($field->getVar('fieldlength') < 50 ? $field->getVar('fieldlength') : 50),
                      'maxlength' => $field->getVar('fieldlength'),
                      'weight' => $field->getVar('weight'),
                      'fieldvalues' => $values,
                      'validation' => $field->getVar('validation'));
        }
        $xoopsTpl->assign('xhelp_custFields', $aFields);
        if(!empty($aFields)){
            $xoopsTpl->assign('xhelp_hasCustFields', true);
        } else {
            $xoopsTpl->assign('xhelp_hasCustFields', false);
        }

        $javascript = "<script type=\"text/javascript\" src=\"". XHELP_BASE_URL ."/include/functions.js\"></script>
<script type=\"text/javascript\" src='".XHELP_SCRIPT_URL."/addTicketDeptChange.php?client'></script>
<script type=\"text/javascript\">
<!--
function departments_onchange()
{
    dept = xoopsGetElementById('departments');
    var wl = new xhelpweblib(fieldHandler);
    wl.customfieldsbydept(dept.value);\n";

        if($xhelp_isStaff){
            $javascript .= "var w = new xhelpweblib(staffHandler);
        w.staffbydept(dept.value);\n";
        }
        $javascript .= "}

var staffHandler = {
    staffbydept: function(result){";
        if($xhelp_isStaff){
            if (isset($_COOKIE['xhelp_logMode']) && $_COOKIE['xhelp_logMode'] == 2 && $xhelp_staff->checkRoleRights(XHELP_SEC_TICKET_OWNERSHIP, $dept_id)) {
                $javascript .= "var sel = gE('owner');";
                $javascript .= "xhelpFillStaffSelect(sel, result);\n";
            }
        }
        $javascript .= "}
}

var fieldHandler = {
    customfieldsbydept: function(result){
        var tbl = gE('tblAddTicket');\n";
        if ($xhelp_isStaff && isset($_COOKIE['xhelp_logMode']) && $_COOKIE['xhelp_logMode'] == 2) {
            $javascript.="var beforeele = gE('privResponse');\n";
        } else {
            $javascript.="var beforeele = gE('addButtons');\n";
        }
        $javascript.="tbody = tbl.tBodies[0];\n";
        $javascript .="xhelpFillCustomFlds(tbody, result, beforeele);
    }
}

function window_onload()
{
    xhelpDOMAddEvent(xoopsGetElementById('departments'), 'change', departments_onchange, true);
}

window.setTimeout('window_onload()', 1500);
//-->
</script>";
        $xoopsTpl->assign('xhelp_baseURL', XHELP_BASE_URL);
        $xoopsTpl->assign('xhelp_includeURL', XHELP_INCLUDE_URL);
        $xoopsTpl->assign('xoops_module_header', $javascript. $xhelp_module_header);
        $xoopsTpl->assign('xhelp_allowUpload', $xoopsModuleConfig['xhelp_allowUpload']);
        $xoopsTpl->assign('xhelp_text_lookup', _XHELP_TEXT_LOOKUP);
        $xoopsTpl->assign('xhelp_text_email', _XHELP_TEXT_EMAIL);
        $xoopsTpl->assign('xhelp_imagePath', XOOPS_URL . '/modules/xhelp/images/');
        $xoopsTpl->assign('xhelp_departments', $aDept);
        $xoopsTpl->assign('xhelp_current_file', basename(__file__));
        $xoopsTpl->assign('xhelp_priorities', array(5, 4, 3, 2, 1));
        $xoopsTpl->assign('xhelp_priorities_desc', array('5' => _XHELP_PRIORITY5, '4' => _XHELP_PRIORITY4,'3' => _XHELP_PRIORITY3, '2' => _XHELP_PRIORITY2, '1' => _XHELP_PRIORITY1));
        $xoopsTpl->assign('xhelp_default_priority', XHELP_DEFAULT_PRIORITY);
        $xoopsTpl->assign('xhelp_currentUser', $xoopsUser->getVar('uid'));
        $xoopsTpl->assign('xhelp_numTicketUploads', $xoopsModuleConfig['xhelp_numTicketUploads']);
        if(isset($_POST['logFor'])){
            $uid = $_POST['logFor'];
            $username = $xoopsUser->getUnameFromId($uid);
            $xoopsTpl->assign('xhelp_username', $username);
            $xoopsTpl->assign('xhelp_user_id', $uid);
        } else {
            $uid = $xoopsUser->getVar('uid');
            $username = $xoopsUser->getVar('uname');
            $xoopsTpl->assign('xhelp_username', $username);
            $xoopsTpl->assign('xhelp_user_id', $uid);
        }
        $xoopsTpl->assign('xhelp_isStaff', $xhelp_isStaff);
        if(!isset($_COOKIE['xhelp_logMode'])){
            $xoopsTpl->assign('xhelp_logMode', 1);
        } else {
            $xoopsTpl->assign('xhelp_logMode', $_COOKIE['xhelp_logMode']);
        }

        if($xhelp_isStaff){
            if(isset($_COOKIE['xhelp_logMode']) && $_COOKIE['xhelp_logMode'] == 2){
                $hStatus =& xhelpGetHandler('status');
                $crit = new Criteria('', '');
                $crit->setSort('description');
                $crit->setOrder('ASC');
                $statuses =& $hStatus->getObjects($crit);
                $aStatuses = array();
                foreach($statuses as $status){
                    $aStatuses[$status->getVar('id')] = array('id' => $status->getVar('id'),
                                                              'desc' => $status->getVar('description'),
                                                              'state' => $status->getVar('state'));
                }

                $xoopsTpl->assign('xhelp_statuses', $aStatuses);
            }
            $xoopsTpl->assign('xhelp_savedSearches', $aSavedSearches);
        }

        $errors = array();
        $aElements = array();
        if($validateErrors =& $_xhelpSession->get('xhelp_validateError')){
            foreach($validateErrors as $fieldname=>$error){
                if(!empty($error['errors'])){
                    $aElements[] = $fieldname;
                    foreach($error['errors'] as $err){
                        $errors[$fieldname] = $err;
                    }
                }
            }
            $xoopsTpl->assign('xhelp_errors', $errors);
        } else {
            $xoopsTpl->assign('xhelp_errors', null);
        }

        $elements = array('subject', 'description');
        foreach($elements as $element){         // Foreach element in the predefined list
            $xoopsTpl->assign("xhelp_element_$element", "formButton");
            foreach($aElements as $aElement){   // Foreach that has an error
                if($aElement == $element){      // If the names are equal
                    $xoopsTpl->assign("xhelp_element_$element", "validateError");
                    break;
                }
            }
        }

        if ($ticket =& $_xhelpSession->get('xhelp_ticket')) {
            $xoopsTpl->assign('xhelp_ticket_uid', $ticket['uid']);
            $xoopsTpl->assign('xhelp_ticket_username', $xoopsUser->getUnameFromId($ticket['uid']));
            $xoopsTpl->assign('xhelp_ticket_subject', stripslashes($ticket['subject']));
            $xoopsTpl->assign('xhelp_ticket_description', stripslashes($ticket['description']));
            $xoopsTpl->assign('xhelp_ticket_department', $ticket['department']);
            $xoopsTpl->assign('xhelp_ticket_priority', $ticket['priority']);
        } else {
            $xoopsTpl->assign('xhelp_ticket_uid', $uid);
            $xoopsTpl->assign('xhelp_ticket_username', $username);
            $xoopsTpl->assign('xhelp_ticket_subject', null);
            $xoopsTpl->assign('xhelp_ticket_description', null);
            $xoopsTpl->assign('xhelp_ticket_department', $dept_id);
            $xoopsTpl->assign('xhelp_ticket_priority', XHELP_DEFAULT_PRIORITY);
        }

        if($response =& $_xhelpSession->get('xhelp_response')){
            $xoopsTpl->assign('xhelp_response_uid', $response['uid']);
            $xoopsTpl->assign('xhelp_response_message', $response['message']);
            $xoopsTpl->assign('xhelp_response_timespent', $response['timeSpent']);
            $xoopsTpl->assign('xhelp_response_userIP', $response['userIP']);
            $xoopsTpl->assign('xhelp_response_private', $response['private']);
            $xoopsTpl->assign('xhelp_ticket_status', $response['status']);
            $xoopsTpl->assign('xhelp_ticket_ownership', $response['owner']);
        } else {
            $xoopsTpl->assign('xhelp_response_uid', null);
            $xoopsTpl->assign('xhelp_response_message', null);
            $xoopsTpl->assign('xhelp_response_timeSpent', null);
            $xoopsTpl->assign('xhelp_response_userIP', null);
            $xoopsTpl->assign('xhelp_response_private', null);
            $xoopsTpl->assign('xhelp_ticket_status', 1);
            $xoopsTpl->assign('xhelp_ticket_ownership', 0);
        }

        require(XOOPS_ROOT_PATH.'/footer.php');                             //Include the page footer
    } else {
        $dept_id = intval($_POST['departments']);

        require_once(XHELP_CLASS_PATH.'/validator.php');
        $v = array();
        $v['subject'][] = new ValidateLength($_POST['subject'], 2, 255);
        $v['description'][] = new ValidateLength($_POST['description'], 2);

        // Get current dept's custom fields
        $fields =& $hFieldDept->fieldsByDepartment($dept_id, true);
        $aFields = array();

        foreach($fields as $field){
            $values = $field->getVar('fieldvalues');
            if ($field->getVar('controltype') == XHELP_CONTROL_YESNO) {
                $values = array(1 => _YES, 0 => _NO);
            }
            $fieldname = $field->getVar('fieldname');

            if($field->getVar('controltype') != XHELP_CONTROL_FILE) {
                $checkField = $_POST[$fieldname];
            } else {
                $checkField = $_FILES[$fieldname];
            }

            $v[$fieldname][] = new ValidateRegex($checkField, $field->getVar('validation'), $field->getVar('required'));

            $aFields[$field->getVar('id')] =
            array('name' => $field->getVar('name'),
                      'desc' => $field->getVar('description'),
                      'fieldname' => $field->getVar('fieldname'),
                      'defaultvalue' => $field->getVar('defaultvalue'),
                      'controltype' => $field->getVar('controltype'),
                      'required' => $field->getVar('required'),
                      'fieldlength' => $field->getVar('fieldlength'),
                      'maxlength' => ($field->getVar('fieldlength') < 50 ? $field->getVar('fieldlength') : 50),
                      'weight' => $field->getVar('weight'),
                      'fieldvalues' => $values,
                      'validation' => $field->getVar('validation'));
        }

        _saveTicket($aFields);      // Save ticket information in a session
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        // Perform each validation
        $fields = array();
        $errors = array();
        foreach($v as $fieldname=>$validator) {
            if (!xhelpCheckRules($validator, $errors)) {
                //Mark field with error
                $fields[$fieldname]['haserrors'] = true;
                $fields[$fieldname]['errors'] = $errors;
            } else {
                $fields[$fieldname]['haserrors'] = false;
            }
        }

        if(!empty($errors)){
            $_xhelpSession->set('xhelp_validateError', $fields);
            $message = _XHELP_MESSAGE_VALIDATE_ERROR;
            header("Location: ".XHELP_BASE_URL."/addTicket.php");
            exit();
        }

        //$hTicket =& xhelpGetHandler('ticket');
        $ticket =& $hTicket->create();
        $ticket->setVar('uid', $_POST['user_id']);
        $ticket->setVar('subject', $_POST['subject']);
        $ticket->setVar('description', $_POST['description']);
        $ticket->setVar('department', $dept_id);
        $ticket->setVar('priority', $_POST['priority']);
        if($xhelp_isStaff && $_COOKIE['xhelp_logMode'] == 2){
            $ticket->setVar('status', $_POST['status']);    // Set status
            if (isset($_POST['owner'])) {  //Check if user claimed ownership
                if ($_POST['owner'] > 0) {
                    $oldOwner = 0;
                    $_xhelpSession->set('xhelp_oldOwner', $oldOwner);
                    $ticket->setVar('ownership', $_POST['owner']);
                    $_xhelpSession->set('xhelp_changeOwner', true);
                }
            }
            $_xhelpSession->set('xhelp_ticket_ownership', $_POST['owner']);  // Store in session
        } else {
            $ticket->setVar('status', 1);
        }
        $ticket->setVar('posted', time());
        $ticket->setVar('userIP', getenv("REMOTE_ADDR"));
        $ticket->setVar('overdueTime', $ticket->getVar('posted') + ($xoopsModuleConfig['xhelp_overdueTime'] *60*60));

        $aUploadFiles = array();
        if($xoopsModuleConfig['xhelp_allowUpload']){
            foreach($_FILES as $key=>$aFile){
                $pos = strpos($key, 'userfile');
                if($pos !== false && is_uploaded_file($aFile['tmp_name'])){     // In the userfile array and uploaded file?
                    if ($ret = $ticket->checkUpload($key, $allowed_mimetypes, $errors)) {
                        $aUploadFiles[$key] = $aFile;
                    } else {
                        $errorstxt = implode('<br />', $errors);
                        $message = sprintf(_XHELP_MESSAGE_FILE_ERROR, $errorstxt);
                        redirect_header(XHELP_BASE_URL."/addTicket.php", 5, $message);
                    }
                }
            }
        }

        if($hTicket->insert($ticket)){

            $hMember =& xoops_gethandler('member');
            $newUser =& $hMember->getUser($ticket->getVar('uid'));
            $ticket->addSubmitter($newUser->getVar('email'), $newUser->getVar('uid'));

            if(count($aUploadFiles) > 0){   // Has uploaded files?
                foreach($aUploadFiles as $key=>$aFile){
                    $file = $ticket->storeUpload($key, null, $allowed_mimetypes);
                    $_eventsrv->trigger('new_file', array(&$ticket, &$file));
                }
            }
             
            // Add custom field values to db
            $hTicketValues = xhelpGetHandler('ticketValues');
            $ticketValues = $hTicketValues->create();

            foreach($aFields as $field){
                $fieldname = $field['fieldname'];
                $fieldtype = $field['controltype'];

                if($fieldtype == XHELP_CONTROL_FILE){               // If custom field was a file upload
                    if($xoopsModuleConfig['xhelp_allowUpload']){    // If uploading is allowed
                        if(is_uploaded_file($_FILES[$fieldname]['tmp_name'])){
                            if (!$ret = $ticket->checkUpload($fieldname, $allowed_mimetypes, $errors)) {
                                $errorstxt = implode('<br />', $errors);

                                $message = sprintf(_XHELP_MESSAGE_FILE_ERROR, $errorstxt);
                                redirect_header(XHELP_BASE_URL."/addTicket.php", 5, $message);
                            }
                            if($file = $ticket->storeUpload($fieldname, -1, $allowed_mimetypes)){
                                $ticketValues->setVar($fieldname, $file->getVar('id') . "_" . $_FILES[$fieldname]['name']);
                            }
                        }
                    }
                } else {
                    $fieldvalue = $_POST[$fieldname];
                    $ticketValues->setVar($fieldname, $fieldvalue);
                }
            }
            $ticketValues->setVar('ticketid', $ticket->getVar('id'));

            if(!$hTicketValues->insert($ticketValues)){
                $message = _XHELP_MESSAGE_NO_CUSTFLD_ADDED;
            }

            $_eventsrv->trigger('new_ticket', array(&$ticket));

            if ($_xhelpSession->get('xhelp_changeOwner')) {
                $oldOwner = $_xhelpSession->get('xhelp_oldOwner');
                $_eventsrv->trigger('update_owner', array(&$ticket, $oldOwner, $xoopsUser->getVar('uid')));
                $_xhelpSession->del('xhelp_changeOwner');
                $_xhelpSession->del('xhelp_oldOwner');
                $_xhelpSession->del('xhelp_ticket_ownership');
            }

            // Add response
            if($xhelp_isStaff && $_COOKIE['xhelp_logMode'] == 2){     // Make sure user is a staff member and is using advanced form
                if($_POST['response'] != ''){                   // Don't run if no value for response
                    $hResponse =& xhelpGetHandler('responses');
                    $newResponse =& $hResponse->create();
                    $newResponse->setVar('uid', $xoopsUser->getVar('uid'));
                    $newResponse->setVar('ticketid', $ticket->getVar('id'));
                    $newResponse->setVar('message', $_POST['response']);
                    $newResponse->setVar('timeSpent', $_POST['timespent']);
                    $newResponse->setVar('updateTime', $ticket->getVar('posted'));
                    $newResponse->setVar('userIP', $ticket->getVar('userIP'));
                    if(isset($_POST['private'])){
                        $newResponse->setVar('private', $_POST['private']);
                    }
                    if($hResponse->insert($newResponse)){
                        $_eventsrv->trigger('new_response', array(&$ticket, &$newResponse));
                        $_xhelpSession->del('xhelp_response');
                    }
                }
            }

            $_xhelpSession->del('xhelp_ticket');
            $_xhelpSession->del('xhelp_validateError');
            $_xhelpSession->del('xhelp_custFields');

            $message = _XHELP_MESSAGE_ADDTICKET;
        } else {
            //$_xhelpSession->set('xhelp_ticket', $ticket);
            $message = _XHELP_MESSAGE_ADDTICKET_ERROR . $ticket->getHtmlErrors();     // Unsuccessfully added new ticket
        }
        redirect_header(XHELP_BASE_URL."/index.php", 5, $message);
    }
} else {    // If not a user
    $config_handler =& xoops_gethandler('config');
    //$xoopsConfigUser =& $config_handler->getConfigsByCat(XOOPS_CONF_USER);
    $xoopsConfigUser = array();
    $crit = new CriteriaCompo(new Criteria('conf_name', 'allow_register'), 'OR');
    $crit->add(new Criteria('conf_name', 'activation_type'), 'OR');
    $myConfigs =& $config_handler->getConfigs($crit);

    foreach($myConfigs as $myConf){
        $xoopsConfigUser[$myConf->getVar('conf_name')] = $myConf->getVar('conf_value');
    }
    if ($xoopsConfigUser['allow_register'] == 0) {    // Use to doublecheck that anonymous users are allowed to register
        header("Location: ".XHELP_BASE_URL."/error.php");
    } else {
        header("Location: ".XHELP_BASE_URL."/anon_addTicket.php");
    }
    exit();
}

function _saveTicket($fields = "")
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $_xhelpSession, $xhelp_isStaff;
function myFunction($a, $b) {
    // Do something
}
    $_xhelpSession->set('xhelp_ticket',
    array('uid' => $_POST['user_id'],
                        'subject' => $_POST['subject'],
                        'description' => htmlspecialchars($_POST['description'], ENT_QUOTES),
                        'department' => $_POST['departments'],
                        'priority' => $_POST['priority']));

    if($xhelp_isStaff && $_COOKIE['xhelp_logMode'] == 2){
        $_xhelpSession->set('xhelp_response',
        array('uid' => $_POST['user_id'],
                            'message' => $_POST['response'],
                            'timeSpent' => $_POST['timespent'],
                            'userIP' => getenv("REMOTE_ADDR"),
                            'private' => (isset($_POST['private'])) ? 1 : 0,
                            'status' => $_POST['status'],
                            'owner' => $_POST['owner']));
    }

    if($fields != ""){
        $_xhelpSession->set('xhelp_custFields', $fields);
    }

    return true;
}

Push — master ( 26776f...d9604e )

addTicket.php ➔ _saveTicket() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

XoopsModules25x / xhelp

Push — master ( 26776f...d9604e )

addTicket.php ➔ _saveTicket() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
