XoopsModules25x /
xhelp
| Conditions | 20 |
| Paths | 4920 |
| Total Lines | 282 |
| Code Lines | 209 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php declare(strict_types=1); |
||
| 321 | function modifyEmailTpl() |
||
| 322 | { |
||
| 323 | global $xoopsConfig, $session; |
||
| 324 | $helper = Helper::getInstance(); |
||
| 325 | |||
| 326 | if (is_dir(XOOPS_ROOT_PATH . '/modules/xhelp/language/' . $xoopsConfig['language'] . '/mail_template')) { |
||
| 327 | $opendir = opendir(XOOPS_ROOT_PATH . '/modules/xhelp/language/' . $xoopsConfig['language'] . '/mail_template/'); |
||
| 328 | $dir = XOOPS_ROOT_PATH . '/modules/xhelp/language/' . $xoopsConfig['language'] . '/mail_template/'; |
||
| 329 | $url = XOOPS_URL . '/modules/xhelp/language/' . $xoopsConfig['language'] . '/mail_template/'; |
||
| 330 | } else { |
||
| 331 | $opendir = opendir(XOOPS_ROOT_PATH . '/modules/xhelp/language/english/mail_template/'); |
||
| 332 | $dir = XOOPS_ROOT_PATH . '/modules/xhelp/language/english/mail_template/'; |
||
| 333 | $url = XOOPS_URL . '/modules/xhelp/language/english/mail_template/'; |
||
| 334 | } |
||
| 335 | |||
| 336 | $notNames = [ |
||
| 337 | _MI_XHELP_DEPT_NEWTICKET_NOTIFYTPL => [ |
||
| 338 | _MI_XHELP_DEPT_NEWTICKET_NOTIFY, |
||
| 339 | _MI_XHELP_DEPT_NEWTICKET_NOTIFYDSC, |
||
| 340 | _MI_XHELP_DEPT_NEWTICKET_NOTIFYTPL, |
||
| 341 | ], |
||
| 342 | _MI_XHELP_DEPT_REMOVEDTICKET_NOTIFYTPL => [ |
||
| 343 | _MI_XHELP_DEPT_REMOVEDTICKET_NOTIFY, |
||
| 344 | _MI_XHELP_DEPT_REMOVEDTICKET_NOTIFYDSC, |
||
| 345 | _MI_XHELP_DEPT_REMOVEDTICKET_NOTIFYTPL, |
||
| 346 | ], |
||
| 347 | _MI_XHELP_DEPT_NEWRESPONSE_NOTIFYTPL => [ |
||
| 348 | _MI_XHELP_DEPT_NEWRESPONSE_NOTIFY, |
||
| 349 | _MI_XHELP_DEPT_NEWRESPONSE_NOTIFYDSC, |
||
| 350 | _MI_XHELP_DEPT_NEWRESPONSE_NOTIFYTPL, |
||
| 351 | ], |
||
| 352 | _MI_XHELP_DEPT_MODIFIEDRESPONSE_NOTIFYTPL => [ |
||
| 353 | _MI_XHELP_DEPT_MODIFIEDRESPONSE_NOTIFY, |
||
| 354 | _MI_XHELP_DEPT_MODIFIEDRESPONSE_NOTIFYDSC, |
||
| 355 | _MI_XHELP_DEPT_MODIFIEDRESPONSE_NOTIFYTPL, |
||
| 356 | ], |
||
| 357 | _MI_XHELP_DEPT_MODIFIEDTICKET_NOTIFYTPL => [ |
||
| 358 | _MI_XHELP_DEPT_MODIFIEDTICKET_NOTIFY, |
||
| 359 | _MI_XHELP_DEPT_MODIFIEDTICKET_NOTIFYDSC, |
||
| 360 | _MI_XHELP_DEPT_MODIFIEDTICKET_NOTIFYTPL, |
||
| 361 | ], |
||
| 362 | _MI_XHELP_DEPT_CHANGEDSTATUS_NOTIFYTPL => [ |
||
| 363 | _MI_XHELP_DEPT_CHANGEDSTATUS_NOTIFY, |
||
| 364 | _MI_XHELP_DEPT_CHANGEDSTATUS_NOTIFYDSC, |
||
| 365 | _MI_XHELP_DEPT_CHANGEDSTATUS_NOTIFYTPL, |
||
| 366 | ], |
||
| 367 | _MI_XHELP_DEPT_CHANGEDPRIORITY_NOTIFYTPL => [ |
||
| 368 | _MI_XHELP_DEPT_CHANGEDPRIORITY_NOTIFY, |
||
| 369 | _MI_XHELP_DEPT_CHANGEDPRIORITY_NOTIFYDSC, |
||
| 370 | _MI_XHELP_DEPT_CHANGEDPRIORITY_NOTIFYTPL, |
||
| 371 | ], |
||
| 372 | _MI_XHELP_DEPT_NEWOWNER_NOTIFYTPL => [ |
||
| 373 | _MI_XHELP_DEPT_NEWOWNER_NOTIFY, |
||
| 374 | _MI_XHELP_DEPT_NEWOWNER_NOTIFYDSC, |
||
| 375 | _MI_XHELP_DEPT_NEWOWNER_NOTIFYTPL, |
||
| 376 | ], |
||
| 377 | _MI_XHELP_DEPT_CLOSETICKET_NOTIFYTPL => [ |
||
| 378 | _MI_XHELP_DEPT_CLOSETICKET_NOTIFY, |
||
| 379 | _MI_XHELP_DEPT_CLOSETICKET_NOTIFYDSC, |
||
| 380 | _MI_XHELP_DEPT_CLOSETICKET_NOTIFYTPL, |
||
| 381 | ], |
||
| 382 | _MI_XHELP_TICKET_NEWOWNER_NOTIFYTPL => [ |
||
| 383 | _MI_XHELP_TICKET_NEWOWNER_NOTIFY, |
||
| 384 | _MI_XHELP_TICKET_NEWOWNER_NOTIFYDSC, |
||
| 385 | _MI_XHELP_TICKET_NEWOWNER_NOTIFYTPL, |
||
| 386 | ], |
||
| 387 | _MI_XHELP_TICKET_REMOVEDTICKET_NOTIFYTPL => [ |
||
| 388 | _MI_XHELP_TICKET_REMOVEDTICKET_NOTIFY, |
||
| 389 | _MI_XHELP_TICKET_REMOVEDTICKET_NOTIFYDSC, |
||
| 390 | _MI_XHELP_TICKET_REMOVEDTICKET_NOTIFYTPL, |
||
| 391 | ], |
||
| 392 | _MI_XHELP_TICKET_MODIFIEDTICKET_NOTIFYTPL => [ |
||
| 393 | _MI_XHELP_TICKET_MODIFIEDTICKET_NOTIFY, |
||
| 394 | _MI_XHELP_TICKET_MODIFIEDTICKET_NOTIFYDSC, |
||
| 395 | _MI_XHELP_TICKET_MODIFIEDTICKET_NOTIFYTPL, |
||
| 396 | ], |
||
| 397 | _MI_XHELP_TICKET_NEWRESPONSE_NOTIFYTPL => [ |
||
| 398 | _MI_XHELP_TICKET_NEWRESPONSE_NOTIFY, |
||
| 399 | _MI_XHELP_TICKET_NEWRESPONSE_NOTIFYDSC, |
||
| 400 | _MI_XHELP_TICKET_NEWRESPONSE_NOTIFYTPL, |
||
| 401 | ], |
||
| 402 | _MI_XHELP_TICKET_MODIFIEDRESPONSE_NOTIFYTPL => [ |
||
| 403 | _MI_XHELP_TICKET_MODIFIEDRESPONSE_NOTIFY, |
||
| 404 | _MI_XHELP_TICKET_MODIFIEDRESPONSE_NOTIFYDSC, |
||
| 405 | _MI_XHELP_TICKET_MODIFIEDRESPONSE_NOTIFYTPL, |
||
| 406 | ], |
||
| 407 | _MI_XHELP_TICKET_CHANGEDSTATUS_NOTIFYTPL => [ |
||
| 408 | _MI_XHELP_TICKET_CHANGEDSTATUS_NOTIFY, |
||
| 409 | _MI_XHELP_TICKET_CHANGEDSTATUS_NOTIFYDSC, |
||
| 410 | _MI_XHELP_TICKET_CHANGEDSTATUS_NOTIFYTPL, |
||
| 411 | ], |
||
| 412 | _MI_XHELP_TICKET_CHANGEDPRIORITY_NOTIFYTPL => [ |
||
| 413 | _MI_XHELP_TICKET_CHANGEDPRIORITY_NOTIFY, |
||
| 414 | _MI_XHELP_TICKET_CHANGEDPRIORITY_NOTIFYDSC, |
||
| 415 | _MI_XHELP_TICKET_CHANGEDPRIORITY_NOTIFYTPL, |
||
| 416 | ], |
||
| 417 | _MI_XHELP_TICKET_NEWTICKET_NOTIFYTPL => [ |
||
| 418 | _MI_XHELP_TICKET_NEWTICKET_NOTIFY, |
||
| 419 | _MI_XHELP_TICKET_NEWTICKET_NOTIFYDSC, |
||
| 420 | _MI_XHELP_TICKET_NEWTICKET_NOTIFYTPL, |
||
| 421 | ], |
||
| 422 | _MI_XHELP_TICKET_NEWTICKET_EMAIL_NOTIFYTPL => [ |
||
| 423 | _MI_XHELP_TICKET_NEWTICKET_EMAIL_NOTIFY, |
||
| 424 | _MI_XHELP_TICKET_NEWTICKET_EMAIL_NOTIFYDSC, |
||
| 425 | _MI_XHELP_TICKET_NEWTICKET_EMAIL_NOTIFYTPL, |
||
| 426 | ], |
||
| 427 | _MI_XHELP_TICKET_CLOSETICKET_NOTIFYTPL => [ |
||
| 428 | _MI_XHELP_TICKET_CLOSETICKET_NOTIFY, |
||
| 429 | _MI_XHELP_TICKET_CLOSETICKET_NOTIFYDSC, |
||
| 430 | _MI_XHELP_TICKET_CLOSETICKET_NOTIFYTPL, |
||
| 431 | ], |
||
| 432 | _MI_XHELP_TICKET_NEWUSER_NOTIFYTPL => [ |
||
| 433 | _MI_XHELP_TICKET_NEWUSER_NOTIFY, |
||
| 434 | _MI_XHELP_TICKET_NEWUSER_NOTIFYDSC, |
||
| 435 | _MI_XHELP_TICKET_NEWUSER_NOTIFYTPL, |
||
| 436 | ], |
||
| 437 | _MI_XHELP_TICKET_NEWUSER_ACT1_NOTIFYTPL => [ |
||
| 438 | _MI_XHELP_TICKET_NEWUSER_ACT1_NOTIFY, |
||
| 439 | _MI_XHELP_TICKET_NEWUSER_ACT1_NOTIFYDSC, |
||
| 440 | _MI_XHELP_TICKET_NEWUSER_ACT1_NOTIFYTPL, |
||
| 441 | ], |
||
| 442 | _MI_XHELP_TICKET_NEWUSER_ACT2_NOTIFYTPL => [ |
||
| 443 | _MI_XHELP_TICKET_NEWUSER_ACT2_NOTIFY, |
||
| 444 | _MI_XHELP_TICKET_NEWUSER_ACT2_NOTIFYDSC, |
||
| 445 | _MI_XHELP_TICKET_NEWUSER_ACT2_NOTIFYTPL, |
||
| 446 | ], |
||
| 447 | _MI_XHELP_TICKET_EMAIL_ERROR_NOTIFYTPL => [ |
||
| 448 | _MI_XHELP_TICKET_EMAIL_ERROR_NOTIFY, |
||
| 449 | _MI_XHELP_TICKET_EMAIL_ERROR_NOTIFYDSC, |
||
| 450 | _MI_XHELP_TICKET_EMAIL_ERROR_NOTIFYTPL, |
||
| 451 | ], |
||
| 452 | _MI_XHELP_DEPT_MERGE_TICKET_NOTIFYTPL => [ |
||
| 453 | _MI_XHELP_DEPT_MERGE_TICKET_NOTIFY, |
||
| 454 | _MI_XHELP_DEPT_MERGE_TICKET_NOTIFYDSC, |
||
| 455 | _MI_XHELP_DEPT_MERGE_TICKET_NOTIFYTPL, |
||
| 456 | ], |
||
| 457 | _MI_XHELP_TICKET_MERGE_TICKET_NOTIFYTPL => [ |
||
| 458 | _MI_XHELP_TICKET_MERGE_TICKET_NOTIFY, |
||
| 459 | _MI_XHELP_TICKET_MERGE_TICKET_NOTIFYDSC, |
||
| 460 | _MI_XHELP_TICKET_MERGE_TICKET_NOTIFYTPL, |
||
| 461 | ], |
||
| 462 | ]; |
||
| 463 | |||
| 464 | $notKeys = array_keys($notNames); |
||
| 465 | |||
| 466 | while (false !== ($file = readdir($opendir))) { |
||
| 467 | //Do not Display . |
||
| 468 | if (is_dir($file)) { |
||
| 469 | continue; |
||
| 470 | } |
||
| 471 | |||
| 472 | if (!in_array($file, $notKeys)) { |
||
| 473 | continue; |
||
| 474 | } |
||
| 475 | |||
| 476 | $aFile = []; |
||
| 477 | $aFile['name'] = $notNames[$file][0]; |
||
| 478 | $aFile['desc'] = $notNames[$file][1]; |
||
| 479 | $aFile['filename'] = $notNames[$file][2]; |
||
| 480 | $aFile['url'] = "notifications.php?op=modifyEmailTpl&file=$file"; |
||
| 481 | $aFiles[] = $aFile; |
||
| 482 | } |
||
| 483 | |||
| 484 | if (isset($_GET['file'])) { |
||
| 485 | xoops_cp_header(); |
||
| 486 | //echo $oAdminButton->renderButtons('manNotify'); |
||
| 487 | $adminObject = Admin::getInstance(); |
||
| 488 | $adminObject->addItemButton(_AM_XHELP_TEXT_MANAGE_NOTIFICATIONS, 'notifications.php?op=manage', 'add'); |
||
| 489 | $adminObject->addItemButton(_AM_XHELP_MENU_MODIFY_EMLTPL, 'notifications.php?op=modifyEmailTpl', 'list'); |
||
| 490 | |||
| 491 | $adminObject->displayNavigation(basename(__FILE__)); |
||
| 492 | $adminObject->displayButton('left'); |
||
| 493 | |||
| 494 | foreach ($aFiles as $file) { |
||
| 495 | if (\Xmf\Request::getString('file', '', 'GET') == $file['filename']) { |
||
| 496 | $myFileName = $file['filename']; |
||
| 497 | $myFileDesc = $file['desc']; |
||
| 498 | $myName = $file['name']; |
||
| 499 | break; |
||
| 500 | } |
||
| 501 | } |
||
| 502 | if (!$has_write = is_writable($dir . $myFileName)) { |
||
| 503 | $message = _AM_XHELP_MESSAGE_FILE_READONLY; |
||
| 504 | $handle = fopen($dir . $myFileName, 'rb'); |
||
| 505 | $fileSize = filesize($dir . $myFileName); |
||
| 506 | } elseif (Request::hasVar('editTemplate', 'POST')) { |
||
| 507 | $handle = fopen($dir . $myFileName, 'wb+'); |
||
| 508 | } else { |
||
| 509 | $handle = fopen($dir . $myFileName, 'rb+'); |
||
| 510 | $fileSize = filesize($dir . $myFileName); |
||
| 511 | } |
||
| 512 | |||
| 513 | if (Request::hasVar('editTemplate', 'POST')) { |
||
| 514 | if (Request::hasVar('templateText', 'POST')) { |
||
| 515 | $text = $_POST['templateText']; // Get new text for template |
||
| 516 | } else { |
||
| 517 | $text = ''; |
||
| 518 | } |
||
| 519 | |||
| 520 | if (!$returnPage = $session->get('xhelp_return_page')) { |
||
| 521 | $returnPage = false; |
||
| 522 | } |
||
| 523 | |||
| 524 | if (fwrite($handle, $text)) { |
||
| 525 | $message = _AM_XHELP_MESSAGE_FILE_UPDATED; |
||
| 526 | $fileSize = filesize($dir . $myFileName); |
||
| 527 | fclose($handle); |
||
| 528 | if ($returnPage) { |
||
| 529 | $helper->redirect((string)$returnPage); |
||
| 530 | } else { |
||
| 531 | $helper->redirect('admin/notifications.php'); |
||
| 532 | } |
||
| 533 | } else { |
||
| 534 | $message = _AM_XHELP_MESSAGE_FILE_UPDATED_ERROR; |
||
| 535 | $fileSize = filesize($dir . $myFileName); |
||
| 536 | fclose($handle); |
||
| 537 | if ($returnPage) { |
||
| 538 | $helper->redirect((string)$returnPage, 3, $message); |
||
| 539 | } else { |
||
| 540 | $helper->redirect('admin/notifications.php', 3, $message); |
||
| 541 | } |
||
| 542 | } |
||
| 543 | } |
||
| 544 | if (!$has_write) { |
||
| 545 | echo "<div id='readOnly' class='errorMsg'>"; |
||
| 546 | echo $message; |
||
| 547 | echo '</div>'; |
||
| 548 | } |
||
| 549 | |||
| 550 | echo "<form action='" . XHELP_ADMIN_URL . '/notifications.php?op=modifyEmailTpl&file=' . $myFileName . "' method='post'>"; |
||
| 551 | echo $GLOBALS['xoopsSecurity']->getTokenHTML(); |
||
| 552 | echo "<table width='100%' border='0' cellspacing='1' class='outer'> |
||
| 553 | <tr><th colspan='2'>" . $myName . "</th></tr> |
||
| 554 | <tr><td colspan='2' class='head'>" . $myFileDesc . '</td></tr>'; |
||
| 555 | |||
| 556 | echo "<tr class='odd'> |
||
| 557 | <td><textarea name='templateText' cols='40' rows='40'>" . fread($handle, $fileSize) . "</textarea></td> |
||
| 558 | <td valign='top'> |
||
| 559 | <b>" . _AM_XHELP_TEXT_GENERAL_TAGS . '</b> |
||
| 560 | <ul> |
||
| 561 | <li>' . _AM_XHELP_TEXT_GENERAL_TAGS1 . '</li> |
||
| 562 | <li>' . _AM_XHELP_TEXT_GENERAL_TAGS2 . '</li> |
||
| 563 | <li>' . _AM_XHELP_TEXT_GENERAL_TAGS3 . '</li> |
||
| 564 | <li>' . _AM_XHELP_TEXT_GENERAL_TAGS4 . '</li> |
||
| 565 | <li>' . _AM_XHELP_TEXT_GENERAL_TAGS5 . '</li> |
||
| 566 | </ul> |
||
| 567 | <br> |
||
| 568 | <u>' . _AM_XHELP_TEXT_TAGS_NO_MODIFY . '</u> |
||
| 569 | </td> |
||
| 570 | </tr>'; |
||
| 571 | |||
| 572 | if ($has_write) { |
||
| 573 | echo "<tr><td class='foot' colspan='2'><input type='submit' name='editTemplate' value='" . _AM_XHELP_BUTTON_UPDATE . "' class='formButton'></td></tr>"; |
||
| 574 | } |
||
| 575 | echo '</table></form>'; |
||
| 576 | } else { |
||
| 577 | xoops_cp_header(); |
||
| 578 | //echo $oAdminButton->renderButtons('manNotify'); |
||
| 579 | $adminObject = Admin::getInstance(); |
||
| 580 | $adminObject->addItemButton(_AM_XHELP_TEXT_MANAGE_NOTIFICATIONS, 'notifications.php?op=manage', 'add'); |
||
| 581 | $adminObject->addItemButton(_AM_XHELP_MENU_MODIFY_EMLTPL, 'notifications.php?op=modifyEmailTpl', 'list'); |
||
| 582 | |||
| 583 | $adminObject->displayNavigation(basename(__FILE__)); |
||
| 584 | $adminObject->displayButton('left'); |
||
| 585 | |||
| 586 | echo "<table width='100%' border='0' cellspacing='1' class='outer'> |
||
| 587 | <tr><th colspan='2'><label>" . _AM_XHELP_MENU_MODIFY_EMLTPL . "</label></th></tr> |
||
| 588 | <tr class='head'><td>" . _AM_XHELP_TEXT_TEMPLATE_NAME . '</td><td>' . _AM_XHELP_TEXT_DESCRIPTION . '</td></tr>'; |
||
| 589 | |||
| 590 | static $rowSwitch = 0; |
||
| 591 | foreach ($aFiles as $file) { |
||
| 592 | if (0 == $rowSwitch) { |
||
| 593 | echo "<tr class='odd'><td><a href='" . $file['url'] . "'>" . $file['name'] . '</a></td><td>' . $file['desc'] . '</td></tr>'; |
||
| 594 | $rowSwitch = 1; |
||
| 595 | } else { |
||
| 596 | echo "<tr class='even'><td><a href='" . $file['url'] . "'>" . $file['name'] . '</a></td><td>' . $file['desc'] . '</td></tr>'; |
||
| 597 | $rowSwitch = 0; |
||
| 598 | } |
||
| 599 | } |
||
| 600 | echo '</table>'; |
||
| 601 | } |
||
| 602 | require_once __DIR__ . '/admin_footer.php'; |
||
| 603 | } |
||
| 604 |
Loading history...