manageDepartments()

Complexity

Conditions	29
Paths	258

Size

Total Lines	253
Code Lines	172

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php declare(strict_types=1);
function manageDepartments()
{
    global $xoopsModule, $aSortBy, $aOrderBy, $aLimitBy, $order, $limit, $start, $sort, $dept_search;
    $module_id = $xoopsModule->getVar('mid');
    $helper    = Xhelp\Helper::getInstance();
    $deptID    = 0;

    /** @var \XoopsGroupHandler $groupHandler */
    $groupHandler = xoops_getHandler('group');
    /** @var \XoopsGroupPermHandler $grouppermHandler */
    $grouppermHandler = xoops_getHandler('groupperm');

    if (Request::hasVar('addDept', 'POST')) {
        $hasErrors = false;
        $errors    = [];
        $groups    = ($_POST['groups'] ?? []);
        /** @var \XoopsModules\Xhelp\DepartmentHandler $departmentHandler */
        $departmentHandler = $helper->getHandler('Department');

        //Department Name supplied?
        if ('' === trim(\Xmf\Request::getString('newDept', '', 'POST'))) {
            $hasErrors           = true;
            $errors['newDept'][] = _AM_XHELP_MESSAGE_NO_DEPT;
        } else {
            //Department Name unique?
            $criteria      = new \Criteria('department', \Xmf\Request::getString('newDept', '', 'POST'));
            $existingDepts = $departmentHandler->getCount($criteria);
            if ($existingDepts) {
                $hasErrors           = true;
                $errors['newDept'][] = _XHELP_MESSAGE_DEPT_EXISTS;
            }
        }

        if ($hasErrors) {
            $session = Xhelp\Session::getInstance();
            //Store existing dept info in session, reload addition page
            $aDept            = [];
            $aDept['newDept'] = \Xmf\Request::getString('newDept', '', 'POST');
            $aDept['groups']  = $groups;
            $session->set('xhelp_addDepartment', $aDept);
            $session->set('xhelp_addDepartmentErrors', $errors);
            redirect_header(Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/department.php', ['op' => 'manageDepartments'], false));

The constant XHELP_ADMIN_URL was not found. Maybe you did not declare it correctly or list all dependencies?

        }

        /** @var \XoopsModules\Xhelp\Department $department */
        $department = $departmentHandler->create();
        $department->setVar('department', \Xmf\Request::getString('newDept', '', 'POST'));

        if ($departmentHandler->insert($department)) {
            $deptID = $department->getVar('id');
            foreach ($groups as $group) {     // Add new group permissions
                $grouppermHandler->addRight(_XHELP_GROUP_PERM_DEPT, $deptID, $group, $module_id);
            }

            // Set as default department?
            if (Request::hasVar('defaultDept', 'POST') && (1 == $_POST['defaultDept'])) {
                Xhelp\Utility::setMeta('default_department', (string)$deptID);
            }

            /** @var \XoopsModules\Xhelp\StaffHandler $staffHandler */
            $staffHandler = $helper->getHandler('Staff');
            $allDeptStaff = $staffHandler->getByAllDepts();
            if (count($allDeptStaff) > 0) {
                /** @var \XoopsModules\Xhelp\MembershipHandler $membershipHandler */
                $membershipHandler = $helper->getHandler('Membership');
                if ($membershipHandler->addStaffToDept($allDeptStaff, $department->getVar('id'))) {
                    $message = _XHELP_MESSAGE_ADD_DEPT;
                } else {
                    $message = _AM_XHELP_MESSAGE_STAFF_UPDATE_ERROR;
                }
            } else {
                $message = _XHELP_MESSAGE_ADD_DEPT;
            }

            // Add configoption for new department
            /** @var \XoopsConfigHandler $configHandler */
            $configHandler = xoops_getHandler('config');
            /** @var \XoopsModules\Xhelp\ConfigOptionHandler $configOptionHandler */
            $configOptionHandler = $helper->getHandler('ConfigOption');

            $criteria = new \Criteria('conf_name', 'xhelp_defaultDept');
            $config   = $configHandler->getConfigs($criteria);

            if (count($config) > 0) {
                $newOption = $configOptionHandler->create();
                $newOption->setVar('confop_name', $department->getVar('department'));
                $newOption->setVar('confop_value', $department->getVar('id'));
                $newOption->setVar('conf_id', $config[0]->getVar('conf_id'));

                if (!$configOptionHandler->insert($newOption)) {
                    $helper->redirect('admin/department.php?op=manageDepartments', 3, _AM_XHELP_MSG_ADD_CONFIG_ERR);
                }
            }
            clearAddSessionVars();
            $helper->redirect('admin/department.php?op=manageDepartments');
        } else {
            $message = _XHELP_MESSAGE_ADD_DEPT_ERROR . $department->getHtmlErrors();
        }

        $deptID = $department->getVar('id');

The assignment to $deptID is dead and can be removed.

        /* Not sure if this is needed. Already exists in if block above (ej)
         foreach ($groups as $group) {
         $grouppermHandler->addRight(_XHELP_GROUP_PERM_DEPT, $deptID, $group, $module_id);
         }
         */

        $helper->redirect('admin/department.php?op=manageDepartments', 3, $message);
    } else {
        /** @var \XoopsModules\Xhelp\DepartmentHandler $departmentHandler */
        $departmentHandler = $helper->getHandler('Department');
        if (false !== $dept_search) {
            $criteria = new \Criteria('department', "%$dept_search%", 'LIKE');
        } else {
            $criteria = new \Criteria('', '');
        }
        $criteria->setOrder($order);
        $criteria->setSort($sort);
        $criteria->setLimit($limit);
        $criteria->setStart($start);
        $total          = $departmentHandler->getCount($criteria);
        $departmentInfo = $departmentHandler->getObjects($criteria);

        $nav = new \XoopsPageNav($total, $limit, $start, 'start', "op=manageDepartments&limit=$limit");

        // Get list of all groups
        $criteria = new \Criteria('', '');
        $criteria->setSort('name');
        $criteria->setOrder('ASC');
        $groups = $groupHandler->getObjects($criteria, true);

        $aGroups = [];
        foreach ($groups as $group_id => $group) {
            $aGroups[$group_id] = $group->getVar('name');
        }
        asort($aGroups);    // Set groups in alphabetical order

        xoops_cp_header();
        //echo $oAdminButton->renderButtons('manDept');
        $adminObject = Admin::getInstance();
        $adminObject->displayNavigation('department.php?op=manageDepartments');

        $session     = Xhelp\Session::getInstance();
        $sess_dept   = $session->get('xhelp_addDepartment');
        $sess_errors = $session->get('xhelp_addDepartmentErrors');

        //Display any form errors
        if (false === !$sess_errors) {
            xhelpRenderErrors($sess_errors, Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/department.php', ['op' => 'clearAddSession'], false));

It seems like $sess_errors can also be of type boolean and string; however, parameter $err_arr of xhelpRenderErrors() does only seem to accept array, maybe add an additional type check?

        }

        if (false !== !$sess_dept) {
            $fld_newDept = '';
            $fld_groups  = [];
        } else {
            $fld_newDept = $sess_dept['newDept'];
            $fld_groups  = $sess_dept['groups'];
        }

        echo "<form method='post' action='" . XHELP_ADMIN_URL . "/department.php?op=manageDepartments'>";
        echo "<table width='100%' cellspacing='1' class='outer'>
              <tr><th colspan='2'><label for='newDept'>" . _AM_XHELP_LINK_ADD_DEPT . ' </label></th></tr>';
        echo "<tr><td class='head' width='20%' valign='top'>" . _AM_XHELP_TEXT_NAME . "</td><td class='even'>";
        echo "<input type='text' id='newDept' name='newDept' class='formButton' value='$fld_newDept'></td></tr>";
        echo "<tr><td class='head' width='20%' valign='top'>" . _AM_XHELP_TEXT_EDIT_DEPT_PERMS . "</td><td class='even'>";
        echo "<select name='groups[]' multiple='multiple'>";
        foreach ($aGroups as $group_id => $group) {
            if (in_array($group_id, $fld_groups)) {
                echo "<option value='$group_id' selected>$group</option>";
            } else {
                echo "<option value='$group_id'>$group</option>";
            }
        }
        echo '</select></td></tr>';
        echo "<tr><td class='head' width='20%' valign='top'>" . _AM_XHELP_TEXT_DEFAULT_DEPT . "?</td>
                  <td class='even'><input type='checkbox' name='defaultDept' id='defaultDept' value='1'></td></tr>";
        echo "<tr><td class='foot' colspan='2'><input type='submit' name='addDept' value='" . _AM_XHELP_BUTTON_SUBMIT . "' class='formButton'></td></tr>";
        echo '</table><br>';
        echo '</form>';
        if ($total > 0) {     // Make sure there are departments
            echo "<form action='" . XHELP_ADMIN_URL . "/department.php?op=manageDepartments' style='margin:0; padding:0;' method='post'>";
            echo $GLOBALS['xoopsSecurity']->getTokenHTML();
            echo "<table width='100%' cellspacing='1' class='outer'>";
            echo "<tr><td align='right'>" . _AM_XHELP_BUTTON_SEARCH . "
                          <input type='text' name='dept_search' value='$dept_search'>
                        &nbsp;&nbsp;&nbsp;
                        " . _AM_XHELP_TEXT_SORT_BY . "
                          <select name='sort'>";
            foreach ($aSortBy as $value => $text) {
                ($sort == $value) ? $selected = 'selected' : $selected = '';
                echo "<option value='$value' $selected>$text</option>";
            }
            echo '</select>
                        &nbsp;&nbsp;&nbsp;
                          ' . _AM_XHELP_TEXT_ORDER_BY . "
                          <select name='order'>";
            foreach ($aOrderBy as $value => $text) {
                ($order == $value) ? $selected = 'selected' : $selected = '';
                echo "<option value='$value' $selected>$text</option>";
            }
            echo '</select>
                          &nbsp;&nbsp;&nbsp;
                          ' . _AM_XHELP_TEXT_NUMBER_PER_PAGE . "
                          <select name='limit'>";
            foreach ($aLimitBy as $value => $text) {
                ($limit == $value) ? $selected = 'selected' : $selected = '';
                echo "<option value='$value' $selected>$text</option>";
            }
            echo "</select>
                          <input type='submit' name='dept_sort' id='dept_sort' value='" . _AM_XHELP_BUTTON_SUBMIT . "'>
                      </td>
                  </tr>";
            echo '</table></form>';
            echo "<table width='100%' cellspacing='1' class='outer'>
                  <tr><th colspan='4'>" . _AM_XHELP_EXISTING_DEPARTMENTS . "</th></tr>
                  <tr><td class='head'>" . _AM_XHELP_TEXT_ID . "</td><td class='head'>" . _AM_XHELP_TEXT_DEPARTMENT . "</td><td class='head'>" . _AM_XHELP_TEXT_DEFAULT . "</td><td class='head'>" . _AM_XHELP_TEXT_ACTIONS . '</td></tr>';

            if (null !== $departmentInfo) {

The condition null !== $departmentInfo is always true.

                $defaultDept = Xhelp\Utility::getMeta('default_department');
                foreach ($departmentInfo as $dept) {
                    echo "<tr><td class='even'>" . $dept->getVar('id') . "</td><td class='even'>" . $dept->getVar('department') . '</td>';
                    if ($dept->getVar('id') != $defaultDept) {
                        echo "<td class='even' width='10%'><a href='"
                             . XHELP_ADMIN_URL
                             . '/department.php?op=updateDefault&amp;id='
                             . $dept->getVar('id')
                             . "'><img src='"
                             . XHELP_IMAGE_URL
                             . "/off.png' alt='"
                             . _AM_XHELP_TEXT_MAKE_DEFAULT_DEPT
                             . "' title='"
                             . _AM_XHELP_TEXT_MAKE_DEFAULT_DEPT
                             . "'></a></td>";
                    } else {
                        echo "<td class='even' width='10%'><img src='" . XHELP_IMAGE_URL . "/on.png'</td>";
                    }
                    //echo "<td class='even' width='10%'><img src='".XHELP_IMAGE_URL."/". (($dept->getVar('id') == $defaultDept) ? "on.png" : "off.png")."'</td>";
                    echo "<td class='even' width='70'><a href='"
                         . XHELP_ADMIN_URL
                         . '/department.php?op=editDepartment&amp;deptid='
                         . $dept->getVar('id')
                         . "'><img src='"
                         . XOOPS_URL
                         . "/modules/xhelp/assets/images/button_edit.png' title='"
                         . _AM_XHELP_TEXT_EDIT
                         . "' name='editDepartment'></a>&nbsp;&nbsp;";
                    echo "<a href='" . XHELP_ADMIN_URL . '/delete.php?deleteDept=1&amp;deptid=' . $dept->getVar('id') . "'><img src='" . XOOPS_URL . "/modules/xhelp/assets/images/button_delete.png' title='" . _AM_XHELP_TEXT_DELETE . "' name='deleteDepartment'></a></td></tr>";
                }
            }
        }
        echo '</td></tr></table>';
        echo "<div id='dept_nav'>" . $nav->renderNav() . '</div>';
        require_once __DIR__ . '/admin_footer.php';
    }