editRole()

Complexity

Conditions	9
Paths	24

Size

Total Lines	108
Code Lines	72

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php declare(strict_types=1);
function editRole()
{
    // require_once XHELP_CLASS_PATH . '/session.php';
    $session = Xhelp\Session::getInstance();
    $helper  = Xhelp\Helper::getInstance();

    $lastPage = $session->get('xhelp_return_op');
    $xhelp_id = 0;

    if (Request::hasVar('id', 'REQUEST')) {
        $xhelp_id = Request::getInt('id', 0, 'REQUEST');
    }

    $uid = Request::getInt('uid', 0, 'REQUEST');

    /** @var \XoopsModules\Xhelp\RoleHandler $roleHandler */
    $roleHandler = $helper->getHandler('Role');
    $role        = $roleHandler->get($xhelp_id);

    if (Request::hasVar('deleteRole', 'POST')) {
        deleteRole($xhelp_id, 'manageStaff');
        exit();

Using exit here is not recommended.

    }

    if (isset($_POST['edit'])) {
        $role->setVar('name', \Xmf\Request::getString('roleName', '', 'POST'));
        $role->setVar('description', \Xmf\Request::getString('roleDescription', '', 'POST'));
        if (Request::hasVar('tasks', 'POST')) {
            $tasksValue = array_sum($_POST['tasks']);
        } else {
            $tasksValue = 0;
        }
        $role->setVar('tasks', $tasksValue);

        if (!$lastPage = $session->get('xhelp_return_op2')) {
            $lastPage = $session->get('xhelp_return_op');
        }

        if ($roleHandler->insert($role)) {
            Xhelp\Utility::resetStaffUpdatedTime();

            $message = _AM_XHELP_MESSAGE_ROLE_UPDATE;

The assignment to $message is dead and can be removed.

            $helper->redirect("admin/staff.php?op=$lastPage&uid=$uid");
        } else {
            $message = _AM_XHELP_MESSAGE_ROLE_UPDATE_ERROR;
            $helper->redirect("admin/staff.php?op=$lastPage&uid=$uid", 3, $message);
        }
    } else {
        $session->set('xhelp_return_op2', $lastPage);
        $session->set('xhelp_return_op', mb_substr(mb_strstr($_SERVER['REQUEST_URI'], 'op='), 3));

        // Set array of security items
        $tasks = [
            XHELP_SEC_TICKET_ADD            => _AM_XHELP_SEC_TEXT_TICKET_ADD,
            XHELP_SEC_TICKET_EDIT           => _AM_XHELP_SEC_TEXT_TICKET_EDIT,
            XHELP_SEC_TICKET_DELETE         => _AM_XHELP_SEC_TEXT_TICKET_DELETE,
            XHELP_SEC_TICKET_OWNERSHIP      => _AM_XHELP_SEC_TEXT_TICKET_OWNERSHIP,
            XHELP_SEC_TICKET_STATUS         => _AM_XHELP_SEC_TEXT_TICKET_STATUS,
            XHELP_SEC_TICKET_PRIORITY       => _AM_XHELP_SEC_TEXT_TICKET_PRIORITY,
            XHELP_SEC_TICKET_LOGUSER        => _AM_XHELP_SEC_TEXT_TICKET_LOGUSER,
            XHELP_SEC_RESPONSE_ADD          => _AM_XHELP_SEC_TEXT_RESPONSE_ADD,
            XHELP_SEC_RESPONSE_EDIT         => _AM_XHELP_SEC_TEXT_RESPONSE_EDIT,
            XHELP_SEC_TICKET_MERGE          => _AM_XHELP_SEC_TEXT_TICKET_MERGE,
            XHELP_SEC_FILE_DELETE           => _AM_XHELP_SEC_TEXT_FILE_DELETE,
            XHELP_SEC_FAQ_ADD               => _AM_XHELP_SEC_TEXT_FAQ_ADD,
            XHELP_SEC_TICKET_TAKE_OWNERSHIP => _AM_XHELP_SEC_TEXT_TICKET_TAKE_OWNERSHIP,
        ];
        xoops_cp_header();
        //echo $oAdminButton->renderButtons('manStaff');
        $adminObject = Admin::getInstance();
        $adminObject->displayNavigation('staff.php?op=editRole');

        echo '<script type="text/javascript" src="' . XOOPS_URL . '/modules/xhelp/include/functions.js"></script>';
        echo "<form action='staff.php?op=editRole&amp;id=" . $xhelp_id . '&amp;uid=' . $uid . "' method='post'>";
        echo $GLOBALS['xoopsSecurity']->getTokenHTML();
        echo "<table width='100%' cellspacing='1' class='outer'>";
        echo "<tr><th colspan='2'>" . _AM_XHELP_TEXT_EDIT_ROLE . '</th></tr>';
        echo "<tr><td class='head'>" . _AM_XHELP_TEXT_NAME . "</td>
                  <td class='even'><input type='text' name='roleName' maxlength='35' value='" . $role->getVar('name') . "' class='formButton'></td>
              </tr>";
        echo "<tr><td class='head'>" . _AM_XHELP_TEXT_DESCRIPTION . "</td>
                  <td class='even'><textarea name='roleDescription' class='formButton'>" . $role->getVar('description') . '</textarea></td>
              </tr>';
        echo "<tr><td class='head'>" . _AM_XHELP_TEXT_PERMISSIONS . "</td>
                  <td class='even'>
                     <table border='0'>
                     <tr><td>";
        foreach ($tasks as $bit_value => $task) {
            if (($role->getVar('tasks') & (2 ** $bit_value)) > 0) {
                echo "<tr><td><input type='checkbox' name='tasks[]' value='" . (2 ** $bit_value) . "' checked>" . $task . '</td></tr>';
            } else {
                echo "<tr><td><input type='checkbox' name='tasks[]' value='" . (2 ** $bit_value) . "'>" . $task . '</td></tr>';
            }
        }
        echo "<tr><td><input type='checkbox' name='allTasks' value='0' onclick='selectAll(this.form,\"tasks[]\",this.checked);'><b>" . _AM_XHELP_TEXT_SELECT_ALL . '</b></td></tr>';
        echo '</table>
                  </td>
              </tr>';
        echo "<tr>
                  <td colspan='2' class='foot'>
                      <input type='submit' name='edit' value='" . _AM_XHELP_BUTTON_UPDATE . "' class='formButton'>
                      <input type='button' name='cancel' value='" . _AM_XHELP_BUTTON_CANCEL . "' onclick='history.go(-1)' class='formButton'>
                      <input type='submit' name='deleteRole' value='" . _AM_XHELP_BUTTON_DELETE . "' class='formButton'>

                  </td>
              </tr>";
        echo '</table></form>';
        require_once __DIR__ . '/admin_footer.php';
    }