edit()

Complexity

Conditions	16
Paths	1440

Size

Total Lines	131
Code Lines	88

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php declare(strict_types=1);
function edit()
{
    global $xoopsModule, $session, $aNotifications, $has_notifications, $aStaffSettings, $aUserSettings;
    $helper = Helper::getInstance();

    if (Request::hasVar('id', 'REQUEST')) {
        $id = Request::getInt('id', 0, 'REQUEST');
    } else {
        // No id specified, return to manage page
        $helper->redirect('admin/notifications.php?op=manage', 3, _AM_XHELP_MESSAGE_NO_ID);
    }

    /** @var \XoopsModules\Xhelp\NotificationHandler $notificationHandler */
    $notificationHandler = $helper->getHandler('Notification');
    $settings            = $notificationHandler->get($id);

The variable $id does not seem to be defined for all execution paths leading up to this point.

    if (null === $settings || false === $settings) {
        $helper->redirect('admin/notifications.php?op=manage', 3, _AM_XHELP_EDIT_ERR);
    }

    xoops_cp_header();
    //echo $oAdminButton->renderButtons('manNotify');
    $adminObject = Admin::getInstance();

    $adminObject->addItemButton(_AM_XHELP_TEXT_MANAGE_NOTIFICATIONS, 'notifications.php?op=manage', 'add');
    $adminObject->addItemButton(_AM_XHELP_MENU_MODIFY_EMLTPL, 'notifications.php?op=modifyEmailTpl', 'list');
    $adminObject->displayButton('left');

    $adminObject->displayNavigation(basename(__FILE__));

    $session->set('xhelp_return_page', mb_substr(mb_strstr($_SERVER['REQUEST_URI'], 'admin/'), 6));

    if (Request::hasVar('save_notification', 'POST')) {
        $settings->setVar('staff_setting', Request::getInt('staff_setting', 0, 'POST'));
        $settings->setVar('user_setting', Request::getInt('user_setting', 0, 'POST'));
        if (XHELP_NOTIF_STAFF_DEPT == Request::getInt('staff_setting', 0, 'POST')) {
            $settings->setVar('staff_options', $_POST['roles']);
        } else {
            $settings->setVar('staff_options', []);
        }
        $notificationHandler->insert($settings, true);
        $helper->redirect("notifications.php?op=edit&id=$id");
    }

    // Retrieve list of email templates
    if (!$templates = $session->get('xhelp_notifications')) {

The assignment to $templates is dead and can be removed.

        $templates = $xoopsModule->getInfo('_email_tpl');
        $session->set('xhelp_notifications', $templates);
    }
    $notification = $aNotifications[$id];

    $staff_settings = Utility::getMeta("notify_staff{$id}");

The assignment to $staff_settings is dead and can be removed.

    $user_settings  = Utility::getMeta("notify_user{$id}");

The assignment to $user_settings is dead and can be removed.

    /** @var RoleHandler $roleHandler */
    $roleHandler = $helper->getHandler('Role');
    if (XHELP_NOTIF_STAFF_DEPT == $settings->getVar('staff_setting')) {
        $selectedRoles = $settings->getVar('staff_options');
    } else {
        $selectedRoles = [];
    }
    $roles = $roleHandler->getObjects();

    echo "<form method='post' action='" . XHELP_ADMIN_URL . '/notifications.php?op=edit&amp;id=' . $id . "'>";

The constant XHELP_ADMIN_URL was not found. Maybe you did not declare it correctly or list all dependencies?

    echo "<table width='100%' cellspacing='1' class='outer'>";
    echo "<tr><th colspan='2'>" . $notification['name'] . '</th></tr>';
    echo "<tr><td class='head' width='20%'>" . _AM_XHELP_TEXT_NOTIF_STAFF . "</td>
              <td class='even' valign='top'>";
    echo "<table border='0'>";
    echo '<tr>';
    foreach ($aStaffSettings as $value => $setting) {
        echo "<td valign='top'>";
        if ($settings->getVar('staff_setting') == $value) {
            $checked = 'checked';
        } else {
            $checked = '';
        }
        echo "<input type='radio' name='staff_setting' id='staff" . $value . "' value='" . $value . "' $checked>
                          <label for='staff" . $value . "'>" . $setting . '</label>&nbsp;';
        if (XHELP_NOTIF_STAFF_DEPT == $value) {
            echo "<br><br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
                        <select name='roles[]' multiple='multiple'>";
            foreach ($roles as $role) {
                $role_id = $role->getVar('id');
                if (in_array($role_id, $selectedRoles)) {
                    echo "<option value='" . $role_id . "' selected>" . $role->getVar('name') . '</option>';
                } else {
                    echo "<option value='" . $role_id . "'>" . $role->getVar('name') . '</option>';
                }
            }
            echo '</select>';
        }
        echo '</td>';
    }
    echo '</tr></table>';
    echo '</td>
          </tr>';
    echo "<tr><td class='head' width='20%'>" . _AM_XHELP_TEXT_NOTIF_USER . "</td>
              <td class='even'>";
    foreach ($aUserSettings as $value => $setting) {
        if ($settings->getVar('user_setting') == $value) {
            $checked = 'checked';
        } else {
            $checked = '';
        }
        echo "<input type='radio' name='user_setting' id='user" . $value . "' value='" . $value . "' $checked>
                          <label for='user" . $value . "'>" . $setting . '</label>&nbsp;';
    }
    echo '</td>
          </tr>';
    echo "<tr>
              <td class='head'></td>
              <td class='even'><input type='submit' name='save_notification' value='" . _AM_XHELP_BUTTON_SUBMIT . "'></td>
          </tr>";
    echo '</table></form><br>';

    echo "<table width='100%' cellspacing='1' class='outer'>";
    echo "<tr><th colspan='3'>" . _AM_XHELP_TEXT_ASSOC_TPL . '</th></tr>';
    echo "<tr class='head'><td>" . _AM_XHELP_TEXT_TEMPLATE_NAME . '</td>
                           <td>' . _AM_XHELP_TEXT_DESCRIPTION . '</td>
                           <td>' . _AM_XHELP_TEXT_ACTIONS . '</td></tr>';
    foreach ($notification['email_tpl'] as $template) {
        echo "<tr class='even'>
                  <td>" . $template['title'] . '</a></td><td>' . $template['description'] . "</td>
                  <td><a href='" . XHELP_ADMIN_URL . 'notifications.php?op=modifyEmailTpl&amp;file=' . $template['mail_template'] . ".tpl'>
                      <img src='" . XOOPS_URL . "/modules/xhelp/assets/images/button_edit.png' title='" . _AM_XHELP_TEXT_EDIT . "' name='editNotification'></a>
                  </td>
              </tr>";
    }
    echo '</table>';

    xoops_cp_footer();
}