Conditions | 29 |
Paths | 29 |
Total Lines | 127 |
Code Lines | 108 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php declare(strict_types=1); |
||
234 | private function mysqlDBType(\XoopsObject $object): array |
||
235 | { |
||
236 | $controltype = $object->getVar('controltype'); |
||
237 | $datatype = $object->getVar('datatype'); |
||
238 | $fieldlength = $object->getVar('fieldlength'); |
||
239 | |||
240 | $mysqldb = []; |
||
241 | $mysqldb['length'] = $fieldlength; |
||
242 | switch ($controltype) { |
||
243 | case \XHELP_CONTROL_TXTBOX: |
||
244 | |||
245 | switch ($datatype) { |
||
246 | case \_XHELP_DATATYPE_TEXT: |
||
247 | if ($fieldlength <= 255) { |
||
248 | $mysqldb['fieldtype'] = 'VARCHAR'; |
||
249 | } elseif ($fieldlength <= 65535) { |
||
250 | $mysqldb['fieldtype'] = 'TEXT'; |
||
251 | } elseif ($fieldlength <= 16777215) { |
||
252 | $mysqldb['fieldtype'] = 'MEDIUMTEXT'; |
||
253 | } else { |
||
254 | $mysqldb['fieldtype'] = 'LONGTEXT'; |
||
255 | } |
||
256 | break; |
||
257 | case \_XHELP_DATATYPE_NUMBER_INT: |
||
258 | $mysqldb['fieldtype'] = 'INT'; |
||
259 | $mysqldb['length'] = 0; |
||
260 | break; |
||
261 | case \_XHELP_DATATYPE_NUMBER_DEC: |
||
262 | $mysqldb['fieldtype'] = 'DECIMAL'; |
||
263 | $mysqldb['length'] = '7,4'; |
||
264 | |||
265 | // no break |
||
266 | default: |
||
267 | $mysqldb['fieldtype'] = 'VARCHAR'; |
||
268 | $mysqldb['length'] = 255; |
||
269 | break; |
||
270 | } |
||
271 | break; |
||
272 | case \XHELP_CONTROL_TXTAREA: |
||
273 | if ($fieldlength <= 255) { |
||
274 | $mysqldb['fieldtype'] = 'VARCHAR'; |
||
275 | } elseif ($fieldlength <= 65535) { |
||
276 | $mysqldb['fieldtype'] = 'TEXT'; |
||
277 | $mysqldb['length'] = 0; |
||
278 | } elseif ($fieldlength <= 16777215) { |
||
279 | $mysqldb['fieldtype'] = 'MEDIUMTEXT'; |
||
280 | $mysqldb['length'] = 0; |
||
281 | } else { |
||
282 | $mysqldb['fieldtype'] = 'LONGTEXT'; |
||
283 | $mysqldb['length'] = 0; |
||
284 | } |
||
285 | break; |
||
286 | case \XHELP_CONTROL_SELECT: |
||
287 | switch ($datatype) { |
||
288 | case \_XHELP_DATATYPE_TEXT: |
||
289 | if ($fieldlength <= 255) { |
||
290 | $mysqldb['fieldtype'] = 'VARCHAR'; |
||
291 | } elseif ($fieldlength <= 65535) { |
||
292 | $mysqldb['fieldtype'] = 'TEXT'; |
||
293 | } elseif ($fieldlength <= 16777215) { |
||
294 | $mysqldb['fieldtype'] = 'MEDIUMTEXT'; |
||
295 | } else { |
||
296 | $mysqldb['fieldtype'] = 'LONGTEXT'; |
||
297 | } |
||
298 | break; |
||
299 | case \_XHELP_DATATYPE_NUMBER_INT: |
||
300 | $mysqldb['fieldtype'] = 'INT'; |
||
301 | $mysqldb['length'] = 0; |
||
302 | break; |
||
303 | case \_XHELP_DATATYPE_NUMBER_DEC: |
||
304 | $mysqldb['fieldtype'] = 'DECIMAL'; |
||
305 | $mysqldb['length'] = '7,4'; |
||
306 | |||
307 | // no break |
||
308 | default: |
||
309 | $mysqldb['fieldtype'] = 'VARCHAR'; |
||
310 | $mysqldb['length'] = 255; |
||
311 | break; |
||
312 | } |
||
313 | break; |
||
314 | case \XHELP_CONTROL_YESNO: |
||
315 | $mysqldb['fieldtype'] = 'TINYINT'; |
||
316 | $mysqldb['length'] = 1; |
||
317 | break; |
||
318 | case \XHELP_CONTROL_RADIOBOX: |
||
319 | switch ($datatype) { |
||
320 | case \_XHELP_DATATYPE_TEXT: |
||
321 | if ($fieldlength <= 255) { |
||
322 | $mysqldb['fieldtype'] = 'VARCHAR'; |
||
323 | } elseif ($fieldlength <= 65535) { |
||
324 | $mysqldb['fieldtype'] = 'TEXT'; |
||
325 | } elseif ($fieldlength <= 16777215) { |
||
326 | $mysqldb['fieldtype'] = 'MEDIUMTEXT'; |
||
327 | } else { |
||
328 | $mysqldb['fieldtype'] = 'LONGTEXT'; |
||
329 | } |
||
330 | break; |
||
331 | case \_XHELP_DATATYPE_NUMBER_INT: |
||
332 | $mysqldb['fieldtype'] = 'INT'; |
||
333 | $mysqldb['length'] = 0; |
||
334 | break; |
||
335 | case \_XHELP_DATATYPE_NUMBER_DEC: |
||
336 | $mysqldb['fieldtype'] = 'DECIMAL'; |
||
337 | $mysqldb['length'] = '7,4'; |
||
338 | |||
339 | // no break |
||
340 | default: |
||
341 | $mysqldb['fieldtype'] = 'VARCHAR'; |
||
342 | $mysqldb['length'] = 255; |
||
343 | break; |
||
344 | } |
||
345 | break; |
||
346 | case \XHELP_CONTROL_DATETIME: |
||
347 | $mysqldb['fieldtype'] = 'INT'; |
||
348 | $mysqldb['length'] = 0; |
||
349 | break; |
||
350 | case \XHELP_CONTROL_FILE: |
||
351 | $mysqldb['fieldtype'] = 'VARCHAR'; |
||
352 | $mysqldb['length'] = 255; |
||
353 | break; |
||
354 | default: |
||
355 | $mysqldb['fieldtype'] = 'VARCHAR'; |
||
356 | $mysqldb['length'] = 255; |
||
357 | break; |
||
358 | } |
||
359 | |||
360 | return $mysqldb; |
||
361 | } |
||
363 |