| Conditions | 14 |
| Paths | 72 |
| Total Lines | 156 |
| Code Lines | 117 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 126 | function show() |
||
| 127 | { |
||
| 128 | global $msgHandler, $xoopsModule, $pathIcon16; |
||
| 129 | $pick = \Xmf\Request::getInt('pick', 0, 'GET'); |
||
| 130 | $start = \Xmf\Request::getInt('start', 0, 'GET'); |
||
| 131 | $sel_status = \Xmf\Request::getInt('sel_status', 0, 'GET'); |
||
| 132 | $sel_order = \Xmf\Request::getInt('sel_order', 0, 'GET'); |
||
| 133 | $limit = 10; |
||
| 134 | $status_option0 = ''; |
||
| 135 | $status_option1 = ''; |
||
| 136 | $status_option2 = ''; |
||
| 137 | $order_option_asc = ''; |
||
| 138 | $order_option_desc = ''; |
||
| 139 | |||
| 140 | switch ($sel_status) { |
||
| 141 | case 0: |
||
| 142 | $status_option0 = 'selected'; |
||
| 143 | $title = AM_XFGUESTBOOK_ALLMSG; |
||
| 144 | $criteria = new \Criteria('msg_id', 0, '>'); |
||
| 145 | $criteria->setSort('post_time'); |
||
| 146 | break; |
||
| 147 | |||
| 148 | case 1: |
||
| 149 | $status_option1 = 'selected'; |
||
| 150 | $title = AM_XFGUESTBOOK_PUBMSG; |
||
| 151 | $criteria = new \Criteria('moderate', '0'); |
||
| 152 | $criteria->setSort('post_time'); |
||
| 153 | break; |
||
| 154 | |||
| 155 | case 2: |
||
| 156 | $status_option2 = 'selected'; |
||
| 157 | $title = AM_XFGUESTBOOK_WAITMSG; |
||
| 158 | $criteria = new \Criteria('moderate', '1'); |
||
| 159 | $criteria->setSort('post_time'); |
||
| 160 | break; |
||
| 161 | |||
| 162 | } |
||
| 163 | |||
| 164 | switch ($sel_order) { |
||
| 165 | case 1: |
||
| 166 | $order_option_asc = 'selected'; |
||
| 167 | $criteria->setOrder('ASC'); |
||
| 168 | break; |
||
| 169 | |||
| 170 | case 0: |
||
| 171 | $order_option_desc = 'selected'; |
||
| 172 | $criteria->setOrder('DESC'); |
||
| 173 | break; |
||
| 174 | } |
||
| 175 | |||
| 176 | $totalcount = $msgHandler->countMsg($criteria); |
||
| 177 | $criteria->setOrder('DESC'); |
||
| 178 | $criteria->setLimit($limit); |
||
| 179 | $criteria->setStart($start); |
||
| 180 | $msg = $msgHandler->getObjects($criteria); |
||
| 181 | |||
| 182 | $badips = Xfguestbook\Utility::get_badips(); |
||
| 183 | |||
| 184 | /* -- Code to show selected terms -- */ |
||
| 185 | echo "<form name='pick' id='pick' action='" . $_SERVER['PHP_SELF'] . '\' method=\'GET\' style=\'margin: 0;\'>'; |
||
| 186 | |||
| 187 | echo " |
||
| 188 | <table width='100%' cellspacing='1' cellpadding='2' border='0' style='border-left: 1px solid #c0c0c0; border-top: 1px solid #c0c0c0; border-right: 1px solid #c0c0c0;'> |
||
| 189 | <tr> |
||
| 190 | <td><span style='font-weight: bold; font-size: 12px; font-variant: small-caps;'>" . $title . ' : ' . $totalcount . "</span></td> |
||
| 191 | <td align='right'> |
||
| 192 | " . AM_XFGUESTBOOK_DISPLAY . " : |
||
| 193 | <select name='sel_status' onchange='submit()'> |
||
| 194 | <option value = '0' $status_option0>" . AM_XFGUESTBOOK_ALLMSG . " </option> |
||
| 195 | <option value = '1' $status_option1>" . AM_XFGUESTBOOK_PUBMSG . " </option> |
||
| 196 | <option value = '2' $status_option2>" . AM_XFGUESTBOOK_WAITMSG . ' </option> |
||
| 197 | </select> |
||
| 198 | ' . AM_XFGUESTBOOK_SELECT_SORT . " |
||
| 199 | <select name='sel_order' onchange='submit()'> |
||
| 200 | <option value = '1' $order_option_asc>" . AM_XFGUESTBOOK_SORT_ASC . "</option> |
||
| 201 | <option value = '0' $order_option_desc>" . AM_XFGUESTBOOK_SORT_DESC . '</option> |
||
| 202 | </select> |
||
| 203 | </td> |
||
| 204 | </tr> |
||
| 205 | </table> |
||
| 206 | </form>'; |
||
| 207 | /* -- end code to show selected terms -- */ |
||
| 208 | |||
| 209 | echo "<table border='1' width='100%' cellpadding ='2' cellspacing='1'>"; |
||
| 210 | echo "<tr class='bg3'>"; |
||
| 211 | echo "<td align='center'></td>"; |
||
| 212 | echo "<td align='center'><b><input type='hidden' name='op' value='delete'></td>"; |
||
| 213 | echo "<td align='center'><b>" . AM_XFGUESTBOOK_NAME . '</td>'; |
||
| 214 | echo "<td align='center'><b>" . AM_XFGUESTBOOK_TITLE . '</td>'; |
||
| 215 | echo "<td align='center'><b>" . AM_XFGUESTBOOK_MESSAGE . '</td>'; |
||
| 216 | echo "<td align='center'><b>" . AM_XFGUESTBOOK_DATE . '</td>'; |
||
| 217 | echo "<td align='center'><b>" . AM_XFGUESTBOOK_ACTION . '</td>'; |
||
| 218 | echo '</tr>'; |
||
| 219 | |||
| 220 | if ('0' != $totalcount) { |
||
| 221 | echo "<form name='msglist' id='list' action='" . $_SERVER['PHP_SELF'] . '\' method=\'POST\' style=\'margin: 0;\'>'; |
||
| 222 | |||
| 223 | foreach ($msg as $onemsg) { |
||
| 224 | $all_msg = []; |
||
| 225 | $all_msg['post_time'] = formatTimestamp($onemsg->getVar('post_time')); |
||
| 226 | $all_msg['msg_id'] = $onemsg->getVar('msg_id'); |
||
| 227 | $all_msg['user'] = ($onemsg->getVar('user_id') > 0) ? \XoopsUser::getUnameFromId($onemsg->getVar('user_id')) : $onemsg->getVar('uname'); |
||
| 228 | $all_msg['action'] = "<a href='main.php?op=edit&msg_id=" . $onemsg->getVar('msg_id') . '\'><img src=\'' . $pathIcon16 . "/edit.png'></a>"; |
||
| 229 | $img_status = "<img src='" . XOOPS_URL . '/modules/' . $xoopsModule->dirname() . '/assets/images/'; |
||
| 230 | if ($onemsg->getVar('moderate')) { |
||
| 231 | $img_status .= "ic15_question.gif'>"; |
||
| 232 | } else { |
||
| 233 | $img_status .= "ic15_ok.gif'>"; |
||
| 234 | } |
||
| 235 | $all_msg['title'] = "<a href='../index.php?op=show_one&msg_id=" . $onemsg->getVar('msg_id') . '\'>' . $onemsg->getVar('title') . '</a>'; |
||
| 236 | $all_msg['message'] = $onemsg->getVar('message'); |
||
| 237 | |||
| 238 | if ($onemsg->getVar('photo')) { |
||
| 239 | $all_msg['message'] = '<img src="' . XOOPS_UPLOAD_URL . '/' . $xoopsModule->getVar('dirname') . '/' . $onemsg->getVar('photo') . '" align = "left" hspace ="10">' . $onemsg->getVar('message'); |
||
| 240 | } else { |
||
| 241 | $all_msg['message'] = $onemsg->getVar('message'); |
||
| 242 | } |
||
| 243 | |||
| 244 | echo '<tr>'; |
||
| 245 | echo "<td align='center' class='even'><input type='checkbox' name='msg_id[]' id='msg_id[]' value='" . $all_msg['msg_id'] . '\'></td>'; |
||
| 246 | echo "<td align='center' class = 'head'><b>" . $img_status . '</b></td>'; |
||
| 247 | echo "<td align='center' class = 'even'>" . $all_msg['user'] . '</td>'; |
||
| 248 | echo "<td align='left' class = 'odd'>" . $all_msg['title'] . '</td>'; |
||
| 249 | echo "<td align='left' class = 'even'>" . $all_msg['message'] . '</td>'; |
||
| 250 | echo "<td class='odd'>" . $all_msg['post_time'] . '<br>'; |
||
| 251 | if (in_array($onemsg->getVar('poster_ip'), $badips)) { |
||
| 252 | echo "<span style='color: #FF0000; '><b>" . $onemsg->getVar('poster_ip') . '</b></span></td>'; |
||
| 253 | } else { |
||
| 254 | echo $onemsg->getVar('poster_ip') . '</td>'; |
||
| 255 | } |
||
| 256 | echo "<td align='center' class='even'>" . $all_msg['action'] . '</td>'; |
||
| 257 | echo '</tr>'; |
||
| 258 | unset($all_msg); |
||
| 259 | } |
||
| 260 | echo "<tr class='foot'><td><select name='op'>"; |
||
| 261 | if (1 != $sel_status) { |
||
| 262 | echo "<option value='approve'>" . AM_XFGUESTBOOK_PUB . '</option>'; |
||
| 263 | } |
||
| 264 | echo "<option value='delete'>" . _DELETE . '</option>'; |
||
| 265 | echo "<option value='banish'>" . AM_XFGUESTBOOK_BAN . '</option>'; |
||
| 266 | echo '</select> </td>'; |
||
| 267 | echo "<td colspan='6'>" . $GLOBALS['xoopsSecurity']->getTokenHTML() . "<input type='submit' value='" . _GO . '\'>'; |
||
| 268 | echo '</td></tr>'; |
||
| 269 | echo '</form>'; |
||
| 270 | } else { |
||
| 271 | echo "<tr ><td align='center' colspan ='10' class = 'head'><b>" . AM_XFGUESTBOOK_NOMSG . '</b></td></tr>'; |
||
| 272 | } |
||
| 273 | echo '</table><br>'; |
||
| 274 | if ($totalcount > $limit) { |
||
| 275 | require_once XOOPS_ROOT_PATH . '/class/pagenav.php'; |
||
| 276 | $pagenav = new \XoopsPageNav($totalcount, $limit, $start, 'start', 'sel_status=' . $sel_status . '&sel_order=' . $sel_order); |
||
| 277 | echo "<div class='center;' class = 'head'>" . $pagenav->renderNav() . '</div><br>'; |
||
| 278 | } else { |
||
| 279 | echo ''; |
||
| 280 | } |
||
| 281 | echo '<br>'; |
||
| 282 | } |
||
| 377 |