Conditions | 8 |
Paths | 8 |
Total Lines | 55 |
Code Lines | 40 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
30 | function b_xfguestbook_show($options) |
||
31 | { |
||
32 | global $xoopsModule, $xoopsModuleConfig, $xoopsDB; |
||
33 | /** @var \XoopsModules\Xfguestbook\Helper $helper */ |
||
34 | $helper = \XoopsModules\Xfguestbook\Helper::getInstance(); |
||
35 | if (empty($xoopsModule) || 'xfguestbook' !== $xoopsModule->getVar('dirname')) { |
||
36 | /** @var XoopsModuleHandler $moduleHandler */ |
||
37 | $moduleHandler = xoops_getHandler('module'); |
||
38 | $module = $moduleHandler->getByDirname('xfguestbook'); |
||
39 | $configHandler = xoops_getHandler('config'); |
||
40 | $config = $configHandler->getConfigsByCat(0, $module->getVar('mid')); |
||
41 | } else { |
||
42 | $module = $xoopsModule; |
||
43 | $config = $xoopsModuleConfig; |
||
44 | } |
||
45 | |||
46 | $block = []; |
||
47 | if (0 != $options[1]) { |
||
48 | $block['full_view'] = true; |
||
49 | } else { |
||
50 | $block['full_view'] = false; |
||
51 | } |
||
52 | |||
53 | $msg_hnd = $helper->getHandler('Message'); |
||
54 | $criteria = new \Criteria('moderate', '0', '='); |
||
55 | $criteria->setSort('post_time'); |
||
56 | $criteria->setOrder('DESC'); |
||
57 | $criteria->setLimit($options[0]); |
||
58 | $nbmsg = $msg_hnd->countMsg($criteria); |
||
59 | |||
60 | $a_item = []; |
||
61 | |||
62 | if ($nbmsg > 0) { |
||
63 | $msg = $msg_hnd->getObjects($criteria); |
||
64 | $ts = \MyTextSanitizer::getInstance(); |
||
65 | foreach ($msg as $onemsg) { |
||
66 | $msg_id = $onemsg->getVar('msg_id'); |
||
67 | $a_item['id'] = $msg_id; |
||
68 | $a_item['title'] = $onemsg->getVar('title'); |
||
69 | if (!XOOPS_USE_MULTIBYTES) { |
||
70 | $length = strlen($onemsg->getVar('title')); |
||
71 | if ($length >= $options[1]) { |
||
72 | $a_item['title'] = substr($a_item['title'], 0, $options[1] - $length) . '...'; |
||
73 | } |
||
74 | } |
||
75 | $a_item['name'] = $onemsg->getVar('uname'); |
||
76 | $a_item['date'] = formatTimestamp($onemsg->getVar('post_time'), 's'); |
||
77 | $block['items'][] = $a_item; |
||
78 | unset($a_item); |
||
79 | } |
||
80 | } else { |
||
81 | $block['nbmsg'] = 0; |
||
82 | } |
||
83 | |||
84 | return $block; |
||
85 | } |
||
99 |