MessageHandler::insert() - Code Metrics - Inspection of "Merge pull request #15 from mambax7/master" - XoopsModules25x/xfguestbook - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 37a2f2...290aa0 )

by Michael
created 2018-11-26 07:39 UTC
MessageHandler::insert() B

↳ Parent: MessageHandler
Complexity

Conditions	7
Paths	14
Size

Total Lines	89
Code Lines	80
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	7
eloc	80
nc	14
nop	1
dl	0
loc	89
rs	7.503
c	0
b	0
f	0
How to fix Long Method

<?php namespace XoopsModules\Xfguestbook;

/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @package
 * @since
 * @author       XOOPS Development Team
 */

use XoopsModules\Xfguestbook;

defined('XOOPS_ROOT_PATH') || die('Restricted access');


/**
 * Class MessageHandler
 */
class MessageHandler
{
    public $db;

    /**
     * MessageHandler constructor.
     * @param \XoopsDatabase|null $db
     */
    public function __construct(\XoopsDatabase $db = null)
    {
        $this->db = $db;
    }

    /**
     * @return Message
     */
    public function create()
    {
        return new Message();
    }

    /**
     * @param $id
     * @return bool|Message
     */
    public function get($id)
    {
        $id = (int)$id;
        if ($id > 0) {
            $sql = 'SELECT * FROM ' . $this->db->prefix('xfguestbook_msg') . ' WHERE msg_id=' . $id;
            $sql = 'SELECT * FROM ' . $this->db->/** @scrutinizer ignore-call */ prefix('xfguestbook_msg') . ' WHERE msg_id=' . $id;
            if (!$result = $this->db->query($sql)) {
                return false;
            }
            $numrows = $this->db->getRowsNum($result);
            if (1 == $numrows) {
                $msg = new Message();
                $msg->assignVars($this->db->fetchArray($result));

                return $msg;
            }
        }

        return false;
    }

    /**
     * @param \XoopsObject $msg
     * @return bool
     */
    public function insert(\XoopsObject $msg)
    {
        if (Message::class !== get_class($msg)) {
            return false;
        }
        if (!$msg->cleanVars()) {
            return false;
        }
        foreach ($msg->cleanVars as $k => $v) {
            ${$k} = $v;
        }
        if (empty($msg_id)) {

            $msg_id = $this->db->genId('xfguestbook_msg_msg_id_seq');
            $sql    = 'INSERT INTO '
                      . $this->db->prefix('xfguestbook_msg')
                      . ' (msg_id, user_id, uname, title, message, note, post_time, email, url, poster_ip, moderate, gender, country, photo, flagdir, other) VALUES ('
                      . $msg_id
                      . ','
                      . $user_id

                      . ', '
                      . $this->db->quoteString($uname)

                      . ', '
                      . $this->db->quoteString($title)

                      . ', '
                      . $this->db->quoteString($message)

                      . ', '
                      . $this->db->quoteString($note)

                      . ', '
                      . $post_time

                      . ',  '
                      . $this->db->quoteString($email)

                      . ', '
                      . $this->db->quoteString($url)

                      . ', '
                      . $this->db->quoteString($poster_ip)

                      . ', '
                      . $moderate

                      . ', '
                      . $this->db->quoteString($gender)

                      . ', '
                      . $this->db->quoteString($country)

                      . ', '
                      . $this->db->quoteString($photo)

                      . ', '
                      . $this->db->quoteString($flagdir)

                      . ', '
                      . $this->db->quoteString($other)

                      . ')';
        } else {
            $sql = 'UPDATE '
                   . $this->db->prefix('xfguestbook_msg')
                   . ' SET user_id='
                   . $user_id
                   . ', uname='
                   . $this->db->quoteString($uname)
                   . ', title='
                   . $this->db->quoteString($title)
                   . ', message='
                   . $this->db->quoteString($message)
                   . ', note='
                   . $this->db->quoteString($note)
                   . ', email='
                   . $this->db->quoteString($email)
                   . ', url='
                   . $this->db->quoteString($url)
                   . ', moderate='
                   . $moderate
                   . ', gender='
                   . $this->db->quoteString($gender)
                   . ', country='
                   . $this->db->quoteString($country)
                   . ', photo='
                   . $this->db->quoteString($photo)
                   . ', flagdir='
                   . $this->db->quoteString($flagdir)
                   . ', other='
                   . $this->db->quoteString($other)
                   . ' WHERE msg_id='
                   . $msg_id;
        }
        if (!$result = $this->db->queryF($sql)) {

            return false;
        }
        if (empty($msg_id)) {
            $msg_id = $this->db->getInsertId();
        }
        $msg->assignVar('msg_id', $msg_id);

        return $msg_id;
    }

    /**
     * @param \XoopsObject $msg
     * @return bool
     */
    public function delete(\XoopsObject $msg)
    {
        global $xoopsModule;
        if (Message::class !== get_class($msg)) {
            return false;
        }
        $sql = sprintf('DELETE FROM `%s` WHERE msg_id = %u', $this->db->prefix('xfguestbook_msg'), $msg->getVar('msg_id'));
        $sql = sprintf('DELETE FROM `%s` WHERE msg_id = %u', $this->db->prefix('xfguestbook_msg'), /** @scrutinizer ignore-type */ $msg->getVar('msg_id'));
        if (isset($this->commentstable) && '' !== $this->commentstable) {
            xoops_comment_delete($xoopsModule->getVar('mid'), $msg_id);

        }

        if (!$result = $this->db->query($sql)) {

            return false;
        }

        return true;
    }

    /**
     * @param  null|\CriteriaElement $criteria
     * @return array
     */
    public function &getObjects(\CriteriaElement $criteria = null)
    {
        $ret   = [];
        $limit = $start = 0;
        $sql   = 'SELECT * FROM ' . $this->db->prefix('xfguestbook_msg');
        if (null !== $criteria && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql   .= ' ' . $criteria->renderWhere();
            $sql   .= ' ' . $criteria->/** @scrutinizer ignore-call */ renderWhere();
            $sort  = ('' !== $criteria->getSort()) ? $criteria->getSort() : 'msg_id';
            $sql   .= ' ORDER BY ' . $sort . ' ' . $criteria->getOrder();
            $limit = $criteria->getLimit();
            $start = $criteria->getStart();
        }
        $result = $this->db->query($sql, $limit, $start);
        if (!$result) {
            return $ret;
        }
        while (false !== ($myrow = $this->db->fetchArray($result))) {
            $msg = new Message();
            $msg->assignVars($myrow);
            $ret[] = $msg;
            unset($msg);
        }

        return $ret;
    }

    /**
     * @param  null|\CriteriaElement $criteria
     * @return int
     */
    public function countMsg(\CriteriaElement $criteria = null)
    {
        $sql = 'SELECT COUNT(*) FROM ' . $this->db->prefix('xfguestbook_msg');
        if (null !== $criteria && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {
            return 0;
        }
        list($count) = $this->db->fetchRow($result);

        return $count;
    }

    /**
     * @param  null|\CriteriaElement $criteria
     * @return array|bool
     */
    public function countMsgByCountry(\CriteriaElement $criteria = null)
    {
        $arr = [];
        $sql = 'SELECT country, flagdir FROM ' . $this->db->prefix('xfguestbook_msg');
        if (null !== $criteria && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {
            return false;
        }
        while (false !== (list($country, $flagdir) = $this->db->fetchRow($result))) {
            $arr[] = $flagdir . '/' . $country;
        }
        $ret = array_count_values($arr);
        arsort($ret);

        return $ret;
    }

    /**
     * @param \CriteriaElement|null $criteria
     * @return array|bool
     */
    public function countMsgByGender(\CriteriaElement $criteria = null)
    {
        $arr = [];
        $sql = 'SELECT gender FROM ' . $this->db->prefix('xfguestbook_msg');
        if (null !== $criteria && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {
            return false;
        }
        while (false !== (list($gender) = $this->db->fetchRow($result))) {
            $arr[] = $gender;
        }
        $ret = array_count_values($arr);

        return $ret;
    }

    /**
     * @param  null|\CriteriaElement $criteria
     * @return array|int
     */
    public function getMsgImg(\CriteriaElement $criteria = null)
    {
        $arr = [];
        $sql = 'SELECT photo FROM ' . $this->db->prefix('xfguestbook_msg') . " WHERE `photo` LIKE 'msg_%'";
        if (null !== $criteria && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {
            return 0;
        }
        while (false !== (list($photo) = $this->db->fetchRow($result))) {
            $arr[] = $photo;
        }

        return $arr;
    }
}

XoopsModules25x / xfguestbook

Push — master ( 37a2f2...290aa0 )

MessageHandler::insert() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
