main.php ➔ delete() - Code Metrics - Inspection of "Merge pull request #9 from mambax7/master" - XoopsModules25x/xfguestbook - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 76b4a1...141e43 )

by Michael
created 2016-06-14 09:18 UTC
main.php ➔ delete() B

↳ Parent: Project
Complexity

Conditions	5
Paths	10
Size

Total Lines	23
Code Lines	17
Duplication

Lines	4
Ratio	17.39 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	5
eloc	17
c	1
b	0
f	0
nc	10
nop	0
dl	4
loc	23
rs	8.5906
<?php

// $Id: admin/index.php,v 1.40 2006/01/01 C. Felix AKA the Cat
//  ------------------------------------------------------------------------ //
//             XF Guestbook                                                  //
// ------------------------------------------------------------------------- //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //

include dirname(dirname(dirname(__DIR__))) . '/include/cp_header.php';
include_once dirname(__DIR__) . '/include/cp_functions.php';
include_once __DIR__ . '/admin_header.php';

if (!isset($xoopsModuleConfig['flagdir'])) {
    redirect_header(XOOPS_URL . '/modules/system/admin.php?fct=modulesadmin&op=update&module=' . $xoopsModule->dirname(), 4, _AM_XFGB_MUST_UPDATE);
}

include_once dirname(__DIR__) . '/include/functions.php';
//include_once("../class/msg.php");

if (isset($_GET['op'])) {

    $op = $_GET['op'];
} elseif (isset($_POST['op'])) {
    $op = $_POST['op'];
} else {
    $op = 'show';
}

if (isset($_GET['msg_id'])) {

    $msg_id = (int)$_GET['msg_id'];
} elseif (isset($_POST['msg_id'])) {
    $msg_id = (int)$_POST['msg_id'];
} else {
    $msg_id = 0;
}

$msg_handler = xoops_getModuleHandler('msg');

function delete()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $msg_handler, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
        $messagesent = _AM_XFGB_MSGDELETED;
        for ($i = 0; $i < $msg_count; $i++) {
            $msg      = $msg_handler->get($_POST['msg_id'][$i]);
            $filename = $msg->getVar('title');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $filename = $msg->getVar('photo');
            if (!$msg_handler->delete($msg)) {
                $messagesent = _AM_XFGB_ERRORDEL;
            }
            if ('' !== $filename) {

                $filename = XOOPS_UPLOAD_PATH . '/' . $xoopsModule->getVar('dirname') . '/' . $filename;
                unlink($filename);
            }
        }
    } else {
        $messagesent = _AM_XFGB_NOMSG;
    }
    redirect_header($_SERVER['PHP_SELF'], 2, $messagesent);
}

function approve()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $msg_handler;
function myFunction($a, $b) {
    // Do something
}
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
        $messagesent = _AM_XFGB_VALIDATE;
        for ($i = 0; $i < $msg_count; $i++) {
            $msg = $msg_handler->get($_POST['msg_id'][$i]);
            $msg->setVar('moderate', 0);
            if (!$msg_handler->insert($msg)) {
                $messagesent = _AM_XFGB_ERRORVALID;
            }
        }
    } else {
        $messagesent = _AM_XFGB_NOMSG;
    }
    redirect_header($_SERVER['PHP_SELF'], 2, $messagesent);
    exit();

}

function banish()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $msg_handler, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $msg_count = (!empty($_POST['msg_id']) && is_array($_POST['msg_id'])) ? count($_POST['msg_id']) : 0;
    if ($msg_count > 0) {
        $messagesent = _AM_XFGB_BANISHED;
        for ($i = 0; $i < $msg_count; $i++) {
            $msg    = $msg_handler->get($_POST['msg_id'][$i]);
            $ip[$i] = $msg->getVar('poster_ip');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $msg->setVar('moderate', 1);
            if (!$msg_handler->insert($msg)) {
                $messagesent = _AM_XFGB_ERRORBANISHED;
            }
        }
        $ip     = array_unique($ip);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $badips = xfgb_get_badips();
        foreach ($ip as $oneip) {
            if (!in_array($oneip, $badips)) {
                $sql    = 'INSERT INTO ' . $xoopsDB->prefix('xfguestbook_badips') . " (ip_value) VALUES ('$oneip')";
                $result = $xoopsDB->query($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            }
        }
    } else {
        $messagesent = _AM_XFGB_NOMSG;
    }

    redirect_header($_SERVER['PHP_SELF'], 2, $messagesent);
    exit();

}

function show()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $msg_handler, $xoopsModule, $pathIcon16;
function myFunction($a, $b) {
    // Do something
}
    $pick              = isset($_GET['pick']) ? (int)$_GET['pick'] : 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $start             = isset($_GET['start']) ? (int)$_GET['start'] : 0;
    $sel_status        = isset($_GET['sel_status']) ? $_GET['sel_status'] : 0;
    $sel_order         = isset($_GET['sel_order']) ? $_GET['sel_order'] : 0;
    $limit             = 10;
    $status_option0    = '';
    $status_option1    = '';
    $status_option2    = '';
    $order_option_asc  = '';
    $order_option_desc = '';

    switch ($sel_status) {
        case 0 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $status_option0 = "selected='selected'";
            $title          = _AM_XFGB_ALLMSG;
            $criteria       = new Criteria('msg_id', 0, '>');
            $criteria->setSort('post_time');
            break;

        case 1 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $status_option1 = "selected='selected'";
            $title          = _AM_XFGB_PUBMSG;
            $criteria       = new Criteria('moderate', '0');
            $criteria->setSort('post_time');
            break;

        case 2 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $status_option2 = "selected='selected'";
            $title          = _AM_XFGB_WAITMSG;
            $criteria       = new Criteria('moderate', '1');
            $criteria->setSort('post_time');
            break;

    }

    switch ($sel_order) {
        case 1:
            $order_option_asc = "selected='selected'";
            $criteria->setOrder('ASC');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            break;

        case 0:
            $order_option_desc = "selected='selected'";
            $criteria->setOrder('DESC');
            break;
    }

    $totalcount = $msg_handler->countMsg($criteria);
    $criteria->setOrder('DESC');
    $criteria->setLimit($limit);
    $criteria->setStart($start);
    $msg =& $msg_handler->getObjects($criteria);

    $badips = xfgb_get_badips();

    /* -- Code to show selected terms -- */
    echo "<form name='pick' id='pick' action='" . $_SERVER['PHP_SELF'] . "' method='GET' style='margin: 0;'>";

    echo "
        <table width='100%' cellspacing='1' cellpadding='2' border='0' style='border-left: 1px solid silver; border-top: 1px solid silver; border-right: 1px solid silver;'>
            <tr>
                <td><span style='font-weight: bold; font-size: 12px; font-variant: small-caps;'>" . $title . ' : ' . $totalcount . "</span></td>
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                <td align='right'>
                " . _AM_XFGB_DISPLAY . " :
                    <select name='sel_status' onchange='submit()'>
                        <option value = '0' $status_option0>" . _AM_XFGB_ALLMSG . " </option>
                        <option value = '1' $status_option1>" . _AM_XFGB_PUBMSG . " </option>
                        <option value = '2' $status_option2>" . _AM_XFGB_WAITMSG . ' </option>
                    </select>
                ' . _AM_XFGB_SELECT_SORT . "
                    <select name='sel_order' onchange='submit()'>
                        <option value = '1' $order_option_asc>" . _AM_XFGB_SORT_ASC . "</option>
                        <option value = '0' $order_option_desc>" . _AM_XFGB_SORT_DESC . '</option>
                    </select>
                </td>
            </tr>
        </table>
        </form>';
    /* -- end code to show selected terms -- */

    echo "<table border='1' width='100%' cellpadding ='2' cellspacing='1'>";
    echo "<tr class='bg3'>";
    echo "<td align='center'></td>";
    echo "<td align='center'><b><input type='hidden' name='op' value='delete' /></td>";
    echo "<td align='center'><b>" . _AM_XFGB_NAME . '</td>';
    echo "<td align='center'><b>" . _AM_XFGB_TITLE . '</td>';
    echo "<td align='center'><b>" . _AM_XFGB_MESSAGE . '</td>';
    echo "<td align='center'><b>" . _AM_XFGB_DATE . '</td>';
    echo "<td align='center'><b>" . _AM_XFGB_ACTION . '</td>';
    echo '</tr>';

    if ('0' != $totalcount) {
        echo "<form name='msglist' id='list' action='" . $_SERVER['PHP_SELF'] . "' method='POST' style='margin: 0;'>";

        foreach ($msg as $onemsg) {
            $all_msg              = array();
            $all_msg['post_time'] = formatTimestamp($onemsg->getVar('post_time'));
            $all_msg['msg_id']    = $onemsg->getVar('msg_id');
            $all_msg['user']      = ($onemsg->getVar('user_id') > 0) ? XoopsUser::getUnameFromId($onemsg->getVar('user_id')) : $onemsg->getVar('uname');
            $all_msg['action']    = "<a href='main.php?op=edit&amp;msg_id=" . $onemsg->getVar('msg_id') . "'><img src='" . $pathIcon16 . "/edit.png'></a>";
            $img_status           = "<img src='" . XOOPS_URL . '/modules/' . $xoopsModule->dirname() . '/assets/images/';
            if ($onemsg->getVar('moderate')) {
                $img_status .= "ic15_question.gif'>";
            } else {
                $img_status .= "ic15_ok.gif'>";
            }
            $all_msg['title']   = "<a href='../main.php?op=show_one&msg_id=" . $onemsg->getVar('msg_id') . "'>" . $onemsg->getVar('title') . '</a>';
            $all_msg['message'] = $onemsg->getVar('message');

            if ($onemsg->getVar('photo')) {
                $all_msg['message'] =
                    "<img src=\"" . XOOPS_UPLOAD_URL . '/' . $xoopsModule->getVar('dirname') . '/' . $onemsg->getVar('photo') . "\" align = \"left\" hspace =\"10\">" . $onemsg->getVar('message');
            } else {
                $all_msg['message'] = $onemsg->getVar('message');
            }

            echo '<tr>';
            echo "<td align='center' class='even'><input type='checkbox' name='msg_id[]' id='msg_id[]' value='" . $all_msg['msg_id'] . "'/></td>";
            echo "<td align='center' class = 'head'><b>" . $img_status . '</b></td>';
            echo "<td align='center' class = 'even'>" . $all_msg['user'] . '</td>';
            echo "<td align='left' class = 'odd'>" . $all_msg['title'] . '</td>';
            echo "<td align='left' class = 'even'>" . $all_msg['message'] . '</td>';
            echo "<td class='odd'>" . $all_msg['post_time'] . '<br>';
            if (in_array($onemsg->getVar('poster_ip'), $badips)) {
                echo "<font color=\"#FF0000\"><b>" . $onemsg->getVar('poster_ip') . '</b></font></td>';
            } else {
                echo $onemsg->getVar('poster_ip') . '</td>';
            }
            echo "<td align='center' class='even'>" . $all_msg['action'] . '</td>';
            echo '</tr>';
            unset($all_msg);
        }
        echo "<tr class='foot'><td><select name='op'>";
        if (1 != $sel_status) {
            echo "<option value='approve'>" . _AM_XFGB_PUB . '</option>';
        }
        echo "<option value='delete'>" . _DELETE . '</option>';
        echo "<option value='banish'>" . _AM_XFGB_BAN . '</option>';
        echo '</select>&nbsp;</td>';
        echo "<td colspan='6'>" . $GLOBALS['xoopsSecurity']->getTokenHTML() . "<input type='submit' value='" . _GO . "' />";
        echo '</td></tr>';
        echo '</form>';
    } else {
        echo "<tr ><td align='center' colspan ='10' class = 'head'><b>" . _AM_XFGB_NOMSG . '</b></td></tr>';
    }
    echo '</table><br>';
    if ($totalcount > $limit) {

        include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
        $pagenav = new XoopsPageNav($totalcount, $limit, $start, 'start', 'sel_status=' . $sel_status . '&sel_order=' . $sel_order);
        echo "<div style='text-align: center;' class = 'head'>" . $pagenav->renderNav() . '</div><br>';
    } else {
        echo '';
    }
    echo '<br>';
}

switch ($op) {
    case 'save':
        global $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
        if (!$GLOBALS['xoopsSecurity']->check()) {
            redirect_header('index.php', 2, implode('<br>', $GLOBALS['xoopsSecurity']->getErrors()));
        }
        $msgstop = '';
        $msg     = $msg_handler->get($msg_id);
        $del_img = isset($_POST['del_img']) ? (int)$_POST['del_img'] : 0;
        if ($del_img) {
            $filename = XOOPS_UPLOAD_PATH . '/' . $xoopsModule->getVar('dirname') . '/' . $msg->getVar('photo');
            unlink($filename);
            $msg->setVar('photo', '');
        } elseif (!empty($_FILES['photo']['name'])) {
            xfgb_upload();
            $photo      = str_replace('tmp_', 'msg_', $preview_name);
            $photos_dir = XOOPS_UPLOAD_PATH . '/' . $xoopsModule->getVar('dirname') . '/';
            rename($photos_dir . $preview_name, $photos_dir . $photo);
            if ('' !== $msg->getVar('photo')) {

                $filename = XOOPS_UPLOAD_PATH . '/' . $xoopsModule->getVar('dirname') . '/' . $msg->getVar('photo');
                unlink($filename);
            }
            $msg->setVar('photo', $photo);
        }
        if (!empty($msgstop)) {
            redirect_header('main.php?op=edit&msg_id=' . $msg_id, 2, $msgstop);
        }
        $uname    = isset($_POST['uname']) ? $_POST['uname'] : '';
        $email    = isset($_POST['email']) ? $_POST['email'] : '';
        $url      = isset($_POST['url']) ? $_POST['url'] : '';
        $title    = isset($_POST['title']) ? $_POST['title'] : '';
        $message  = isset($_POST['message']) ? $_POST['message'] : '';
        $note     = isset($_POST['note']) ? $_POST['note'] : '';
        $gender   = isset($_POST['gender']) ? $_POST['gender'] : '';
        $country  = isset($_POST['country']) ? $_POST['country'] : '';
        $other    = isset($_POST['other']) ? $_POST['other'] : '';
        $moderate = isset($_POST['moderate']) ? (int)$_POST['moderate'] : 0;

        $msg->setVar('uname', $uname);
        $msg->setVar('email', $email);
        $msg->setVar('url', $url);
        $msg->setVar('title', $title);
        $msg->setVar('message', $message);
        $msg->setVar('note', $note);
        $msg->setVar('gender', $gender);
        if ('' !== $country) {
            $msg->setVar('country', $country);
            $msg->setVar('flagdir', $xoopsModuleConfig['flagdir']);
        }
        $msg->setVar('other', $other);
        $msg->setVar('moderate', $moderate);
        if ($msg_handler->insert($msg)) {
            redirect_header('main.php?op=show', 1, _AM_XFGB_MSGMOD);
        } else {
            redirect_header('main.php?op=show', 2, _AM_XFGB_MSGERROR);
        }
        break;

    case 'edit':
        xoops_cp_header();
        $index_admin = new ModuleAdmin();
        echo $index_admin->addNavigation(basename(__FILE__));
        //xfguestbook_admin_menu(0);
        $msg = $msg_handler->get($msg_id);
        include_once dirname(__DIR__) . '/include/form_edit.inc.php';
        $msg_form->display();
        include __DIR__ . '/admin_footer.php';
        //xoops_cp_footer();
        break;

    case 'approve':
        approve();
        break;

    case 'delete':
        delete();
        break;

    case 'banish':
        banish();
        break;

    case 'show':
    default:

        xoops_cp_header();
        $index_admin = new ModuleAdmin();
        echo $index_admin->addNavigation(basename(__FILE__));
        //xfguestbook_admin_menu(0);
        show();
        include __DIR__ . '/admin_footer.php';
        //xoops_cp_footer();
        break;
}

Push — master ( 76b4a1...141e43 )

main.php ➔ delete() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

XoopsModules25x / xfguestbook

Push — master ( 76b4a1...141e43 )

main.php ➔ delete() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
