ip_manager.php ➔ badIpSave() - Code Metrics - Inspection of "Merge pull request #9 from mambax7/master" - XoopsModules25x/xfguestbook - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 76b4a1...141e43 )

by Michael

created 2016-06-14 09:18 UTC

ip_manager.php ➔ badIpSave() B

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	26
Code Lines	20

Duplication

Lines	26
Ratio	100 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	3
eloc	20
c	3
b	0
f	0
nc	3
nop	2
dl	26
loc	26
rs	8.8571

<?php

// $Id: admin/ip_manager.php,v 1.0 2006/01/01 C. Felix alias the Cat
//  ------------------------------------------------------------------------ //
//             XF Guestbook                                                  //
// ------------------------------------------------------------------------- //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //

include dirname(dirname(dirname(__DIR__))) . '/include/cp_header.php';
include_once dirname(__DIR__) . '/include/cp_functions.php';
include_once __DIR__ . '/admin_header.php';
include_once dirname(__DIR__) . '/include/functions.php';

if (isset($_GET['op'])) {

    $op = $_GET['op'];
} elseif (isset($_POST['op'])) {
    $op = $_POST['op'];
} else {
    $op = 'badIpShow';
}

if (isset($_GET['ip_id'])) {

    $ip_id = (int)$_GET['ip_id'];
} elseif (isset($_POST['ip_id'])) {
    $ip_id = (int)$_POST['ip_id'];
} else {
    $ip_id = 0;
}

$ip_value = isset($_POST['ip_value']) ? $_POST['ip_value'] : '';

/**
 * @param $ip_id
 */
function badIpDel($ip_id)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $ip_count = (!empty($_POST['ip_id']) && is_array($_POST['ip_id'])) ? count($_POST['ip_id']) : 0;
    if ($ip_count > 0) {
        $messagesent = _AM_XFGB_BADIP_DELETED;
        for ($i = 0; $i < $ip_count; $i++) {
            $sql = sprintf('DELETE FROM %s WHERE ip_id = %u', $xoopsDB->prefix('xfguestbook_badips'), $_POST['ip_id'][$i]);
            if (!$result = $xoopsDB->query($sql)) {
                $messagesent = _AM_XFGB_ERRORDEL;
            }
        }
    } else {
        $messagesent = _AM_XFGB_NOBADIP;
    }
    redirect_header($_SERVER['PHP_SELF'], 2, $messagesent);
}

/**
 * @param null $ip_id
 */
function badIpForm($ip_id = null)
{
    include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
    if ($ip_id) {
        $sform    = new XoopsThemeForm(_AM_XFGB_MOD_BADIP, 'op', xoops_getenv('PHP_SELF'));
        $badips   = xfgb_get_badips(true);
        $ip_value = $badips[$ip_id]['ip_value'];
    } else {
        $sform    = new XoopsThemeForm(_AM_XFGB_ADD_BADIP, 'op', xoops_getenv('PHP_SELF'));
        $ip_value = '';
    }

    $sform->addElement(new XoopsFormText(_AM_XFGB_VALUE, 'ip_value', 50, 50, $ip_value), true);

    $button_tray = new XoopsFormElementTray('', '');
    $button_tray->addElement(new XoopsFormButton('', 'save', _SUBMIT, 'submit'));
    if ($ip_id) {
        $button_tray->addElement(new XoopsFormHidden('ip_id', $ip_id));
    }
    $button_tray->addElement(new XoopsFormHidden('op', 'badIpSave'));
    $sform->addElement($button_tray);
    $sform->display();
}

/**
 * @param $ip_id
 * @param $ip_value
 */
function badIpSave($ip_id, $ip_value)

{
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    $myts = MyTextSanitizer::getInstance();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    //$ip_value=$myts->makeTboxData4Save($ip_value);

    if (!empty($ip_id)) {
        $sql = 'UPDATE ' . $xoopsDB->prefix('xfguestbook_badips') . " SET ip_id='$ip_id', ip_value='$ip_value'";
        $sql .= " WHERE ip_id = $ip_id";
        $xoopsDB->query($sql);
        $messagesent = _AM_XFGB_BADIP_UPDATED;
    } else {
        $sql = sprintf("SELECT COUNT(*) FROM  %s WHERE ip_value = '%s'", $xoopsDB->prefix('xfguestbook_badips'), $ip_value);
        list($count) = $xoopsDB->fetchRow($xoopsDB->query($sql));
        if ($count > 0) {
            $messagesent = '<font color="#FF0000">' . _AM_XFGB_BADIP_EXIST . '</font>';
        } else {
            $country_id = $xoopsDB->genId('ip_id_seq');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $sql        = sprintf("INSERT INTO %s (ip_id, ip_value) VALUES (%s, '%s')", $xoopsDB->prefix('xfguestbook_badips'), $ip_id, $ip_value);
            $xoopsDB->query($sql);
            $messagesent = _AM_XFGB_BADIP_ADDED;
        }
    }
    redirect_header('ip_manager.php', 2, $messagesent);
    exit();

}

function badIpShow()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $action, $start, $xoopsModule, $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
    $myts      = MyTextSanitizer::getInstance();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $limit     = 15;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $badips    = xfgb_get_badips(true);
    $nb_badips = count($badips);

    echo "
    <table width='100%' cellspacing='1' cellpadding='2' border='0' style='border-left: 1px solid silver; border-top: 1px solid silver; border-right: 1px solid silver;'>
        <tr>
            <td><span style='font-weight: bold; font-size: 12px; font-variant: small-caps;'>" . _AM_XFGB_DISP_BADIPS . ' : ' . $nb_badips . "</span></td>
            <td align='right'>
            </td>
        </tr>
    </table>";

    echo "<table border='1' width='100%' cellpadding ='2' cellspacing='1'>";
    echo "<tr class='bg3'>";
    echo '<td></td>';
    echo "<td align='center'><b>" . _AM_XFGB_IPS . '</td>';
    echo "<td align='center'><b>" . _AM_XFGB_ACTION . '</td>';
    echo '</tr>';

    if ('0' != count($badips)) {
        echo "<form name='badiplist' id='list' action='" . $_SERVER['PHP_SELF'] . "' method='POST' style='margin: 0;'>";

        for ($i = 0; $i < $nb_badips; $i++) {
            echo '<tr>';
            echo "<td align='center' class='even'><input type='checkbox' name='ip_id[]' id='ip_id[]' value='" . $badips[$i]['ip_id'] . "'/></td>";
            echo "<td class = 'odd'>" . $badips[$i]['ip_value'] . '</td>';
            echo "<td align='center' class='even'><a href='ip_manager.php?op=badIpEdit&amp;ip_id=" . $badips[$i]['ip_id'] . "'>" . _EDIT . '</a></td>';
            echo '</tr>';
            //          unset($badips);

        }
        echo "<tr class='foot'><td><select name='op'>";
        echo "<option value='badIpDel'>" . _DELETE . '</option>';
        echo '</select>&nbsp;</td>';
        echo "<td colspan='3'>" . $GLOBALS['xoopsSecurity']->getTokenHTML() . "<input type='submit' value='" . _GO . "' />";
        echo '</td></tr>';
        echo '</form>';
    } else {
        echo "<tr ><td align='center' colspan ='3' class = 'head'><b>" . _AM_XFGB_NOBADIP . '</b></td></tr>';
    }
    echo '</table><br>';
    echo '<br>';
}

switch ($op) {
    case 'badIpForm':

        xoops_cp_header();
        $index_admin = new ModuleAdmin();
        echo $index_admin->addNavigation(basename(__FILE__));
        //xfguestbook_admin_menu(3);
        badIpForm($ip_id);
        include __DIR__ . '/admin_footer.php';
        //xoops_cp_footer();
        break;
    case 'badIpDel':
        badIpDel($ip_id);
        break;
    case 'badIpEdit':

        xoops_cp_header();
        $index_admin = new ModuleAdmin();
        echo $index_admin->addNavigation(basename(__FILE__));
        //xfguestbook_admin_menu(3);
        badIpForm($ip_id);
        include __DIR__ . '/admin_footer.php';
        //xoops_cp_footer();
        break;
    case 'badIpSave':
        badIpSave($ip_id, $ip_value);
        break;
    case 'badIpAdd':

        xoops_cp_header();
        $index_admin = new ModuleAdmin();
        echo $index_admin->addNavigation(basename(__FILE__));
        //xfguestbook_admin_menu(3);
        badIpForm();
        include __DIR__ . '/admin_footer.php';
        //xoops_cp_footer();
        break;
    case 'badIpShow':
    default:

        xoops_cp_header();
        $index_admin = new ModuleAdmin();
        echo $index_admin->addNavigation(basename(__FILE__));
        //xfguestbook_admin_menu(3);
        badIpShow();
        badIpForm();
        include __DIR__ . '/admin_footer.php';
        //xoops_cp_footer();
        break;
}


Push — master ( 76b4a1...141e43 )

ip_manager.php ➔ badIpSave() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

XoopsModules25x / xfguestbook

Push — master ( 76b4a1...141e43 )

ip_manager.php ➔ badIpSave() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like