XfgbFormSelectCountry

Complexity

Total Complexity

3

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 31 and the first side effect is on line 26.

// $Id: xfgbformselectcountry.php,v 1.2 2005/08/10 Exp $
//  ------------------------------------------------------------------------ //
//             XF Guestbook                                                  //
// ------------------------------------------------------------------------- //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //

include_once dirname(dirname(dirname(__DIR__))) . '/class/xoopsform/formselect.php';

/**
 * Class XfgbFormSelectCountry
 */
class XfgbFormSelectCountry extends XoopsFormSelect

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * XfgbFormSelectCountry constructor.
     * @param      $caption
     * @param      $name
     * @param null $value
     * @param int  $size
     * @param bool $nullopt
     * @return XfgbFormSelectCountry

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct($caption, $name, $value=null, $size=1, $nullopt=false)
    {
        $db = XoopsDatabaseFactory::getDatabaseConnection();
        parent::__construct($caption, $name, $value, $size);
        $sql = 'SELECT country_code, country_name FROM ' . $db->prefix('xfguestbook_country') . ' ORDER BY country_name';
        $result = $db->query($sql);
        if ($nullopt) {
            $this->addOption('', '-');
        }
        $this->addOption('other', _MI_XFGB_OTHER);
        while ($myrow = $db->fetchArray($result)) {
            $this->addOption($myrow['country_code'], $myrow['country_name']);
        }
    }
}