Issues in index.php - New Issues - Inspection of "3.10. FINAL" - XoopsModules25x/xfguestbook - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Michael

created 2016-10-20 11:18 UTC

index.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
//
//  ------------------------------------------------------------------------ //
//             XF Guestbook                                                  //
// ------------------------------------------------------------------------- //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write metalslugto the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //

include __DIR__ . '/../../mainfile.php';
//include_once(XOOPS_ROOT_PATH."/modules/".$xoopsModule->dirname()."/class/msg.php");
include_once XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->dirname() . '/include/functions.php';
if (isset($_GET['msg_id'])) {
    $msg_id = (int)$_GET['msg_id'];
} elseif (isset($_POST['msg_id'])) {
    $msg_id = (int)$_POST['msg_id'];
} else {
    $msg_id = 0;
}

if (isset($_GET['op'])) {
    $op = $_GET['op'];
} elseif (isset($_POST['op'])) {
    $op = $_POST['op'];
} else {
    $op = 'show_all';
}

$msgHandler = xoops_getModuleHandler('msg');

//Admin or not
$xoopsUser ? $adminview = $xoopsUser->isAdmin() : $adminview = 0;

/**
 * @param $msg_id
 */
function delete($msg_id)
{
    global $msgHandler, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
    $ok = isset($_POST['ok']) ? (int)$_POST['ok'] : 0;
    if ($ok == 1) {
        $msg        = $msgHandler->get($msg_id);
        $del_msg_ok = $msgHandler->delete($msg);
        $filename   = $msg->getVar('photo');
        if ($filename !== '') {
            $filename = XOOPS_UPLOAD_PATH . '/' . $xoopsModule->getVar('dirname') . '/' . $filename;
            unlink($filename);
        }
        if ($del_msg_ok) {
            $messagesent = _MD_XFGB_MSGDELETED;
        } else {
            $messagesent = _MD_XFGB_ERRORDEL;
        }
        redirect_header('index.php', 2, $messagesent);
    } else {
        xoops_confirm(array('op' => 'delete', 'msg_id' => $msg_id, 'ok' => 1), 'index.php', _DELETE);
    }
}

/**
 * @param $msg_id
 */
function approve($msg_id)
{
    global $msgHandler;
function myFunction($a, $b) {
    // Do something
}

    $msg = $msgHandler->get($msg_id);
    $msg->setVar('moderate', 0);
    if (!$msgHandler->insert($msg)) {
        $messagesent = _MD_XFGB_ERRORVALID;
    } else {
        $messagesent = _MD_XFGB_VALIDATE;
    }
    redirect_header('index.php?op=show_waiting', 2, $messagesent);
}

/**
 * @param $msg
 */
function xfgb_getmsg($msg)
{
    global $nbmsg, $xoopsModule, $xoopsUser, $xoopsModuleConfig, $xoopsTpl, $xoopsConfig, $options, $opt, $xoopsDB;

    $arr_country = xfgb_getAllCountry();
    $xoopsTpl->assign('display_msg', true);
    foreach ($msg as $onemsg) {
        if ($poster = xfgb_get_user_data($onemsg->getVar('user_id'))) {
            $a_msg = &$poster;
        } else {
            $a_msg             = array();
            $a_msg['poster']   = $onemsg->getVar('uname');
            $a_msg['rank']     = '';
            $a_msg['rank_img'] = '';
            $a_msg['avatar']   = '';
        }
        $memberHandler = xoops_getHandler('member');
        $user          = $memberHandler->getUser($onemsg->getVar('user_id'));
        // email
        if ($xoopsModuleConfig['showemail']
            || ($onemsg->getVar('email')
                && (($user->getVar('user_viewemail') == 1
                     || $onemsg->getVar('user_id') == 0)
                    && is_object($xoopsUser)))
        ) {
            $a_msg['email'] = "<a href=\"javascript:openWithSelfMain('"
                              . XOOPS_URL
                              . '/modules/xfguestbook/contact.php?msg_id='
                              . $onemsg->getVar('msg_id')
                              . "', 'contact', 600, 450);\"><img src=\""
                              . XOOPS_URL
                              . "/images/icons/email.gif\" alt=\""
                              . _SENDEMAILTO
                              . "\" /></a>";
        }
        // url
        if ($onemsg->getVar('url')) {
            $a_msg['url'] = '<a href="'
                            . $onemsg->getVar('url')
                            . '" target="_blank"><img src="'
                            . XOOPS_URL
                            . '/images/icons/www.gif" alt="'
                            . _VISITWEBSITE
                            . '"></a>';
        }
        // gender
        if ($onemsg->getVar('gender') !== '') {
            $a_msg['gender'] = '<a href="index.php?op=show_gender&param='
                               . $onemsg->getVar('gender')
                               . '"><img src="assets/images/'
                               . $onemsg->getVar('gender')
                               . '.gif"</a>';
        }
        // flag
        if ($onemsg->getVar('country') !== '') {
            if ($onemsg->getVar('country') != 'other') {
                $flag = XOOPS_ROOT_PATH
                        . '/modules/'
                        . $xoopsModule->dirname()
                        . '/assets/images/flags/'
                        . $onemsg->getVar('flagdir')
                        . '/'
                        . $onemsg->getVar('country')
                        . '.gif';
                if (array_key_exists($onemsg->getVar('flagdir') . '/' . $onemsg->getVar('country'), $arr_country)) {
                    $country_name = $arr_country[$onemsg->getVar('flagdir') . '/' . $onemsg->getVar('country')];
                } else {
                    $country_name = '';
                }
                if (file_exists($flag)) {
                    $a_msg['country'] = "<img src=\""
                                        . XOOPS_URL
                                        . '/modules/xfguestbook/assets/images/flags/'
                                        . $onemsg->getVar('flagdir')
                                        . '/'
                                        . $onemsg->getVar('country')
                                        . ".gif\" alt=\""
                                        . $country_name
                                        . "\">";
                } else {
                    $a_msg['country'] = $country_name;
                }
                $a_msg['country'] = "<a href=\"index.php?op=show_country&param="
                                    . $onemsg->getVar('flagdir')
                                    . '/'
                                    . $onemsg->getVar('country')
                                    . "\">"
                                    . $a_msg['country']
                                    . '</a>';
            } else {
                $a_msg['country'] = $onemsg->getVar('other');
            }
        }
        $a_msg['msg_id']  = $onemsg->getVar('msg_id');
        $a_msg['i']       = $nbmsg;
        $a_msg['title']   = $onemsg->getVar('title');
        $a_msg['date']    = formatTimestamp($onemsg->getVar('post_time'), 's');
        $a_msg['message'] = $onemsg->getVar('message');
        if ($options['opt_url'] == 1) {
            $a_msg['message'] = str_replace('target="_blank"', 'target="_blank" rel="nofollow"', $a_msg['message']);
        }
        $a_msg['note_msg']  = $onemsg->getVar('note');
        $a_msg['poster_ip'] = $onemsg->getVar('poster_ip');
        $a_msg['moderate']  = $onemsg->getVar('moderate');
        if (isset($country_name)) {
            $a_msg['local'] = "<a href=\"index.php?op=show_country&param="
                              . $onemsg->getVar('flagdir')
                              . '/'
                              . $onemsg->getVar('country')
                              . "\">"
                              . $country_name
                              . '</a>';
        }
        $a_msg['photo'] = $onemsg->getVar('photo');
        $xoopsTpl->append('msg', $a_msg);
        $nbmsg--;
    }
}

function xfgb_genderlist()
{
    global $options, $xoopsTpl, $xoopsModuleConfig, $xoopsModule, $msgHandler;
    $criteria = new Criteria('moderate', 0);
    $arr_msg  = $msgHandler->countMsgByGender($criteria);
    $i        = 0;
    foreach ($arr_msg as $k => $v) {
        if ($k === 'M') {
            $gender[$i] = _MD_XFGB_MALES . '<br>';
            $gender[$i] .= '<img src="assets/images/M.gif" alt="' . _MD_XFGB_MALES . '"><br><br>';
            $gender[$i] .= '<a href="index.php?op=show_gender&param=M">' . $v . _MD_XFGB_MESSAGES . '</a>';
        } elseif ($k === 'F') {
            $gender[$i] = _MD_XFGB_FEMALES . '<br>';
            $gender[$i] .= '<img src="assets/images/F.gif" alt="' . _MD_XFGB_FEMALES . '"><br><br>';
            $gender[$i] .= '<a href="index.php?op=show_gender&param=F">' . $v . _MD_XFGB_MESSAGES . '</a>';
        } else {
            $gender[$i] = _MD_XFGB_UNKNOW2 . '<br>';
            $gender[$i] .= '<img src="assets/images/U.gif"><br><br>';
            $gender[$i] .= $v . _MD_XFGB_MESSAGES;
        }
        $i++;
    }
    $xoopsTpl->assign('gender', $gender);
    $xoopsTpl->assign('display_gender', $options['opt_gender']);
}

// end functions

// if op = show_***, functions needed
//if (substr($op, 0, 4) == 'show') {
if (0 === strpos($op, 'show')) {
    $debut = isset($_GET['debut']) ? (int)$_GET['debut'] : 0;
    $param = isset($_GET['param']) ? $_GET['param'] : '';

    include_once __DIR__ . '/include/functions.php';
    $GLOBALS['xoopsOption']['template_main'] = 'xfguestbook_index.tpl';
    include_once XOOPS_ROOT_PATH . '/header.php';
    include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
    include_once XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->dirname() . '/include/config.inc.php';
    $options = getOptions();

    $criteria = new Criteria('moderate', 0);
    $nbmsg    = $msgHandler->countMsg($criteria);

    $xoopsTpl->assign('msg_message_count', sprintf(_MD_XFGB_THEREIS, '<b>' . $nbmsg . '</b>'));
    $xoopsTpl->assign('msg_moderated', $xoopsModuleConfig['moderate']);
    $xoopsTpl->assign('msg_lang_name', $xoopsConfig['language']);
    $xoopsTpl->assign('xoops_pagetitle', $xoopsModule->name() . ' -messages');
    if ($adminview) {
        $nbwait = $msgHandler->countMsg(new Criteria('moderate', '1'));
        $xoopsTpl->assign('msg_moderate_text', sprintf(_MD_XFGB_MODERATING, "<font class='fg2'><a href='"
                                                                            . XOOPS_URL
                                                                            . "/modules/xfguestbook/index.php?op=show_waiting'>"
                                                                            . $nbwait
                                                                            . '</a></font>'));
    }
}

switch ($op) {
    case 'delete':
        if ($adminview) {
            include_once XOOPS_ROOT_PATH . '/header.php';
            delete($msg_id);
        } else {
            redirect_header('index.php', 1, '');
        }
        break;

    case 'approve':
        if ($adminview) {
            include_once XOOPS_ROOT_PATH . '/header.php';
            approve($msg_id);
        } else {
            redirect_header('index.php', 1, '');
        }
        break;

    case 'show_stat':
        if ($options['opt_gender'] > 0) {
            xfgb_genderlist();
        }
        break;

    case 'show_waiting':
        $pagenav = new XoopsPageNav($nbwait, $xoopsModuleConfig['perpage'], $debut, 'debut', 'op=show_waiting');
        $xoopsTpl->assign('msg_page_nav', $pagenav->renderNav());
        $criteria = new Criteria('moderate', 1);
        $criteria->setOrder('DESC');
        $criteria->setLimit($xoopsModuleConfig['perpage']);
        $criteria->setStart($debut);
        $msg =& $msgHandler->getObjects($criteria);
        $nbwait -= $debut;
        $nbmsg = $nbwait;
        xfgb_getmsg($msg);
        break;

    case 'show_one':
        if ($adminview) {
            $criteria = new Criteria('msg_id', $msg_id);
        } else {
            $criteria = new CriteriaCompo(new Criteria('moderate', '0'));
            $criteria->add(new Criteria('msg_id', $msg_id));
        }
        $msg =& $msgHandler->getObjects($criteria);
        xfgb_getmsg($msg);
        if ($options['opt_gender'] > 0) {
            xfgb_genderlist();
        }
        break;

    case 'show_country':
        list($flagdir, $country) = explode('/', $param);
        $criteria = new CriteriaCompo(new Criteria('moderate', '0'));
        if ($flagdir == $xoopsModuleConfig['flagdir']) {
            $criteria->add(new Criteria('flagdir', $flagdir));
        }
        $criteria->add(new Criteria('country', $country));
        $nbmsg   = $msgHandler->countMsg($criteria);
        $pagenav = new XoopsPageNav($nbmsg, $xoopsModuleConfig['perpage'], $debut, 'debut', 'op=show_country&param=' . $param);
        $criteria->setOrder('DESC');
        $criteria->setLimit($xoopsModuleConfig['perpage']);
        $criteria->setStart($debut);
        $msg =& $msgHandler->getObjects($criteria);
        $nbmsg -= $debut;
        $xoopsTpl->assign('msg_page_nav', $pagenav->renderNav());
        xfgb_getmsg($msg);
        break;

    case 'show_gender':
        $criteria = new CriteriaCompo(new Criteria('moderate', '0'));
        $criteria->add(new Criteria('gender', $param));
        $nbmsg   = $msgHandler->countMsg($criteria);
        $pagenav = new XoopsPageNav($nbmsg, $xoopsModuleConfig['perpage'], $debut, 'debut', 'op=show_gender&param=' . $param);
        $criteria->setOrder('DESC');
        $criteria->setLimit($xoopsModuleConfig['perpage']);
        $criteria->setStart($debut);
        $msg =& $msgHandler->getObjects($criteria);
        $nbmsg -= $debut;
        $xoopsTpl->assign('msg_page_nav', $pagenav->renderNav());
        xfgb_getmsg($msg);
        if ($options['opt_gender'] > 0) {
            xfgb_genderlist();
        }
        break;

    case 'show_all':
    default:
        $pagenav = new XoopsPageNav($nbmsg, $xoopsModuleConfig['perpage'], $debut, 'debut', '');
        $xoopsTpl->assign('msg_page_nav', $pagenav->renderNav());
        $criteria = new Criteria('moderate', 0);
        $criteria->setOrder('DESC');
        $criteria->setLimit($xoopsModuleConfig['perpage']);
        $criteria->setStart($debut);
        $msg =& $msgHandler->getObjects($criteria);
        $nbmsg -= $debut;
        xfgb_getmsg($msg);
        if ($options['opt_gender'] > 0) {
            xfgb_genderlist();
        }
        break;

    case 'cancel':
        $photos_dir     = XOOPS_UPLOAD_PATH . '/' . $xoopsModule->getVar('dirname');
        $nb_removed_tmp = xfgb_clear_tmp_files($photos_dir);
        redirect_header('index.php', 0);
        break;
}
$sql = $xoopsDB->query('SELECT * FROM ' . $xoopsDB->prefix('xfguestbook_country') . ' ORDER BY country_name ASC');

while ($coun = $xoopsDB->fetchArray($sql)) {
    $sql2 = $xoopsDB->query('SELECT COUNT(country) tot FROM '
                            . $xoopsDB->prefix('xfguestbook_msg')
                            . " WHERE country='"
                            . $coun['country_code']
                            . "'");
    list($tlocal) = $xoopsDB->fetchRow($sql2);
    $tlocal = $tlocal ?: '0';
    if ($tlocal > 0) {
        $opt["<a href=\"index.php?op=show_country&param="
             . $xoopsModuleConfig['flagdir']
             . '/'
             . $coun['country_code']
             . "\">"
             . $coun['country_name']
             . '</a>'] = $tlocal;
    } else {
        $opt[$coun['country_name']] = $tlocal;
    }
}
$xoopsTpl->assign('country_l', $opt);

include XOOPS_ROOT_PATH . '/footer.php';


Pull Request — master (#10)

index.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2		//
3		// ------------------------------------------------------------------------ //
4		// XF Guestbook //
5		// ------------------------------------------------------------------------- //
6		// This program is free software; you can redistribute it and/or modify //
7		// it under the terms of the GNU General Public License as published by //
8		// the Free Software Foundation; either version 2 of the License, or //
9		// (at your option) any later version. //
10		// //
11		// You may not change or alter any portion of this comment or credits //
12		// of supporting developers from this source code or any supporting //
13		// source code which is considered copyrighted (c) material of the //
14		// original comment or credit authors. //
15		// //
16		// This program is distributed in the hope that it will be useful, //
17		// but WITHOUT ANY WARRANTY; without even the implied warranty of //
18		// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
19		// GNU General Public License for more details. //
20		// //
21		// You should have received a copy of the GNU General Public License //
22		// along with this program; if not, write metalslugto the Free Software //
23		// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA //
24		// ------------------------------------------------------------------------ //
25
26		include __DIR__ . '/../../mainfile.php';
27		//include_once(XOOPS_ROOT_PATH."/modules/".$xoopsModule->dirname()."/class/msg.php");
28		include_once XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->dirname() . '/include/functions.php';
29	View Code Duplication	if (isset($_GET['msg_id'])) {
30		$msg_id = (int)$_GET['msg_id'];
31		} elseif (isset($_POST['msg_id'])) {
32		$msg_id = (int)$_POST['msg_id'];
33		} else {
34		$msg_id = 0;
35		}
36
37	View Code Duplication	if (isset($_GET['op'])) {
38		$op = $_GET['op'];
39		} elseif (isset($_POST['op'])) {
40		$op = $_POST['op'];
41		} else {
42		$op = 'show_all';
43		}
44
45		$msgHandler = xoops_getModuleHandler('msg');
46
47		//Admin or not
48		$xoopsUser ? $adminview = $xoopsUser->isAdmin() : $adminview = 0;
49
50		/**
51		* @param $msg_id
52		*/
53		function delete($msg_id)
54		{
55		global $msgHandler, $xoopsModule;
		0 ignored issues – show Compatibility Best Practice introduced 2016-10-20 11:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
56		$ok = isset($_POST['ok']) ? (int)$_POST['ok'] : 0;
57		if ($ok == 1) {
58		$msg = $msgHandler->get($msg_id);
59		$del_msg_ok = $msgHandler->delete($msg);
60		$filename = $msg->getVar('photo');
61	View Code Duplication	if ($filename !== '') {
62		$filename = XOOPS_UPLOAD_PATH . '/' . $xoopsModule->getVar('dirname') . '/' . $filename;
63		unlink($filename);
64		}
65		if ($del_msg_ok) {
66		$messagesent = _MD_XFGB_MSGDELETED;
67		} else {
68		$messagesent = _MD_XFGB_ERRORDEL;
69		}
70		redirect_header('index.php', 2, $messagesent);
71		} else {
72		xoops_confirm(array('op' => 'delete', 'msg_id' => $msg_id, 'ok' => 1), 'index.php', _DELETE);
73		}
74		}
75
76		/**
77		* @param $msg_id
78		*/
79		function approve($msg_id)
80		{
81		global $msgHandler;
		0 ignored issues – show Compatibility Best Practice introduced 2016-10-20 11:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
82
83		$msg = $msgHandler->get($msg_id);
84		$msg->setVar('moderate', 0);
85		if (!$msgHandler->insert($msg)) {
86		$messagesent = _MD_XFGB_ERRORVALID;
87		} else {
88		$messagesent = _MD_XFGB_VALIDATE;
89		}
90		redirect_header('index.php?op=show_waiting', 2, $messagesent);
91		}
92
93		/**
94		* @param $msg
95		*/
96		function xfgb_getmsg($msg)
97		{
98		global $nbmsg, $xoopsModule, $xoopsUser, $xoopsModuleConfig, $xoopsTpl, $xoopsConfig, $options, $opt, $xoopsDB;
99
100		$arr_country = xfgb_getAllCountry();
101		$xoopsTpl->assign('display_msg', true);
102		foreach ($msg as $onemsg) {
103		if ($poster = xfgb_get_user_data($onemsg->getVar('user_id'))) {
104		$a_msg = &$poster;
105		} else {
106		$a_msg = array();
107		$a_msg['poster'] = $onemsg->getVar('uname');
108		$a_msg['rank'] = '';
109		$a_msg['rank_img'] = '';
110		$a_msg['avatar'] = '';
111		}
112		$memberHandler = xoops_getHandler('member');
113		$user = $memberHandler->getUser($onemsg->getVar('user_id'));
114		// email
115		if ($xoopsModuleConfig['showemail']
116		\|\| ($onemsg->getVar('email')
117		&& (($user->getVar('user_viewemail') == 1
118		\|\| $onemsg->getVar('user_id') == 0)
119		&& is_object($xoopsUser)))
120		) {
121		$a_msg['email'] = "<a href=\"javascript:openWithSelfMain('"
122		. XOOPS_URL
123		. '/modules/xfguestbook/contact.php?msg_id='
124		. $onemsg->getVar('msg_id')
125		. "', 'contact', 600, 450);\"><img src=\""
126		. XOOPS_URL
127		. "/images/icons/email.gif\" alt=\""
128		. _SENDEMAILTO
129		. "\" /></a>";
130		}
131		// url
132		if ($onemsg->getVar('url')) {
133		$a_msg['url'] = '<a href="'
134		. $onemsg->getVar('url')
135		. '" target="_blank"><img src="'
136		. XOOPS_URL
137		. '/images/icons/www.gif" alt="'
138		. _VISITWEBSITE
139		. '"></a>';
140		}
141		// gender
142		if ($onemsg->getVar('gender') !== '') {
143		$a_msg['gender'] = '<a href="index.php?op=show_gender&param='
144		. $onemsg->getVar('gender')
145		. '"><img src="assets/images/'
146		. $onemsg->getVar('gender')
147		. '.gif"</a>';
148		}
149		// flag
150		if ($onemsg->getVar('country') !== '') {
151		if ($onemsg->getVar('country') != 'other') {
152		$flag = XOOPS_ROOT_PATH
153		. '/modules/'
154		. $xoopsModule->dirname()
155		. '/assets/images/flags/'
156		. $onemsg->getVar('flagdir')
157		. '/'
158		. $onemsg->getVar('country')
159		. '.gif';
160		if (array_key_exists($onemsg->getVar('flagdir') . '/' . $onemsg->getVar('country'), $arr_country)) {
161		$country_name = $arr_country[$onemsg->getVar('flagdir') . '/' . $onemsg->getVar('country')];
162		} else {
163		$country_name = '';
164		}
165	View Code Duplication	if (file_exists($flag)) {
166		$a_msg['country'] = "<img src=\""
167		. XOOPS_URL
168		. '/modules/xfguestbook/assets/images/flags/'
169		. $onemsg->getVar('flagdir')
170		. '/'
171		. $onemsg->getVar('country')
172		. ".gif\" alt=\""
173		. $country_name
174		. "\">";
175		} else {
176		$a_msg['country'] = $country_name;
177		}
178		$a_msg['country'] = "<a href=\"index.php?op=show_country&param="
179		. $onemsg->getVar('flagdir')
180		. '/'
181		. $onemsg->getVar('country')
182		. "\">"
183		. $a_msg['country']
184		. '</a>';
185		} else {
186		$a_msg['country'] = $onemsg->getVar('other');
187		}
188		}
189		$a_msg['msg_id'] = $onemsg->getVar('msg_id');
190		$a_msg['i'] = $nbmsg;
191		$a_msg['title'] = $onemsg->getVar('title');
192		$a_msg['date'] = formatTimestamp($onemsg->getVar('post_time'), 's');
193		$a_msg['message'] = $onemsg->getVar('message');
194		if ($options['opt_url'] == 1) {
195		$a_msg['message'] = str_replace('target="_blank"', 'target="_blank" rel="nofollow"', $a_msg['message']);
196		}
197		$a_msg['note_msg'] = $onemsg->getVar('note');
198		$a_msg['poster_ip'] = $onemsg->getVar('poster_ip');
199		$a_msg['moderate'] = $onemsg->getVar('moderate');
200		if (isset($country_name)) {
201		$a_msg['local'] = "<a href=\"index.php?op=show_country&param="
202		. $onemsg->getVar('flagdir')
203		. '/'
204		. $onemsg->getVar('country')
205		. "\">"
206		. $country_name
207		. '</a>';
208		}
209		$a_msg['photo'] = $onemsg->getVar('photo');
210		$xoopsTpl->append('msg', $a_msg);
211		$nbmsg--;
212		}
213		}
214
215		function xfgb_genderlist()
216		{
217		global $options, $xoopsTpl, $xoopsModuleConfig, $xoopsModule, $msgHandler;
218		$criteria = new Criteria('moderate', 0);
219		$arr_msg = $msgHandler->countMsgByGender($criteria);
220		$i = 0;
221		foreach ($arr_msg as $k => $v) {
222		if ($k === 'M') {
223		$gender[$i] = _MD_XFGB_MALES . '<br>';
224		$gender[$i] .= '<img src="assets/images/M.gif" alt="' . _MD_XFGB_MALES . '"><br><br>';
225		$gender[$i] .= '<a href="index.php?op=show_gender&param=M">' . $v . _MD_XFGB_MESSAGES . '</a>';
226		} elseif ($k === 'F') {
227		$gender[$i] = _MD_XFGB_FEMALES . '<br>';
228		$gender[$i] .= '<img src="assets/images/F.gif" alt="' . _MD_XFGB_FEMALES . '"><br><br>';
229		$gender[$i] .= '<a href="index.php?op=show_gender&param=F">' . $v . _MD_XFGB_MESSAGES . '</a>';
230		} else {
231		$gender[$i] = _MD_XFGB_UNKNOW2 . '<br>';
232		$gender[$i] .= '<img src="assets/images/U.gif"><br><br>';
233		$gender[$i] .= $v . _MD_XFGB_MESSAGES;
234		}
235		$i++;
236		}
237		$xoopsTpl->assign('gender', $gender);
238		$xoopsTpl->assign('display_gender', $options['opt_gender']);
239		}
240
241		// end functions
242
243		// if op = show_***, functions needed
244		//if (substr($op, 0, 4) == 'show') {
245		if (0 === strpos($op, 'show')) {
246		$debut = isset($_GET['debut']) ? (int)$_GET['debut'] : 0;
247		$param = isset($_GET['param']) ? $_GET['param'] : '';
248
249		include_once __DIR__ . '/include/functions.php';
250		$GLOBALS['xoopsOption']['template_main'] = 'xfguestbook_index.tpl';
251		include_once XOOPS_ROOT_PATH . '/header.php';
252		include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
253		include_once XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->dirname() . '/include/config.inc.php';
254		$options = getOptions();
255
256		$criteria = new Criteria('moderate', 0);
257		$nbmsg = $msgHandler->countMsg($criteria);
258
259		$xoopsTpl->assign('msg_message_count', sprintf(_MD_XFGB_THEREIS, '<b>' . $nbmsg . '</b>'));
260		$xoopsTpl->assign('msg_moderated', $xoopsModuleConfig['moderate']);
261		$xoopsTpl->assign('msg_lang_name', $xoopsConfig['language']);
262		$xoopsTpl->assign('xoops_pagetitle', $xoopsModule->name() . ' -messages');
263		if ($adminview) {
264		$nbwait = $msgHandler->countMsg(new Criteria('moderate', '1'));
265		$xoopsTpl->assign('msg_moderate_text', sprintf(_MD_XFGB_MODERATING, "<font class='fg2'><a href='"
266		. XOOPS_URL
267		. "/modules/xfguestbook/index.php?op=show_waiting'>"
268		. $nbwait
269		. '</a></font>'));
270		}
271		}
272
273		switch ($op) {
274	View Code Duplication	case 'delete':
275		if ($adminview) {
276		include_once XOOPS_ROOT_PATH . '/header.php';
277		delete($msg_id);
278		} else {
279		redirect_header('index.php', 1, '');
280		}
281		break;
282
283	View Code Duplication	case 'approve':
284		if ($adminview) {
285		include_once XOOPS_ROOT_PATH . '/header.php';
286		approve($msg_id);
287		} else {
288		redirect_header('index.php', 1, '');
289		}
290		break;
291
292		case 'show_stat':
293		if ($options['opt_gender'] > 0) {
294		xfgb_genderlist();
295		}
296		break;
297
298	View Code Duplication	case 'show_waiting':
299		$pagenav = new XoopsPageNav($nbwait, $xoopsModuleConfig['perpage'], $debut, 'debut', 'op=show_waiting');
300		$xoopsTpl->assign('msg_page_nav', $pagenav->renderNav());
301		$criteria = new Criteria('moderate', 1);
302		$criteria->setOrder('DESC');
303		$criteria->setLimit($xoopsModuleConfig['perpage']);
304		$criteria->setStart($debut);
305		$msg =& $msgHandler->getObjects($criteria);
306		$nbwait -= $debut;
307		$nbmsg = $nbwait;
308		xfgb_getmsg($msg);
309		break;
310
311		case 'show_one':
312		if ($adminview) {
313		$criteria = new Criteria('msg_id', $msg_id);
314		} else {
315		$criteria = new CriteriaCompo(new Criteria('moderate', '0'));
316		$criteria->add(new Criteria('msg_id', $msg_id));
317		}
318		$msg =& $msgHandler->getObjects($criteria);
319		xfgb_getmsg($msg);
320		if ($options['opt_gender'] > 0) {
321		xfgb_genderlist();
322		}
323		break;
324
325		case 'show_country':
326		list($flagdir, $country) = explode('/', $param);
327		$criteria = new CriteriaCompo(new Criteria('moderate', '0'));
328		if ($flagdir == $xoopsModuleConfig['flagdir']) {
329		$criteria->add(new Criteria('flagdir', $flagdir));
330		}
331		$criteria->add(new Criteria('country', $country));
332		$nbmsg = $msgHandler->countMsg($criteria);
333		$pagenav = new XoopsPageNav($nbmsg, $xoopsModuleConfig['perpage'], $debut, 'debut', 'op=show_country&param=' . $param);
334		$criteria->setOrder('DESC');
335		$criteria->setLimit($xoopsModuleConfig['perpage']);
336		$criteria->setStart($debut);
337		$msg =& $msgHandler->getObjects($criteria);
338		$nbmsg -= $debut;
339		$xoopsTpl->assign('msg_page_nav', $pagenav->renderNav());
340		xfgb_getmsg($msg);
341		break;
342
343		case 'show_gender':
344		$criteria = new CriteriaCompo(new Criteria('moderate', '0'));
345		$criteria->add(new Criteria('gender', $param));
346		$nbmsg = $msgHandler->countMsg($criteria);
347		$pagenav = new XoopsPageNav($nbmsg, $xoopsModuleConfig['perpage'], $debut, 'debut', 'op=show_gender&param=' . $param);
348		$criteria->setOrder('DESC');
349		$criteria->setLimit($xoopsModuleConfig['perpage']);
350		$criteria->setStart($debut);
351		$msg =& $msgHandler->getObjects($criteria);
352		$nbmsg -= $debut;
353		$xoopsTpl->assign('msg_page_nav', $pagenav->renderNav());
354		xfgb_getmsg($msg);
355		if ($options['opt_gender'] > 0) {
356		xfgb_genderlist();
357		}
358		break;
359
360		case 'show_all':
361	View Code Duplication	default:
362		$pagenav = new XoopsPageNav($nbmsg, $xoopsModuleConfig['perpage'], $debut, 'debut', '');
363		$xoopsTpl->assign('msg_page_nav', $pagenav->renderNav());
364		$criteria = new Criteria('moderate', 0);
365		$criteria->setOrder('DESC');
366		$criteria->setLimit($xoopsModuleConfig['perpage']);
367		$criteria->setStart($debut);
368		$msg =& $msgHandler->getObjects($criteria);
369		$nbmsg -= $debut;
370		xfgb_getmsg($msg);
371		if ($options['opt_gender'] > 0) {
372		xfgb_genderlist();
373		}
374		break;
375
376	View Code Duplication	case 'cancel':
377		$photos_dir = XOOPS_UPLOAD_PATH . '/' . $xoopsModule->getVar('dirname');
378		$nb_removed_tmp = xfgb_clear_tmp_files($photos_dir);
379		redirect_header('index.php', 0);
380		break;
381		}
382		$sql = $xoopsDB->query('SELECT * FROM ' . $xoopsDB->prefix('xfguestbook_country') . ' ORDER BY country_name ASC');
383
384		while ($coun = $xoopsDB->fetchArray($sql)) {
385		$sql2 = $xoopsDB->query('SELECT COUNT(country) tot FROM '
386		. $xoopsDB->prefix('xfguestbook_msg')
387		. " WHERE country='"
388		. $coun['country_code']
389		. "'");
390		list($tlocal) = $xoopsDB->fetchRow($sql2);
391		$tlocal = $tlocal ?: '0';
392		if ($tlocal > 0) {
393		$opt["<a href=\"index.php?op=show_country&param="
394		. $xoopsModuleConfig['flagdir']
395		. '/'
396		. $coun['country_code']
397		. "\">"
398		. $coun['country_name']
399		. '</a>'] = $tlocal;
400		} else {
401		$opt[$coun['country_name']] = $tlocal;
402		}
403		}
404		$xoopsTpl->assign('country_l', $opt);
405
406		include XOOPS_ROOT_PATH . '/footer.php';
407

XoopsModules25x / xfguestbook

Pull Request — master (#10)

index.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like