XoopsModules25x /
xfguestbook
| Conditions | 8 |
| Paths | 8 |
| Total Lines | 59 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 31 | function b_xfguestbook_show($options) |
||
| 32 | { |
||
| 33 | global $xoopsModule, $xoopsModuleConfig, $xoopsDB; |
||
| 34 | /** @var Helper $helper */ |
||
| 35 | $helper = Helper::getInstance(); |
||
| 36 | if (empty($xoopsModule) || 'xfguestbook' !== $xoopsModule->getVar('dirname')) { |
||
| 37 | /** @var \XoopsModuleHandler $moduleHandler */ |
||
| 38 | $moduleHandler = xoops_getHandler('module'); |
||
| 39 | $module = $moduleHandler->getByDirname('xfguestbook'); |
||
| 40 | /** @var \XoopsConfigHandler $configHandler */ |
||
| 41 | $configHandler = xoops_getHandler('config'); |
||
| 42 | $config = $configHandler->getConfigsByCat(0, $module->getVar('mid')); |
||
|
Unused Code
introduced
by
|
|||
| 43 | } else { |
||
| 44 | $module = $xoopsModule; |
||
| 45 | $config = $xoopsModuleConfig; |
||
| 46 | } |
||
| 47 | |||
| 48 | $block = []; |
||
| 49 | if (0 != $options[1]) { |
||
| 50 | $block['full_view'] = true; |
||
| 51 | } else { |
||
| 52 | $block['full_view'] = false; |
||
| 53 | } |
||
| 54 | |||
| 55 | /** @var \XoopsModules\Xfguestbook\MessageHandler $messageHandler */ |
||
| 56 | $messageHandler = $helper->getHandler('Message'); |
||
| 57 | $criteria = new \Criteria('moderate', '0', '='); |
||
| 58 | $criteria->setSort('post_time'); |
||
| 59 | $criteria->setOrder('DESC'); |
||
| 60 | $criteria->setLimit($options[0]); |
||
| 61 | $nbmsg = $messageHandler->countMsg($criteria); |
||
| 62 | |||
| 63 | $a_item = []; |
||
| 64 | |||
| 65 | if ($nbmsg > 0) { |
||
| 66 | $msg = $messageHandler->getObjects($criteria); |
||
| 67 | $ts = \MyTextSanitizer::getInstance(); |
||
| 68 | |||
| 69 | /** @var \XoopsModules\Xfguestbook\Message $onemsg */ |
||
| 70 | foreach ($msg as $onemsg) { |
||
| 71 | $msg_id = $onemsg->getVar('msg_id'); |
||
| 72 | $a_item['id'] = $msg_id; |
||
| 73 | $a_item['title'] = $onemsg->getVar('title'); |
||
| 74 | if (!XOOPS_USE_MULTIBYTES) { |
||
| 75 | $length = mb_strlen($onemsg->getVar('title')); |
||
| 76 | if ($length >= $options[1]) { |
||
| 77 | $a_item['title'] = mb_substr($a_item['title'], 0, $options[1] - $length) . '...'; |
||
| 78 | } |
||
| 79 | } |
||
| 80 | $a_item['name'] = $onemsg->getVar('uname'); |
||
| 81 | $a_item['date'] = formatTimestamp($onemsg->getVar('post_time'), 's'); |
||
| 82 | $block['items'][] = $a_item; |
||
| 83 | unset($a_item); |
||
| 84 | } |
||
| 85 | } else { |
||
| 86 | $block['nbmsg'] = 0; |
||
| 87 | } |
||
| 88 | |||
| 89 | return $block; |
||
| 90 | } |
||
| 104 |
Loading history...