donations.php ➔ Config() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/xdonations - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 4a1a1e...7e0534 )

by Michael
created 2016-06-01 04:09 UTC
donations.php ➔ Config() D

↳ Parent: Project
Complexity

Conditions	13
Paths	192
Size

Total Lines	374
Code Lines	214
Duplication

Lines	15
Ratio	4.01 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	13
eloc	214
c	1
b	0
f	0
nc	192
nop	0
dl	15
loc	374
rs	4.6605
How to fix Long Method Complexity

<?php

/************************************************************************/
/* Donations - Paypal financial management module for Xoops 2           */
/* Copyright (c) 2004 by Xoops2 Donations Module Dev Team			    */
/* http://dev.xoops.org/modules/xfmod/project/?group_id=1060			*/
/* $Id: donations.php 8193 2011-11-07 02:42:53Z beckmi $      */

/************************************************************************/
/*                                                                      */
/* Based on NukeTreasury for PHP-Nuke - by Dave Lawrence AKA Thrash     */
/* NukeTreasury - Financial management for PHP-Nuke                     */
/* Copyright (c) 2004 by Dave Lawrence AKA Thrash                       */
/*                       [email protected]                         */
/*                       [email protected]                          */
/*                                                                      */
/************************************************************************/
/*                                                                      */
/* This program is free software; you can redistribute it and/or modify */
/* it under the terms of the GNU General Public License as published by */
/* the Free Software Foundation; either version 2 of the License.       */
/*                                                                      */
/* This program is distributed in the hope that it will be useful, but  */
/* WITHOUT ANY WARRANTY; without even the implied warranty of           */
/* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU     */
/* General Public License for more details.                             */
/*                                                                      */
/* You should have received a copy of the GNU General Public License    */
/* along with this program; if not, write to the Free Software          */
/* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  */
/* USA                                                                  */
/************************************************************************/

include '..' . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'include' . DIRECTORY_SEPARATOR . 'cp_header.php';

xoops_loadLanguage('main', $xoopsModule->getVar('dirname'));
include '..' . DIRECTORY_SEPARATOR . 'include' . DIRECTORY_SEPARATOR . 'functions.php';
include_once 'admin_header.php';
xoops_cp_header();
//adminmain();

$tr_config = configInfo();
//determine the currency
$PP_CURR_CODE = explode('|',$tr_config['pp_curr_code']); // [USD,GBP,JPY,CAD,EUR,AUD]

$PP_CURR_CODE = $PP_CURR_CODE[0];
$curr_sign = define_curr($PP_CURR_CODE);

/***************************************************************************
 *
 ***************************************************************************/
function Treasury()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $tr_config, $xoopsDB, $xoopsModule, $modversion, $curr_sign, $pathIcon16;
function myFunction($a, $b) {
    // Do something
}
    include_once XOOPS_ROOT_PATH . DIRECTORY_SEPARATOR . 'class'   . DIRECTORY_SEPARATOR . 'xoopsformloader.php';
    $indexAdmin = new ModuleAdmin();
echo $indexAdmin->addNavigation('donations.php?op=Treasury');

    // Register paging
    $maxRows_Recordset1 = 10;
    $pageNum_Recordset1 = (isset($_POST['pageNum_Recordset1'])) ? intval($_POST['pageNum_Recordset1']) : 0 ;
    $startRow_Recordset1 = $pageNum_Recordset1 * $maxRows_Recordset1;

    //	$query_Recordset1 = "SELECT id, date, DATE_FORMAT(date, '%d-%b-%Y') as fdate, DATE_FORMAT(date, '%d') as day, DATE_FORMAT(date, '%m') as mon, DATE_FORMAT(date, '%Y') as year, num, name, descr, amount FROM ".$xoopsDB->prefix("donations_financial")." order by date DESC";

    $query_Recordset1 = "SELECT id, date, DATE_FORMAT(date, '%d-%b-%Y') as fdate, num, name, descr, amount FROM ".$xoopsDB->prefix("donations_financial")." ORDER BY date DESC";
    $query_limit_Recordset1 = "$query_Recordset1 LIMIT $startRow_Recordset1, $maxRows_Recordset1";
    $Recordset1 = $xoopsDB->query($query_limit_Recordset1);
    $row_Recordset1 = $xoopsDB->fetchArray($Recordset1);

    if (isset($_POST['totalRows_Recordset1'])) {
        $totalRows_Recordset1 = $_POST['totalRows_Recordset1'];
    } else {
        $all_Recordset1 = $xoopsDB->query($query_Recordset1);
        $totalRows_Recordset1 = $xoopsDB->getRowsNum($all_Recordset1);
    }
    $totalPages_Recordset1 = ceil($totalRows_Recordset1/$maxRows_Recordset1)-1;
    $queryString_Recordset1 = "&totalRows_Recordset1=".$totalRows_Recordset1."#AdminTop";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    // Collect IPN reconcile data
    // First, get the date of the last time we reconciled
    $query_Recordset2 = "SELECT `date` AS recdate FROM " . $xoopsDB->prefix("donations_financial") . " WHERE name = 'PayPal IPN' ORDER BY date DESC LIMIT 1";
    $Recordset2 = $xoopsDB->query($query_Recordset2);
    $row_Recordset2 = $xoopsDB->fetchArray($Recordset2);
    $recdate = $row_Recordset2['recdate'];

    // Get the date of the last donation
    $query_Recordset2 = "SELECT `payment_date` AS curdate FROM ".$xoopsDB->prefix("donations_transactions")." WHERE payment_status = 'Completed' AND (txn_type = 'send_money' OR txn_type = 'web_accept' ) ORDER BY payment_date DESC LIMIT 1";
    $Recordset2 = $xoopsDB->query($query_Recordset2);
    $row_Recordset2 = $xoopsDB->fetchArray($Recordset2);
    $curdate = $row_Recordset2['curdate'];

    // Collect the IPN transactions between recdate and curdate
    $query_Recordset2 = "SELECT custom, SUM(mc_gross) AS gross, SUM(mc_gross - mc_fee) AS net FROM ".$xoopsDB->prefix("donations_transactions")." WHERE (payment_date > '{$recdate}' AND payment_date <= '{$curdate}') GROUP BY txn_id";
    $Recordset2 = $xoopsDB->query($query_Recordset2);

    // Iterate over the records skipping the ones that total out to zero(refunds)
    $ipn_tot = 0;
    $num_ipn = 0;
    while( $row_Recordset2 = $xoopsDB->fetchArray($Recordset2) ) {
        if( $row_Recordset2['gross'] > 0 ) {
            $ipn_tot += $row_Recordset2['net'];
            $num_ipn++;
        }
    }

    // Get the register balance & total number of records
    $query_Recordset4 = "SELECT SUM(amount) AS total, COUNT(*) as numRec FROM " . $xoopsDB->prefix("donations_financial") . "";
    $Recordset4 = $xoopsDB->query($query_Recordset4);
    list($total, $numRec) = $xoopsDB->fetchRow($Recordset4);
    /*

     $row_Recordset4 = $xoopsDB->fetchArray($Recordset4);
     $total = $row_Recordset4['total'];

     // Query to remove the Edit/Delete buttons if no results will be listed.
     $queryRec = "SELECT COUNT(*) FROM ".$xoopsDB->prefix("donations_financial")."";
     list($numRec) = $xoopsDB->fetchRow($queryRec);
     */
    // Output the page
    echo "<table style=\"border-width: 1px; width: 100%; text-align: center;\">\n"
    . "<tr><td>\n";
    echo "<table style=\"border-width: 0px; padding: 0px; margin: 0px; text-align: center;\">\n";
    echo "  <tr><td style=\"width: 100%; text-align: center; font-weight: bold;\">";
    echo "<font class=\"option\"><h3>" . _AD_DON_TREASURY_F_REGISTER . "</h3></font></td></tr>\n";
    echo "  <tr><td style=\"width: 100%;\">" . _AD_DON_NEW_IPN_COUNT . " {$num_ipn} - " . _AD_DON_TOTALING . " {$curr_sign}{$ipn_tot}";
    echo "</td></tr>\n";
    echo "<tr><td style=\"width: 100%; text-align: center;\">\n";
    echo "  <form action=\"donations.php?op=IpnRec#AdminTop\" method=\"post\">\n";
    echo "    <input type=\"hidden\" name=\"op\" value=\"IpnRec\" />\n"
    ."    <input type=\"submit\" value=\""._AD_DON_SYNCHRONISE_IPN."\" onClick=\"return confirm('"._AD_DON_CONFIRM_TOTAL_UP."')\" />\n"
    ."  </form>\n";
    echo "</td></tr></table>\n";

    if( $pageNum_Recordset1 > 0 ) {
        echo "<table style=\"border-width: 0px; text-align: center;\">\n"
        . "  <tr>\n";
        echo "    <td><form action=\"donations.php#AdminTop\" method=\"post\">\n"
        . "<input type=\"hidden\" name=\"op\" value=\"Treasury\" />\n"
        . "<input type=\"hidden\" name=\"pageNum_Recordset1\" value=\"0\" />\n"
        . "<input type=\"hidden\" name=\"totalRows_Recordset1\" value=\"{$totalRows_Recordset1}\" />\n"
        . "<input type=\"submit\" name=\"navig\" value=\"|&lt;\" title=\"" . _AD_DON_CURRENT . "\" /></form></td>\n";
        echo "<td><form action=\"donations.php#AdminTop\" method=\"post\">\n"
        . "<input type=\"hidden\" name=\"op\" value=\"Treasury\" />\n"
        . "<input type=\"hidden\" name=\"pageNum_Recordset1\" value=\"" . max(0, $pageNum_Recordset1 - 1) . "\" />\n"
        . "<input type=\"hidden\" name=\"totalRows_Recordset1\" value=\"{$totalRows_Recordset1}\" />\n"
        . "<input type=\"submit\" name=\"navig\" value=\"&lt;\" title=\"" . _AD_DON_NEXT_NEWEST . "\" /></form></td>\n";
        if( $pageNum_Recordset1 < $totalPages_Recordset1 ) {
            echo "<td><form action=\"donations.php#AdminTop\" method=\"post\">\n"
            . "<input type=\"hidden\" name=\"op\" value=\"Treasury\" />\n"
            . "<input type=\"hidden\" name=\"pageNum_Recordset1\" value=\"" . min($totalPages_Recordset1, $pageNum_Recordset1 + 1) . "\" />\n"
            . "<input type=\"hidden\" name=\"totalRows_Recordset1\" value=\"{$totalRows_Recordset1}\" />\n"
            . "<input type=\"submit\" name=\"navig\" value=\"&gt;\" title=\"" . _AD_DON_NEXT_OLDEST ."\" /></form></td>\n";
            echo "<td><form action=\"donations.php#AdminTop\" method=\"post\">\n"
            . "<input type=\"hidden\" name=\"op\" value=\"Treasury\" />\n"
            . "<input type=\"hidden\" name=\"pageNum_Recordset1\" value=\"{$totalPages_Recordset1}\" />\n"
            . "<input type=\"hidden\" name=\"totalRows_Recordset1\" value=\"{$totalRows_Recordset1}\" />\n"
            . "<input type=\"submit\" name=\"navig\" value=\"&gt;|\" title=\"" . _AD_DON_OLDEST . "\" /></form></td>\n";
        }
        echo "</tr></table>\n";
    }

        echo "<table class='outer' width='100%' border='0' cellpadding='0' cellspacing='0'>"
        . "<th align='center'>" . _AD_DON_DATE
        . "</th><th align='center'>". _AD_DON_NUM
        . "</th><th align='center'>" . _AD_DON_NAME
        . "</th><th align='center'>" . _AD_DON_DESCRIPTION
        . "</th><th align='center'>" . _AD_DON_AMOUNT
        . "</th><th align='center'>" . _AD_DON_ACTION
        . "</th></tr>\n";
//		$class = 'even';


        $row=0;
    do {
        $row += 1;
        echo "<tr>\n";
        echo "</td>\n"
        ."<td style=\"text-align: center;\">$row_Recordset1[fdate]</td>\n"
        ."<td style=\"text-align: center; width: 8px;\">$row_Recordset1[num]</td>\n"
        ."<td style=\"text-align: center;\">$row_Recordset1[name]</td>\n"
        ."<td style=\"text-align: center;\">$row_Recordset1[descr]</td>\n"
        ."<td style=\"text-align: right;\"><span ";
        $amt =  sprintf("%10.2f",$row_Recordset1['amount']);
        if( $amt < 0 ) {
            echo "style=\"color: #FF0000;\"";
        }
        echo ">{$curr_sign}{$amt}</span></td>\n";
        
        if ( $numRec!=0 ) {
        echo "<td style=\"text-align: center;\">";
        $jscriptCmd = "<a href=\"javascript: void 0\" onclick=\""
            ."document.recedit.id.value = '$row_Recordset1[id]'; "
            ."document.recedit.StartDate.value = '$row_Recordset1[fdate]'; ";
            $jscriptCmd .= "document.recedit.Num.value = '$row_Recordset1[num]'; "
            ."document.recedit.Name.value = '$row_Recordset1[name]'; "
            ."document.recedit.Descr.value = '$row_Recordset1[descr]'; "
            ."document.recedit.Amount.value = '$row_Recordset1[amount]'; "
            ."document.recedit.Submit.value = 'Modify'; "
            ."document.recedit.op.value = 'FinRegEdit'; "
            ."return false;\">"
            ."<img style=\"border-width: 0px; width: 16px; height: 16px;\" src=". $pathIcon16 .'/edit.png'." alt='" . _EDIT . "' title='" . _EDIT . "' /></a>&nbsp;"
            ."<a href=\"donations.php?op=FinRegDel&id=$row_Recordset1[id]\">"
            ."<img style=\"border-width: 0px; width: 16px; height: 16px;\" src=". $pathIcon16 .'/delete.png'." alt='" . _DELETE . "' title='" . _DELETE ."'\" onClick=\"return confirm('" . _AD_DON_CONFIRM_DELETE . '\n\n' . _AD_DON_CONFIRM_ACTION . "')\""
            ." /></a>"
            ."</td>\n"
            ;
            echo $jscriptCmd;
       }
            

    } while ($row_Recordset1 = $xoopsDB->fetchArray($Recordset1));

    echo "</table>\n"  . "<table style=\"width: 100%; text-align: center;\"><br/>\n";
    echo "<tr><td style=\"text-align: right; font-weight: bold;\" colspan=\"5\"><h4>" . _AD_DON_NETBAL . ":&nbsp;&nbsp;{$curr_sign}";
    echo sprintf("%0.2f", $total) . "&nbsp;</h4></td></tr>\n";
    echo "</table><br/>\n";

    echo "<table style=\"text-align: center;\">\n"
    . "<tr><td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_DATE . "</td>\n"
    . "<td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_NUM . "</td>\n"
    . "<td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_NAME . "</td>\n"
    . "<td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_DESCRIPTION . "</td>\n"
    . "<td style=\"text-align: right; font-weight: bold;\">" . _AD_DON_AMOUNT . "</td></tr>\n"
    . "<tr>\n"
    . "<td style=\"text-align: center;\">\n"
    . "<form action=\"donations.php\" method=\"post\" name=\"recedit\">\n"
    . "<input name=\"id\" type=\"hidden\" />\n";
    $newDate = new XoopsFormTextDateSelect('Date', 'StartDate', $size = 15, NULL);
    $showDate = $newDate->render();
    echo $showDate . "</td>\n";
    echo "<td style=\"text-align: center; width: 8px;\"><input name=\"Num\" type=\"text\" size=\"8\" /></td>\n"
    . "<td style=\"text-align: center;\"><input name=\"Name\" type=\"text\" /></td>\n"
    . "<td style=\"text-align: center;\"><input name=\"Descr\" type=\"text\" /></td>\n"
    . "<td style=\"text-align: right;\"><input name=\"Amount\" type=\"text\" size=\"8\" /></td>\n";
    echo "</tr>\n";
    echo "<tr><td style=\"text-align: right;\" colspan=\"5\">\n"
    . "<input name=\"\" type=\"reset\" value=\"" . _RESET . "\" onclick=\""
    . "document.recedit.Submit.value = '"._ADD."'; "
    . "document.recedit.op.value = 'FinRegAdd'; "
    . "return true;\" />&nbsp;\n"
    . "<input type=\"hidden\" name=\"op\" value=\"FinRegAdd\" /><input name=\"Submit\" type=\"submit\" value=\"" . _AD_DON_ADD . "\" />\n"
    . "</form>\n";
    echo "</td></tr>\n";
    echo "</table>\n";
    echo "</td></tr></table>\n";
}

function FinancialRegAdd()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $tr_config, $modversion, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    $time = date("h:i:s");
    //	$nTime = $_POST['StartYear'].'-'.$_POST['StartMonth'].'-'.$_POST['StartDay'].' '.$time;

    //	$nTime = strtotime($nTime);

    $nTime = strtotime("{$_POST['StartDate']} {$time}");
    if($nTime == -1) {
        echo _AD_DON_ERR_BAD_DATE_FORMAT . "<br />\n";
    } else {
        if ( strlen($_POST['Name']) == 0) {
            echo _AD_DON_ERR_BAD_NAME_FORMAT . "<br />\n";
        } else {
            if( !is_numeric($_POST['Amount'])) {
                echo _AD_DON_INVALID_AMOUNT."<br />";
            } else {
                echo _AD_DON_FIELD_PASSED."<br />";
                echo strftime("%Y-%m-%d", $nTime) . " $_POST[Num] $_POST[Name] $_POST[Descr] $_POST[Amount]<br /><br />";

                $insert_Recordset = "INSERT INTO `".$xoopsDB->prefix("donations_financial")."` VALUES "
                . "(NULL, '" . strftime("%Y-%m-%d %H:%M:%S", $nTime) . "','" . addslashes($_POST['Num']) . "','" . addslashes($_POST['Name'])
                . "','" . addslashes($_POST['Descr']) . "','" . addslashes($_POST['Amount']) . "')";

                $rvalue = $xoopsDB->query($insert_Recordset);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                echo "$insert_Recordset";
                echo strftime("%Y-%m-%d", $nTime) . " $_POST[Num] $_POST[Name] $_POST[Descr] $_POST[Amount]<br /><br />$insert_Recordset";
                Header("Location: donations.php?op=Treasury#AdminTop");
            }
        }
    }
}

function FinancialRegDel()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $tr_config, $modversion, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    echo _AD_DON_FIELD_PASSED . "<br />\n";

    if( is_numeric($_GET['id']) && ($_GET['id'] > 0) ) {
        $del_Recordset = "DELETE FROM `" . $xoopsDB->prefix("donations_financial") . "`"
        . " WHERE `id`='" . intval($_GET[id]) . "' LIMIT 1";
        $rvalue = $xoopsDB->queryF($del_Recordset);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        header("Location: donations.php?op=Treasury#AdminTop");
    } else {
        echo "<br />" . _AD_DON_ERR_INVALID_RECORD_ID . "<br />\n";
    }
}

function FinancialRegEdit()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $tr_config, $modversion, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    $time = date("h:i:s");
    //    $nTime = $_POST['StartYear'].'-'.$_POST['StartMonth'].'-'.$_POST['StartDay'].' '.$time;

    $nTime = $_POST['StartDate'] . ' ' . $time;
    $nTime = strtotime($nTime);

    if($nTime == -1) {
        echo _AD_DON_ERR_BAD_DATE_FORMAT . "<br />\n";
    } else {
        if( strlen($_POST['Name']) == 0) {
            echo _AD_DON_ERR_BAD_NAME_FORMAT . "<br />\n";
        } else {
            if( !is_numeric($_POST['Amount'])) {
                echo _AD_DON_INVALID_AMOUNT2 . '<br />\n';
            } else {
                echo _AD_DON_FIELD_PASSED . "<br />\n";

                echo strftime("%Y-%m-%d", $nTime) . " $_POST[Num] $_POST[Name] $_POST[Descr] $_POST[Amount]<br /><br />\n";

                $insert_Recordset = "UPDATE `".$xoopsDB->prefix("donations_financial")."` SET date='". strftime("%Y-%m-%d %H:%M:%S", $nTime) . "', num='$_POST[Num]', Name='$_POST[Name]', "
                . "descr='$_POST[Descr]', amount='$_POST[Amount]' WHERE id='$_POST[id]' LIMIT 1";

                echo "$insert_Recordset";
                $rvalue = $xoopsDB->query($insert_Recordset);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

                echo "$_POST[id]" . strftime("%Y-%m-%d", $nTime) . " $_POST[Num] $_POST[Name] $_POST[Descr] $_POST[Amount]<br /><br />$insert_Recordset";

                Header("Location: donations.php?op=Treasury#AdminTop");

            }
        }
    }
}

/*********************************************************************
 *
 *********************************************************************/
function Config()
{
    global $tr_config, $xoopsModule, $modversion, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    //------------------------------------------------------------------------
    $indexAdmin = new ModuleAdmin();
    echo $indexAdmin->addNavigation('donations.php?op=Config');
    ?>
<script Language="JavaScript">
function isEmailAddr(email)
{
  var result = false;
  var theStr = new String(email);
  var index = theStr.indexOf("@");
  if (index > 0)
  {
    var pindex = theStr.indexOf(".",index);
    if ((pindex > index+1) && (theStr.length > pindex+1))
    result = true;
  }
  return result;
}

function validRequired(formField,fieldLabel,message)
{
    var result = true;

    if (formField.value == "")
    {
        alert(message.replace("%1\$s", field));

        formField.focus();
        result = false;
    }

    return result;
}

function allDigits(str)
{
    return inValidCharSet(str,"0123456789");
}

function inValidCharSet(str,charset)
{
    var result = true;

    // Note: doesn't use regular expressions to avoid early Mac browser bugs
    for (var i=0;i<str.length;i++)
        if (charset.indexOf(str.substr(i,1))<0)
        {
            result = false;
            break;
        }

    return result;
}

function validInt(formField,fieldLabel,required,message)
{
    var result = true;

    if (required && !validRequired(formField,fieldLabel,message))
        result = false;

    if (result)
    {
// 		var num = parseInt(formField.value,10);
        if (!allDigits(formField.value))
        {
            if(required)
            {
                //alert('Please enter a number for the "' + fieldLabel +'" field.');
                alert(message.replace("%1\$s",fieldLabel));
                formField.focus();
                result = false;
            }
            else if ( formField.value == "" )
            {
                return true;
            }
            else
            {
                //alert('Please enter a number or a blank for the "' + fieldLabel +'" field.');
                alert(message.replace("%1\$s",fieldLabel));
                formField.focus();
                result = false;
            }
        }
    }

    return result;
}


function validdateURL(formField, value, secure)
{

    var match = /https/i.test(value);

    if( value != "" && !/^http/i.test(value) )
    {
        alert('The URL must start with http://');
        formField.focus();
        return false;
    }

    if( secure && value != "" && !/^https/i.test(value) )
    {
//		alert('This should reside on a HTTPS server.  Users will be warned about viewing secure and non-secure data on the same page');

        return confirm('This URL does not begin with https://\nThis image should reside on an HTTPS server.\nIf you use this URL, users will receive a warning\nabout viewing secure and non-secure data on the same page.\n\n  Are you sure you want to continue?');
    }

    return true;
}


function checkCancelledURL()
{
    if( document.tr_configs.var_pp_image_url.value == "")
        alert('There is no URL for a Cancelled payment.  If you do not enter\na URL for cancelled payments PayPal will also use\nthis URL for cancelled payments.');
    return true;
}
</script>
    <?php
    //-------------------------------------------------------------------------------
    echo "<form name=\"tr_configs\" action=\"donations.php\" method=\"post\">\n"
    . "<input type=\"hidden\" name=\"op\" value=\"ConfigUpdate\" />\n";
    echo "<table style=\"border-width: 1px; width: 90%; text-align: center;\"><tr>\n";
    echo "<td style=\"text-align: center; font-weight: bold;\" class=\"title\">\n";
    echo "<h3>" . _AD_DON_CONFIG_MODULE . "</h3>\n";
    echo "<table style=\"border-width: 1px; text-align: center;\">\n";

    ShowTextBox('don_button_top', "<span style=\"font-weight: bold;\">" . _AD_DON_IMG_BUTTON_TOP . "</span>", '', '70', 'onChange="return validdateURL(this,this.value);"');
    ShowImgXYBox('don_top_img_width', 'don_top_img_height', "<span style=\"font-weight: bold;\">" . _AD_DON_IMAGE_SIZE . "</span>", '4', "onChange='return validInt(this,\""._AD_DON_IMAGE_SIZE."\",0,\""._AD_DON_ALERTE_INPUT_NUMBER."\");'");
    ShowTextBox('don_button_submit', "<span style=\"font-weight: bold;\">" . _AD_DON_IMG_BUTTON_URL . "</span>", '', '70', 'onChange="return validdateURL(this,this.value);"');
    ShowImgXYBox('don_sub_img_width', 'don_sub_img_height', "<span style=\"font-weight: bold;\">" . _AD_DON_IMAGE_SIZE . "</span>", '4', "onChange='return validInt(this,\""._AD_DON_IMAGE_SIZE."\",0,\""._AD_DON_ALERTE_INPUT_NUMBER."\");'");
    //"onChange='return validInt(this,"._AD_DON_IMAGE_SIZE.")'"
    ShowTextBox('don_name_prompt', "<span style=\"font-weight: bold;\">" . _AD_DON_USERNAME_REQUEST . "</span>", '', '70', '');
    ShowTextBox('don_name_yes', "<span style=\"font-weight: bold;\">" . _AD_DON_USERNAME_REQUEST_YES . "</span>", '', '50', '');
    ShowTextBox('don_name_no', "<span style=\"font-weight: bold;\">" . _AD_DON_USERNAME_REQUEST_NO . "</span>", '', '50', '');

    $desc = 'This is where you can appeal to your'
          . 'users and your community for donations.'
        . 'Suggestion: Explain why you need donations,'
          . 'what you do with the money and how you'
          . 'manage it. Make them comfortable that'
        . 'they are not throwing their money away.';

    $sql = "SELECT * FROM " . $xoopsDB->prefix("donations_config") . " WHERE name = 'don_text'";
    $Recordset = $xoopsDB->query($sql);
    $row = $xoopsDB->fetchArray($Recordset);
    $donText = $row['text'];
    echo "<tr>\n"
    ."  <td title=\"{$desc}\" style=\"text-align: right; font-weight: bold;\">" . _AD_DON_INTRODUCE_TEXT . "</td>\n"
    ."  <td title=\"{$desc}\" style=\"text-align: left;\">"
    ."<textarea name=\"var_don_text-rawtext-txt\" cols=\"100\" rows=\"20\">{$donText}</textarea></td>\n";
    echo "</tr>\n";

//    ShowTextBox('don_amt_checked', '<span style=\'font-weight: bold;\'>'._AD_DON_AMOUNT_DEFAULT.'</span>', '', '4', "onChange=\"return validInt(this,'"._AD_DON_AMOUNT_DEFAULT."',1,'"._AD_DON_ALERTE_INPUT_NUMBER."');\"");


    echo "</table>\n";
    echo "<br />\n";

    $query_Recordset1 = "SELECT * FROM ".$xoopsDB->prefix("donations_config")." WHERE name = 'don_amount' ORDER BY subtype";
    $Recordset1 = $xoopsDB->query($query_Recordset1);
    $row_Recordset1 = $xoopsDB->fetchArray($Recordset1);
    $totalRows_Recordset1 = $xoopsDB->getRowsNum($Recordset1);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $desc = htmlentities($row_Recordset1['text']);

    echo "<table style=\"border-width: 1px; width: 100px; text-align: center;\">\n";
    echo "  <tr><td style=\"text-align: center; width: 100%; font-weight: bold;\" colspan=\"8\">" . _AD_DON_SUGGESTED_AMOUNT . "<br /></td></tr>\n";
    $row1 = "  <tr><td title=\"{$desc}\" style=\"text-align: center;\"></td>\n";
    $row2 = "  <tr><td title=\"{$desc}\" style=\"text-align: center; font-weight: bold;\">" . _AD_DON_AMOUNT . "</td>\n";
    do {
        $row1 .= "    <td title=\"{$desc}\" style=\"text-align: center;\">{$row_Recordset1['subtype']}</td>\n";
        $row2 .= "    <td title=\"{$desc}\" style=\"text-align: center;\"><input size=\"4\" name=\"var_don_amount-{$row_Recordset1['subtype']}\" type=\"text\" value=\"{$row_Recordset1['value']}\" onChange=\"return validInt(this,'"._AD_DON_SUGGESTED_AMOUNT." #{$row_Recordset1['subtype']}',1,'"._AD_DON_ALERTE_INPUT_NUMBER."');\" /></td>\n";
    } while ($row_Recordset1 = $xoopsDB->fetchArray($Recordset1));

    $row1 .= "</tr>\n";
    $row2 .= "</tr>\n";
    echo "{$row1} {$row2}\n";

    // display default option
    $query_cfg = "SELECT * FROM ".$xoopsDB->prefix("donations_config")
               . " WHERE name = 'don_amt_checked' LIMIT 1";
    $cfgResult = $xoopsDB->query($query_cfg);
    $amt = $xoopsDB->fetchArray($cfgResult);
    $amt_checked = intval($amt['value']);
    echo "<tr><td>" . _AD_DON_DEFAULT . "</td>\n";
    for ($i=1; $i<8; $i++) {
        $checked = ($i == $amt_checked) ? ' checked' : '';
        echo "<td><input type=\"radio\" name=\"var_don_amt_checked\"{$checked} value=\"{$i}\"></td>\n";
    }
    echo "</tr>\n";
    echo "</table>\n";

    echo "</td></tr>\n";
    echo "<tr><td style=\"text-align: center; width: 100%;\"><br /><input type=\"submit\" value=\"" . _AD_DON_SUBMIT ."\" /></td></tr>";
    echo "</table><br /><br />\n";
    echo $indexAdmin->addNavigation('donations.php?op=Config');
    echo "<table style=\"border-width: 1px; width: 90%; text-align: center;\"><tr>\n";
    echo "<td class=\"title\" style=\"font-weight: bold; text-align: center;\"><h3>" . _AD_DON_CONFIG_PAYPAL_HEADER . "</h3><br />\n";
    echo "<table style=\"border-width: 1px; text-align: center;\">\n";

    $rsql = "SELECT rank_id, rank_title FROM " . $xoopsDB->prefix('ranks') . "";
    $rresult = $xoopsDB->query($rsql);
    $r_array = array();
    while( $r_row = $xoopsDB->fetchRow($rresult) ){
        $r_array[] = $r_row;
    }
    ShowDropBox('paypal_url', '<span style=\'font-weight: bold;\'>'._AD_DON_IPN_URL.'</span>');
    ShowTextBox('receiver_email', '<span style=\'font-weight: bold;\'>'._AD_DON_IPN_EMAIL_RECEIVER.'</span>', '', '40', '');
    ShowTextBox('ty_url', '<span style=\'font-weight: bold;\'>' . _AD_DON_IPN_URL_SUCCESS . '</span>', '', '80', 'onChange="checkCancelledURL(); return validdateURL(this,this.value);"');
    ShowTextBox('pp_cancel_url', '<span style=\'font-weight: bold;\'>'._AD_DON_IPN_URL_CANCELED.'</span>', '', '80', 'onChange="return validdateURL(this,this.value);"');
    ShowTextBox('pp_itemname', '<span style=\'font-weight: bold;\'>'._AD_DON_PP_ITEM_NAME.'</span>', '', '20', '');
    ShowTextBox('pp_item_num', '<span style=\'font-weight: bold;\'>'._AD_DON_PP_ITEM_NUMBER.'</span>', '', '20', '');
    ShowTextBox('pp_image_url', '<span style=\'font-weight: bold;\'>'._AD_DON_PP_IMG.'</span>', '', '60', '');
    ShowYNBox('pp_get_addr', '<span style=\'font-weight: bold;\'>'._AD_DON_PP_ASK_CP_ADRESS.'</span>');
    ShowDropBox('pp_curr_code', '<span style=\'font-weight: bold;\'>'._AD_DON_PP_MONEY.'</span>');
    $gsql = "SELECT groupid, name FROM ".$xoopsDB->prefix('groups')." WHERE groupid>3";
    $gresult = $xoopsDB->query($gsql);
    $g_array = array();
    while( $g_row = $xoopsDB->fetchRow($gresult) ){
        $g_array[] = $g_row;
    }
    ShowArrayDropBox('assign_group', '<span style=\'font-weight: bold;\'>'._AD_DON_PP_GROUP.'</span>', $g_array);
    $rsql = "SELECT rank_id, rank_title FROM " . $xoopsDB->prefix('ranks') . "";
    $rresult = $xoopsDB->query($rsql);
    $r_array = array();
    while( $r_row = $xoopsDB->fetchRow($rresult) ){
        $r_array[] = $r_row;
    }
    ShowArrayDropBox('assign_rank', '<span style=\'font-weight: bold;\'>'._AD_DON_PP_RANK.'</span>', $r_array);
    ShowYNBox('don_forceadd', '<span style=\'font-weight: bold;\'>'._AD_DON_ADD_ANYWAY.'</span>');

    echo "</table><br />\n";

    echo "<table style=\"border-width: 1px; width: 100px; text-align: center;\">\n";
    echo "  <tr><td style=\"text-align: center; width: 100%; font-weight: bold;\" colspan=\"2\">" . _AD_DON_IPN_LOGGING . "<br /></td></tr>\n";
    echo "  <tr>\n"
    . "    <td style=\"text-align: right; font-weight: bold;\">" . _AD_DON_IPN_LOGGING_LEVEL . "</td>\n"
    . "    <td style=\"text-align: left;\">\n"
    . "      <select size=\"1\" name=\"var_ipn_dbg_lvl\">\n";
    echo "        <option ";
    if ( 0 == $tr_config['ipn_dbg_lvl'] ) {
        echo "selected ";
    }
    echo "value=\"0\">" . _AD_DON_LOG_OFF . "</option>\n";
    echo "        <option ";
    if ( $tr_config['ipn_dbg_lvl'] == 1 ) {
        echo "selected ";
    }
    echo "value=\"1\">" . _AD_DON_LOG_ONLY_ERRORS . "</option>\n";
    echo "        <option ";
    if ( $tr_config['ipn_dbg_lvl'] == 2 ) {
        echo "selected ";
    }
    echo "value=\"2\">" . _AD_DON_LOG_EVERYTHING . "</option>\n";
    echo "      </select>\n"
    . "    </td>\n"
    . "  </tr>\n";

    ShowTextBox('ipn_log_entries', '<nobr><span style=\'font-weight: bold;\'>'._AD_DON_LOG_ENTRY.'</span></nobr>', '', '4', '');

    $desc = 'This box shows the link to the IPN recorder.
    This link must be pasted EXACTLY as it is
    into your PayPal IPN profile.  You can click
    on the "test" link to the right to verify
    that the IPN recorder is functioning correctly.';
    $desc = htmlentities($desc);
    echo "<tr>\n"
    . "  <td title =\"$desc\" style=\"text-align: right; font-weight: bold;\">" . _AD_DON_IPN_LINK . "</td>\n"
    . "  <td title =\"$desc\" style=\"text-align: center;\">&nbsp;" . XOOPS_URL . "/modules/" . $xoopsModule->getVar('dirname') . "/ipnppd.php&nbsp;&nbsp;\n"
    . "    <br /><a href=\"" . XOOPS_URL . "/modules/" . $xoopsModule->getVar('dirname') . "/ipnppd.php?dbg=1\" target=\"_blank\"><span style=\"font-weight: bold; font-style: italic;\"><img src=\"../images/admin/info.png\" style=\"height: 16px; width: 16px;\" alt=\"\">&nbsp;". _AD_DON_TEST_IPN . "</span></a>\n"
    . "  </td>\n"
    . "</tr>\n";
    echo "</table><br />\n";
    echo "</td></tr>\n";
    echo "<tr><td style=\"text-align: center; width: 100%;\"><input type=\"submit\" value=\"" . _AD_DON_SUBMIT . "\" />\n";
    echo "</td></tr></table><br /><br />";
    echo $indexAdmin->addNavigation('donations.php?op=Config');
    echo "<table style=\"border-width: 1px; width: 90%; text-align: center;\">\n"
    . "  <tr>\n";
    echo "    <td style=\"text-align: center; font-weight: bold;\" class=\"title\">\n"
    . "      <h3>" . _AD_DON_GOAL_PREFERENCES . "</h3>\n";
    echo "      <table style=\"border-width: 1px; text-align: center;\">\n"
    . "        <tr><td style=\"text-align: center;\">\n";
    echo "          <table style=\"border-width: 1px; text-align: center;\">\n";
    ShowDropBox('use_goal', '<span style=\'font-weight: bold;\'>'._AD_DON_GOAL_TYPE.'.</span>');
    echo "          </table>\n";

    $query_Recordset1 = "SELECT * FROM ".$xoopsDB->prefix("donations_config")." WHERE name = 'week_goal' AND subtype<>'Default'";
    $Recordset1 = $xoopsDB->query($query_Recordset1);
    $row_Recordset1 = $xoopsDB->fetchArray($Recordset1);
    $totalRows_Recordset1 = $xoopsDB->getRowsNum($Recordset1);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $desc = htmlentities($row_Recordset1['text']);

    echo "          <table style=\"border-width: 1px; width: 100px; text-align: center;\">\n"
    . "            <tr><td style=\"text-align: center; width: 100%; font-weight: bold;\" colspan=\"5\">" . _AD_DON_GOAL_HEBDO . "<br /></td></tr>\n";
    $row1 = "  <tr>\n"
    . "    <td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_WEEK . "</td>\n";
    $row2 = "  <tr>\n"
    . "    <td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_GOAL . "</td>\n";
    //-------------------------------------------------------------
    $shortMonth = explode('|', _AD_DON_SHORT_MONTH);
    $ordinaux   = explode('|', _AD_DON_NUMBER_ORDINAUX);
    //-------------------------------------------------------------
    $h = 0;
    do {

        $ord = $ordinaux[$h++];
        $row1 .= "    <td title=\"{$desc}\" style=\"text-align: center;\">{$ord}</td>\n";
        $row2 .= "    <td title=\"{$desc}\" style=\"text-align: center;\"><input size=\"4\" name=\"var_week_goal-$row_Recordset1[subtype]\" type=\"text\" value=\"$row_Recordset1[value]\" onChange=\"return validInt(this,'$row_Recordset1[subtype] " . _AD_DON_GOAL_DONATION . "',1,'" . _AD_DON_ALERTE_INPUT_NUMBER . "');\" /></td>\n";
    } while ($row_Recordset1 = $xoopsDB->fetchArray($Recordset1));
    $row1 .= "  </tr>\n";
    $row2 .= "  </tr>\n";
    echo "{$row1} {$row2}";

    echo "</table>\n";

    $query_Recordset1 = "SELECT * FROM ".$xoopsDB->prefix("donations_config")." WHERE name = 'month_goal' AND subtype<>'Default'";
    $Recordset1 = $xoopsDB->query($query_Recordset1);
    $row_Recordset1 = $xoopsDB->fetchArray($Recordset1);
    $totalRows_Recordset1 = $xoopsDB->getRowsNum($Recordset1);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $desc = htmlentities($row_Recordset1['text']);

    $h = 0;
    echo "<table style=\"border-width: 1px; width: 100px; text-align: center;\">\n";
    echo "  <tr><td style=\"text-align: center; width: 100%; font-weight: bold;\" colspan=\"13\">" . _AD_DON_GOAL_MENSUEL . "</td></tr><br />\n";
    $row1 = "  <tr>\n"
    . "    <td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_MONTH . "</td>\n";
    $row2 = "  <tr>\n"
    . "    <td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_GOAL . "</td>\n";
    do {

        $month = $shortMonth[$h++];
        $row1 .= "    <td title=\"{$desc}\" style=\"text-align: center;\">{$month}</td>\n";
        $row2 .= "    <td title=\"{$desc}\" style=\"text-align: center;\"><input size=\"4\" name=\"var_month_goal-$row_Recordset1[subtype]\" type=\"text\" value=\"$row_Recordset1[value]\" onChange=\"return validInt(this,'$row_Recordset1[subtype] "._AD_DON_GOAL_DONATION."',1,'"._AD_DON_ALERTE_INPUT_NUMBER."');\" /></td>\n";
    } while ($row_Recordset1 = $xoopsDB->fetchArray($Recordset1));
    $row1 .= "  </tr>\n";
    $row2 .= "  </tr>\n";
    echo "{$row1}{$row2}";

    echo "</table>\n";
    echo "<table style=\"border-width: 1px; width: 100px; text-align: center\">\n";
    ShowTextBox('swing_day', '<span style=\'font-weight: bold;\'>'._AD_DON_SWING_DAY.'</span>', '175', '4', "onChange='return validInt(this,\""._AD_DON_SWING_DAY."\",1,\""._AD_DON_ALERTE_INPUT_NUMBER."\");'");
    echo "</table>\n";

    $query_Recordset1 = "SELECT * FROM ".$xoopsDB->prefix("donations_config")." WHERE name = 'quarter_goal' AND subtype<>'Default'";
    $Recordset1 = $xoopsDB->query($query_Recordset1);
    $row_Recordset1 = $xoopsDB->fetchArray($Recordset1);
    $totalRows_Recordset1 = $xoopsDB->getRowsNum($Recordset1);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $desc = htmlentities($row_Recordset1['text']);

    echo "<table style=\"border-width: 1px; width: 100px; text-align: center;\">\n";
    echo "  <tr><td style=\"text-align: center; width: 100%; font-weight: bold;\" colspan=\"5\">" . _AD_DON_QUARTER . "<br /></td></tr>\n";
    $row1 = "  <tr><td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_QUARTER . "</td>\n";
    $row2 = "  <tr><td style=\"text-align: center; font-weight: bold;\">" . _AD_DON_GOAL . "</td>\n";
    $h = 0;
    do {

        $ord = $ordinaux[$h++];
        $row1 .= "    <td title='{$desc}' style='text-align: center;'>{$ord}</td>\n";
        $row2 .= "    <td title='{$desc}' style='text-align: center;'><input size=\"4\" name=\"var_quarter_goal-$row_Recordset1[subtype]\" type=\"text\" value=\"$row_Recordset1[value]\" onChange=\"return validInt(this,'$row_Recordset1[subtype] "._AD_DON_GOAL_DONATION."',1,'"._AD_DON_ALERTE_INPUT_NUMBER."');\" /></td>\n";
    } while ($row_Recordset1 = $xoopsDB->fetchArray($Recordset1));
    $row1 .= "  </tr>\n";
    $row2 .= "  </tr>\n";
    echo "{$row1} {$row2}";

    echo "</table><br />\n";
    echo "</td></tr>\n";
    echo "<tr><td style=\"text-align: center; width: 100%;\"><input type=\"submit\" value=\"" . _AD_DON_SUBMIT . "\"></td></tr>\n";
    echo "</table><br/>\n";
    echo "</td></tr></table>\n";
    echo "</form>\n";
}

/**
 *
 * Update Configuration Settings in the database
 */
function ConfigUpdate()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $tr_config, $modversion, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    echo "<br />" . _AD_DON_ERR_SQL_FAILURE . "<br /><br />\n";

    $error = 1;
    $ilog = "<br />\n";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    foreach( $_POST as $option => $value ) {
        /// Look for form variables
        if( preg_match("/var_/",$option)) {
            $varnm = preg_replace("/var_/","",$option);
            // Check for subtype field

            if( preg_match("/-(.*)/",$varnm,$subtype) ) {
                echo "<br />subtype = $subtype[1] <br />\n";
                $temp = $varnm;
                $varnm = preg_replace("/-.*/","",$temp);
                // Is this is a text field?
                if( preg_match("/([^-]*)-txt/",$subtype[1], $subtype2) ) {
                    if (!get_magic_quotes_gpc()) {
                        $textarea = addslashes($value);
                    } else {
                        $textarea = $value;
                    }

                    echo "$varnm $subtype2[1] text=> " . nl2br(htmlspecialchars($textarea)) . "<br />\n";
                    $error &= UpdateDb($varnm, $subtype2[1], "0", $textarea);
                } else {
                    echo "$varnm $subtype[1] => $value<br />\n";
                    $error &= UpdateDbShort($varnm, $subtype[1], $value);

                }
            } else {
                echo "$varnm => $value<br />\n";
                $error &= UpdateDbShort($varnm, "", $value);

            }
        }
    }

    // If there were no errors
    if( 0 == $error )
    Header("Location: donations.php?op=Config#AdminTop");
}

/**
 *
 * Reconcile the IPN Log
 */
function IpnRec()
{
    global $tr_config, $modversion, $xoopsDB, $curr_sign;
function myFunction($a, $b) {
    // Do something
}
    $query_Recordset1 = "SELECT `date` AS recdate FROM " . $xoopsDB->prefix("donations_financial")
    ." WHERE name='PayPal IPN' ORDER BY date DESC LIMIT 1";
    $Recordset1 = $xoopsDB->query($query_Recordset1);
    if ($Recordset1) {
        $row_Recordset1 = $xoopsDB->fetchArray($Recordset1);
        if($row_Recordset1){
            $recdate = "payment_date > '" . $row_Recordset1['recdate'] . "' AND";
        }else{
            $recdate = '';
        }
    } else {
        $recdate = '';
    }

    $query_Recordset1 = "SELECT `payment_date` AS curdate from " . $xoopsDB->prefix("donations_transactions")
    ." WHERE payment_status='Completed' AND (txn_type='send_money' OR txn_type='web_accept')"
    ." ORDER BY payment_date DESC LIMIT 1";
    $Recordset1 = $xoopsDB->query($query_Recordset1);
    $row_Recordset1 = $xoopsDB->fetchArray($Recordset1);
    $curdate = $row_Recordset1['curdate'];
    $query_Recordset1 = "SELECT SUM(mc_gross - mc_fee) AS ipn_total, COUNT(*) AS numrecs"
    . " FROM " . $xoopsDB->prefix("donations_transactions")
    . " WHERE ({$recdate} payment_date <= '{$curdate}')"
    . " AND payment_status = 'Completed' AND (txn_type='send_money' OR txn_type='web_accept')";
    $Recordset1 = $xoopsDB->query($query_Recordset1);
    $row_Recordset1 = $xoopsDB->fetchArray($Recordset1);

    echo "<span style='text-align: center; font-weight: bold;' class='title'>" . _AD_DON_UPDATE_REGISTER_IPN . "</span><br /><br />";
    if( 0 == $row_Recordset1['numrecs'] ) {
        echo _AD_DON_NO_NEW_IPNS;
    } else {
        $insert_set = "INSERT INTO `" . $xoopsDB->prefix("donations_financial") . "` (`date`,`num`,`name`,`descr`,`amount`) VALUES ('{$curdate}','','PayPal IPN','Auto-Reconcile','{$row_Recordset1['ipn_total']}')";

        if($xoopsDB->query($insert_set)) {
            echo sprintf(_AD_DON_RECORDS_INSERTED, $row_Recordset1[numrecs], $curr_sign, $row_Recordset1['ipn_total']);
        } else {
            echo sprintf(_AD_DON_ERR_DB_INSERTION, $row_Recordset1[numrecs]);
        }
    }

    echo "<br /><br /><form action=\"donations.php?op=Treasury#AdminTop\" method=\"post\">";
    echo "<input type=\"hidden\" name=\"op\" value=\"Treasury\" />"
    ."<input type=\"submit\" value=\"" . _AD_DON_RETURN . "\" />"
    ."</form>";
}

/**
 *
 * Display the IPN Log
 *
 */
function ShowLog() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    global $tr_config, $modversion, $xoopsDB, $curr_sign;
function myFunction($a, $b) {
    // Do something
}
    include_once XOOPS_ROOT_PATH . DIRECTORY_SEPARATOR . 'class'   . DIRECTORY_SEPARATOR . 'xoopsformloader.php';
    $indexAdmin = new ModuleAdmin();
    echo $indexAdmin->addNavigation('donations.php?op=ShowLog');

    $query_Recordset1 = "SELECT id, log_date, payment_date, logentry FROM " . $xoopsDB->prefix('donations_translog') . " ORDER BY log_date DESC";
    $transRecords = $xoopsDB->query($query_Recordset1);
    $numRows = $xoopsDB->getRowsNum($transRecords);
    $logForm = new XoopsThemeForm(_AD_DON_SHOW_LOG, 'logform', $_SERVER['PHP_SELF'], 'POST');

    if ($numRows) {
        while( list($rId, $rLdate, $rPdate, $rLentry) = $xoopsDB->fetchRow($transRecords) ) {
            $thisTray = 'logTray_' . $rId;
            $$thisTray = new XoopsFormElementTray($rId, '<br />');
            $$thisTray->addElement(new XoopsFormLabel( _AD_DON_LOG_DATE, $rLdate));
            $$thisTray->addElement(new XoopsFormLabel( _AD_DON_PMNT_DATE, $rPdate));
            $rLentrySplit = '';
            $rLentry = htmlspecialchars($rLentry);
            $dispWidth = 110;
            do {
                //                echo '[' . strlen($rLentry) . ']<br />';

                $pos = strrpos($rLentry, ' ', ($dispWidth - strlen($rLentry)));
                if ( !$pos) {
                    $pos = strrpos($rLentry, ',', ($dispWidth - strlen($rLentry)));
                    if ( !$pos) {
                        $rLentrySplit .= '<br />' . substr($rLentry, 0, $dispWidth);
                        $rLentry = substr($rLentry, $dispWidth);
                    } else {

                        $rLentrySplit .= '<br />' . substr($rLentry, 0, $pos+1);
                        $rLentry = substr($rLentry, $pos);
                    }
                } else {

                    $rLentrySplit .= '<br />' . substr($rLentry, 0, $pos+1);
                    $rLentry = substr($rLentry, $pos);
                }
            } while  ( strlen($rLentry) > $dispWidth );
            $$thisTray->addElement(new XoopsFormLabel( _AD_DON_LOG_ENTRY_TXT, $rLentrySplit . $rLentry));

            //            $$thisTray->addElement(new XoopsFormLabel( _AD_DON_LOGENTRY, $rLentry));

            $logForm->addElement($$thisTray);
        }
        $buttonTray = new XoopsFormElementTray('');
        $cButton = new XoopsFormButton('', 'op', _AD_DON_CLEAR_LOG, 'submit');
        $cButton->setExtra("onclick=\"this.form.elements.op.value='ClearLog'\"", TRUE);
        $buttonTray->addElement($cButton);
        $logForm->addElement($buttonTray);
    } else {
        //FIXME: replace this with 'full width' cell
        $logForm->addElement(new XoopsFormLabel( '', _AD_DON_LOG_EMPTY));
    }
    $logForm->display();
}

/**
 *
 * Clear the IPN log
 * @param int $ok =0 ask to verify, !=0 clear the log
 */
function ClearLog($ok = 0)
{
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    if ($ok > 0) {
        $sql = "DELETE FROM " . $xoopsDB->prefix('donations_translog') ;
        $success = $xoopsDB->query($sql);
        $retMsg = $success ? _AD_DON_LOG_CLEARED : _AD_DON_LOG_NOT_CLEARED ;
        echo "<form name=\"ipnlog\" action=\"donations.php\" method=\"get\">";
        echo "<table style=\"text-align: center; border-width: 0px; margin: 4px;\"><tr><td>{$retMsg}</td></tr>";
        echo "<tr><td><input type=\"submit\" value=\"" . _AD_DON_CONTINUE . "\" /></td></tr></table>";
        echo "</form>";
        //        redirect_header('./index.php', 2, $retMsg);

        //        exit();
    } else {
        xoops_confirm(array('op' => 'ClearLog', 'ok' => 1), 'index.php', _AD_DON_CLEAR_THIS_LOG, _DELETE );
    }
}
/**
 *
 * Process incoming operand
 *
 */

$op = (isset($_GET['op'])) ? $_GET['op'] : 'Treasury';
$op = (isset($_POST['op'])) ?  $_POST['op'] : $op;

Switch($op)
{
    case 'FinRegAdd':
        FinancialRegAdd();
        break;

    case 'FinRegEdit':
        FinancialRegEdit();
        break;

    case 'FinRegDel':
        FinancialRegDel();
        break;

    case 'Config':
        Config();
        break;

    case 'ConfigUpdate':
        ConfigUpdate();
        break;

    case 'IpnRec':
        IpnRec();
        break;
    case 'ShowLog':
        ShowLog();
        break;

    case 'ClearLog':
        $ok = isset($_GET['ok']) ? intval($_GET['ok']) : 0;
        $ok = isset($_POST['ok']) ? intval($_POST['ok']) : $ok;
        ClearLog($ok);
        break;

    default:
    case 'Treasury':
        Treasury();
        break;
}
include "admin_footer.php";
?>

Push — master ( 4a1a1e...7e0534 )

donations.php ➔ Config() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

XoopsModules25x / xdonations

Push — master ( 4a1a1e...7e0534 )

donations.php ➔ Config() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
