XoopsModules25x / wfdownloads

class/Download.php

<?php

namespace XoopsModules\Wfdownloads;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * Wfdownloads module
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         GNU GPL 2 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @package         wfdownload
 * @since           3.23
 * @author          Xoops Development Team
 */

require_once \dirname(__DIR__) . '/include/common.php';

/**
 * Class Download
 */
class Download extends \XoopsObject
{
    /**
     * @access public
     */
    public $helper;
    /**
     * @var Category
     * @access public
     */
    public $category;
    public $db;

    /**
     * @param int|null $id
     */
    public function __construct($id = null)
    {
        /** @var \XoopsModules\Wfdownloads\Helper $this ->helper */
        $this->helper = Helper::getInstance();

The property helper does not seem to exist on XoopsModules\Wfdownloads\Helper.

        $this->db     = \XoopsDatabaseFactory::getDatabaseConnection();

The property db does not seem to exist on XoopsModules\Wfdownloads\Helper.

        $this->initVar('lid', \XOBJ_DTYPE_INT);

The method initVar() does not exist on XoopsModules\Wfdownloads\Helper. Did you maybe mean init()?

        $this->initVar('cid', \XOBJ_DTYPE_INT, 0);
        $this->initVar('title', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('url', \XOBJ_DTYPE_URL, 'http://');
        $this->initVar('filename', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('filetype', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('homepage', \XOBJ_DTYPE_URL, 'http://');
        $this->initVar('version', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('size', \XOBJ_DTYPE_INT, 0);
        $this->initVar('platform', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('screenshot', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('screenshot2', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('screenshot3', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('screenshot4', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('submitter', \XOBJ_DTYPE_INT);
        $this->initVar('publisher', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('status', \XOBJ_DTYPE_INT, \_WFDOWNLOADS_STATUS_WAITING);
        $this->initVar('date', \XOBJ_DTYPE_INT);
        $this->initVar('hits', \XOBJ_DTYPE_INT, 0);
        $this->initVar('rating', \XOBJ_DTYPE_OTHER, 0.0);
        $this->initVar('votes', \XOBJ_DTYPE_INT, 0);
        $this->initVar('comments', \XOBJ_DTYPE_INT, 0);
        $this->initVar('license', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('mirror', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('price', \XOBJ_DTYPE_TXTBOX, 0);
        $this->initVar('paypalemail', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('features', \XOBJ_DTYPE_TXTAREA, '');
        $this->initVar('requirements', \XOBJ_DTYPE_TXTAREA, '');
        $this->initVar('homepagetitle', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('forumid', \XOBJ_DTYPE_INT, 0);
        $this->initVar('limitations', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('versiontypes', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('dhistory', \XOBJ_DTYPE_TXTAREA, '');
        $this->initVar('published', \XOBJ_DTYPE_INT, 0); // published time or 0
        $this->initVar('expired', \XOBJ_DTYPE_INT, 0);
        $this->initVar('updated', \XOBJ_DTYPE_INT, 0); // uploaded time or 0
        $this->initVar('offline', \XOBJ_DTYPE_INT, false); // boolean
        $this->initVar('summary', \XOBJ_DTYPE_TXTAREA, '');
        $this->initVar('description', \XOBJ_DTYPE_TXTAREA, '');
        $this->initVar('ipaddress', \XOBJ_DTYPE_TXTBOX, '');
        $this->initVar('notifypub', \XOBJ_DTYPE_INT, 0);
        // Formulize module support (2006/05/04) jpc
        $this->initVar('formulize_idreq', \XOBJ_DTYPE_INT, 0);
        // added 3.23
        $this->initVar('screenshots', \XOBJ_DTYPE_ARRAY, []); // IN PROGRESS
        $this->initVar('dohtml', \XOBJ_DTYPE_INT, false); // boolean
        $this->initVar('dosmiley', \XOBJ_DTYPE_INT, true); // boolean
        $this->initVar('doxcode', \XOBJ_DTYPE_INT, true); // boolean
        $this->initVar('doimage', \XOBJ_DTYPE_INT, true); // boolean
        $this->initVar('dobr', \XOBJ_DTYPE_INT, true); // boolean

        if (null !== $id) {
            $item = $this->helper->getHandler('Item')->get($id);
            foreach ($item->vars as $k => $v) {
                $this->assignVar($k, $v['value']);

The method assignVar() does not exist on XoopsModules\Wfdownloads\Helper.

            }
        }
    }

    /**
     * @param string $method
     * @param array  $args
     *
     * @return mixed
     */
    public function __call($method, $args)
    {
        $arg = $args[0] ?? null;

        return $this->getVar($method, $arg);
    }

    /**
     * @return null|\XoopsModules\Wfdownloads\Category
     */
    public function category()
    {
        if (!isset($this->_category)) {
            $this->_category = $this->helper->getHandler('Category')->get($this->getVar('cid'));

The property _category does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        return $this->_category;
    }

    /**
     * @return mixed
     */
    public function getDownloadInfo()
    {
        \xoops_load('XoopsUserUtility');

        $download['id']  = $this->getVar('lid');

$download was never initialized. Although not strictly required by PHP, it is generally a good practice to add $download = array(); before regardless.

        $download['cid'] = $this->getVar('cid');

        $use_mirrors = $this->helper->getConfig('enable_mirrors');
        $add_mirror  = false;
        if (!\is_object($GLOBALS['xoopsUser'])
            && (\_WFDOWNLOADS_ANONPOST_MIRROR == $this->helper->getConfig('anonpost')
                || \_WFDOWNLOADS_ANONPOST_BOTH == $this->helper->getConfig('anonpost'))
            && (\_WFDOWNLOADS_SUBMISSIONS_MIRROR == $this->helper->getConfig('submissions')
                || \_WFDOWNLOADS_SUBMISSIONS_BOTH == $this->helper->getConfig('submissions'))
            && true === $use_mirrors) {
            $add_mirror = true;
        } elseif (\is_object($GLOBALS['xoopsUser'])
                  && (\_WFDOWNLOADS_SUBMISSIONS_MIRROR == $this->helper->getConfig('submissions')
                      || \_WFDOWNLOADS_SUBMISSIONS_BOTH == $this->helper->getConfig('submissions')
                      || Utility::userIsAdmin())
                  && true === $use_mirrors) {
            $add_mirror = true;
        }
        $download['add_mirror']  = $add_mirror;
        $download['use_mirrors'] = $use_mirrors;

        $download['use_reviews']       = $this->helper->getConfig('enable_reviews');
        $download['use_ratings']       = $this->helper->getConfig('enable_ratings');
        $download['use_brokenreports'] = $this->helper->getConfig('enable_brokenreports');
        $download['rateimg']           = 'rate' . \round(\number_format($this->getVar('rating'), 0) / 2) . '.gif'; // this definition is not removed for backward compatibility issues
        $download['average_rating']    = $this->getVar('rating'); // new
        $download['votes']             = (1 == $this->getVar('votes')) ? \_MD_WFDOWNLOADS_ONEVOTE : \sprintf(\_MD_WFDOWNLOADS_NUMVOTES, $this->getVar('votes'));

It seems like $this->getVar('votes') can also be of type array and array; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

        $download['hits']              = $this->getVar('hits');

        $download['path'] = $this->helper->getHandler('Category')->getNicePath($download['cid']);

        $download['imageheader'] = Utility::headerImage();

        $download['title']    = \trim($this->getVar('title'));

It seems like $this->getVar('title') can also be of type array and array; however, parameter $str of trim() does only seem to accept string, maybe add an additional type check?

        $download['url']      = $this->getVar('url');
        $download['filename'] = $this->getVar('filename');
        $download['filetype'] = $this->getVar('filetype');
        /*
                if ($this->getVar('screenshot')) { // IN PROGRESS
                    $download['screenshot_full'] = $this->getVar('screenshot'); // IN PROGRESS
                    $download['screenshot_full1'] = $this->getVar('screenshot'); // IN PROGRESS
                    if ($this->getVar('screenshot') // IN PROGRESS
                        && file_exists(XOOPS_ROOT_PATH . '/' . $this->helper->getConfig('screenshots') . '/' . xoops_trim($this->getVar('screenshot')))
                    ) {
                        if ($this->helper->getConfig('usethumbs') === true) {
                            $download['screenshot_thumb'] = Utility::createThumb(
                                $download['screenshot_full'], $this->helper->getConfig('screenshots'), 'thumbs',
                                $this->helper->getConfig('shotwidth'), $this->helper->getConfig('shotheight'),
                                $this->helper->getConfig('imagequality'), $this->helper->getConfig('updatethumbs'), $this->helper->getConfig('keepaspect')
                            );
                        } else {
                            $download['screenshot_thumb'] = XOOPS_URL . '/' . $this->helper->getConfig('screenshots') . '/' . xoops_trim($this->getVar('screenshot'));
                        }
                        $download['screenshot_thumb1'] = $download['screenshot_thumb']; // IN PROGRESS
                    }
                }
                if ($this->getVar('screenshot2') && $this->helper->getConfig('max_screenshot') >= 2) { // IN PROGRESS
                    $download['screenshot_full2'] = $this->getVar('screenshot2');
                    if ($this->getVar('screenshot2')
                        && file_exists(XOOPS_ROOT_PATH . '/' . $this->helper->getConfig('screenshots') . '/' . xoops_trim($this->getVar('screenshot2')))
                    ) {
                        if ($this->helper->getConfig('usethumbs') === true) {
                            $download['screenshot_thumb2'] = Utility::createThumb(
                                $download['screenshot_full2'], $this->helper->getConfig('screenshots'), 'thumbs',
                                $this->helper->getConfig('shotwidth'), $this->helper->getConfig('shotheight'),
                                $this->helper->getConfig('imagequality'), $this->helper->getConfig('updatethumbs'), $this->helper->getConfig('keepaspect')
                            );
                        } else {
                            $download['screenshot_thumb2'] = XOOPS_URL . '/' . $this->helper->getConfig('screenshots') . '/' . xoops_trim($this->getVar('screenshot2'));
                        }
                    }
                }
                if ($this->getVar('screenshot3') && $this->helper->getConfig('max_screenshot') >= 3) { // IN PROGRESS
                    $download['screenshot_full3'] = $this->getVar('screenshot3');
                    if ($this->getVar('screenshot3')
                        && file_exists(XOOPS_ROOT_PATH . '/' . $this->helper->getConfig('screenshots') . '/' . xoops_trim($this->getVar('screenshot3')))
                    ) {
                        if ($this->helper->getConfig('usethumbs') === true) {
                            $download['screenshot_thumb3'] = Utility::createThumb(
                                $download['screenshot_full3'], $this->helper->getConfig('screenshots'), 'thumbs',
                                $this->helper->getConfig('shotwidth'), $this->helper->getConfig('shotheight'),
                                $this->helper->getConfig('imagequality'), $this->helper->getConfig('updatethumbs'), $this->helper->getConfig('keepaspect')
                            );
                        } else {
                            $download['screenshot_thumb3'] = XOOPS_URL . '/' . $this->helper->getConfig('screenshots') . '/' . xoops_trim($this->getVar('screenshot3'));
                        }
                    }
                }
                if ($this->getVar('screenshot4') && $this->helper->getConfig('max_screenshot') >= 4) { // IN PROGRESS
                    $download['screenshot_full4'] = $this->getVar('screenshot4');
                    if ($this->getVar('screenshot4')
                        && file_exists(XOOPS_ROOT_PATH . '/' . $this->helper->getConfig('screenshots') . '/' . xoops_trim($this->getVar('screenshot4')))
                    ) {
                        if ($this->helper->getConfig('usethumbs') === true) {
                            $download['screenshot_thumb4'] = Utility::createThumb(
                                $download['screenshot_full4'], $this->helper->getConfig('screenshots'), 'thumbs',
                                $this->helper->getConfig('shotwidth'), $this->helper->getConfig('shotheight'),
                                $this->helper->getConfig('imagequality'), $this->helper->getConfig('updatethumbs'), $this->helper->getConfig('keepaspect')
                            );
                        } else {
                            $download['screenshot_thumb4'] = XOOPS_URL . '/' . $this->helper->getConfig('screenshots') . '/' . xoops_trim($this->getVar('screenshot4'));
                        }
                    }
                }
        */
        // IN PROGRESS
        $screenshots             = $this->getVar('screenshots');
        $download['screenshots'] = [];
        foreach ($screenshots as $key => $screenshot) {
            if (\file_exists(XOOPS_ROOT_PATH . '/' . $this->helper->getConfig('screenshots') . '/' . \xoops_trim($screenshot))) {
                if ('' != $screenshot && 1 === $this->helper->getConfig('usethumbs')) {
                    $screenshot_thumb = Utility::createThumb(
                        $screenshot,
                        $this->helper->getConfig('screenshots'),
                        'thumbs',
                        $this->helper->getConfig('shotwidth'),
                        $this->helper->getConfig('shotheight'),
                        $this->helper->getConfig('imagequality'),
                        $this->helper->getConfig('updatethumbs'),
                        $this->helper->getConfig('keepaspect')
                    );
                } else {
                    $screenshot_thumb = XOOPS_URL . '/' . $this->helper->getConfig('screenshots') . '/' . \xoops_trim($screenshot);
                }
                $download['screenshots'][$key]['filename']  = $screenshot;
                $download['screenshots'][$key]['thumb_url'] = $screenshot_thumb;
                unset($screenshot_thumb);
            }
        }

        $download['homepage'] = (!$this->getVar('homepage') || 'http://' === $this->getVar('homepage')) ? '' : $GLOBALS['myts']->htmlSpecialChars(\trim($this->getVar('homepage')));

        $homepagetitle = $this->getVar('homepagetitle');
        if ($download['homepage'] && !empty($download['homepage'])) {
            $download['homepagetitle'] = ('' !== $homepagetitle) ? \trim($download['homepage']) : \trim($homepagetitle);
            $download['homepage']      = "<a href='" . $download['homepage'] . "' target='_blank'>" . $homepagetitle . '</a>';
        } else {
            $download['homepage'] = '';
        }

        if (true !== $use_mirrors) {
            $download['mirror'] = ('http://' === $this->getVar('mirror')) ? '' : \trim($this->getVar('mirror'));
            if ($download['mirror'] && !empty($download['mirror'])) {
                $download['mirror'] = "<a href='" . $download['mirror'] . "' target='_blank'>" . \_MD_WFDOWNLOADS_MIRRORSITE . '</a>';
            } else {
                $download['mirror'] = '';
            }
        }

        $download['comments'] = $this->getVar('comments');

        $download['version'] = $this->getVar('version') ?: 0;

        $download['downtime'] = \str_replace('|', '<br>', Utility::getDownloadTime($this->getVar('size'), 1, 1, 1, 1, 0));

        $download['size'] = Utility::bytesToSize1024($this->getVar('size'));

        $time                     = (0 != $this->getVar('updated')) ? $this->getVar('updated') : $this->getVar('published');
        $download['updated']      = \formatTimestamp($time, $this->helper->getConfig('dateformat'));
        $download['lang_subdate'] = (0 != $this->getVar('updated')) ? \_MD_WFDOWNLOADS_UPDATEDON : \_MD_WFDOWNLOADS_SUBMITDATE;

        $summary = $this->getVar('summary');
        if ((\_WFDOWNLOADS_AUTOSUMMARY_YES == $this->helper->getConfig('autosummary')) || (\_WFDOWNLOADS_AUTOSUMMARY_IFBLANK == $this->helper->getConfig('autosummary') && empty($summary))) {
            // generate auto summary from description field
            $download['summary'] = $this->getVar('description');
            // patch for multilanguage summary if xlanguage module is installed
            if (Utility::checkModule('xlanguage')) {
                global $xlanguage;
                require_once XOOPS_ROOT_PATH . '/modules/xlanguage/include/vars.php';
                require_once XOOPS_ROOT_PATH . '/modules/xlanguage/include/functions.php';
                $download['summary'] = xlanguage_ml($download['summary']);

The function xlanguage_ml was not found. Maybe you did not declare it correctly or list all dependencies?

            }
            // html or plain text auto summary
            if ($this->helper->getConfig('autosumplaintext')) {
                $download['summary'] = \strip_tags($download['summary'], '<br><br>');
            }
            // truncate auto summary
            $autosumLength = (int)$this->helper->getConfig('autosumlength');
            if (mb_strlen($download['summary']) > $autosumLength) {
                $download['summary'] = Utility::truncateHtml($download['summary'], $autosumLength, '...', false, true);
            }
        } else {
            $download['summary'] = $summary;
        }

        $download['description'] = $this->getVar('description'); //no html
        //
        $download['price'] = (0 != $this->getVar('price')) ? $this->getVar('price') : \_MD_WFDOWNLOADS_PRICEFREE;

        $limitationsArray        = $this->helper->getConfig('limitations');
        $download['limitations'] = ('' === $this->getVar('limitations')) ? \_MD_WFDOWNLOADS_NOTSPECIFIED : $GLOBALS['myts']->htmlSpecialChars(\trim($limitationsArray[$this->getVar('limitations')]));
        //
        //        $versiontypesArray        = $this->helper->getConfig('versiontypes');
        //        $download['versiontypes'] = ('' === $this->getVar('versiontypes')) ? _MD_WFDOWNLOADS_NOTSPECIFIED : $GLOBALS['myts']->htmlSpecialChars(trim($versiontypesArray[$this->getVar('versiontypes')]));
        $temp                     = $this->getVar('versiontypes') ?? '';
        $download['versiontypes'] = (!$temp) ? \_MD_WFDOWNLOADS_NOTSPECIFIED : $temp;

        $licenseArray        = $this->helper->getConfig('license');
        $download['license'] = ('' === $this->getVar('license')) ? \_MD_WFDOWNLOADS_NOTSPECIFIED : $GLOBALS['myts']->htmlSpecialChars(\trim($licenseArray[$this->getVar('license')]));

        $download['submitter'] = \XoopsUserUtility::getUnameFromId($this->getVar('submitter'));

        $publisher             = $this->getVar('publisher');
        $download['publisher'] = !empty($publisher) ? $publisher : '';

        $platformArray        = $this->helper->getConfig('platform');
        $download['platform'] = $GLOBALS['myts']->htmlSpecialChars($platformArray[$this->getVar('platform')]);

        $history             = $this->getVar('dhistory', 'n');
        $download['history'] = $GLOBALS['myts']->displayTarea($history, true);

        $download['features'] = [];
        if ($this->getVar('features')) {
            $features = \explode('|', \trim($this->getVar('features')));
            foreach ($features as $feature) {
                $download['features'][] = $feature;
            }
        }

        $download['requirements'] = [];
        if ($this->getVar('requirements')) {
            $requirements = \explode('|', \trim($this->getVar('requirements')));
            foreach ($requirements as $requirement) {
                $download['requirements'][] = $requirement;
            }
        }

        $download['mail_subject'] = \rawurlencode(\sprintf(\_MD_WFDOWNLOADS_INTFILEFOUND, $GLOBALS['xoopsConfig']['sitename']));

        $download['mail_body'] = \rawurlencode(\sprintf(\_MD_WFDOWNLOADS_INTFILEFOUND, $GLOBALS['xoopsConfig']['sitename']) . ':  ' . WFDOWNLOADS_URL . '/singlefile.php?cid=' . $download['cid'] . '&amp;lid=' . $download['id']);

The constant XoopsModules\Wfdownloads\WFDOWNLOADS_URL was not found. Maybe you did not declare it correctly or list all dependencies?

        $download['isadmin'] = Utility::userIsAdmin() ? true : false;

        $download['adminlink'] = '';
        if (true === $download['isadmin']) {
            $download['adminlink'] = '[<a href="' . WFDOWNLOADS_URL . '/admin/downloads.php?op=download.edit&amp;lid=' . $download['id'] . '">' . \_MD_WFDOWNLOADS_EDIT . '</a> | ';
            $download['adminlink'] .= '<a href="' . WFDOWNLOADS_URL . '/admin/downloads.php?op=download.delete&amp;lid=' . $download['id'] . '">' . \_MD_WFDOWNLOADS_DELETE . '</a>]';
        }

        $download['is_updated'] = ($this->getVar('updated') > 0) ? \_MD_WFDOWNLOADS_UPDATEDON : \_MD_WFDOWNLOADS_SUBMITDATE;

        if (\is_object($GLOBALS['xoopsUser']) && true !== $download['isadmin']) {
            $download['useradminlink'] = (int)$GLOBALS['xoopsUser']->getvar('uid') == $this->getVar('submitter'); // this definition is not removed for backward compatibility issues
            $download['issubmitter']   = (int)$GLOBALS['xoopsUser']->getvar('uid') == $this->getVar('submitter');
        }

        $sql2                    = 'SELECT rated';
        $sql2                    .= ' FROM ' . $GLOBALS['xoopsDB']->prefix('wfdownloads_reviews');
        $sql2                    .= " WHERE lid = '" . (int)$download['id'] . "' AND submit = '1'";
        $results                 = $GLOBALS['xoopsDB']->query($sql2);
        $numrows                 = $GLOBALS['xoopsDB']->getRowsNum($results);
        $download['reviews_num'] = $numrows ?: 0;

        $totalReviewsRating = 0;
        while (false !== ($review_text = $GLOBALS['xoopsDB']->fetchArray($results))) {
            $totalReviewsRating += $review_text['rated'];
        }
        $averageReviewsRating              = ($download['reviews_num'] > 0) ? $totalReviewsRating / $download['reviews_num'] : 0;
        $download['review_average_rating'] = $averageReviewsRating; // new
        //
        $download['review_rateimg'] = 'rate' . \round(\number_format($averageReviewsRating, 0) / 2) . '.gif'; // this definition is not removed for backward compatibility issues
        //
        $download['icons'] = Utility::displayIcons($this->getVar('published'), $this->getVar('status'), $this->getVar('hits'));

        $sql3                    = 'SELECT downurl';
        $sql3                    .= ' FROM ' . $GLOBALS['xoopsDB']->prefix('wfdownloads_mirrors');
        $sql3                    .= " WHERE lid = '" . (int)$download['id'] . "' AND submit = '1'";
        $results3                = $GLOBALS['xoopsDB']->query($sql3);
        $numrows2                = $GLOBALS['xoopsDB']->getRowsNum($results3);
        $download['mirrors_num'] = $numrows2 ?: 0;
        // file url
        $fullFilename = \trim($download['filename']);
        if (('' === !$download['url'] && 'http://' === !$download['url']) || '' == $fullFilename) {

The condition '' === ! $download['url'] is always false.

            $download['file_url'] = $GLOBALS['myts']->htmlSpecialChars(\preg_replace('/javascript:/si', 'javascript:', $download['url']), \ENT_QUOTES);
        } else {
            $download['file_url'] = XOOPS_URL . \str_replace(XOOPS_ROOT_PATH, '', $this->helper->getConfig('uploaddir')) . '/' . \stripslashes(\trim($fullFilename));
        }
        // has_custom_fields
        $download['has_custom_fields'] = (Utility::checkModule('formulize') && $this->getVar('formulize_idreq'));

        return $download;
    }

    /**
     * @param array $customArray
     *
     * @return \XoopsThemeForm
     */
    public function getForm($customArray = []) // $custom array added April 22, 2006 by jwe)
    {
        require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
        require_once XOOPS_ROOT_PATH . '/class/tree.php';

        $groups = \is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : [0 => XOOPS_GROUP_ANONYMOUS];

        $use_mirrors = $this->helper->getConfig('enable_mirrors');

        $sform = new \XoopsThemeForm(\_MD_WFDOWNLOADS_SUBMITCATHEAD, 'storyform', $_SERVER['REQUEST_URI']);
        $sform->setExtra('enctype="multipart/form-data"');
        // download: title
        $sform->addElement(new \XoopsFormText(\_MD_WFDOWNLOADS_FILETITLE, 'title', 50, 255, $this->getVar('title', 'e')), true);

It seems like $this->getVar('title', 'e') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

        // download: url
        $sform->addElement(new \XoopsFormText(\_MD_WFDOWNLOADS_DLURL, 'url', 50, 255, $this->getVar('url', 'e')), false);
        if (!$this->isNew()) {
            // download: filename
            $sform->addElement(new \XoopsFormHidden('filename', $this->getVar('filename', 'e')));

It seems like $this->getVar('filename', 'e') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

            // download: filetype
            $sform->addElement(new \XoopsFormHidden('filetype', $this->getVar('filetype', 'e')));
        }
        // download: userfile
        if (($this->helper->getConfig('useruploads')
             && \array_intersect($this->helper->getConfig('useruploadsgroup'), $groups))

It seems like $this->helper->getConfig('useruploadsgroup') can also be of type null; however, parameter $array1 of array_intersect() does only seem to accept array, maybe add an additional type check?

            || Utility::userIsAdmin()) {
            $userfile_file = new \XoopsFormFile(\_MD_WFDOWNLOADS_UPLOAD_FILEC, 'userfile', 0);
            // get max file size (setup and php.ini)
            $phpiniMaxFileSize = \min((int)\ini_get('upload_max_filesize'), (int)\ini_get('post_max_size'), (int)\ini_get('memory_limit')) * 1024 * 1024; // bytes
            $maxFileSize       = Utility::bytesToSize1024(\min($this->helper->getConfig('maxfilesize'), $phpiniMaxFileSize));
            // get allowed mimetypes
            if (Utility::userIsAdmin()) {
                $criteria = new \Criteria('mime_admin', true);

true of type true is incompatible with the type string expected by parameter $value of Criteria::__construct().

            } else {
                $criteria = new \Criteria('mime_user', true);
            }
            $mimetypes         = $this->helper->getHandler('Mimetype')->getList($criteria);
            $allowedExtensions = \implode(' | ', $mimetypes);
            $userfile_file->setDescription(\sprintf(\_MD_WFDOWNLOADS_UPLOAD_FILEC_DESC, $maxFileSize, $this->helper->getConfig('maximgwidth'), $this->helper->getConfig('maximgheight'), $allowedExtensions, mb_substr($allowedExtensions, 0, 40) . '...'));
            $sform->addElement($userfile_file, false);
        }
        // download: mirror
        if (true !== $use_mirrors) {
            $sform->addElement(new \XoopsFormText(\_MD_WFDOWNLOADS_MIRROR, 'mirror', 50, 255, $this->getVar('mirror', 'e')), false);
        }
        // download: cid
        // Formulize module support (2006/05/04) jpc - start
        if (Utility::checkModule('formulize')) {
            $sform->addElement(new \XoopsFormHidden('cid', $this->getVar('cid', 'e')));
        } else {
            $categoryObjs     = $this->helper->getHandler('Category')->getUserUpCategories();
            $categoryObjsTree = new ObjectTree($categoryObjs, 'cid', 'pid');

            if (Utility::checkVerXoops($GLOBALS['xoopsModule'], '2.5.9')) {
                $catSelect = $categoryObjsTree->makeSelectElement('cid', 'title', '--', $this->getVar('cid'), true, 0, '', \_MD_WFDOWNLOADS_CATEGORYC);

It seems like $this->getVar('cid') can also be of type array and array; however, parameter $selected of XoopsObjectTree::makeSelectElement() does only seem to accept string, maybe add an additional type check?

                $sform->addElement($catSelect);
            } else {
                $sform->addElement(new \XoopsFormLabel(\_MD_WFDOWNLOADS_CATEGORYC, $categoryObjsTree->makeSelBox('cid', 'title', '-', $this->getVar('cid', 'e'))));

It seems like $this->getVar('cid', 'e') can also be of type array and array; however, parameter $selected of XoopsModules\Wfdownloads\ObjectTree::makeSelBox() does only seem to accept string, maybe add an additional type check?

            }
        }

        if (0 == \count($customArray)) {
            // download: homepagetitle
            $sform->addElement(new \XoopsFormText(\_MD_WFDOWNLOADS_HOMEPAGETITLEC, 'homepagetitle', 50, 255, $this->getVar('homepagetitle', 'e')), false);
            // download: homepage
            $sform->addElement(new \XoopsFormText(\_MD_WFDOWNLOADS_HOMEPAGEC, 'homepage', 50, 255, $this->getVar('homepage', 'e')), false);
            // download: version
            $sform->addElement(new \XoopsFormText(\_MD_WFDOWNLOADS_VERSIONC, 'version', 10, 20, $this->getVar('version', 'e')), false);
            // download: publisher
            $sform->addElement(new \XoopsFormText(\_MD_WFDOWNLOADS_PUBLISHERC, 'publisher', 50, 255, $this->getVar('publisher', 'e')), false);
            // download: size
            $sform->addElement(new \XoopsFormText(\_MD_WFDOWNLOADS_FILESIZEC, 'size', 10, 20, $this->getVar('size', 'e')), false);
            // download: platform
            $platform_array  = $this->helper->getConfig('platform');
            $platform_select = new \XoopsFormSelect(\_MD_WFDOWNLOADS_PLATFORMC, 'platform', $this->getVar('platform', 'e'));
            $platform_select->addOptionArray($platform_array);
            $sform->addElement($platform_select);
            // download: license
            $license_array  = $this->helper->getConfig('license');
            $license_select = new \XoopsFormSelect(\_MD_WFDOWNLOADS_LICENCEC, 'license', $this->getVar('license', 'e'));
            $license_select->addOptionArray($license_array);
            $sform->addElement($license_select);
            // download: limitations
            $limitations_array  = $this->helper->getConfig('limitations');
            $limitations_select = new \XoopsFormSelect(\_MD_WFDOWNLOADS_LIMITATIONS, 'limitations', $this->getVar('limitations', 'e'));
            $limitations_select->addOptionArray($limitations_array);
            $sform->addElement($limitations_select);
            // download: versiontype
            $versiontypes_array  = $this->helper->getConfig('versiontypes');
            $versiontypes_select = new \XoopsFormSelect(\_MD_WFDOWNLOADS_VERSIONTYPES, 'versiontypes', $this->getVar('versiontypes', 'e'));
            $versiontypes_select->addOptionArray($versiontypes_array);
            $sform->addElement($versiontypes_select);
            // download: price
            $sform->addElement(new \XoopsFormText(\_MD_WFDOWNLOADS_PRICEC, 'price', 10, 20, $this->getVar('price', 'e')), false);
            // download: summary
            switch ($this->helper->getConfig('autosummary')) {
                case \_WFDOWNLOADS_AUTOSUMMARY_YES:
                    $summary_dhtmltextarea = new \XoopsFormDhtmlTextArea(\_MD_WFDOWNLOADS_SUMMARY, 'summary', $this->getVar('summary', 'e'), 10, 60, 'smartHiddenSummary');

It seems like $this->getVar('summary', 'e') can also be of type array and array; however, parameter $value of XoopsFormDhtmlTextArea::__construct() does only seem to accept string, maybe add an additional type check?

                    $summary_dhtmltextarea->setDescription(\_MD_WFDOWNLOADS_SUMMARY_DESC_AUTOSUMMARY_YES);
                    $summary_dhtmltextarea->setExtra('disabled', 'disabled');

'disabled' of type string is incompatible with the type boolean expected by parameter $replace of XoopsFormElement::setExtra().

                    $sform->addElement($summary_dhtmltextarea, false);
                    break;
                case \_WFDOWNLOADS_AUTOSUMMARY_IFBLANK:
                    $summary_dhtmltextarea = new \XoopsFormDhtmlTextArea(\_MD_WFDOWNLOADS_SUMMARY, 'summary', $this->getVar('summary', 'e'), 10, 60, 'smartHiddenSummary');
                    $summary_dhtmltextarea->setDescription(\_MD_WFDOWNLOADS_SUMMARY_DESC_AUTOSUMMARY_IFBLANK);
                    $sform->addElement($summary_dhtmltextarea, false);
                    break;
                default:
                case \_WFDOWNLOADS_AUTOSUMMARY_NO:
                    $summary_dhtmltextarea = new \XoopsFormDhtmlTextArea(\_MD_WFDOWNLOADS_SUMMARY, 'summary', $this->getVar('summary', 'e'), 10, 60, 'smartHiddenSummary');
                    $summary_dhtmltextarea->setDescription(\_MD_WFDOWNLOADS_SUMMARY_DESC_AUTOSUMMARY_NO);
                    $sform->addElement($summary_dhtmltextarea, false);
                    break;
            }
            // download: description
            $description_dhtmltextarea = new \XoopsFormDhtmlTextArea(\_MD_WFDOWNLOADS_DESCRIPTION, 'description', $this->getVar('description', 'e'), 15, 60, 'smartHiddenDescription');
            $description_dhtmltextarea->setDescription(\_MD_WFDOWNLOADS_DESCRIPTION_DESC);
            $sform->addElement($description_dhtmltextarea, true);
            // download: dohtml, dosmiley, doxcode, doimage, dobr
            $options_tray = new \XoopsFormElementTray(\_MD_WFDOWNLOADS_TEXTOPTIONS, '<br>');
            $options_tray->setDescription(\_MD_WFDOWNLOADS_TEXTOPTIONS_DESC);
            $html_checkbox = new \XoopsFormCheckBox('', 'dohtml', $this->getVar('dohtml'));
            $html_checkbox->addOption(1, \_MD_WFDOWNLOADS_ALLOWHTML);
            $options_tray->addElement($html_checkbox);
            $smiley_checkbox = new \XoopsFormCheckBox('', 'dosmiley', $this->getVar('dosmiley'));
            $smiley_checkbox->addOption(1, \_MD_WFDOWNLOADS_ALLOWSMILEY);
            $options_tray->addElement($smiley_checkbox);
            $xcodes_checkbox = new \XoopsFormCheckBox('', 'doxcode', $this->getVar('doxcode'));
            $xcodes_checkbox->addOption(1, \_MD_WFDOWNLOADS_ALLOWXCODE);
            $options_tray->addElement($xcodes_checkbox);
            $noimages_checkbox = new \XoopsFormCheckBox('', 'doimage', $this->getVar('doimage'));
            $noimages_checkbox->addOption(1, \_MD_WFDOWNLOADS_ALLOWIMAGES);
            $options_tray->addElement($noimages_checkbox);
            $breaks_checkbox = new \XoopsFormCheckBox('', 'dobr', $this->getVar('dobr'));
            $breaks_checkbox->addOption(1, \_MD_WFDOWNLOADS_ALLOWBREAK);
            $options_tray->addElement($breaks_checkbox);
            $sform->addElement($options_tray);
            // download: features
            $features_textarea = new \XoopsFormTextArea(\_MD_WFDOWNLOADS_KEYFEATURESC, 'features', $this->getVar('features', 'e'), 7, 60);

It seems like $this->getVar('features', 'e') can also be of type array and array; however, parameter $value of XoopsFormTextArea::__construct() does only seem to accept string, maybe add an additional type check?

            $features_textarea->setDescription(\_MD_WFDOWNLOADS_KEYFEATURESC_DESC);
            $sform->addElement($features_textarea, false);
            // download: requirements
            $requirements_textarea = new \XoopsFormTextArea(\_MD_WFDOWNLOADS_REQUIREMENTSC, 'requirements', $this->getVar('requirements', 'e'), 7, 60);
            $requirements_textarea->setDescription(\_MD_WFDOWNLOADS_REQUIREMENTSC_DESC);
            $sform->addElement($requirements_textarea, false);
        } else {
            // if we are using a custom form, then add in the form's elements here
            $sform->addElement(new \XoopsFormDhtmlTextArea(\_MD_WFDOWNLOADS_DESCRIPTION, 'description', $this->getVar('description', 'e'), 15, 60, 'smartHiddenDescription'), true);
            $sform->addElement(new \XoopsFormHidden('size', $this->getVar('size', 'e')));
            if (Utility::checkModule('formulize')) {
                require_once XOOPS_ROOT_PATH . '/modules/formulize/include/formdisplay.php';
                require_once XOOPS_ROOT_PATH . '/modules/formulize/include/functions.php';
                $sform = compileElements(// is a Formulize function

The function compileElements was not found. Maybe you did not declare it correctly or list all dependencies?

                    $customArray['fid'],
                    $sform,
                    $customArray['formulize_mgr'],
                    $customArray['prevEntry'],
                    $customArray['entry'],
                    $customArray['go_back'],
                    $customArray['parentLinks'],
                    $customArray['owner_groups'],
                    $customArray['groups'],
                    null,
                    null,
                    null,
                    null,
                    null,
                    null,
                    null,
                    null,
                    null,
                    null
                );
            }
            // IN PROGRESS... formulize module not installed!!!
        }
        // Formulize module support (2006/05/04) jpc - end
        // download: dhistory
        $sform->addElement(new \XoopsFormTextArea(\_MD_WFDOWNLOADS_HISTORYC, 'dhistory', $this->getVar('dhistory', 'e'), 7, 60), false);
        if (!$this->isNew() && '' !== $this->getVar('dhistory', 'n')) {
            $dhistoryaddedd_textarea = new \XoopsFormTextArea(\_MD_WFDOWNLOADS_HISTORYD, 'dhistoryaddedd', '', 7, 60);
            $dhistoryaddedd_textarea->setDescription(\_MD_WFDOWNLOADS_HISTORYD_DESC);
            $sform->addElement($dhistoryaddedd_textarea, false);
        }
        // download: screenshot, screenshot2, screenshot3, screenshot4
        if (($this->helper->getConfig('useruploads')
             && \array_intersect($this->helper->getConfig('useruploadsgroup'), $groups))
            || Utility::userIsAdmin()) {
            $sform->addElement(new \XoopsFormFile(\_MD_WFDOWNLOADS_DUPLOADSCRSHOT, 'screenshot', 0), false); // IN PROGRESS
            if ($this->helper->getConfig('max_screenshot') >= 2) {
                $sform->addElement(new \XoopsFormFile(\_MD_WFDOWNLOADS_DUPLOADSCRSHOT, 'screenshot2', 0), false); // IN PROGRESS
            }
            if ($this->helper->getConfig('max_screenshot') >= 3) {
                $sform->addElement(new \XoopsFormFile(\_MD_WFDOWNLOADS_DUPLOADSCRSHOT, 'screenshot3', 0), false); // IN PROGRESS
            }
            if ($this->helper->getConfig('max_screenshot') >= 4) {
                $sform->addElement(new \XoopsFormFile(\_MD_WFDOWNLOADS_DUPLOADSCRSHOT, 'screenshot4', 0), false); // IN PROGRESS
            }
        }

        // download: notifypub
        $option_tray     = new \XoopsFormElementTray(\_MD_WFDOWNLOADS_OPTIONS, '<br>');
        $notify_checkbox = new \XoopsFormCheckBox('', 'notifypub');
        $notify_checkbox->addOption(1, \_MD_WFDOWNLOADS_NOTIFYAPPROVE);
        $option_tray->addElement($notify_checkbox);
        $sform->addElement($option_tray);
        // form: button tray
        $buttonTray = new \XoopsFormElementTray('', '');
        if ($this->isNew()) {
            $buttonTray->addElement(new \XoopsFormHidden('op', 'download.save'));
            $button_submit = new \XoopsFormButton('', '', _SUBMIT, 'submit');
            //$button_submit->setExtra('onclick="this.form.elements.op.value=\'download.save\'"');
            $buttonTray->addElement($button_submit);
        } else {
            $buttonTray->addElement(new \XoopsFormHidden('lid', (int)$this->getVar('lid')));
            $buttonTray->addElement(new \XoopsFormHidden('op', 'download.save'));
            $button_submit = new \XoopsFormButton('', '', _SUBMIT, 'submit');
            //$button_submit->setExtra('onclick="this.form.elements.op.value=\'download.save\'"');
            $buttonTray->addElement($button_submit);
        }
        $button_reset = new \XoopsFormButton('', '', _RESET, 'reset');
        $buttonTray->addElement($button_reset);
        $buttonCancel = new \XoopsFormButton('', '', _CANCEL, 'button');
        $buttonCancel->setExtra('onclick="history.go(-1)"');
        $buttonTray->addElement($buttonCancel);
        $sform->addElement($buttonTray);

        return $sform;
    }

    /**
     * @param       $title
     * @param array $customArray
     *
     * @return \XoopsThemeForm
     */
    public function getAdminForm($title, $customArray = []) // $custom array added April 22, 2006 by jwe
    {
        require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

        $use_mirrors = $this->helper->getConfig('enable_mirrors');

        $sform = new \XoopsThemeForm($title, 'storyform', $_SERVER['REQUEST_URI']);
        $sform->setExtra('enctype="multipart/form-data"');
        // download: lid
        if (!$this->isNew()) {
            $sform->addElement(new \XoopsFormLabel(\_AM_WFDOWNLOADS_FILE_ID, (int)$this->getVar('lid')));
        }
        // download: ipaddress
        if ('' != $this->getVar('ipaddress')) {
            $sform->addElement(new \XoopsFormLabel(\_AM_WFDOWNLOADS_FILE_IP, $this->getVar('ipaddress')));

It seems like $this->getVar('ipaddress') can also be of type array and array; however, parameter $value of XoopsFormLabel::__construct() does only seem to accept string, maybe add an additional type check?

        }
        // download: title
        $titles_tray = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_TITLE, '<br>');
        $titles      = new \XoopsFormText('', 'title', 50, 255, $this->getVar('title', 'e'));

It seems like $this->getVar('title', 'e') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

        $titles_tray->addElement($titles);
        $titles_checkbox = new \XoopsFormCheckBox('', 'title_checkbox', 0);
        $titles_checkbox->addOption(1, \_AM_WFDOWNLOADS_FILE_USE_UPLOAD_TITLE);
        $titles_tray->addElement($titles_checkbox);
        $sform->addElement($titles_tray);
        // download: submitter
        if (!$this->isNew()) {
            //$sform -> addElement(new \XoopsFormText(_AM_WFDOWNLOADS_FILE_SUBMITTERID, 'submitter', 10, 10, $this->getVar('submitter', 'e')), true);
            $submitter_select = new \XoopsFormSelectUser(\_AM_WFDOWNLOADS_FILE_SUBMITTER, 'submitter', false, $this->getVar('submitter', 'e'), 1, false);
            $submitter_select->setDescription(\_AM_WFDOWNLOADS_FILE_SUBMITTER_DESC);
            $sform->addElement($submitter_select);
        } else {
            $sform->addElement(new \XoopsFormHidden('submitter', $GLOBALS['xoopsUser']->getVar('uid', 'e')));
        }
        // download: url
        $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_DLURL, 'url', 50, 255, $this->getVar('url', 'e')), false);
        // download: filename
        $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_FILENAME, 'filename', 50, 255, $this->getVar('filename', 'e')), false);
        // download: filetype
        $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_FILETYPE, 'filetype', 50, 100, $this->getVar('filetype', 'e')), false);
        // download: mirror
        if (true !== $use_mirrors) {
            $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_MIRRORURL, 'mirror', 50, 255, $this->getVar('mirror', 'e')), false);
        }
        // download: userfile
        $userfile_file = new \XoopsFormFile(\_MD_WFDOWNLOADS_UPLOAD_FILEC, 'userfile', 0);
        // get max file size (setup and php.ini)
        $phpiniMaxFileSize = \min((int)\ini_get('upload_max_filesize'), (int)\ini_get('post_max_size'), (int)\ini_get('memory_limit')) * 1024 * 1024; // bytes
        $maxFileSize       = Utility::bytesToSize1024(\min($this->helper->getConfig('maxfilesize'), $phpiniMaxFileSize));
        // get allowed mimetypes
        $criteria          = new \Criteria('mime_admin', true);

true of type true is incompatible with the type string expected by parameter $value of Criteria::__construct().

        $mimetypes         = $this->helper->getHandler('Mimetype')->getList($criteria);
        $allowedExtensions = \implode(' | ', $mimetypes);
        $userfile_file->setDescription(\sprintf(\_MD_WFDOWNLOADS_UPLOAD_FILEC_DESC, $maxFileSize, $this->helper->getConfig('maximgwidth'), $this->helper->getConfig('maximgheight'), $allowedExtensions, mb_substr($allowedExtensions, 0, 40) . '...'));
        $sform->addElement($userfile_file, false);
        // download: cid
        $categoryObjs     = $this->helper->getHandler('Category')->getObjects();
        $categoryObjsTree = new ObjectTree($categoryObjs, 'cid', 'pid');

        if (Utility::checkVerXoops($GLOBALS['xoopsModule'], '2.5.9')) {
            $catSelect = $categoryObjsTree->makeSelectElement('cid', 'title', '--', $this->getVar('cid'), true, 0, '', \_AM_WFDOWNLOADS_FILE_CATEGORY);

It seems like $this->getVar('cid') can also be of type array and array; however, parameter $selected of XoopsObjectTree::makeSelectElement() does only seem to accept string, maybe add an additional type check?

            $sform->addElement($catSelect);
        } else {
            $sform->addElement(new \XoopsFormLabel(\_AM_WFDOWNLOADS_FILE_CATEGORY, $categoryObjsTree->makeSelBox('cid', 'title', '-', $this->getVar('cid', 'e'))));

It seems like $this->getVar('cid', 'e') can also be of type array and array; however, parameter $selected of XoopsModules\Wfdownloads\ObjectTree::makeSelBox() does only seem to accept string, maybe add an additional type check?

        }

        // Formulize module support (2006/03/06, 2006/03/08) jpc - start
        if (0 == \count($customArray)) {
            // download: homepagetitle
            $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_HOMEPAGETITLE, 'homepagetitle', 50, 255, $this->getVar('homepagetitle', 'e')), false);
            // download: homepage
            $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_HOMEPAGE, 'homepage', 50, 255, $this->getVar('homepage', 'e')), false);
            // download: version
            $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_VERSION, 'version', 10, 20, $this->getVar('version', 'e')), false);
            // download: publisher
            $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_PUBLISHER, 'publisher', 50, 255, $this->getVar('publisher', 'e')), false);
            // download: size
            $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_SIZE, 'size', 10, 20, $this->getVar('size', 'e')), false);
            // download: platform
            $platform_array  = $this->helper->getConfig('platform');
            $platform_select = new \XoopsFormSelect('', 'platform', $this->getVar('platform', 'e'), '', '', 0);

'' of type string is incompatible with the type boolean expected by parameter $multiple of XoopsFormSelect::__construct().

'' of type string is incompatible with the type integer expected by parameter $size of XoopsFormSelect::__construct().

The call to XoopsFormSelect::__construct() has too many arguments starting with 0.

            $platform_select->addOptionArray($platform_array);
            $platform_tray = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_PLATFORM, ' ');
            $platform_tray->addElement($platform_select);
            $sform->addElement($platform_tray);
            // download: license
            $license_array  = $this->helper->getConfig('license');
            $license_select = new \XoopsFormSelect('', 'license', $this->getVar('license', 'e'), '', '', 0);
            $license_select->addOptionArray($license_array);
            $license_tray = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_LICENCE, ' ');
            $license_tray->addElement($license_select);
            $sform->addElement($license_tray);
            // download: limitations
            $limitations_array  = $this->helper->getConfig('limitations');
            $limitations_select = new \XoopsFormSelect('', 'limitations', $this->getVar('limitations', 'e'), '', '', 0);
            $limitations_select->addOptionArray($limitations_array);
            $limitations_tray = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_LIMITATIONS, ' ');
            $limitations_tray->addElement($limitations_select);
            $sform->addElement($limitations_tray);
            // download: versiontypes
            $versiontypes_array  = $this->helper->getConfig('versiontypes');
            $versiontypes_select = new \XoopsFormSelect('', 'versiontypes', $this->getVar('versiontypes', 'e'), '', '', 0);
            $versiontypes_select->addOptionArray($versiontypes_array);
            $versiontypes_tray = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_VERSIONTYPES, ' ');
            $versiontypes_tray->addElement($versiontypes_select);
            $sform->addElement($versiontypes_tray);
            // download: versiontypes
            $sform->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_FILE_PRICE, 'price', 10, 20, $this->getVar('price', 'e')), false);
            // download: summary
            $mode              = 'html';
            $summary_tray      = new \XoopsFormElementTray(\_MD_WFDOWNLOADS_SUMMARY, '<br>');
            $options['name']   = 'summary';

$options was never initialized. Although not strictly required by PHP, it is generally a good practice to add $options = array(); before regardless.

            $options['value']  = $this->getVar('summary', 'e');
            $options['rows']   = 10;
            $options['cols']   = '100%';
            $options['width']  = '100%';
            $options['height'] = '200px';
            $options['mode']   = $mode; // for editors that support mode option
            $summary_editor    = new \XoopsFormEditor('', $this->helper->getConfig('editor_options'), $options, $nohtml = false, $onfailure = 'textarea');
            $summary_tray->addElement($summary_editor);
            switch ($this->helper->getConfig('autosummary')) {
                case \_WFDOWNLOADS_AUTOSUMMARY_YES:
                    $summary_tray->setDescription(\_MD_WFDOWNLOADS_SUMMARY_DESC_AUTOSUMMARY_YES);
                    break;
                case \_WFDOWNLOADS_AUTOSUMMARY_IFBLANK:
                    $summary_tray->setDescription(\_MD_WFDOWNLOADS_SUMMARY_DESC_AUTOSUMMARY_IFBLANK);
                    break;
                default:
                case \_WFDOWNLOADS_AUTOSUMMARY_NO:
                    $summary_tray->setDescription(\_MD_WFDOWNLOADS_SUMMARY_DESC_AUTOSUMMARY_NO);
                    break;
            }
            $sform->addElement($summary_tray);
            // download: decription
            $description_tray   = new \XoopsFormElementTray(\_MD_WFDOWNLOADS_DESCRIPTION, '<br>');
            $options['name']    = 'description';
            $options['value']   = $this->getVar('description', 'e');
            $options['rows']    = 15;
            $options['cols']    = '100%';
            $options['width']   = '100%';
            $options['height']  = '200px';
            $description_editor = new \XoopsFormEditor('', $this->helper->getConfig('editor_options'), $options, $nohtml = false, $onfailure = 'textarea');
            $description_tray->addElement($description_editor, true);
            $description_tray->setDescription(\_MD_WFDOWNLOADS_DESCRIPTION_DESC);
            $sform->addElement($description_tray);
            // download: dohtml, dosmiley, doxcode, doimage, dobr
            $options_tray = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_TEXTOPTIONS, ' ');
            $options_tray->setDescription(\_AM_WFDOWNLOADS_TEXTOPTIONS_DESC);
            $html_checkbox = new \XoopsFormCheckBox('', 'dohtml', $this->getVar('dohtml'));
            $html_checkbox->addOption(1, \_AM_WFDOWNLOADS_ALLOWHTML);
            $options_tray->addElement($html_checkbox);
            $smiley_checkbox = new \XoopsFormCheckBox('', 'dosmiley', $this->getVar('dosmiley'));
            $smiley_checkbox->addOption(1, \_AM_WFDOWNLOADS_ALLOWSMILEY);
            $options_tray->addElement($smiley_checkbox);
            $xcodes_checkbox = new \XoopsFormCheckBox('', 'doxcode', $this->getVar('doxcode'));
            $xcodes_checkbox->addOption(1, \_AM_WFDOWNLOADS_ALLOWXCODE);
            $options_tray->addElement($xcodes_checkbox);
            $noimages_checkbox = new \XoopsFormCheckBox('', 'doimage', $this->getVar('doimage'));
            $noimages_checkbox->addOption(1, \_AM_WFDOWNLOADS_ALLOWIMAGES);
            $options_tray->addElement($noimages_checkbox);
            $breaks_checkbox = new \XoopsFormCheckBox('', 'dobr', $this->getVar('dobr'));
            $breaks_checkbox->addOption(1, \_AM_WFDOWNLOADS_ALLOWBREAK);
            $options_tray->addElement($breaks_checkbox);
            $sform->addElement($options_tray);
            // download: features
            $sform->addElement(new \XoopsFormTextArea(\_AM_WFDOWNLOADS_FILE_KEYFEATURES, 'features', $this->getVar('features', 'e'), 7, 60), false);

It seems like $this->getVar('features', 'e') can also be of type array and array; however, parameter $value of XoopsFormTextArea::__construct() does only seem to accept string, maybe add an additional type check?

            // download: requirements
            $sform->addElement(new \XoopsFormTextArea(\_AM_WFDOWNLOADS_FILE_REQUIREMENTS, 'requirements', $this->getVar('requirements', 'e'), 7, 60), false);
        } else {
            // if we are using a custom form, then add in the form's elements here
            // download: description
            $description_tray   = new \XoopsFormElementTray(\_MD_WFDOWNLOADS_DESCRIPTION, '<br>');
            $options['name']    = 'description';
            $options['value']   = $this->getVar('description', 'e');
            $options['rows']    = 15;
            $options['cols']    = '100%';
            $options['width']   = '100%';
            $options['height']  = '200px';
            $description_editor = new \XoopsFormEditor('', $this->helper->getConfig('editor_options'), $options, $nohtml = false, $onfailure = 'textarea');
            $description_tray->addElement($description_editor, true);
            $description_tray->setDescription(\_MD_WFDOWNLOADS_DESCRIPTION_DESC);
            $sform->addElement($description_tray);
            // download: size
            $sform->addElement(new \XoopsFormHidden('size', $this->getVar('size', 'e')));

It seems like $this->getVar('size', 'e') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

            if (Utility::checkModule('formulize')) {
                require_once XOOPS_ROOT_PATH . '/modules/formulize/include/formdisplay.php';
                require_once XOOPS_ROOT_PATH . '/modules/formulize/include/functions.php';
                $sform = compileElements(// is a Formulize function

The function compileElements was not found. Maybe you did not declare it correctly or list all dependencies?

                    $customArray['fid'],
                    $sform,
                    $customArray['formulize_mgr'],
                    $customArray['prevEntry'],
                    $customArray['entry'],
                    $customArray['go_back'],
                    $customArray['parentLinks'],
                    $customArray['owner_groups'],
                    $customArray['groups'],
                    null,
                    null,
                    null,
                    null,
                    null,
                    null,
                    null,
                    null,
                    null,
                    null
                );
            }
            // IN PROGRESS... Formulize module not installed!!!
        }
        // Formulize module support (2006/03/06, 2006/03/08) jpc - end
        // download: dhistory
        $sform->addElement(new \XoopsFormTextArea(\_AM_WFDOWNLOADS_FILE_HISTORY, 'dhistory', $this->getVar('dhistory', 'e'), 7, 60), false);
        if (!$this->isNew() && '' != $this->getVar('dhistory')) {
            $sform->addElement(new \XoopsFormTextArea(\_AM_WFDOWNLOADS_FILE_HISTORYD, 'dhistoryaddedd', '', 7, 60), false);
        }

        // download: screenshot
        $graph_array1       = WfsLists::getListTypeAsArray(XOOPS_ROOT_PATH . '/' . $this->helper->getConfig('screenshots'), 'images');
        $indeximage_select1 = new \XoopsFormSelect('', 'screenshot', $this->getVar('screenshot', 'e'));
        $indeximage_select1->addOptionArray($graph_array1);
        $indeximage_select1->setExtra("onchange='showImgSelected(\"image1\", \"screenshot\", \"" . $this->helper->getConfig('screenshots') . '", "", "' . XOOPS_URL . "\")'");
        $indeximage_tray1 = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_SHOTIMAGE, ' ');
        $indeximage_tray1->addElement($indeximage_select1);
        if ('' != $this->getVar('screenshot')) { // IN PROGRESS
            $indeximage_tray1->addElement(new \XoopsFormLabel('', "<br><br><img src='" . XOOPS_URL . '/' . $this->helper->getConfig('screenshots') . '/' . $this->getVar('screenshot', 'e') . "' id='image1' alt='' title='screenshot 1'>"));
        } else {
            $indeximage_tray1->addElement(new \XoopsFormLabel('', "<br><br><img src='" . XOOPS_URL . "/uploads/blank.png' id='image1' alt='' title=''>"));
        }
        $sform->addElement($indeximage_tray1);

        // download: screenshot2
        $graph_array2       = WfsLists::getListTypeAsArray(XOOPS_ROOT_PATH . '/' . $this->helper->getConfig('screenshots'), 'images');
        $indeximage_select2 = new \XoopsFormSelect('', 'screenshot2', $this->getVar('screenshot2', 'e'));
        $indeximage_select2->addOptionArray($graph_array2);
        $indeximage_select2->setExtra("onchange='showImgSelected(\"image2\", \"screenshot2\", \"" . $this->helper->getConfig('screenshots') . '", "", "' . XOOPS_URL . "\")'");
        $indeximage_tray2 = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_SHOTIMAGE, '&nbsp;');
        $indeximage_tray2->addElement($indeximage_select2);
        if ('' != $this->getVar('screenshot2')) {
            $indeximage_tray2->addElement(new \XoopsFormLabel('', "<br><br><img src='" . XOOPS_URL . '/' . $this->helper->getConfig('screenshots') . '/' . $this->getVar('screenshot2', 'e') . "' id='image2' alt='' title='screenshot 2'>"));
        } else {
            $indeximage_tray2->addElement(new \XoopsFormLabel('', "<br><br><img src='" . XOOPS_URL . "/uploads/blank.png' id='image2' alt='' title=''>"));
        }
        $sform->addElement($indeximage_tray2);

        // download: screenshot3
        $graph_array3       = WfsLists::getListTypeAsArray(XOOPS_ROOT_PATH . '/' . $this->helper->getConfig('screenshots'), 'images');
        $indeximage_select3 = new \XoopsFormSelect('', 'screenshot3', $this->getVar('screenshot3', 'e', true));

The call to XoopsObject::getVar() has too many arguments starting with true.

        $indeximage_select3->addOptionArray($graph_array3);
        $indeximage_select3->setExtra("onchange='showImgSelected(\"image3\", \"screenshot3\", \"" . $this->helper->getConfig('screenshots') . '", "", "' . XOOPS_URL . "\")'");
        $indeximage_tray3 = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_SHOTIMAGE, ' ');
        $indeximage_tray3->addElement($indeximage_select3);
        if ('' != $this->getVar('screenshot3')) {
            $indeximage_tray3->addElement(new \XoopsFormLabel('', "<br><br><img src='" . XOOPS_URL . '/' . $this->helper->getConfig('screenshots') . '/' . $this->getVar('screenshot3', 'e') . "' id='image3' alt='' title='screenshot 3'>"));
        } else {
            $indeximage_tray3->addElement(new \XoopsFormLabel('', "<br><br><img src='" . XOOPS_URL . "/uploads/blank.png' id='image3' alt='' title=''>"));
        }
        $sform->addElement($indeximage_tray3);

        // download: screenshot4
        $graph_array4       = WfsLists::getListTypeAsArray(XOOPS_ROOT_PATH . '/' . $this->helper->getConfig('screenshots'), 'images');
        $indeximage_select4 = new \XoopsFormSelect('', 'screenshot4', $this->getVar('screenshot4', 'e'));
        $indeximage_select4->addOptionArray($graph_array4);
        $indeximage_select4->setExtra("onchange='showImgSelected(\"image4\", \"screenshot4\", \"" . $this->helper->getConfig('screenshots') . '", "", "' . XOOPS_URL . "\")'");
        $indeximage_tray4 = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_SHOTIMAGE, '&nbsp;');
        $indeximage_tray4->addElement($indeximage_select4);
        if ('' != $this->getVar('screenshot4')) {
            $indeximage_tray4->addElement(new \XoopsFormLabel('', "<br><br><img src='" . XOOPS_URL . '/' . $this->helper->getConfig('screenshots') . '/' . $this->getVar('screenshot4', 'e') . "' id='image4' alt='' title='screenshot 4'>"));
        } else {
            $indeximage_tray4->addElement(new \XoopsFormLabel('', "<br><br><img src='" . XOOPS_URL . "/uploads/blank.png' id='image4' alt='' title=''>"));
        }
        $sform->addElement($indeximage_tray4);

        $sform->insertBreak(\sprintf(\_AM_WFDOWNLOADS_FILE_MUSTBEVALID, '<b>' . $this->helper->getConfig('screenshots') . '</b>'), 'even');

        // download: published
        $publishtext = ($this->isNew() || 0 == $this->getVar('published')) ? \_AM_WFDOWNLOADS_FILE_SETPUBLISHDATE : \_AM_WFDOWNLOADS_FILE_SETNEWPUBLISHDATE;
        if ($this->getVar('published') > \time()) {
            $publishtext = \_AM_WFDOWNLOADS_FILE_SETPUBDATESETS;
        }
        $ispublished          = $this->getVar('published') > \time();
        $publishdates         = ($this->getVar('published') > \time()) ? \_AM_WFDOWNLOADS_FILE_PUBLISHDATESET . \formatTimestamp($this->getVar('published', 'e'), 'Y-m-d H:s') : \_AM_WFDOWNLOADS_FILE_SETDATETIMEPUBLISH;
        $publishdate_checkbox = new \XoopsFormCheckBox('', 'publishdateactivate', $ispublished);
        $publishdate_checkbox->addOption(1, $publishdates . '<br>');
        if (!$this->isNew()) {
            $sform->addElement(new \XoopsFormHidden('was_published', $this->getVar('published', 'e')));
            $sform->addElement(new \XoopsFormHidden('was_expired', $this->getVar('expired', 'e')));
        }
        $publishdate_tray = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_PUBLISHDATE, '');
        $publishdate_tray->addElement($publishdate_checkbox);
        $publishdate_tray->addElement(new \XoopsFormDateTime($publishtext, 'published', 15, $this->getVar('published', 'e')));
        $publishdate_tray->addElement(new \XoopsFormRadioYN(\_AM_WFDOWNLOADS_FILE_CLEARPUBLISHDATE, 'clearpublish', 0));
        $sform->addElement($publishdate_tray);
        // download: expired
        $isexpired           = $this->getVar('expired', 'e') > \time();
        $expiredates         = ($this->getVar('expired', 'e') > \time()) ? \_AM_WFDOWNLOADS_FILE_EXPIREDATESET . \formatTimestamp($this->getVar('expired'), 'Y-m-d H:s') : \_AM_WFDOWNLOADS_FILE_SETDATETIMEEXPIRE;
        $warning             = ($this->getVar('published') > $this->getVar('expired')
                                && $this->getVar('expired') > \time()) ? \_AM_WFDOWNLOADS_FILE_EXPIREWARNING : '';
        $expiredate_checkbox = new \XoopsFormCheckBox('', 'expiredateactivate', $isexpired);
        $expiredate_checkbox->addOption(1, $expiredates . '<br>');
        $expiredate_tray = new \XoopsFormElementTray(\_AM_WFDOWNLOADS_FILE_EXPIREDATE . $warning, '');
        $expiredate_tray->addElement($expiredate_checkbox);
        $expiredate_tray->addElement(new \XoopsFormDateTime(\_AM_WFDOWNLOADS_FILE_SETEXPIREDATE, 'expired', 15, $this->getVar('expired')));
        $expiredate_tray->addElement(new \XoopsFormRadioYN(\_AM_WFDOWNLOADS_FILE_CLEAREXPIREDATE, 'clearexpire', 0));
        $sform->addElement($expiredate_tray);
        // download: offline
        $filestatus_radio = new \XoopsFormRadioYN(\_AM_WFDOWNLOADS_FILE_FILESSTATUS, 'offline', $this->getVar('offline', 'e'));

It seems like $this->getVar('offline', 'e') can also be of type array and array; however, parameter $value of XoopsFormRadioYN::__construct() does only seem to accept string, maybe add an additional type check?

        $sform->addElement($filestatus_radio);
        // download: up_dated
        $file_updated_radio = new \XoopsFormRadioYN(\_AM_WFDOWNLOADS_FILE_SETASUPDATED, 'up_dated', true === $this->getVar('updated', 'e'));
        $sform->addElement($file_updated_radio);
        // download: approved
        if (!$this->isNew() && 0 == $this->getVar('published')) {
            $approved         = 0 != $this->getVar('published');

The assignment to $approved is dead and can be removed.

            $approve_checkbox = new \XoopsFormCheckBox(\_AM_WFDOWNLOADS_FILE_EDITAPPROVE, 'approved', true);
            $approve_checkbox->addOption(1, ' ');
            $sform->addElement($approve_checkbox);
        }
        // form: button tray
        $buttonTray = new \XoopsFormElementTray('', '');
        $buttonTray->addElement(new \XoopsFormHidden('op', 'download.save'));
        if ($this->isNew()) {
            $buttonTray->addElement(new \XoopsFormHidden('status', \_WFDOWNLOADS_STATUS_APPROVED));
            $buttonTray->addElement(new \XoopsFormHidden('notifypub', $this->getVar('notifypub', 'e')));

            $buttonTray->addElement(new \XoopsFormButton('', '', _SUBMIT, 'submit'));
        } else {
            $buttonTray->addElement(new \XoopsFormHidden('status', \_WFDOWNLOADS_STATUS_UPDATED));
            $buttonTray->addElement(new \XoopsFormHidden('lid', (int)$this->getVar('lid')));
            $button_submit = new \XoopsFormButton('', '', _SUBMIT, 'submit');
            $button_submit->setExtra('onclick="this.form.elements.op.value=\'download.save\'"');
            $buttonTray->addElement($button_submit);
            $deleteButton = new \XoopsFormButton('', '', _DELETE, 'submit');
            $deleteButton->setExtra('onclick="this.form.elements.op.value=\'download.delete\'"');
            $buttonTray->addElement($deleteButton);
        }
        $button_reset = new \XoopsFormButton('', '', _RESET, 'reset');
        $buttonTray->addElement($button_reset);
        $buttonCancel = new \XoopsFormButton('', '', _CANCEL, 'button');
        $buttonCancel->setExtra('onclick="history.go(-1)"');
        $buttonTray->addElement($buttonCancel);

        $sform->addElement($buttonTray);

        return $sform;
    }

    // Formulize module support (2006/03/06, 2006/03/08) jpc - start

    /**
     * @param $title
     *
     * @return \XoopsThemeForm
     */
    public function getCategoryForm($title)
    {
        require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
        require_once XOOPS_ROOT_PATH . '/class/tree.php';
        $sform = new \XoopsThemeForm($title, 'storyform', $_SERVER['REQUEST_URI']);
        $sform->setExtra('enctype="multipart/form-data"');
        // download: cid
        $categoryObjs     = $this->helper->getHandler('Category')->getUserUpCategories();
        $categoryObjsTree = new ObjectTree($categoryObjs, 'cid', 'pid');

        if (Utility::checkVerXoops($GLOBALS['xoopsModule'], '2.5.9')) {
            $catSelect = $categoryObjsTree->makeSelectElement('cid', 'title', '-', $this->getVar('cid'), true, 0, '', \_MD_WFDOWNLOADS_CATEGORYC);

It seems like $this->getVar('cid') can also be of type array and array; however, parameter $selected of XoopsObjectTree::makeSelectElement() does only seem to accept string, maybe add an additional type check?

            $sform->addElement($catSelect);
        } else {
            $sform->addElement(new \XoopsFormLabel(\_MD_WFDOWNLOADS_CATEGORYC, $categoryObjsTree->makeSelBox('cid', 'title', '-', $this->getVar('cid', 'e'))));

It seems like $this->getVar('cid', 'e') can also be of type array and array; however, parameter $selected of XoopsModules\Wfdownloads\ObjectTree::makeSelBox() does only seem to accept string, maybe add an additional type check?

        }

        // form: button tray
        $buttonTray = new \XoopsFormElementTray('', '');
        $buttonTray->addElement(new \XoopsFormButton('', 'submit_category', _SUBMIT, 'submit'));
        if (!$this->isNew()) {
            $buttonTray->addElement(new \XoopsFormHidden('lid', $this->getVar('lid', 'e')));

It seems like $this->getVar('lid', 'e') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

        }
        $sform->addElement($buttonTray);

        return $sform;
    }

    // Formulize module support (2006/03/06, 2006/03/08) jpc - end

    /**
     * Returns an array representation of the object
     *
     * @return array
     */
    public function toArray()
    {
        $ret  = [];
        $vars = &$this->getVars();
        foreach (\array_keys($vars) as $i) {
            $ret[$i] = $this->getVar($i);
        }

        return $ret;
    }
}