wfdownloads_top_by_cat_show()

Complexity

Conditions	10
Paths	33

Size

Total Lines	56
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function wfdownloads_top_by_cat_show($options)
{
    if (!class_exists(Helper::class)) {
        return false;

The expression return false returns the type false which is incompatible with the documented return type array.

    }
    $helper = Helper::getInstance();
    $categoryHandler = new Wfdownloads\CategoryHandler($GLOBALS['xoopsDB']);

    /** @var \XoopsGroupPermHandler $grouppermHandler */
    $grouppermHandler         = xoops_getHandler('groupperm');
    $groups                   = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : [0 => XOOPS_GROUP_ANONYMOUS];
    $allowedDownCategoriesIds = $grouppermHandler->getItemIds('WFDownCatPerm', $groups, $helper->getModule()->mid());

    $block = [];

    // get downloads
    $criteria = new CriteriaCompo();
    $criteria->add(new Criteria('cid', '(' . implode(',', $allowedDownCategoriesIds) . ')', 'IN'));
    $criteria->add(new Criteria('offline', false));

false of type false is incompatible with the type string expected by parameter $value of Criteria::__construct().

    $criteria->setSort('date');
    $criteria->setOrder('DESC');
    $criteria->setLimit($options[1]);
    $downloadObjs = $helper->getHandler('Download')->getObjects($criteria);

    foreach ($downloadObjs as $downloadObj) {
        $download = $downloadObj->toArray();
        if (!in_array((int)$download['cid'], $allowedDownCategoriesIds)) {
            continue;
        }
        $download['title'] = xoops_substr($download['title'], 0, $options[2] - 1);
        $download['id']    = (int)$download['lid'];
        if ('published' === $options[0]) {
            $download['date'] = formatTimestamp($download['published'], $helper->getConfig('dateformat'));
        } else {
            $download['date'] = formatTimestamp($download['date'], $helper->getConfig('dateformat'));
        }
        $download['dirname']  = $helper->getModule()->dirname();
        $block['downloads'][] = $download;
    }

    $categoriesTopParentByCid = $helper->getHandler('Category')->getAllSubcatsTopParentCid();

    //    foreach ($helper->getHandler('Category')->topCategories as $cid) {
    if ($categoryHandler->topCategories && is_array($categoryHandler->topCategories)) {

The condition is_array($categoryHandler->topCategories) is always false.

        foreach ($categoryHandler->topCategories as $cid) {
            $block['topcats'][$cid]['title']  = $helper->getHandler('Category')->allCategories[$cid]->getVar('title');
            $block['topcats'][$cid]['cid']    = $cid;
            $block['topcats'][$cid]['imgurl'] = $helper->getHandler('Category')->allCategories[$cid]->getVar('imgurl');
        }
    }

    foreach ($block['downloads'] as $value) {
        $block['topcats'][$categoriesTopParentByCid[$value['cid']]]['downloads'][] = $value;
    }

    return $block;
}