wfdownloads_notify_iteminfo()

Complexity

Conditions	6
Paths	8

Size

Total Lines	44
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function wfdownloads_notify_iteminfo($category, $item_id)
{
    global $xoopsModule, $xoopsModuleConfig;

    if (empty($xoopsModule) || 'wfdownloads' !== $xoopsModule->dirname()) {
        /** @var \XoopsModuleHandler $moduleHandler */
        $moduleHandler = xoops_getHandler('module');
        /** @var \XoopsModule $module */
        $module = $moduleHandler->getByDirname('wfdownloads');
        /** @var \XoopsConfigHandler $configHandler */
        $configHandler = xoops_getHandler('config');
        $config        = $configHandler->getConfigsByCat(0, (int)$module->mid());

The assignment to $config is dead and can be removed.

    } else {
        $module = $xoopsModule;

The assignment to $module is dead and can be removed.

        $config = $xoopsModuleConfig;
    }
    if ('global' === $category) {
        $item['name'] = '';

$item was never initialized. Although not strictly required by PHP, it is generally a good practice to add $item = array(); before regardless.

        $item['url']  = '';

        return $item;
    }
    if ('category' === $category) {
        // Assume we have a valid category id
        $sql          = 'SELECT title FROM ' . $GLOBALS['xoopsDB']->prefix('wfdownloads_cat') . " WHERE cid = '" . (int)$item_id . "'";
        $result       = $GLOBALS['xoopsDB']->query($sql); // TODO: error check
        $result_array = $GLOBALS['xoopsDB']->fetchArray($result);
        $item['name'] = $result_array['title'];
        $item['url']  = WFDOWNLOADS_URL . '/viewcat.php?cid=' . (int)$item_id;

The constant WFDOWNLOADS_URL was not found. Maybe you did not declare it correctly or list all dependencies?

        return $item;
    }
    if ('file' === $category) {
        // Assume we have a valid file id
        $sql          = 'SELECT cid,title FROM ' . $GLOBALS['xoopsDB']->prefix('wfdownloads_downloads') . " WHERE lid = '" . (int)$item_id . "'";
        $result       = $GLOBALS['xoopsDB']->query($sql); // TODO: error check
        $result_array = $GLOBALS['xoopsDB']->fetchArray($result);
        $item['name'] = $result_array['title'];
        $item['url']  = WFDOWNLOADS_URL . '/singlefile.php?cid=' . (int)$result_array['cid'] . '&lid=' . (int)$item_id;

        return $item;
    }

    return null;
}