| Conditions | 3 |
| Paths | 3 |
| Total Lines | 64 |
| Code Lines | 54 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 39 | public function __construct($id = null) |
||
| 40 | { |
||
| 41 | parent::__construct(); |
||
| 42 | $this->initVar('requestid', \XOBJ_DTYPE_INT); |
||
| 43 | |||
| 44 | $this->initVar('modifysubmitter', \XOBJ_DTYPE_INT, 0); |
||
| 45 | $this->initVar('requestdate', \XOBJ_DTYPE_INT, 0); |
||
| 46 | |||
| 47 | $this->initVar('lid', \XOBJ_DTYPE_INT); |
||
| 48 | $this->initVar('cid', \XOBJ_DTYPE_INT, 0); |
||
| 49 | $this->initVar('title', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 50 | $this->initVar('url', \XOBJ_DTYPE_URL, 'http://'); |
||
| 51 | $this->initVar('filename', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 52 | $this->initVar('filetype', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 53 | $this->initVar('homepage', \XOBJ_DTYPE_URL, 'http://'); |
||
| 54 | $this->initVar('version', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 55 | $this->initVar('size', \XOBJ_DTYPE_INT, 0); |
||
| 56 | $this->initVar('platform', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 57 | $this->initVar('screenshot', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 58 | $this->initVar('screenshot2', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 59 | $this->initVar('screenshot3', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 60 | $this->initVar('screenshot4', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 61 | $this->initVar('submitter', \XOBJ_DTYPE_INT); |
||
| 62 | $this->initVar('publisher', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 63 | $this->initVar('status', \XOBJ_DTYPE_INT, \_WFDOWNLOADS_STATUS_WAITING); |
||
| 64 | $this->initVar('date', \XOBJ_DTYPE_INT); |
||
| 65 | $this->initVar('hits', \XOBJ_DTYPE_INT, 0); |
||
| 66 | $this->initVar('rating', \XOBJ_DTYPE_OTHER, 0.0); |
||
| 67 | $this->initVar('votes', \XOBJ_DTYPE_INT, 0); |
||
| 68 | $this->initVar('comments', \XOBJ_DTYPE_INT, 0); |
||
| 69 | $this->initVar('license', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 70 | $this->initVar('mirror', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 71 | $this->initVar('price', \XOBJ_DTYPE_TXTBOX, 0); |
||
| 72 | $this->initVar('paypalemail', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 73 | $this->initVar('features', \XOBJ_DTYPE_TXTAREA, ''); |
||
| 74 | $this->initVar('requirements', \XOBJ_DTYPE_TXTAREA, ''); |
||
| 75 | $this->initVar('homepagetitle', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 76 | $this->initVar('forumid', \XOBJ_DTYPE_INT, 0); |
||
| 77 | $this->initVar('limitations', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 78 | $this->initVar('versiontypes', \XOBJ_DTYPE_TXTBOX, ''); |
||
| 79 | $this->initVar('dhistory', \XOBJ_DTYPE_TXTAREA, ''); |
||
| 80 | $this->initVar('published', \XOBJ_DTYPE_INT, 0); // published time or 0 |
||
| 81 | $this->initVar('expired', \XOBJ_DTYPE_INT, 0); |
||
| 82 | $this->initVar('updated', \XOBJ_DTYPE_INT, 0); // uploaded time or 0 |
||
| 83 | $this->initVar('offline', \XOBJ_DTYPE_INT, false); // boolean |
||
| 84 | $this->initVar('summary', \XOBJ_DTYPE_TXTAREA, ''); |
||
| 85 | $this->initVar('description', \XOBJ_DTYPE_TXTAREA, ''); |
||
| 86 | // $this->initVar('ipaddress', XOBJ_DTYPE_TXTBOX, ''); |
||
| 87 | // $this->initVar('notifypub', XOBJ_DTYPE_INT, 0); |
||
| 88 | // added 3.23 |
||
| 89 | $this->initVar('screenshots', \XOBJ_DTYPE_ARRAY, []); // IN PROGRESS |
||
| 90 | $this->initVar('dohtml', \XOBJ_DTYPE_INT, false); // boolean |
||
| 91 | $this->initVar('dosmiley', \XOBJ_DTYPE_INT, true); // boolean |
||
| 92 | $this->initVar('doxcode', \XOBJ_DTYPE_INT, true); // boolean |
||
| 93 | $this->initVar('doimage', \XOBJ_DTYPE_INT, true); // boolean |
||
| 94 | $this->initVar('dobr', \XOBJ_DTYPE_INT, true); // boolean |
||
| 95 | |||
| 96 | //Obsolete |
||
| 97 | unset($this->vars['ipaddress'], $this->vars['notifypub']); |
||
| 98 | |||
| 99 | if (null !== $id) { |
||
| 100 | $item = $this->helper->getHandler('Item')->get($id); |
||
| 101 | foreach ($item->vars as $k => $v) { |
||
| 102 | $this->assignVar($k, $v['value']); |
||
| 103 | } |
||
| 107 |