XoopsModules\Wfdownloads\Mimetype::getForm()

Complexity

Conditions	4
Paths	8

Size

Total Lines	54
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getForm($action = false)
    {
        require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

        if (!$action) {
            $action = $_SERVER['REQUEST_URI'];
        }
        $title = $this->isNew() ? \_AM_WFDOWNLOADS_MIME_CREATEF : \_AM_WFDOWNLOADS_MIME_MODIFYF;

        $form = new \XoopsThemeForm($title, 'form_error', $action, 'post', true);
        $form->setExtra('enctype="multipart/form-data"');
        // mime_ext
        $mime_ext_text = new \XoopsFormText(\_AM_WFDOWNLOADS_MIME_EXTF, 'mime_ext', 5, 60, $this->getVar('mime_ext', 'e'));

It seems like $this->getVar('mime_ext', 'e') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

        $mime_ext_text->setDescription(\_AM_WFDOWNLOADS_MIME_EXTF_DESC);
        $form->addElement($mime_ext_text, true);
        // mime_name
        $mime_name_text = new \XoopsFormText(\_AM_WFDOWNLOADS_MIME_NAMEF, 'mime_name', 50, 255, $this->getVar('mime_name', 'e'));
        $mime_name_text->setDescription(\_AM_WFDOWNLOADS_MIME_NAMEF_DESC);
        $form->addElement($mime_name_text, true);
        // mime_type
        $mime_type_textarea = new \XoopsFormTextArea(\_AM_WFDOWNLOADS_MIME_TYPEF, 'mime_type', $this->getVar('mime_types', 'e'));

It seems like $this->getVar('mime_types', 'e') can also be of type array and array; however, parameter $value of XoopsFormTextArea::__construct() does only seem to accept string, maybe add an additional type check?

        $mime_type_textarea->setDescription(\_AM_WFDOWNLOADS_MIME_TYPEF_DESC);
        $form->addElement($mime_type_textarea, 7, 60);

7 of type integer is incompatible with the type boolean expected by parameter $required of XoopsForm::addElement().

The call to XoopsForm::addElement() has too many arguments starting with 60.

        // mime_admin
        $madmin_radio = new \XoopsFormRadioYN(\_AM_WFDOWNLOADS_MIME_ADMINF, 'mime_admin', $this->getVar('mime_admin', 'e'));

It seems like $this->getVar('mime_admin', 'e') can also be of type array and array; however, parameter $value of XoopsFormRadioYN::__construct() does only seem to accept string, maybe add an additional type check?

        $form->addElement($madmin_radio);
        // mime_user
        $muser_radio = new \XoopsFormRadioYN(\_AM_WFDOWNLOADS_MIME_USERF, 'mime_user', $this->getVar('mime_user', 'e'));
        $form->addElement($muser_radio);
        // op
        $form->addElement(new \XoopsFormHidden('op', 'save'));
        // buttons
        $buttonTray = new \XoopsFormElementTray('', '');
        if ($this->isNew()) {
            $butt_create = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_MIME_CREATE, 'submit');
            $butt_create->setExtra('onclick="this.form.elements.op.value=\'mimetype.save\'"');
            $buttonTray->addElement($butt_create);
            $butt_clear = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_MIME_CLEAR, 'reset');
            $buttonTray->addElement($butt_clear);
            $butt_cancel = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_MIME_CANCEL, 'button');
            $butt_cancel->setExtra('onclick="history.go(-1)"');
            $buttonTray->addElement($butt_cancel);
        } else {
            $form->addElement(new \XoopsFormHidden('mime_id', $this->getVar('mime_id')));

It seems like $this->getVar('mime_id') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

            $butt_create = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_MIME_MODIFY, 'submit');
            $butt_create->setExtra('onclick="this.form.elements.op.value=\'mimetype.save\'"');
            $buttonTray->addElement($butt_create);
            $butt_cancel = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_MIME_CANCEL, 'button');
            $butt_cancel->setExtra('onclick="history.go(-1)"');
            $buttonTray->addElement($butt_cancel);
        }
        $form->addElement($buttonTray);

        return $form;
    }