XoopsModules\Wfdownloads\Review

Complexity

Total Complexity

7

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getForm()	0	67	4
A	__construct()	0	18	3

<?php

namespace XoopsModules\Wfdownloads;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * Wfdownloads module
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         GNU GPL 2 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @package         wfdownload
 * @since           3.23
 * @author          Xoops Development Team
 */

use XoopsModules\Wfdownloads;

require_once \dirname(__DIR__) . '/include/common.php';

/**
 * Class Review
 */
class Review extends \XoopsObject
{
    /**
     * @access public
     */
    public $helper;
    public $db;

    /**
     * @param int|null $id
     */
    public function __construct($id = null)
    {
        /** @var \XoopsModules\Wfdownloads\Helper $this ->helper */
        $this->helper = Helper::getInstance();

The property helper does not seem to exist on XoopsModules\Wfdownloads\Helper.

        $this->db     = \XoopsDatabaseFactory::getDatabaseConnection();

The property db does not seem to exist on XoopsModules\Wfdownloads\Helper.

        $this->initVar('review_id', \XOBJ_DTYPE_INT);

The method initVar() does not exist on XoopsModules\Wfdownloads\Helper. Did you maybe mean init()?

        $this->initVar('lid', \XOBJ_DTYPE_INT);
        $this->initVar('title', \XOBJ_DTYPE_TXTBOX);
        $this->initVar('review', \XOBJ_DTYPE_TXTAREA);
        $this->initVar('submit', \XOBJ_DTYPE_INT); // boolean
        $this->initVar('date', \XOBJ_DTYPE_INT);
        $this->initVar('uid', \XOBJ_DTYPE_INT);
        $this->initVar('rated', \XOBJ_DTYPE_INT);

        if (null !== $id) {
            $item = $this->helper->getHandler('Item')->get($id);
            foreach ($item->vars as $k => $v) {
                $this->assignVar($k, $v['value']);

The method assignVar() does not exist on XoopsModules\Wfdownloads\Helper.

            }
        }
    }

    /**
     * @return \XoopsThemeForm
     */
    public function getForm()
    {
        require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
        $uid = !empty($GLOBALS['xoopsUser']) ? (int)$GLOBALS['xoopsUser']->getVar('uid') : 0;

        $form = new \XoopsThemeForm(\_AM_WFDOWNLOADS_REV_SNEWMNAMEDESC, 'reviewform', $_SERVER['REQUEST_URI']);
        // review: title
        $form->addElement(new \XoopsFormText(\_AM_WFDOWNLOADS_REV_FTITLE, 'title', 30, 40, $this->getVar('title', 'e')), true);

It seems like $this->getVar('title', 'e') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

        // review: rated
        $rating_select = new \XoopsFormSelect(\_AM_WFDOWNLOADS_REV_FRATING, 'rated', $this->getVar('rated'));
        $rating_select->addOptionArray(
            [
                '1'  => 1,
                '2'  => 2,
                '3'  => 3,
                '4'  => 4,
                '5'  => 5,
                '6'  => 6,
                '7'  => 7,
                '8'  => 8,
                '9'  => 9,
                '10' => 10,
            ]
        );
        $form->addElement($rating_select);
        // review: review
        $form->addElement(new \XoopsFormDhtmlTextArea(\_AM_WFDOWNLOADS_REV_FDESCRIPTION, 'review', $this->getVar('review', 'e'), 15, 60), true);

It seems like $this->getVar('review', 'e') can also be of type array and array; however, parameter $value of XoopsFormDhtmlTextArea::__construct() does only seem to accept string, maybe add an additional type check?

        // form: approve
        $approved         = (0 == $this->getVar('submit')) ? 0 : 1;
        $approve_checkbox = new \XoopsFormCheckBox(\_AM_WFDOWNLOADS_REV_FAPPROVE, 'approve', $approved);
        $approve_checkbox->addOption(1, ' ');
        $form->addElement($approve_checkbox);
        // review: lid
        $form->addElement(new \XoopsFormHidden('lid', (int)$this->getVar('lid')));
        // review: uid
        $form->addElement(new \XoopsFormHidden('uid', $uid));
        // review: review_id
        $form->addElement(new \XoopsFormHidden('review_id', (int)$this->getVar('review_id')));
        // form: confirm
        $form->addElement(new \XoopsFormHidden('confirm', 1));
        // form: op
        $form->addElement(new \XoopsFormHidden('op', ''));
        // form: buttons
        $buttonTray = new \XoopsFormElementTray('', '');
        if ($this->isNew()) {
            $butt_create = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_BSAVE, 'submit');
            $butt_create->setExtra('onclick="this.form.elements.op.value=\'review.save\'"');
            $buttonTray->addElement($butt_create);
            $butt_clear = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_BRESET, 'reset');
            $buttonTray->addElement($butt_clear);
            $butt_cancel = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_BCANCEL, 'button');
            $butt_cancel->setExtra('onclick="history.go(-1)"');
            $buttonTray->addElement($butt_cancel);
        } else {
            $butt_create = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_BSAVE, 'submit');
            $butt_create->setExtra('onclick="this.form.elements.op.value=\'review.save\'"');
            $buttonTray->addElement($butt_create);
            $butt_delete = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_BDELETE, 'submit');
            $butt_delete->setExtra('onclick="this.form.elements.op.value=\'review.delete\'"');
            $buttonTray->addElement($butt_delete);
            $butt_cancel = new \XoopsFormButton('', '', \_AM_WFDOWNLOADS_BCANCEL, 'button');
            $butt_cancel->setExtra('onclick="history.go(-1)"');
            $buttonTray->addElement($butt_cancel);
        }
        $form->addElement($buttonTray);

        return $form;
    }
}