Issues in utility.php (master) - Issues in master - XoopsModules25x/userlog - Measure and Improve Code Quality continuously with Scrutinizer

Issues (304)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/utility.php (14 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Class MyalbumUtil
 */
class UserLogUtility extends XoopsObject
namespace YourVendor;

class YourClass { }
{
    /**
     * Function responsible for checking if a directory exists, we can also write in and create an index.html file
     *
     * @param string $folder The full path of the directory to check
     *
     * @return void
     */
    public static function createFolder($folder)
    {
        //        try {
        //            if (!mkdir($folder) && !is_dir($folder)) {

        //                throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));

        //            } else {

        //                file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');

        //            }
        //        }
        //        catch (Exception $e) {

        //            echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';

        //        }
        try {
            if (!file_exists($folder)) {
                if (!mkdir($folder) && !is_dir($folder)) {
                    throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
                }

                file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
            }
        } catch (Exception $e) {
            echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
        }
    }

    /**
     * @param $file
     * @param $folder
     * @return bool
     */
    public static function copyFile($file, $folder)
    {
        return copy($file, $folder);
        //        try {
        //            if (!is_dir($folder)) {

        //                throw new \RuntimeException(sprintf('Unable to copy file as: %s ', $folder));

        //            } else {

        //                return copy($file, $folder);

        //            }
        //        } catch (Exception $e) {

        //            echo 'Caught exception: ', $e->getMessage(), "\n", "<br>";

        //        }
        //        return false;
    }

    /**
     * @param $src
     * @param $dst
     */
    public static function recurseCopy($src, $dst)
    {
        $dir = opendir($src);
        //    @mkdir($dst);
        while (false !== ($file = readdir($dir))) {
            if (('.' !== $file) && ('..' !== $file)) {
                if (is_dir($src . '/' . $file)) {
                    self::recurseCopy($src . '/' . $file, $dst . '/' . $file);
                } else {
                    copy($src . '/' . $file, $dst . '/' . $file);
                }
            }
        }
        closedir($dir);
    }

    /**
     *
     * Verifies XOOPS version meets minimum requirements for this module
     * @static
     * @param XoopsModule $module

     *
     * @param null|string $requiredVer
     * @return bool true if meets requirements, false if not
     */
    public static function checkVerXoops(XoopsModule $module = null, $requiredVer = null)
    {
        $moduleDirName = basename(dirname(__DIR__));
        if (null === $module) {
            $module = XoopsModule::getByDirname($moduleDirName);
        }
        xoops_loadLanguage('admin', $moduleDirName);
        //check for minimum XOOPS version
        $currentVer = substr(XOOPS_VERSION, 6); // get the numeric part of string
        $currArray  = explode('.', $currentVer);
        if (null === $requiredVer) {
            $requiredVer = '' . $module->getInfo('min_xoops'); //making sure it's a string
        }
        $reqArray = explode('.', $requiredVer);
        $success  = true;
        foreach ($reqArray as $k => $v) {
            if (isset($currArray[$k])) {
                if ($currArray[$k] > $v) {
                    break;
                }

                if ($currArray[$k] == $v) {
                    continue;
                } else {
                    $success = false;
                    break;
                }
            } else {
                if ((int)$v > 0) { // handles versions like x.x.x.0_RC2
                    $success = false;
                    break;
                }
            }
        }

        if (false === $success) {
            $module->setErrors(sprintf(_AM_USERLOG_ERROR_BAD_XOOPS, $requiredVer, $currentVer));
        }

        return $success;
    }

    /**
     *
     * Verifies PHP version meets minimum requirements for this module
     * @static
     * @param XoopsModule $module
     *
     * @return bool true if meets requirements, false if not
     */
    public static function checkVerPhp(XoopsModule $module)
    {
        xoops_loadLanguage('admin', $module->dirname());
        // check for minimum PHP version
        $success = true;
        $verNum  = PHP_VERSION;
        $reqVer  = $module->getInfo('min_php');
        if (false !== $reqVer && '' !== $reqVer) {
            if (version_compare($verNum, $reqVer, '<')) {
                $module->setErrors(sprintf(_AM_USERLOG_ERROR_BAD_PHP, $reqVer, $verNum));
                $success = false;
            }
        }

        return $success;
    }
}


1			<?php
2
3			/**
4			* Class MyalbumUtil
5			*/
6			class UserLogUtility extends XoopsObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			/**
9			* Function responsible for checking if a directory exists, we can also write in and create an index.html file
10			*
11			* @param string $folder The full path of the directory to check
12			*
13			* @return void
14			*/
15			public static function createFolder($folder)
16			{
17			// try {
18			// if (!mkdir($folder) && !is_dir($folder)) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
19			// throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
20			// } else {
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
21			// file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
22			// }
23			// }
24			// catch (Exception $e) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
25			// echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26			// }
27			try {
28			if (!file_exists($folder)) {
29			if (!mkdir($folder) && !is_dir($folder)) {
30			throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
31			}
32
33			file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
34			}
35			} catch (Exception $e) {
36			echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
37			}
38			}
39
40			/**
41			* @param $file
42			* @param $folder
43			* @return bool
44			*/
45			public static function copyFile($file, $folder)
46			{
47			return copy($file, $folder);
48			// try {
49			// if (!is_dir($folder)) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50			// throw new \RuntimeException(sprintf('Unable to copy file as: %s ', $folder));
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
51			// } else {
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52			// return copy($file, $folder);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
53			// }
54			// } catch (Exception $e) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
55			// echo 'Caught exception: ', $e->getMessage(), "\n", "<br>";
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
56			// }
57			// return false;
58			}
59
60			/**
61			* @param $src
62			* @param $dst
63			*/
64			public static function recurseCopy($src, $dst)
65			{
66			$dir = opendir($src);
67			// @mkdir($dst);
68			while (false !== ($file = readdir($dir))) {
69			if (('.' !== $file) && ('..' !== $file)) {
70			if (is_dir($src . '/' . $file)) {
71			self::recurseCopy($src . '/' . $file, $dst . '/' . $file);
72			} else {
73			copy($src . '/' . $file, $dst . '/' . $file);
74			}
75			}
76			}
77			closedir($dir);
78			}
79
80			/**
81			*
82			* Verifies XOOPS version meets minimum requirements for this module
83			* @static
84			* @param XoopsModule $module
			0 ignored issues – show Documentation introduced 2017-08-04 04:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$module` not be `null\|XoopsModule`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
85			*
86			* @param null\|string $requiredVer
87			* @return bool true if meets requirements, false if not
88			*/
89			public static function checkVerXoops(XoopsModule $module = null, $requiredVer = null)
90			{
91			$moduleDirName = basename(dirname(__DIR__));
92			if (null === $module) {
93			$module = XoopsModule::getByDirname($moduleDirName);
94			}
95			xoops_loadLanguage('admin', $moduleDirName);
96			//check for minimum XOOPS version
97			$currentVer = substr(XOOPS_VERSION, 6); // get the numeric part of string
98			$currArray = explode('.', $currentVer);
99			if (null === $requiredVer) {
100			$requiredVer = '' . $module->getInfo('min_xoops'); //making sure it's a string
101			}
102			$reqArray = explode('.', $requiredVer);
103			$success = true;
104			foreach ($reqArray as $k => $v) {
105			if (isset($currArray[$k])) {
106			if ($currArray[$k] > $v) {
107			break;
108			}
109
110			if ($currArray[$k] == $v) {
111			continue;
112			} else {
113			$success = false;
114			break;
115			}
116			} else {
117			if ((int)$v > 0) { // handles versions like x.x.x.0_RC2
118			$success = false;
119			break;
120			}
121			}
122			}
123
124			if (false === $success) {
125			$module->setErrors(sprintf(_AM_USERLOG_ERROR_BAD_XOOPS, $requiredVer, $currentVer));
126			}
127
128			return $success;
129			}
130
131			/**
132			*
133			* Verifies PHP version meets minimum requirements for this module
134			* @static
135			* @param XoopsModule $module
136			*
137			* @return bool true if meets requirements, false if not
138			*/
139			public static function checkVerPhp(XoopsModule $module)
140			{
141			xoops_loadLanguage('admin', $module->dirname());
142			// check for minimum PHP version
143			$success = true;
144			$verNum = PHP_VERSION;
145			$reqVer = $module->getInfo('min_php');
146			if (false !== $reqVer && '' !== $reqVer) {
147			if (version_compare($verNum, $reqVer, '<')) {
148			$module->setErrors(sprintf(_AM_USERLOG_ERROR_BAD_PHP, $reqVer, $verNum));
149			$success = false;
150			}
151			}
152
153			return $success;
154			}
155			}
156

XoopsModules25x / userlog

Issues (304)

Security Analysis not enabled

class/utility.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like