Issues in plugin.php (master) - Issues in master - XoopsModules25x/userlog - Measure and Improve Code Quality continuously with Scrutinizer

Issues (304)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/plugin/plugin.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         http://www.fsf.org/copyleft/gpl.html GNU public license
 * @author          trabis <[email protected]>
 */
// irmtfan copy from xoops26 xoops_lib/Xoops/Module/plugin.php class
// change XoopsLoad -> self
// change $xoops -> $GLOBALS['xoops']
// change  Userlog_Module_Plugin_Abstract , Userlog_Module_Plugin
// change  $xoops->getActiveModules() -> xoops_getActiveModules()

class Userlog_Module_Plugin
namespace YourVendor;

class YourClass { }
{
    /**
     * @param string $dirname
     * @param string $pluginName
     * @param bool   $force
     *
     * @return bool|Xoops_Module_Plugin_Abstract false if plugin does not exist
     */
    public static function getPlugin($dirname, $pluginName = 'system', $force = false)
    {
        $inactiveModules = false;
        if ($force) {
            $inactiveModules = [$dirname];
        }
        $available = self::getPlugins($pluginName, $inactiveModules);
        if (!in_array($dirname, array_keys($available))) {
            return false;
        }

        return $available[$dirname];
    }

    /**
     * @param string     $pluginName
     * @param array|bool $inactiveModules
     *
     * @return mixed
     */
    public static function getPlugins($pluginName = 'system', $inactiveModules = false)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        static $plugins = [];
        if (!isset($plugins[$pluginName])) {
            $plugins[$pluginName] = [];
            //$xoops = Xoops::getInstance();


            //Load interface for this plugin
            if (!self::loadFile($GLOBALS['xoops']->path("modules/{$pluginName}/class/plugin/interface.php"))) {
                return $plugins[$pluginName];
            }

            $dirnames = xoops_getActiveModules();
            if (is_array($inactiveModules)) {
                $dirnames = array_merge($dirnames, $inactiveModules);
            }
            foreach ($dirnames as $dirname) {
                if (self::loadFile($GLOBALS['xoops']->path("modules/{$dirname}/class/plugin/{$pluginName}.php"))
                    || self::loadFile($GLOBALS['xoops']->path("modules/{$pluginName}/class/plugin/{$dirname}.php"))) {
                    $className = ucfirst($dirname) . ucfirst($pluginName) . 'Plugin';
                    $interface = ucfirst($pluginName) . 'PluginInterface';
                    $class     = new $className($dirname);
                    if ($class instanceof Userlog_Module_Plugin_Abstract && $class instanceof $interface) {
                        $plugins[$pluginName][$dirname] = $class;
                    }
                }
            }
        }

        return $plugins[$pluginName];
    }

    /**
     * @param      $file
     * @param bool $once
     *
     * @return bool
     */

    public static function loadFile($file, $once = true)
    {
        self::_securityCheck($file);
        if (self::fileExists($file)) {
            if ($once) {
                require_once $file;
            } else {
                include $file;
            }

            return true;
        }

        return false;
    }

    /**
     * @param $file
     *
     * @return mixed
     */

    public static function fileExists($file)
    {
        static $included = [];
        if (!isset($included[$file])) {
            $included[$file] = file_exists($file);
        }

        return $included[$file];
    }

    /**
     * @param $filename
     */
    protected static function _securityCheck($filename)
    {
        /**
         * Security check
         */
        if (preg_match('/[^a-z0-9\\/\\\\_.:-]/i', $filename)) {
            exit('Security check: Illegal character in filename');

        }
    }
}


1			<?php
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* @copyright XOOPS Project (https://xoops.org)
14			* @license http://www.fsf.org/copyleft/gpl.html GNU public license
15			* @author trabis <[email protected]>
16			*/
17			// irmtfan copy from xoops26 xoops_lib/Xoops/Module/plugin.php class
18			// change XoopsLoad -> self
19			// change $xoops -> $GLOBALS['xoops']
20			// change Userlog_Module_Plugin_Abstract , Userlog_Module_Plugin
21			// change $xoops->getActiveModules() -> xoops_getActiveModules()
22
23			class Userlog_Module_Plugin
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-28 18:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
24			{
25			/**
26			* @param string $dirname
27			* @param string $pluginName
28			* @param bool $force
29			*
30			* @return bool\|Xoops_Module_Plugin_Abstract false if plugin does not exist
31			*/
32			public static function getPlugin($dirname, $pluginName = 'system', $force = false)
33			{
34			$inactiveModules = false;
35			if ($force) {
36			$inactiveModules = [$dirname];
37			}
38			$available = self::getPlugins($pluginName, $inactiveModules);
39			if (!in_array($dirname, array_keys($available))) {
40			return false;
41			}
42
43			return $available[$dirname];
44			}
45
46			/**
47			* @param string $pluginName
48			* @param array\|bool $inactiveModules
49			*
50			* @return mixed
51			*/
52			public static function getPlugins($pluginName = 'system', $inactiveModules = false)
			0 ignored issues – show Coding Style introduced 2016-08-28 18:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this `getPlugins` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
53			{
54			static $plugins = [];
55			if (!isset($plugins[$pluginName])) {
56			$plugins[$pluginName] = [];
57			//$xoops = Xoops::getInstance();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-28 18:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58
59			//Load interface for this plugin
60			if (!self::loadFile($GLOBALS['xoops']->path("modules/{$pluginName}/class/plugin/interface.php"))) {
61			return $plugins[$pluginName];
62			}
63
64			$dirnames = xoops_getActiveModules();
65			if (is_array($inactiveModules)) {
66			$dirnames = array_merge($dirnames, $inactiveModules);
67			}
68			foreach ($dirnames as $dirname) {
69			if (self::loadFile($GLOBALS['xoops']->path("modules/{$dirname}/class/plugin/{$pluginName}.php"))
70			\|\| self::loadFile($GLOBALS['xoops']->path("modules/{$pluginName}/class/plugin/{$dirname}.php"))) {
71			$className = ucfirst($dirname) . ucfirst($pluginName) . 'Plugin';
72			$interface = ucfirst($pluginName) . 'PluginInterface';
73			$class = new $className($dirname);
74			if ($class instanceof Userlog_Module_Plugin_Abstract && $class instanceof $interface) {
75			$plugins[$pluginName][$dirname] = $class;
76			}
77			}
78			}
79			}
80
81			return $plugins[$pluginName];
82			}
83
84			/**
85			* @param $file
86			* @param bool $once
87			*
88			* @return bool
89			*/
90
91			public static function loadFile($file, $once = true)
92			{
93			self::_securityCheck($file);
94			if (self::fileExists($file)) {
95			if ($once) {
96			require_once $file;
97			} else {
98			include $file;
99			}
100
101			return true;
102			}
103
104			return false;
105			}
106
107			/**
108			* @param $file
109			*
110			* @return mixed
111			*/
112
113			public static function fileExists($file)
114			{
115			static $included = [];
116			if (!isset($included[$file])) {
117			$included[$file] = file_exists($file);
118			}
119
120			return $included[$file];
121			}
122
123			/**
124			* @param $filename
125			*/
126			protected static function _securityCheck($filename)
127			{
128			/**
129			* Security check
130			*/
131			if (preg_match('/[^a-z0-9\\/\\\\_.:-]/i', $filename)) {
132			exit('Security check: Illegal character in filename');
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-28 18:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `_securityCheck()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
133			}
134			}
135			}
136

XoopsModules25x / userlog

Issues (304)

Security Analysis not enabled

class/plugin/plugin.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like