importMydownloads()

Complexity

Conditions	11
Paths	136

Size

Total Lines	150
Code Lines	97

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php declare(strict_types=1);
function importMydownloads($path = '', $imgurl = '')
{
    $moduleDirName = basename(dirname(__DIR__));

    $ok = \Xmf\Request::getInt('ok', 0, 'POST');

    global $xoopsDB;

    if (1 === $ok) {
        //Vider les tables

        $myTables = ['tdmdownloads_broken', 'tdmdownloads_cat', 'tdmdownloads_downloads', 'tdmdownloads_fielddata', 'tdmdownloads_modfielddata', 'tdmdownloads_votedata'];

        $table = new TableLoad();

        $tables = new Tables();

        foreach ($myTables as $myTable) {
            if ($tables->useTable($myTable)) { // if this returns false, there is no table
                $table::truncateTable($myTable);
            }
        }

        //Inserer les données des catégories

        $query_topic = $xoopsDB->query('SELECT cid, pid, title, imgurl FROM ' . $xoopsDB->prefix('mydownloads_cat'));

        while (false !== ($donnees = $xoopsDB->fetchArray($query_topic))) {
            if ('' === $donnees['imgurl']) {
                $img = 'blank.gif';
            } else {
                $img = substr_replace($donnees['imgurl'], '', 0, mb_strlen($imgurl));

                @copy($path . $img, XOOPS_ROOT_PATH . '/uploads/' . $moduleDirName . '/images/cats/' . $img);

It seems like you do not handle an error condition for copy(). This can introduce security issues, and is generally not recommended.

Are you sure $img of type array|string can be used in concatenation?

            }

            $title = $donnees['title'];

            $insert = $xoopsDB->queryF('INSERT INTO ' . $xoopsDB->prefix('tdmdownloads_cat') . " (cat_cid, cat_pid, cat_title, cat_imgurl, cat_description_main, cat_weight ) VALUES ('" . $donnees['cid'] . "', '" . $donnees['pid'] . "', '" . $title . "', '" . $img . "', '', '0')");

            if (!$insert) {
                $errors[] = ['title' => _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA, 'info' => $donnees['title']];
            }

            $successes[] = sprintf(_AM_TDMDOWNLOADS_IMPORT_CAT_IMP, $donnees['title']);
        }

        echo '<br>';

        //Inserer les données des téléchargemnts

        $query_links = $xoopsDB->query('SELECT lid, cid, title, url, homepage, version, size, platform, logourl, submitter, status, date, hits, rating, votes, comments FROM ' . $xoopsDB->prefix('mydownloads_downloads'));

        while (false !== ($donnees = $xoopsDB->fetchArray($query_links))) {
            //On recupere la description

            $requete = $xoopsDB->queryF('SELECT description FROM ' . $xoopsDB->prefix('mydownloads_text') . " WHERE lid = '" . $donnees['lid'] . "'");

            [$description] = $xoopsDB->fetchRow($requete);

            $insert = $xoopsDB->queryF(
                'INSERT INTO '
                . $xoopsDB->prefix('tdmdownloads_downloads')
                . " (
            lid, cid, title, url, homepage, version, size, platform, description, logourl, submitter, status, date, hits, rating, votes, comments, top) VALUES
            ('"
                . $donnees['lid']
                . "', '"
                . $donnees['cid']
                . "', '"
                . $donnees['title']
                . "', '"
                . $donnees['url']
                . "', '"
                . $donnees['homepage']
                . "', '"
                . $donnees['version']
                . "', '"
                . $donnees['size']
                . "', '"
                . $donnees['platform']
                . "', '"
                . $description
                . "',  '"
                . $donnees['logourl']
                . "', '"
                . $donnees['submitter']
                . "', '"
                . $donnees['status']
                . "', '"
                . $donnees['date']
                . "', '"
                . $donnees['hits']
                . "', '"
                . $donnees['rating']
                . "', '"
                . $donnees['votes']
                . "', '0', '0' )"
            );

            if (!$insert) {
                $errors[] = ['title' => _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA, 'info' => $donnees['title']];
            }

            $successes[] = sprintf(_AM_TDMDOWNLOADS_IMPORT_DOWNLOADS_IMP, $donnees['title']);

            @copy($path . $donnees['logourl'], XOOPS_ROOT_PATH . '/uploads/' . $moduleDirName . '/images/shots/' . $donnees['logourl']);
        }

        echo '<br>';

        //Inserer les données des votes

        $query_vote = $xoopsDB->query('SELECT ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp FROM ' . $xoopsDB->prefix('mydownloads_votedata'));

        while (false !== ($donnees = $xoopsDB->fetchArray($query_vote))) {
            $insert = $xoopsDB->queryF(
                'INSERT INTO '
                . $xoopsDB->prefix('tdmdownloads_votedata')
                . " (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp ) VALUES ('"
                . $donnees['ratingid']
                . "', '"
                . $donnees['lid']
                . "', '"
                . $donnees['ratinguser']
                . "', '"
                . $donnees['rating']
                . "', '"
                . $donnees['ratinghostname']
                . "', '"
                . $donnees['ratingtimestamp']
                . "')"
            );

            if (!$insert) {
                $errors[] = ['title' => _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA, 'info' => $donnees['ratingid']];
            }

            $successes[] = sprintf(_AM_TDMDOWNLOADS_IMPORT_VOTE_IMP, $donnees['ratingid']);
        }

        echo '<br><br>';

        echo "<div class='errorMsg'>";

        echo _AM_TDMDOWNLOADS_IMPORT_OK;

        echo '</div>';
    } else {
        xoops_confirm(['op' => 'importMydownloads', 'ok' => 1, 'path' => $path, 'imgurl' => $imgurl], 'import.php', _AM_TDMDOWNLOADS_IMPORT_CONF_MYDOWNLOADS . '<br>');
    }