install.php ➔ xoops_module_install_tdmdownloads() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/tdmdownloads - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c39b68...a1acf8 )

by Michael

created 2016-06-01 04:05 UTC

install.php ➔ xoops_module_install_tdmdownloads() D

↳ Parent: Project

Complexity

Conditions	8
Paths	128

Size

Total Lines	102
Code Lines	80

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	8
eloc	80
c	2
b	0
f	1
nc	128
nop	0
dl	0
loc	102
rs	4.606

How to fix Long Method

<?php
/**
 * TDMDownload
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright   Gregory Mage (Aka Mage)
 * @license     GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @author      Gregory Mage (Aka Mage)
 */

function xoops_module_install_tdmdownloads() {
    global $xoopsModule, $xoopsConfig, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    $namemodule = "TDMDownloads";
    if( file_exists(XOOPS_ROOT_PATH."/modules/".$namemodule."/language/".$xoopsConfig['language']."/admin.php") ) {
        include_once(XOOPS_ROOT_PATH."/modules/".$namemodule."/language/".$xoopsConfig['language']."/admin.php");
    } else {
        include_once(XOOPS_ROOT_PATH."/modules/".$namemodule."/language/english/admin.php");
    }
    $downloadsfield_Handler =& xoops_getModuleHandler('tdmdownloads_field', 'TDMDownloads');
    $obj =& $downloadsfield_Handler->create();
    $obj->setVar('title', _AM_TDMDOWNLOADS_FORMHOMEPAGE);
    $obj->setVar('img', 'homepage.png');
    $obj->setVar('weight', 1);
    $obj->setVar('search', 0);
    $obj->setVar('status', 1);
    $obj->setVar('status_def', 1);
    $downloadsfield_Handler->insert($obj);
    $obj =& $downloadsfield_Handler->create();
    $obj->setVar('title', _AM_TDMDOWNLOADS_FORMVERSION);
    $obj->setVar('img', 'version.png');
    $obj->setVar('weight', 2);
    $obj->setVar('search', 0);
    $obj->setVar('status', 1);
    $obj->setVar('status_def', 1);
    $downloadsfield_Handler->insert($obj);
    $obj =& $downloadsfield_Handler->create();
    $obj->setVar('title', _AM_TDMDOWNLOADS_FORMSIZE);
    $obj->setVar('img', 'size.png');
    $obj->setVar('weight', 3);
    $obj->setVar('search', 0);
    $obj->setVar('status', 1);
    $obj->setVar('status_def', 1);
    $downloadsfield_Handler->insert($obj);
    $obj =& $downloadsfield_Handler->create();
    $obj->setVar('title', _AM_TDMDOWNLOADS_FORMPLATFORM);
    $obj->setVar('img', 'platform.png');
    $obj->setVar('weight', 4);
    $obj->setVar('search', 0);
    $obj->setVar('status', 1);
    $obj->setVar('status_def', 1);
    $downloadsfield_Handler->insert($obj);

    //Creation du fichier ".$namemodule."/
    $dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."";
    if(!is_dir($dir))
        mkdir($dir, 0777);
        chmod($dir, 0777);

    //Creation du fichier ".$namemodule."/images/
    $dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/images";
    if(!is_dir($dir))
        mkdir($dir, 0777);
        chmod($dir, 0777);

    //Creation du fichier ".$namemodule."/images/cat
    $dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/cats";
    if(!is_dir($dir))
        mkdir($dir, 0777);
        chmod($dir, 0777);

    //Creation du fichier ".$namemodule."/images/shots
    $dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/shots";
    if(!is_dir($dir))
        mkdir($dir, 0777);
        chmod($dir, 0777);

    //Creation du fichier ".$namemodule."/images/field
    $dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field";
    if(!is_dir($dir))
        mkdir($dir, 0777);
        chmod($dir, 0777);

    //Creation du fichier ".$namemodule."/downloads
    $dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/downloads";
    if(!is_dir($dir))
        mkdir($dir, 0777);
        chmod($dir, 0777);

    //Copie des index.html
    $indexFile = XOOPS_ROOT_PATH."/modules/".$namemodule."/include/index.html";
    copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/index.html");
    copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/index.html");
    copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/cats/index.html");
    copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/shots/index.html");
    copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/index.html");
    copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/downloads/index.html");

    //Copie des blank.gif
    $blankFile = XOOPS_ROOT_PATH."/modules/".$namemodule."/images/blank.gif";
    copy($blankFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/cats/blank.gif");
    copy($blankFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/shots/blank.gif");
    copy($blankFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/blank.gif");

    //Copie des images pour les champs
    copy(XOOPS_ROOT_PATH."/modules/".$namemodule."/images/icon/homepage.png", XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/homepage.png");
    copy(XOOPS_ROOT_PATH."/modules/".$namemodule."/images/icon/version.png", XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/version.png");
    copy(XOOPS_ROOT_PATH."/modules/".$namemodule."/images/icon/size.png", XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/size.png");
    copy(XOOPS_ROOT_PATH."/modules/".$namemodule."/images/icon/platform.png", XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/platform.png");

    return true;
}


Push — master ( c39b68...a1acf8 )

install.php ➔ xoops_module_install_tdmdownloads() D

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* TDMDownload
4			*
5			* You may not change or alter any portion of this comment or credits
6			* of supporting developers from this source code or any supporting source code
7			* which is considered copyrighted (c) material of the original comment or credit authors.
8			* This program is distributed in the hope that it will be useful,
9			* but WITHOUT ANY WARRANTY; without even the implied warranty of
10			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11			*
12			* @copyright Gregory Mage (Aka Mage)
13			* @license GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
14			* @author Gregory Mage (Aka Mage)
15			*/
16
17			function xoops_module_install_tdmdownloads() {
18			global $xoopsModule, $xoopsConfig, $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:17 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
19
20			$namemodule = "TDMDownloads";
21			if( file_exists(XOOPS_ROOT_PATH."/modules/".$namemodule."/language/".$xoopsConfig['language']."/admin.php") ) {
22			include_once(XOOPS_ROOT_PATH."/modules/".$namemodule."/language/".$xoopsConfig['language']."/admin.php");
23			} else {
24			include_once(XOOPS_ROOT_PATH."/modules/".$namemodule."/language/english/admin.php");
25			}
26			$downloadsfield_Handler =& xoops_getModuleHandler('tdmdownloads_field', 'TDMDownloads');
27			$obj =& $downloadsfield_Handler->create();
28			$obj->setVar('title', _AM_TDMDOWNLOADS_FORMHOMEPAGE);
29			$obj->setVar('img', 'homepage.png');
30			$obj->setVar('weight', 1);
31			$obj->setVar('search', 0);
32			$obj->setVar('status', 1);
33			$obj->setVar('status_def', 1);
34			$downloadsfield_Handler->insert($obj);
35			$obj =& $downloadsfield_Handler->create();
36			$obj->setVar('title', _AM_TDMDOWNLOADS_FORMVERSION);
37			$obj->setVar('img', 'version.png');
38			$obj->setVar('weight', 2);
39			$obj->setVar('search', 0);
40			$obj->setVar('status', 1);
41			$obj->setVar('status_def', 1);
42			$downloadsfield_Handler->insert($obj);
43			$obj =& $downloadsfield_Handler->create();
44			$obj->setVar('title', _AM_TDMDOWNLOADS_FORMSIZE);
45			$obj->setVar('img', 'size.png');
46			$obj->setVar('weight', 3);
47			$obj->setVar('search', 0);
48			$obj->setVar('status', 1);
49			$obj->setVar('status_def', 1);
50			$downloadsfield_Handler->insert($obj);
51			$obj =& $downloadsfield_Handler->create();
52			$obj->setVar('title', _AM_TDMDOWNLOADS_FORMPLATFORM);
53			$obj->setVar('img', 'platform.png');
54			$obj->setVar('weight', 4);
55			$obj->setVar('search', 0);
56			$obj->setVar('status', 1);
57			$obj->setVar('status_def', 1);
58			$downloadsfield_Handler->insert($obj);
59
60			//Creation du fichier ".$namemodule."/
61			$dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."";
62			if(!is_dir($dir))
63			mkdir($dir, 0777);
64			chmod($dir, 0777);
65
66			//Creation du fichier ".$namemodule."/images/
67			$dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/images";
68			if(!is_dir($dir))
69			mkdir($dir, 0777);
70			chmod($dir, 0777);
71
72			//Creation du fichier ".$namemodule."/images/cat
73			$dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/cats";
74			if(!is_dir($dir))
75			mkdir($dir, 0777);
76			chmod($dir, 0777);
77
78			//Creation du fichier ".$namemodule."/images/shots
79			$dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/shots";
80			if(!is_dir($dir))
81			mkdir($dir, 0777);
82			chmod($dir, 0777);
83
84			//Creation du fichier ".$namemodule."/images/field
85			$dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field";
86			if(!is_dir($dir))
87			mkdir($dir, 0777);
88			chmod($dir, 0777);
89
90			//Creation du fichier ".$namemodule."/downloads
91			$dir = XOOPS_ROOT_PATH."/uploads/".$namemodule."/downloads";
92			if(!is_dir($dir))
93			mkdir($dir, 0777);
94			chmod($dir, 0777);
95
96			//Copie des index.html
97			$indexFile = XOOPS_ROOT_PATH."/modules/".$namemodule."/include/index.html";
98			copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/index.html");
99			copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/index.html");
100			copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/cats/index.html");
101			copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/shots/index.html");
102			copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/index.html");
103			copy($indexFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/downloads/index.html");
104
105			//Copie des blank.gif
106			$blankFile = XOOPS_ROOT_PATH."/modules/".$namemodule."/images/blank.gif";
107			copy($blankFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/cats/blank.gif");
108			copy($blankFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/shots/blank.gif");
109			copy($blankFile, XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/blank.gif");
110
111			//Copie des images pour les champs
112			copy(XOOPS_ROOT_PATH."/modules/".$namemodule."/images/icon/homepage.png", XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/homepage.png");
113			copy(XOOPS_ROOT_PATH."/modules/".$namemodule."/images/icon/version.png", XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/version.png");
114			copy(XOOPS_ROOT_PATH."/modules/".$namemodule."/images/icon/size.png", XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/size.png");
115			copy(XOOPS_ROOT_PATH."/modules/".$namemodule."/images/icon/platform.png", XOOPS_ROOT_PATH."/uploads/".$namemodule."/images/field/platform.png");
116
117			return true;
118			}
119

XoopsModules25x / tdmdownloads

Push — master ( c39b68...a1acf8 )

install.php ➔ xoops_module_install_tdmdownloads() D

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like