import.php ➔ Import_mydownloads() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/tdmdownloads - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( c39b68...a1acf8 )

by Michael
created 2016-06-01 04:05 UTC
import.php ➔ Import_mydownloads() C

↳ Parent: Project
Complexity

Conditions	10
Paths	92
Size

Total Lines	64
Code Lines	46
Duplication

Lines	13
Ratio	20.31 %
Importance

Changes	3
Bugs	0	Features	0
Metric	Value
cc	10
eloc	46
c	3
b	0
f	0
nc	92
nop	2
dl	13
loc	64
rs	6.309
How to fix Long Method Complexity

<?php

/**
 * TDMDownload
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright   Gregory Mage (Aka Mage)
 * @license     GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @author      Gregory Mage (Aka Mage)
 */

include 'admin_header.php';
xoops_cp_header();
if (TDMDownloads_checkModuleAdmin()) {
    $import_admin = new ModuleAdmin();
    echo $import_admin->addNavigation('import.php');
}
//Action dans switch
if (isset($_REQUEST['op'])) {
    $op = $_REQUEST['op'];
} else {
    $op = 'index';
}

// import depuis mydownloads
function Import_mydownloads($path='', $imgurl='')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    $ok =  isset($_POST['ok']) ? intval($_POST['ok']) : 0;
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    if ($ok == 1) {
        //Vider les tables
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_broken"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_cat"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_downloads"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_fielddata"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_modfielddata"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_votedata"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //Inserer les donn�es des cat�gories
        $query_topic = $xoopsDB->query("SELECT cid, pid, title, imgurl FROM ".$xoopsDB->prefix("mydownloads_cat"));
        while ($donnees = $xoopsDB->fetchArray($query_topic)) {
            if ($donnees['imgurl'] == "") {
                $img = "blank.gif";
            } else {
                $img = substr_replace($donnees['imgurl'],'',0,strlen($imgurl));
                @copy($path . $img, XOOPS_ROOT_PATH . "/uploads/TDMDownloads/images/cats/" . $img);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }

            $title = $donnees['title'];
            $insert = $xoopsDB->queryF("INSERT INTO ".$xoopsDB->prefix("tdmdownloads_cat")." (cat_cid, cat_pid, cat_title, cat_imgurl, cat_description_main, cat_weight ) VALUES ('".$donnees['cid']."', '".$donnees['pid']."', '".$title."', '".$img."', '', '0')");
            if (!$insert) {

                echo "<font color='red'>" . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA .": </font> " . $donnees['title'] . "<br>";
            }
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_CAT_IMP . '<br/>', $donnees['title']);
        }
        echo '<br/>';

        //Inserer les donnees des t�l�chargemnts
        $query_links = $xoopsDB->query("SELECT lid, cid, title, url, homepage, version, size, platform, logourl, submitter, status, date, hits, rating, votes, comments FROM ".$xoopsDB->prefix("mydownloads_downloads"));
        while ($donnees = $xoopsDB->fetchArray($query_links)) {
            //On recupere la description
            $requete = $xoopsDB->queryF("SELECT description FROM ".$xoopsDB->prefix("mydownloads_text")." WHERE lid = '".$donnees['lid']."'");
            list ($description) = $xoopsDB -> fetchRow($requete);
            $insert = $xoopsDB->queryF("INSERT INTO ".$xoopsDB->prefix("tdmdownloads_downloads")." (
            lid, cid, title, url, homepage, version, size, platform, description, logourl, submitter, status, date, hits, rating, votes, comments, top) VALUES
            ('".$donnees['lid']."', '".$donnees['cid']."', '".$donnees['title']."', '".$donnees['url']."', '".$donnees['homepage']."', '".$donnees['version']."', '".$donnees['size']."', '".$donnees['platform']."', '".$description."',  '".$donnees['logourl']."', '".$donnees['submitter']."', '".$donnees['status']."', '".$donnees['date']."', '".$donnees['hits']."', '".$donnees['rating']."', '".$donnees['votes']."', '0', '0' )");
            if (!$insert) {

                echo "<font color='red'>" . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA .": </font> " . $donnees['title'] . "<br>";
            }
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_DOWNLOADS_IMP . '<br/>', $donnees['title']);
            @copy($path . $donnees['logourl'], XOOPS_ROOT_PATH . "/uploads/TDMDownloads/images/shots/" . $donnees['logourl']);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        echo '<br/>';
        //Inserer les donnees des votes
        $query_vote = $xoopsDB->query("SELECT ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp FROM ".$xoopsDB->prefix("mydownloads_votedata"));
        while ($donnees = $xoopsDB->fetchArray($query_vote)) {

            $insert = $xoopsDB->queryF("INSERT INTO ".$xoopsDB->prefix("tdmdownloads_votedata")." (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp ) VALUES ('".$donnees['ratingid']."', '".$donnees['lid']."', '".$donnees['ratinguser']."', '".$donnees['rating']."', '".$donnees['ratinghostname']."', '". $donnees['ratingtimestamp']."')");
            if (!$insert) {
                echo "<font color='red'>" . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA .": </font> " . $donnees['ratingid'] . "<br>";
            }
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_VOTE_IMP . '<br/>', $donnees['ratingid']);
        }
        echo "<br><br>";
        echo "<div class='errorMsg'>";
        echo _AM_TDMDOWNLOADS_IMPORT_OK;
        echo "</div>";
    } else {
        xoops_confirm(array('op' => 'import_mydownloads', 'ok' => 1, 'path' => $path, 'imgurl' => $imgurl), 'import.php', _AM_TDMDOWNLOADS_IMPORT_CONF_MYDOWNLOADS . '<br>');
    }
}

// import depuis WF-Downloads
function Import_wfdownloads($shots='', $catimg='')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    $ok =  isset($_POST['ok']) ? intval($_POST['ok']) : 0;
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    if ($ok == 1) {
        //Vider les tables
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_broken"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_cat"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_downloads"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_fielddata"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_modfielddata"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_votedata"));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //Inserer les donn�es des cat�gories
        $query_topic = $xoopsDB->query("SELECT cid, pid, title, imgurl, description, total, summary, spotlighttop, spotlighthis, dohtml, dosmiley, doxcode, doimage, dobr, weight, formulize_fid FROM ".$xoopsDB->prefix("wfdownloads_cat"));
        while ($donnees = $xoopsDB->fetchArray($query_topic)) {
            if ($donnees['imgurl'] == "") {
                $img = "blank.gif";
            } else {
                $img = $donnees['imgurl'];
                @copy($catimg . $img, XOOPS_ROOT_PATH . "/uploads/TDMDownloads/images/cats/" . $img);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
            $insert = $xoopsDB->queryF("INSERT INTO ".$xoopsDB->prefix("tdmdownloads_cat")." (cat_cid, cat_pid, cat_title, cat_imgurl, cat_description_main, cat_weight ) VALUES ('".$donnees['cid']."', '".$donnees['pid']."', '".$donnees['title']."', '".$img."', '".addcslashes($donnees['description'],"'")."', '".$donnees['weight']."')");
            if (!$insert) {

                echo "<font color='red'>" . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA .": </font> " . $donnees['title'] . "<br>";
            }
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_CAT_IMP . '<br/>', $donnees['title']);
        }
        echo '<br/>';

        //Inserer les donnees des t�l�chargemnts
        $query_links = $xoopsDB->query("SELECT lid, cid, title, url, filename, filetype, homepage, version, size, platform, screenshot, screenshot2, screenshot3, screenshot4, submitter, publisher, status, date, hits, rating, votes, comments, license, mirror, price, paypalemail, features, requirements, homepagetitle, forumid, limitations, versiontypes, dhistory, published, expired, updated, offline, summary, description, ipaddress, notifypub, formulize_idreq  FROM ".$xoopsDB->prefix("wfdownloads_downloads"));
        while ($donnees = $xoopsDB->fetchArray($query_links)) {
            if ($donnees['url']=='') {
                $newurl = XOOPS_URL . '/uploads/' . $donnees['filename'];
            } else {
                $newurl = $donnees['url'];
            }
            $insert = $xoopsDB->queryF("INSERT INTO ".$xoopsDB->prefix("tdmdownloads_downloads")." (
            lid, cid, title, url, homepage, version, size, platform, description, logourl, submitter, status, date, hits, rating, votes, comments, top) VALUES
            ('".$donnees['lid']."', '".$donnees['cid']."', '".$donnees['title']."', '".$newurl."', '".$donnees['homepage']."', '".$donnees['version']."', '".$donnees['size']."', '".$donnees['platform']."', '".addcslashes($donnees['description'],"'")."',  '".$donnees['screenshot']."', '".$donnees['submitter']."', '".$donnees['status']."', '".$donnees['date']."', '".$donnees['hits']."', '".$donnees['rating']."', '".$donnees['votes']."', '0', '0' )");

            if (!$insert) {

                echo "<font color='red'>" . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA .": </font> " . $donnees['title'] . "<br>";
            }
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_DOWNLOADS_IMP . '<br/>', $donnees['title']);
            @copy($shots . $donnees['screenshot'], XOOPS_ROOT_PATH . "/uploads/TDMDownloads/images/shots/" . $donnees['screenshot']);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        echo '<br/>';

        //Inserer les donnees des votes
        $query_vote = $xoopsDB->query("SELECT ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp FROM ".$xoopsDB->prefix("wfdownloads_votedata"));
        while ($donnees = $xoopsDB->fetchArray($query_vote)) {

            $insert = $xoopsDB->queryF("INSERT INTO ".$xoopsDB->prefix("tdmdownloads_votedata")." (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp ) VALUES ('".$donnees['ratingid']."', '".$donnees['lid']."', '".$donnees['ratinguser']."', '".$donnees['rating']."', '".$donnees['ratinghostname']."', '". $donnees['ratingtimestamp']."')");
            if (!$insert) {
                echo "<font color='red'>" . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA .": </font> " . $donnees['ratingid'] . "<br>";
            }
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_VOTE_IMP . '<br/>', $donnees['ratingid']);
        }
        echo "<br><br>";
        echo "<div class='errorMsg'>";
        echo _AM_TDMDOWNLOADS_IMPORT_OK;
        echo "</div>";
    } else {
        xoops_confirm(array('op' => 'import_wfdownloads', 'ok' => 1, 'shots' => $shots, 'catimg' => $catimg), 'import.php', _AM_TDMDOWNLOADS_IMPORT_CONF_WFDOWNLOADS . '<br>');
    }
}

switch ($op) {
    case "index":
        default:
        echo "<br><br>";
        echo "<div class='errorMsg'>";
        echo _AM_TDMDOWNLOADS_IMPORT_WARNING;
        echo "</div>";
        echo "<br><br>";
        if (TDMDownloads_checkModuleAdmin()) {
            $a_admin = new ModuleAdmin();
            $a_admin->addItemButton(_AM_TDMDOWNLOADS_IMPORT_MYDOWNLOADS, 'import.php?op=form_mydownloads', 'add');
            $a_admin->addItemButton(_AM_TDMDOWNLOADS_IMPORT_WFDOWNLOADS, 'import.php?op=form_wfdownloads', 'add');
            echo $a_admin->renderButton("center");
        }
    break;

    // import Mydownloads
    case "import_mydownloads":
        if ($_REQUEST['path'] == '' || $_REQUEST['imgurl'] == '') {
            redirect_header('import.php?op=form_mydownloads', 3, _AM_TDMDOWNLOADS_IMPORT_ERREUR);
        } else {
            Import_mydownloads($_REQUEST['path'],$_REQUEST['imgurl']);
        }
    break;

    case "form_mydownloads":

        echo "<br><br>";
        echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_TDMDOWNLOADS_IMPORT_NUMBER . "</legend>";
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        $query = $xoopsDB->query("SELECT COUNT(lid) as count FROM ".$xoopsDB->prefix("mydownloads_downloads"));
        list( $count_downloads ) = $xoopsDB->fetchRow( $query ) ;
        if ($count_downloads < 1) {
            echo _AM_TDMDOWNLOADS_IMPORT_DONT_DOWNLOADS . "<br />";
        } else {
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_NB_DOWNLOADS, $count_downloads);
        }
        $query = $xoopsDB->query("SELECT COUNT(cid) as count FROM ".$xoopsDB->prefix("mydownloads_cat"));
        list( $count_topic ) = $xoopsDB->fetchRow( $query ) ;
        if ($count_topic < 1) {
            echo ""._AM_TDMDOWNLOADS_IMPORT_DONT_TOPIC."<br>";
        } else {
            echo sprintf('<br/>' . _AM_TDMDOWNLOADS_IMPORT_NB_CAT, $count_topic);
        }
        echo "</fieldset>";
        echo "<br><br>";
        echo "<table width='100%' border='0'>
                <form action='import.php?op=import_mydownloads' method=POST>
                <tr>
                    <td  class='even'>" . _AM_TDMDOWNLOADS_IMPORT_MYDOWNLOADS_PATH . "</td>
                    <td  class='odd'><input type='text' name='path' id='import_data' size='100' value='" . XOOPS_ROOT_PATH . "/modules/mydownloads/images/shots/' /></td>
                </tr>
                <tr>
                    <td  class='even'>" . _AM_TDMDOWNLOADS_IMPORT_MYDOWNLOADS_URL . "</td>
                    <td  class='odd'><input type='text' name='imgurl' id='import_data' size='100' value='" . XOOPS_URL . "/modules/mydownloads/images/shots/' /></td>
                </tr>
                <tr>
                    <td  class='even'>" . _AM_TDMDOWNLOADS_IMPORT_DOWNLOADS . "</td>
                    <td  class='odd'><input type='submit' name='button' id='import_data' value='" . _AM_TDMDOWNLOADS_IMPORT1 . "'></td>
                </tr>
                </form>
            </table>";
    break;

    // import WF-Downloads
    case "import_wfdownloads":
        if ($_REQUEST['shots'] == '' || $_REQUEST['catimg'] == '') {
            redirect_header('import.php?op=form_wfdownloads', 3, _AM_TDMDOWNLOADS_IMPORT_ERREUR);
        } else {
            Import_wfdownloads($_REQUEST['shots'],$_REQUEST['catimg']);
        }
    break;

    case "form_wfdownloads":

        echo "<br><br>";
        echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_TDMDOWNLOADS_IMPORT_NUMBER . "</legend>";
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        $query = $xoopsDB->query("SELECT COUNT(lid) as count FROM ".$xoopsDB->prefix("wfdownloads_downloads"));
        list( $count_downloads ) = $xoopsDB->fetchRow( $query ) ;
        if ($count_downloads < 1) {
            echo _AM_TDMDOWNLOADS_IMPORT_DONT_DOWNLOADS . "<br />";
        } else {
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_NB_DOWNLOADS, $count_downloads);
        }
        $query = $xoopsDB->query("SELECT COUNT(cid) as count FROM ".$xoopsDB->prefix("wfdownloads_cat"));
        list( $count_topic ) = $xoopsDB->fetchRow( $query ) ;
        if ($count_topic < 1) {
            echo ""._AM_TDMDOWNLOADS_IMPORT_DONT_TOPIC."<br>";
        } else {
            echo sprintf('<br/>' . _AM_TDMDOWNLOADS_IMPORT_NB_CAT, $count_topic);
        }
        echo "</fieldset>";
        echo "<br><br>";
        echo "<table width='100%' border='0'>
                <form action='import.php?op=import_wfdownloads' method=POST>
                <tr>
                    <td  class='even'>" . _AM_TDMDOWNLOADS_IMPORT_WFDOWNLOADS_SHOTS . "</td>
                    <td  class='odd'><input type='text' name='shots' id='import_data' size='100' value='" . XOOPS_ROOT_PATH . "/modules/wfdownloads/images/screenshots/' /></td>
                </tr>
                <tr>
                    <td  class='even'>" . _AM_TDMDOWNLOADS_IMPORT_WFDOWNLOADS_CATIMG . "</td>
                    <td  class='odd'><input type='text' name='catimg' id='import_data' size='100' value='" . XOOPS_ROOT_PATH . "/modules/wfdownloads/images/category/' /></td>
                </tr>
                <tr>
                    <td  class='even'>" . _AM_TDMDOWNLOADS_IMPORT_DOWNLOADS . "</td>
                    <td  class='odd'><input type='submit' name='button' id='import_data' value='" . _AM_TDMDOWNLOADS_IMPORT1 . "'></td>
                </tr>
                </form>
            </table>";
    break;
}

xoops_cp_footer();

Push — master ( c39b68...a1acf8 )

import.php ➔ Import_mydownloads() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

XoopsModules25x / tdmdownloads

Push — master ( c39b68...a1acf8 )

import.php ➔ Import_mydownloads() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
