XoopsModules\Tdmdownloads\Form\UploadForm::__construct()

Complexity

Conditions	6
Paths	8

Size

Total Lines	55
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php namespace XoopsModules\Tdmdownloads\Form;
    public function __construct($target)
    {
        $moduleDirName      = basename(dirname(dirname(__DIR__)));
        $moduleDirNameUpper = mb_strtoupper($moduleDirName);
        /** @var  \XoopsModules\Tdmdownloads\Helper $this->helper */
        $this->helper       = $target->helper;
        $this->targetObject = $target;

        $title = $this->targetObject->isNew() ? sprintf(constant('CO_' . $moduleDirNameUpper . '_' . 'FIELD_ADD')) : sprintf(constant('CO_' . $moduleDirNameUpper . '_' . 'FIELD_EDIT'));

The assignment to $title is dead and can be removed.

        parent::__construct('', 'form', xoops_getenv('PHP_SELF'), 'post', true);
        $this->setExtra('enctype="multipart/form-data"');

        //include ID field, it's needed so the module knows if it is a new form or an edited form

        $hidden = new \XoopsFormHidden('fid', $this->targetObject->getVar('cat_cid'));

It seems like $this->targetObject->getVar('cat_cid') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

        $this->addElement($hidden);
        unset($hidden);


        $categoryHandler = new \XoopsModules\Tdmdownloads\CategoryHandler();
        $start = Request::getInt('start', 0);
        $catPaginationLimit = $this->helper->getConfig('userpager') ?: 10;

        $criteria = new \CriteriaCompo();
        $criteria->setOrder('DESC');
        $criteria->setLimit($catPaginationLimit);
        $criteria->setStart($start);

        $catCount = $categoryHandler->getCount($criteria);

The assignment to $catCount is dead and can be removed.

        $catArray = $categoryHandler->getAll($criteria);

        // Form Select Category
        $categoryIdSelect = new \XoopsFormSelect( constant('CO_' . $moduleDirNameUpper . '_' . 'SELECT'), 'cat_title', $this->targetObject->getVar('cat_cid'));
        $categoryIdSelect->setExtra('onchange="submit()"');
//        $categoryIdSelect->addOption(0, ' ');

        foreach(array_keys($catArray) as $i) {
            $catName = $catArray[$i]->getVar('cat_title');
            $catPid = $catArray[$i]->getVar('cat_pid');
            if ( 0 < $catPid ) {
                $categoryObj = $categoryHandler->get($catPid);
                if (is_object( $categoryObj)) {
                    $catName .= ' (' . $categoryObj->getVar('cat_title') . ')';
                } else {
                    $catName .= ' (' . constant('CO_' . $moduleDirNameUpper . '_' . 'ERROR_CATPID') . ')';
                }
            }
            $categoryIdSelect->addOption($catArray[$i]->getVar('cat_cid'), $catName);
        }

        $this->addElement($categoryIdSelect);
        unset($categoryCriteria);

The variable $categoryCriteria seems to be never defined.

        $this->addElement(new \XoopsFormHidden('start', 0));
        $this->addElement(new \XoopsFormHidden('limit', 0));
    }