XoopsModules\Tdmdownloads\Common\Images::getFormImages()

Complexity

Conditions	12
Paths	2048

Size

Total Lines	153
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php declare(strict_types=1);
    public function getFormImages($action = false)
    {
        $moduleDirName = \basename(dirname(__DIR__, 2));

        $moduleDirNameUpper = \mb_strtoupper($moduleDirName);

        $helper = Helper::getInstance();

        if (!$action) {
            $action = $_SERVER['REQUEST_URI'];
        }

        // Title

        $title = $this->isNew() ? \sprintf(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_ADD')) : \sprintf(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_EDIT'));

        // Get Theme Form

        \xoops_load('XoopsFormLoader');

        $form = new \XoopsThemeForm($title, 'form', $action, 'post', true);

        $form->setExtra('enctype="multipart/form-data"');

        // Form Text ImgTitle

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_TITLE'), 'img_title', 50, 255, $this->getVar('img_title')));

It seems like $this->getVar('img_title') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

        // Form editor ImgDesc

        $editorConfigs = [];

        $editorConfigs['name'] = 'img_desc';

        $editorConfigs['value'] = $this->getVar('img_desc', 'e');

        $editorConfigs['rows'] = 5;

        $editorConfigs['cols'] = 40;

        $editorConfigs['width'] = '100%';

        $editorConfigs['height'] = '400px';

        $editorConfigs['editor'] = $helper->getConfig('editor');

        $form->addElement(new \XoopsFormEditor(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_DESC'), 'img_desc', $editorConfigs));

        // Form Text ImgName

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_NAME'), 'img_name', 50, 255, $this->getVar('img_name')), true);

        // Form Text ImgNameLarge

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_NAMELARGE'), 'img_namelarge', 50, 255, $this->getVar('img_namelarge')), true);

        // Form Text ImgOrigname

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_NAMEORIG'), 'img_nameorig', 50, 255, $this->getVar('img_nameorig')), true);

        // Form Text ImgMimetype

        $imgMimetype = $this->isNew() ? '0' : $this->getVar('img_mimetype');

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_MIMETYPE'), 'img_mimetype', 20, 150, $imgMimetype));

        // Form Text ImgSize

        $imgSize = $this->isNew() ? '0' : $this->getVar('img_size');

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_SIZE'), 'img_size', 20, 150, $imgSize));

        // Form Text ImgResx

        $imgResx = $this->isNew() ? '0' : $this->getVar('img_resx');

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_RESX'), 'img_resx', 20, 150, $imgResx));

        // Form Text ImgResy

        $imgResy = $this->isNew() ? '0' : $this->getVar('img_resy');

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_RESY'), 'img_resy', 20, 150, $imgResy));

        // Form Text ImgDownloads

        $imgDownloads = $this->isNew() ? '0' : $this->getVar('img_downloads');

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_DOWNLOADS'), 'img_downloads', 20, 150, $imgDownloads));

        // Form Text ImgRatinglikes

        $imgRatinglikes = $this->isNew() ? '0' : $this->getVar('img_ratinglikes');

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_RATINGLIKES'), 'img_ratinglikes', 20, 150, $imgRatinglikes));

        // Form Text ImgVotes

        $imgVotes = $this->isNew() ? '0' : $this->getVar('img_votes');

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_VOTES'), 'img_votes', 20, 150, $imgVotes));

        // Form Text ImgWeight

        $imgWeight = $this->isNew() ? '0' : $this->getVar('img_weight');

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_WEIGHT'), 'img_weight', 20, 150, $imgWeight));

        // Form Table albums

        $albumsHandler = $helper->getHandler('Albums');

        $imgAlbidSelect = new \XoopsFormSelect(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_ALBID'), 'img_albid', $this->getVar('img_albid'));

        $imgAlbidSelect->addOptionArray($albumsHandler->getList());

The method getList() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsModuleHandler or XoopsImageHandler or XoopsRankHandler or XoopsCommentHandler or XoopsTplsetHandler or XoopsAvatarHandler or XoopsBlockHandler or XoopsImageSetHandler or XoopsPersistableObjectHandler or XoopsImagecategoryHandler.

        $form->addElement($imgAlbidSelect, true);

        // Images handler

        $imagesHandler = $helper->getHandler('Images');

        // Form Select Images

        $imgStateSelect = new \XoopsFormSelect(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_STATE'), 'img_state', $this->getVar('img_state'));

        $imgStateSelect->addOption('Empty');

        $imgStateSelect->addOptionArray($imagesHandler->getList());

        $form->addElement($imgStateSelect, true);

        // Form Text Date Select ImgDate

        $imgDate = $this->isNew() ? 0 : $this->getVar('img_date');

        $form->addElement(new \XoopsFormTextDateSelect(\constant('CO_' . $moduleDirNameUpper . '_' . 'DATE'), 'img_date', '', $imgDate));

'' of type string is incompatible with the type integer expected by parameter $size of XoopsFormTextDateSelect::__construct().

        // Form Select User ImgSubmitter

        $form->addElement(new \XoopsFormSelectUser(\constant('CO_' . $moduleDirNameUpper . '_' . 'SUBMITTER'), 'img_submitter', false, $this->getVar('img_submitter')));

        // Form Text ImgIp

        $form->addElement(new \XoopsFormText(\constant('CO_' . $moduleDirNameUpper . '_' . 'IMAGE_IP'), 'img_ip', 50, 255, $this->getVar('img_ip')));

        // To Save

        $form->addElement(new \XoopsFormHidden('op', 'save'));

        $form->addElement(new \XoopsFormButtonTray('', \_SUBMIT, 'submit', '', false));

        return $form;
    }