Import_wfdownloads()

Complexity

Conditions	11
Paths	152

Size

Total Lines

64

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
function Import_wfdownloads($shots='', $catimg='')
{
    $ok =  isset($_POST['ok']) ? intval($_POST['ok']) : 0;
    global $xoopsDB;
    if ($ok == 1) {
        //Vider les tables
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_broken"));

The assignment to $query is dead and can be removed.

        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_cat"));
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_downloads"));
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_fielddata"));
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_modfielddata"));
        $query = $xoopsDB->queryF("truncate table ".$xoopsDB->prefix("tdmdownloads_votedata"));
        //Inserer les donn�es des cat�gories
        $query_topic = $xoopsDB->query("SELECT cid, pid, title, imgurl, description, total, summary, spotlighttop, spotlighthis, dohtml, dosmiley, doxcode, doimage, dobr, weight, formulize_fid FROM ".$xoopsDB->prefix("wfdownloads_cat"));
        while ($donnees = $xoopsDB->fetchArray($query_topic)) {
            if ($donnees['imgurl'] == "") {
                $img = "blank.gif";
            } else {
                $img = $donnees['imgurl'];
                @copy($catimg . $img, XOOPS_ROOT_PATH . "/uploads/TDMDownloads/images/cats/" . $img);

It seems like you do not handle an error condition for copy(). This can introduce security issues, and is generally not recommended.

            }
            $insert = $xoopsDB->queryF("INSERT INTO ".$xoopsDB->prefix("tdmdownloads_cat")." (cat_cid, cat_pid, cat_title, cat_imgurl, cat_description_main, cat_weight ) VALUES ('".$donnees['cid']."', '".$donnees['pid']."', '".addcslashes($donnees['title'],"'")."', '".$img."', '".addcslashes($donnees['description'],"'")."', '".$donnees['weight']."')");
            if (!$insert) {
                echo "<font color='red'>" . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA .": </font> " . $donnees['title'] . "<br>";
            }
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_CAT_IMP . '<br/>', $donnees['title']);
        }
        echo '<br/>';

        //Inserer les donnees des t�l�chargemnts
        $query_links = $xoopsDB->query("SELECT lid, cid, title, url, filename, filetype, homepage, version, size, platform, screenshot, screenshot2, screenshot3, screenshot4, submitter, publisher, status, date, hits, rating, votes, comments, license, mirror, price, paypalemail, features, requirements, homepagetitle, forumid, limitations, versiontypes, dhistory, published, expired, updated, offline, summary, description, ipaddress, notifypub, formulize_idreq  FROM ".$xoopsDB->prefix("wfdownloads_downloads"));
        while ($donnees = $xoopsDB->fetchArray($query_links)) {
            if ($donnees['url']=='') {
                $newurl = XOOPS_URL . '/uploads/' . $donnees['filename'];
            } else {
                $newurl = $donnees['url'];
            }
            $insert = $xoopsDB->queryF("INSERT INTO ".$xoopsDB->prefix("tdmdownloads_downloads")." (
            lid, cid, title, url, homepage, version, size, platform, description, logourl, submitter, status, date, hits, rating, votes, comments, top) VALUES
            ('".$donnees['lid']."', '".$donnees['cid']."', '".addcslashes($donnees['title'],"'")."', '".$newurl."', '".$donnees['homepage']."', '".$donnees['version']."', '".$donnees['size']."', '".$donnees['platform']."', '".addcslashes($donnees['description'],"'")."',  '".$donnees['screenshot']."', '".$donnees['submitter']."', '".$donnees['status']."', '".$donnees['date']."', '".$donnees['hits']."', '".$donnees['rating']."', '".$donnees['votes']."', '0', '0' )");

            if (!$insert) {
                echo "<font color='red'>" . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA .": </font> " . $donnees['title'] . "<br>";
            }
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_DOWNLOADS_IMP . '<br/>', $donnees['title']);
            @copy($shots . $donnees['screenshot'], XOOPS_ROOT_PATH . "/uploads/TDMDownloads/images/shots/" . $donnees['screenshot']);
        }
        echo '<br/>';

        //Inserer les donnees des votes
        $query_vote = $xoopsDB->query("SELECT ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp FROM ".$xoopsDB->prefix("wfdownloads_votedata"));
        while ($donnees = $xoopsDB->fetchArray($query_vote)) {
            $insert = $xoopsDB->queryF("INSERT INTO ".$xoopsDB->prefix("tdmdownloads_votedata")." (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp ) VALUES ('".$donnees['ratingid']."', '".$donnees['lid']."', '".$donnees['ratinguser']."', '".$donnees['rating']."', '".$donnees['ratinghostname']."', '". $donnees['ratingtimestamp']."')");
            if (!$insert) {
                echo "<font color='red'>" . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA .": </font> " . $donnees['ratingid'] . "<br>";
            }
            echo sprintf(_AM_TDMDOWNLOADS_IMPORT_VOTE_IMP . '<br/>', $donnees['ratingid']);
        }
        echo "<br><br>";
        echo "<div class='errorMsg'>";
        echo _AM_TDMDOWNLOADS_IMPORT_OK;
        echo "</div>";
    } else {
        xoops_confirm(array('op' => 'import_wfdownloads', 'ok' => 1, 'shots' => $shots, 'catimg' => $catimg), 'import.php', _AM_TDMDOWNLOADS_IMPORT_CONF_WFDOWNLOADS . '<br>');
    }