importWfdownloads()

Complexity

Conditions	15
Paths	25

Size

Total Lines	98
Code Lines	74

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function importWfdownloads($shots = '', $catimg = '')
{
    $moduleDirName = basename(dirname(__DIR__));
    $ok            = \Xmf\Request::getInt('ok', 0, 'POST');
    global $xoopsDB;
    if (1 === $ok) {
        //Vider les tables
        $myTables = ['tdmdownloads_broken', 'tdmdownloads_cat', 'tdmdownloads_downloads', 'tdmdownloads_fielddata', 'tdmdownloads_modfielddata', 'tdmdownloads_votedata'];
        $table    = new TableLoad();
        $tables   = new Tables();
        foreach ($myTables as $myTable) {
            if ($tables->useTable($myTable)) { // if this returns false, there is no table
                $table::truncateTable($myTable);
            }
        }
        //Inserer les données des catégories
        $result = $xoopsDB->query('SELECT cid, pid, title, imgurl, description, total, summary, spotlighttop, spotlighthis, dohtml, dosmiley, doxcode, doimage, dobr, weight, formulize_fid FROM ' . $xoopsDB->prefix('wfdownloads_cat'));
        if ($result instanceof \mysqli_result) {
            while (false !== ($donnees = $xoopsDB->fetchArray($result))) {
                if ('' === $donnees['imgurl']) {
                    $img = 'blank.gif';
                } else {
                    $img = $donnees['imgurl'];
                    @copy($catimg . $img, XOOPS_ROOT_PATH . '/uploads/' . $moduleDirName . '/images/cats/' . $img);

It seems like you do not handle an error condition for copy(). This can introduce security issues, and is generally not recommended.

                }
                $insert = $xoopsDB->queryF(
                    'INSERT INTO ' . $xoopsDB->prefix('tdmdownloads_cat') . " (cat_cid, cat_pid, cat_title, cat_imgurl, cat_description_main, cat_weight ) VALUES ('" . $donnees['cid'] . "', '" . $donnees['pid'] . "', '" . addcslashes($donnees['title'], "'") . "', '" . $img . "', '" . addcslashes(
                        $donnees['description'],
                        "'"
                    ) . "', '" . $donnees['weight'] . "')"
                );
                if (!$insert) {
                    $errors[] = ['title' => _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA, 'info' => $donnees['title']];
                }
                $successes[] = sprintf(_AM_TDMDOWNLOADS_IMPORT_CAT_IMP, $donnees['title']);
            }
        }
        echo '<br>';
        //Inserer les données des téléchargemnts
        $query_links = $xoopsDB->query(
            'SELECT lid, cid, title, url, filename, filetype, homepage, version, size, platform, screenshot, screenshot2, screenshot3, screenshot4, submitter, publisher, status, date, hits, rating, votes, comments, license, mirror, price, paypalemail, features, requirements, homepagetitle, forumid, limitations, versiontypes, dhistory, published, expired, updated, offline, summary, description, ipaddress, notifypub, formulize_idreq  FROM '
            . $xoopsDB->prefix('wfdownloads_downloads')
        );
        if ($query_links instanceof \mysqli_result) {
            while (false !== ($donnees = $xoopsDB->fetchArray($query_links))) {
                if ('' === $donnees['url']) {
                    $newurl = XOOPS_URL . '/uploads/' . $donnees['filename'];
                } else {
                    $newurl = $donnees['url'];
                }
                $insert = $xoopsDB->queryF(
                    'INSERT INTO ' . $xoopsDB->prefix('tdmdownloads_downloads') . " (
            lid, cid, title, url, homepage, version, size, platform, description, logourl, submitter, status, date, hits, rating, votes, comments, top) VALUES
            ('" . $donnees['lid'] . "', '" . $donnees['cid'] . "', '" . addcslashes($donnees['title'], "'") . "', '" . $newurl . "', '" . $donnees['homepage'] . "', '" . $donnees['version'] . "', '" . $donnees['size'] . "', '" . $donnees['platform'] . "', '" . addcslashes(
                        $donnees['description'],
                        "'"
                    ) . "',  '" . $donnees['screenshot'] . "', '" . $donnees['submitter'] . "', '" . $donnees['status'] . "', '" . $donnees['date'] . "', '" . $donnees['hits'] . "', '" . $donnees['rating'] . "', '" . $donnees['votes'] . "', '0', '0' )"
                );
                if (!$insert) {
                    $errors[] = ['title' => _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA, 'info' => $donnees['title']];
                }
                $successes[] = sprintf(_AM_TDMDOWNLOADS_IMPORT_DOWNLOADS_IMP, $donnees['title']);
                @copy($shots . $donnees['screenshot'], XOOPS_ROOT_PATH . '/uploads/' . $moduleDirName . '/images/shots/' . $donnees['screenshot']);
            }
        }
        echo '<br>';
        //Inserer les données des votes
        $query_vote = $xoopsDB->query('SELECT ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp FROM ' . $xoopsDB->prefix('wfdownloads_votedata'));
        if ($query_vote instanceof \mysqli_result) {
            while (false !== ($donnees = $xoopsDB->fetchArray($query_vote))) {
                $insert = $xoopsDB->queryF(
                    'INSERT INTO '
                    . $xoopsDB->prefix('tdmdownloads_votedata')
                    . " (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp ) VALUES ('"
                    . $donnees['ratingid']
                    . "', '"
                    . $donnees['lid']
                    . "', '"
                    . $donnees['ratinguser']
                    . "', '"
                    . $donnees['rating']
                    . "', '"
                    . $donnees['ratinghostname']
                    . "', '"
                    . $donnees['ratingtimestamp']
                    . "')"
                );
                if (!$insert) {
                    echo '<span style="color: #ff0000; ">' . _AM_TDMDOWNLOADS_IMPORT_ERROR_DATA . ': </span> ' . $donnees['ratingid'] . '<br>';
                }
                echo sprintf(_AM_TDMDOWNLOADS_IMPORT_VOTE_IMP . '<br>', $donnees['ratingid']);
            }
        }
        $successes[] = _AM_TDMDOWNLOADS_IMPORT_OK;
        $GLOBALS['xoopsTpl']->assign('successes', $successes);
        $GLOBALS['xoopsTpl']->assign('errors', $errors);

The variable $errors does not seem to be defined for all execution paths leading up to this point.

    } else {
        xoops_confirm(['op' => 'importWfdownloads', 'ok' => 1, 'shots' => $shots, 'catimg' => $catimg], 'import.php', _AM_TDMDOWNLOADS_IMPORT_CONF_WFDOWNLOADS . '<br>');
    }