Issues in register.php (master) - Issues in master - XoopsModules25x/suico - Measure and Improve Code Quality continuously with Scrutinizer

Issues (432)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

register.php (3 issues)

Labels

Bug 3

Severity

<?php declare(strict_types=1);

/**
 * Extended User Profile
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright       (c) 2000-2016 XOOPS Project (www.xoops.org)
 * @license             GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @since               2.3.0
 * @author              Taiwen Jiang <[email protected]>
 * @author              Jan Pedersen
 * @author              trabis <[email protected]>
 */

use Xmf\Request;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

$GLOBALS['xoopsOption']['template_main'] = 'suico_register.tpl';
require __DIR__ . '/header.php';
if ($GLOBALS['xoopsUser']) {
    header('location: index.php?uid= ' . $GLOBALS['xoopsUser']->getVar('uid'));
    exit();
}
if (!empty($_GET['op']) && in_array($_GET['op'], ['actv', 'activate'], true)) {
    header('location: ./activate.php' . (Request::getString('QUERY_STRING', '', 'SERVER')));
    exit();
}
xoops_load('XoopsUserUtility');
$myts = \MyTextSanitizer::getInstance();
/** @var XoopsConfigHandler $configHandler */
$configHandler              = xoops_getHandler('config');
$GLOBALS['xoopsConfigUser'] = $configHandler->getConfigsByCat(XOOPS_CONF_USER);
if (empty($GLOBALS['xoopsConfigUser']['allow_register'])) {
    redirect_header('index.php', 6, _US_NOREGISTER);
}
// get the key we need to access our 'op' in $_POST
// if this key is not set, empty $_POST since this is a new registration and
// no legitimate data would be there.
$opkey = 'profile_opname';
if (isset($_SESSION[$opkey])) {
    $current_opname = $_SESSION[$opkey];
    unset($_SESSION[$opkey]);
    if (!isset($_POST[$current_opname])) {
        $_POST = [];
    }
} else {
    $_POST          = [];
    $current_opname = 'op'; // does not matter, it isn't there
}
$op           = $_POST[$current_opname] ?? 'register';
$current_step = isset($_POST['step']) ? (int)$_POST['step'] : 0;
// The newly introduced variable $_SESSION['profile_post'] is contaminated by $_POST, thus we use an old vaiable to hold uid parameter
$uid = !empty($_SESSION['profile_register_uid']) ? (int)$_SESSION['profile_register_uid'] : 0;
// First step is already secured by with the captcha Token so lets check the others
if ($current_step > 0 && !$GLOBALS['xoopsSecurity']->check()) {
    redirect_header('user.php', 5, _PROFILE_MA_EXPIRED);
}
$criteria = new CriteriaCompo();
$criteria->setSort('step_order');
$regstepHandler = $helper->getHandler('Regstep');
if (!$steps = $regstepHandler->getAll($criteria, null, false, false)) {
    redirect_header(XOOPS_URL . '/', 6, _PROFILE_MA_NOSTEPSAVAILABLE);
}
foreach (array_keys($steps) as $key) {
    $steps[$key]['step_no'] = $key + 1;
}
$GLOBALS['xoopsTpl']->assign('steps', $steps);
$GLOBALS['xoopsTpl']->assign('lang_register_steps', _PROFILE_MA_REGISTER_STEPS);
$xoBreadcrumbs[] = [
    'link'  => XOOPS_URL . '/modules/' . $GLOBALS['xoopsModule']->getVar('dirname', 'n') . '/register.php',
    'title' => _PROFILE_MA_REGISTER,
];
if (isset($steps[$current_step])) {
    $xoBreadcrumbs[] = ['title' => $steps[$current_step]['step_name']];
}
/** @var XoopsMemberHandler $memberHandler */
$memberHandler  = xoops_getHandler('member');
$profileHandler = $helper->getHandler('Profile');
$fields         = $profileHandler->loadFields();
$userfields     = $profileHandler->getUserVars();
if (0 == $uid) {
    // No user yet? Create one and set default values.
    $newuser = $memberHandler->createUser();
    $profile = $profileHandler->create();
    if (count($fields) > 0) {
        foreach (array_keys($fields) as $i) {
            $fieldname = $fields[$i]->getVar('field_name');
            if (in_array($fieldname, $userfields, true)) {
                $default = $fields[$i]->getVar('field_default');
                if ('' === $default || null === $default) {
                    continue;
                }
                $newuser->setVar($fieldname, $default);
            }
        }
    }
} else {
    // We already have a user? Just load it! Security is handled by token so there is no fake uid here.
    $newuser = $memberHandler->getUser($uid);
    $profile = $profileHandler->get($uid);
}
// Lets merge current $_POST  with $_SESSION['profile_post'] so we can have access to info submited in previous steps
// Get all fields that we can expect from a $_POST inlcuding our private '_message_'
$fieldnames = [];
foreach (array_keys($fields) as $i) {
    $fieldnames[] = $fields[$i]->getVar('field_name');
}
$fieldnames   = array_merge($fieldnames, $userfields);
$fieldnames[] = '_message_';
// Get $_POST that matches above criteria, we do not need to store step, tokens, etc
$postfields = [];
foreach ($fieldnames as $fieldname) {
    if (isset($_POST[$fieldname])) {
        $postfields[$fieldname] = $_POST[$fieldname];
    }
}
if (0 == $current_step) {
    // Reset any previous session for first step
    $_SESSION['profile_post']         = [];
    $_SESSION['profile_register_uid'] = null;
} else {
    // Merge current $_POST  with $_SESSION['profile_post']
    $_SESSION['profile_post'] = array_merge($_SESSION['profile_post'], $postfields);
    $_POST                    = array_merge($_SESSION['profile_post'], $_POST);
}
// Set vars from $_POST/$_SESSION['profile_post']
foreach (array_keys($fields) as $field) {
    if (!isset($_POST[$field])) {
        continue;
    }
    $value = $fields[$field]->getValueForSave($_POST[$field]);
    if (in_array($field, $userfields, true)) {
        $newuser->setVar($field, $value);
    } else {
        $profile->setVar($field, $value);
    }
}
$stop = '';
//Client side validation
if (isset($_POST['step'], $_SESSION['profile_required'])) {
    foreach ($_SESSION['profile_required'] as $name => $title) {
        if (empty($_POST[$name])) {
            $stop .= sprintf(_FORM_ENTER, $title) . '<br>';
        }
    }
}
// Check user data at first step
if (1 == $current_step) {
    $uname      = Request::getString('uname', '', 'POST');
    $email      = Request::getString('email', '', 'POST');
    $url        = Request::getString('url', '', 'POST');
    $pass       = Request::getString('pass', '', 'POST');
    $vpass      = Request::getString('pass', '', 'POST');
    $agree_disc = (isset($_POST['agree_disc']) && (int)$_POST['agree_disc']) ? 1 : 0;
    if (0 != $GLOBALS['xoopsConfigUser']['reg_dispdsclmr'] && '' !== $GLOBALS['xoopsConfigUser']['reg_disclaimer']) {
        if (empty($agree_disc)) {
            $stop .= _US_UNEEDAGREE . '<br>';
        }
    }
    $newuser->setVar('uname', $uname);
    $newuser->setVar('email', $email);
    $newuser->setVar('pass', $pass ? password_hash($pass, PASSWORD_DEFAULT) : '');
    $stop .= XoopsUserUtility::validate($newuser, $pass, $vpass);
    xoops_load('XoopsCaptcha');
    $xoopsCaptcha = XoopsCaptcha::getInstance();
    if (!$xoopsCaptcha->verify()) {
        $stop .= $xoopsCaptcha->getMessage();
    }
}
// If the last step required SAVE or if we're on the last step then we will insert/update user on database
if ($current_step > 0 && empty($stop) && (!empty($steps[$current_step - 1]['step_save']) || !isset($steps[$current_step]))) {
    if (1 == $GLOBALS['xoopsModuleConfig']['profileCaptchaAfterStep1'] && $current_step > 1) {
        xoops_load('XoopsCaptcha');
        $xoopsCaptcha2 = XoopsCaptcha::getInstance();
        if (!$xoopsCaptcha2->verify()) {
            $stop .= $xoopsCaptcha2->getMessage();
        }
    }
    if (empty($stop)) {
        $isNew = $newuser->isNew();
        //Did created an user already? If not then let us set some extra info
        if ($isNew) {
            $uname = Request::getString('uname', '', 'POST');
            $email = Request::getString('email', '', 'POST');
            $url   = Request::getString('url', '', 'POST');
            $pass  = Request::getString('pass', '', 'POST');
            $newuser->setVar('uname', $uname);
            $newuser->setVar('email', $email);
            $newuser->setVar('pass', $pass ? password_hash($pass, PASSWORD_DEFAULT) : '');
            $actkey = bin2hex(random_bytes(4));
            $newuser->setVar('actkey', $actkey, true);
            $newuser->setVar('user_regdate', time(), true);
            $newuser->setVar('uorder', $GLOBALS['xoopsConfig']['com_order'], true);
            $newuser->setVar('umode', $GLOBALS['xoopsConfig']['com_mode'], true);
            $newuser->setVar('theme', $GLOBALS['xoopsConfig']['theme_set'], true);
            $newuser->setVar('user_avatar', 'avatars/blank.gif', true);
            if (1 == $GLOBALS['xoopsConfigUser']['activation_type']) {
                $newuser->setVar('level', 1, true);
            } else {
                $newuser->setVar('level', 0, true);
            }
        }
        // Insert/update user and check if we have succeded
        if ($memberHandler->insertUser($newuser)) {
            // User inserted! Now insert custom profile fields
            $profile->setVar('profile_id', $newuser->getVar('uid'));
            $profileHandler->insert($profile);
            // We are good! If this is 'was' a new user then we handle notification
            if ($isNew) {
                if (1 == $GLOBALS['xoopsConfigUser']['new_user_notify'] && !empty($GLOBALS['xoopsConfigUser']['new_user_notify_group'])) {
                    $xoopsMailer = xoops_getMailer();
                    $xoopsMailer->reset();
                    $xoopsMailer->useMail();
                    $xoopsMailer->setToGroups($memberHandler->getGroup($GLOBALS['xoopsConfigUser']['new_user_notify_group']));
                    $xoopsMailer->setFromEmail($GLOBALS['xoopsConfig']['adminmail']);
                    $xoopsMailer->setFromName($GLOBALS['xoopsConfig']['sitename']);
                    $xoopsMailer->setSubject(sprintf(_US_NEWUSERREGAT, $GLOBALS['xoopsConfig']['sitename']));
                    $xoopsMailer->setBody(sprintf(_US_HASJUSTREG, $newuser->getVar('uname')));
                    $xoopsMailer->setBody(sprintf(_US_HASJUSTREG, /** @scrutinizer ignore-type */ $newuser->getVar('uname')));
                    $xoopsMailer->send(true);
                }
                $message = '';
                if (!$memberHandler->addUserToGroup(XOOPS_GROUP_USERS, $newuser->getVar('uid'))) {
                if (!$memberHandler->addUserToGroup(/** @scrutinizer ignore-type */ XOOPS_GROUP_USERS, $newuser->getVar('uid'))) {
                    $message = _PROFILE_MA_REGISTER_NOTGROUP . '<br>';
                } elseif (1 == $GLOBALS['xoopsConfigUser']['activation_type']) {
                    XoopsUserUtility::sendWelcome($newuser);
                } elseif (0 == $GLOBALS['xoopsConfigUser']['activation_type']) {
                    $xoopsMailer = xoops_getMailer();
                    $xoopsMailer->reset();
                    $xoopsMailer->useMail();
                    $xoopsMailer->setTemplate('register.tpl');
                    $xoopsMailer->assign('SITENAME', $GLOBALS['xoopsConfig']['sitename']);
                    $xoopsMailer->assign('ADMINMAIL', $GLOBALS['xoopsConfig']['adminmail']);
                    $xoopsMailer->assign('SITEURL', XOOPS_URL . '/');
                    $xoopsMailer->assign('X_UPASS', $_POST['vpass']);
                    $xoopsMailer->setToUsers($newuser);
                    $xoopsMailer->setFromEmail($GLOBALS['xoopsConfig']['adminmail']);
                    $xoopsMailer->setFromName($GLOBALS['xoopsConfig']['sitename']);
                    $xoopsMailer->setSubject(sprintf(_US_USERKEYFOR, $newuser->getVar('uname')));
                    if ($xoopsMailer->send(true)) {
                        $_SESSION['profile_post']['_message_'] = 1;
                    } else {
                        $_SESSION['profile_post']['_message_'] = 0;
                    }
                } elseif (2 == $GLOBALS['xoopsConfigUser']['activation_type']) {
                    $xoopsMailer = xoops_getMailer();
                    $xoopsMailer->reset();
                    $xoopsMailer->useMail();
                    $xoopsMailer->setTemplate('adminactivate.tpl');
                    $xoopsMailer->assign('USERNAME', $newuser->getVar('uname'));
                    $xoopsMailer->assign('USEREMAIL', $newuser->getVar('email'));
                    $xoopsMailer->assign('USERACTLINK', XOOPS_URL . '/modules/' . $GLOBALS['xoopsModule']->getVar('dirname', 'n') . '/activate.php?id=' . $newuser->getVar('uid') . '&actkey=' . $newuser->getVar('actkey', 'n'));
                    $xoopsMailer->assign('SITENAME', $GLOBALS['xoopsConfig']['sitename']);
                    $xoopsMailer->assign('ADMINMAIL', $GLOBALS['xoopsConfig']['adminmail']);
                    $xoopsMailer->assign('SITEURL', XOOPS_URL . '/');
                    $xoopsMailer->setToGroups($memberHandler->getGroup($GLOBALS['xoopsConfigUser']['activation_group']));
                    $xoopsMailer->setFromEmail($GLOBALS['xoopsConfig']['adminmail']);
                    $xoopsMailer->setFromName($GLOBALS['xoopsConfig']['sitename']);
                    $xoopsMailer->setSubject(sprintf(_US_USERKEYFOR, $newuser->getVar('uname')));
                    if ($xoopsMailer->send()) {
                        $_SESSION['profile_post']['_message_'] = 3;
                    } else {
                        $_SESSION['profile_post']['_message_'] = 2;
                    }
                }
                if ($message) {
                    $GLOBALS['xoopsTpl']->append('confirm', $message);
                }
                $_SESSION['profile_register_uid'] = $newuser->getVar('uid');
            }
        } else {
            $stop .= _US_REGISTERNG . '<br>';
            $stop .= implode('<br>', $newuser->getErrors());
        }
    }
}
if (!empty($stop) || isset($steps[$current_step])) {
    require_once __DIR__ . '/include/forms.php';
    $current_step = empty($stop) ? $current_step : $current_step - 1;
    $reg_form     = profile_getRegisterForm($newuser, $profile, $steps[$current_step]);
    $reg_form->assign($GLOBALS['xoopsTpl']);
    $GLOBALS['xoopsTpl']->assign('current_step', $current_step);
    $GLOBALS['xoopsTpl']->assign('stop', $stop);
} else {
    // No errors and no more steps, finish
    $GLOBALS['xoopsTpl']->assign('finish', _PROFILE_MA_REGISTER_FINISH);
    $GLOBALS['xoopsTpl']->assign('current_step', -1);
    if (1 == $GLOBALS['xoopsConfigUser']['activation_type'] && !empty($_SESSION['profile_post']['pass'])) {
        $GLOBALS['xoopsTpl']->assign('finish_login', _PROFILE_MA_FINISH_LOGIN);
        $GLOBALS['xoopsTpl']->assign('finish_uname', $newuser->getVar('uname'));
        $GLOBALS['xoopsTpl']->assign('finish_pass', htmlspecialchars($_SESSION['profile_post']['pass'], ENT_QUOTES | ENT_HTML5));
    }
    if (isset($_SESSION['profile_post']['_message_'])) {
        //todo, if user is activated by admin, then we should inform it along with error messages.  _US_YOURREGMAILNG is not enough
        $messages = [_US_YOURREGMAILNG, _US_YOURREGISTERED, _US_YOURREGMAILNG, _US_YOURREGISTERED2];
        $GLOBALS['xoopsTpl']->assign('finish_message', $messages[$_SESSION['profile_post']['_message_']]);
    }
    $_SESSION['profile_post'] = null;
}
require_once XOOPS_ROOT_PATH . '/footer.php';


XoopsModules25x / suico

Issues (432)

Security Analysis not enabled

register.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like