Issues in Controller.php (master) - Issues in master - XoopsModules25x/suico - Measure and Improve Code Quality continuously with Scrutinizer

Issues (432)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/Controller.php (1 issue)

Labels

Severity

Minor 1

<?php declare(strict_types=1);

namespace XoopsModules\Suico;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

use Criteria;
use CriteriaCompo;
use Xmf\Request;
use XoopsUser;
use XoopsUserHandler;

/**
 * @category        Module
 * @copyright       {@link https://xoops.org/ XOOPS Project}
 * @license         GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author          Marcello Brandão aka  Suico, Mamba, LioMJ  <https://xoops.org>
 */
require_once XOOPS_ROOT_PATH . '/kernel/object.php';
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
require_once XOOPS_ROOT_PATH . '/class/criteria.php';
require_once XOOPS_ROOT_PATH . '/class/pagenav.php';

/**
 * Class Controller
 */
class Controller extends \XoopsObject
{
    public \XoopsDatabase $db;
    public                $user;
    public int            $isOwner;
    public int            $isUser;
    public int            $isAnonym;
    public int            $isFriend;
    public                $uidOwner;
    public $nameOwner;
    public $owner;
    public $albumFactory;
    public $visitorsFactory;
    public $audioFactory;
    public $videosFactory;
    public $friendrequestFactory;
    public $friendshipsFactory;
    public $relgroupusersFactory;
    public $suspensionsFactory;
    public $groupsFactory;
    public $notesFactory;
    public $configsFactory;
    public $section;
    public $privilegeLevel;
    public                $isSuspended;
    public Helper         $helper;
    public int            $isSelfRequest;
    public int            $isOtherRequest;

    /**
     * Constructor
     *
     * @param \XoopsDatabase $xoopsDatabase
     * @param                $user
     * @param null           $xoopsModule
     */
    public function __construct(\XoopsDatabase $xoopsDatabase, $user, $xoopsModule = null)
    {
        $this->helper         = Helper::getInstance();
        $this->db             = $xoopsDatabase;
        $this->user           = $user;
        $this->isOwner        = 0;
        $this->isAnonym       = 1;
        $this->isFriend       = 0;
        $this->isUser         = 0;
        $this->isSelfRequest  = 0;
        $this->isOtherRequest = 0;
        $this->createFactories();
        $this->getPermissions();
        $this->checkPrivilege('');
        $this->checkSuspension();
    }

    /**
     * @return void
     */
    public function checkSuspension(): void
    {
        $criteria_suspended = new Criteria('uid', $this->uidOwner);
        if (1 === $this->isSuspended) {
            $suspensions = $this->suspensionsFactory->getObjects($criteria_suspended);
            /** @var Suspensions $suspension */
            $suspension = $suspensions[0];
            if (\time() > $suspension->getVar('suspension_time')) {
                $suspension = $this->suspensionsFactory->create(false);
                $suspension->load($this->uidOwner);
                $this->owner->setVar('email', $suspension->getVar('old_email', 'n'));
                $this->owner->setVar('pass', $suspension->getVar('old_pass', 'n'));
                $this->owner->setVar('user_sig', $suspension->getVar('old_signature', 'n'));
                $userHandler = new XoopsUserHandler($this->db);
                $userHandler->insert($this->owner, true);
                $criteria = new Criteria('uid', $this->uidOwner);
                $this->suspensionsFactory->deleteAll($criteria);
            }
        }
    }

    /**
     * @return void
     */
    public function checkPrivilege()
    {
    }

    /**
     * Checkinf privilege levels
     *
     * @param int $privilegeNeeded 0 anonym 1 member 2 friend 3 owner
     * @return bool true if privilege enough
     */
    public function checkPrivilegeLevel(
        $privilegeNeeded = 1
    ) {
        return $privilegeNeeded <= $this->privilegeLevel;
    }

    /**
     * Set permissions according to user is logged or not , is owner or not etc..
     */
    public function getPermissions(): void
    {
        global $_GET, $xoopsUser;
        /**
         * @desc Check if the user uid exists if not redirect back to where he was
         */
        if (!empty($_GET['uid'])) {
            /** @var \XoopsMemberHandler $memberHandler */
            $memberHandler = \xoops_getHandler('member');
            $user          = $memberHandler->getUser(Request::getInt('uid', 0, 'GET'));
            if (!\is_object($user)) {
                \redirect_header('index.php', 3, \_MD_SUICO_USER_DOESNTEXIST);
            }
        }
        /**
         * If anonymous and uid not set then redirect to admins profile
         * Else redirects to own profile
         */
        if (empty($this->user)) {
            $this->isAnonym = 1;
            $this->isUser   = 0;
            if (!empty($_GET['uid'])) {
                $this->uidOwner = Request::getInt('uid', 0, 'GET');
            } else {
                $this->uidOwner = 1;
                $this->isOwner  = 0;
            }
        } else {
            $this->isAnonym = 0;
            $this->isUser   = 1;
            if (!empty($_GET['uid'])) {
                $this->uidOwner = Request::getInt('uid', 0, 'GET');
                $this->isOwner  = $this->user->getVar('uid') === Request::getInt('uid', 0, 'GET') ? 1 : 0;
            } else {
                $this->uidOwner = $this->user->getVar('uid');
                $this->isOwner  = 1;
            }
        }
        $this->owner        = new XoopsUser($this->uidOwner);
        $criteria_suspended = new Criteria('uid', $this->uidOwner);
        $this->isSuspended  = $this->suspensionsFactory->getCount($criteria_suspended) > 0 ? 1 : 0;
        if ('' === $this->owner->getVar('name')) {
            $this->nameOwner = $this->owner->getVar('uname');
        } else {
            $this->nameOwner = $this->owner->getVar('name');
        }
        //isFriend?
        $criteria_friends = new Criteria('friend1_uid', $this->uidOwner);
        if ($xoopsUser) {
            $criteriaIsfriend = new CriteriaCompo(new Criteria('friend2_uid', $this->user->getVar('uid')));
            $criteriaIsfriend->add($criteria_friends);
            $this->isFriend = $this->friendshipsFactory->getCount($criteriaIsfriend);
        } else {
            $this->isFriend = 0;
        }
        $this->privilegeLevel = 1;
        if (1 === $this->isAnonym) {
            $this->privilegeLevel = 1;
        }
        if (1 === $this->isUser) {
            $this->privilegeLevel = 2;
        }
        if (1 === $this->isFriend) {
            $this->privilegeLevel = 3;
        }
        if (1 === $this->isOwner) {
            $this->privilegeLevel = 4;
        }
    }

    /**
     * Get for each section the number of objects the user possess
     *
     * @return array(countGroups=>"",countPhotos=>"",countFriends=>"",countGroups=>"")
     */
    public function getNumbersSections()
    {
        $criteriaGroups            = new Criteria('rel_user_uid', $this->uidOwner);
        $nbSections['countGroups'] = $this->relgroupusersFactory->getCount($criteriaGroups);

        $criteriaUid               = new Criteria('uid_owner', $this->uidOwner);
        $criteriaAlbum             = new CriteriaCompo($criteriaUid);
        if (0 === $this->isOwner) {
            $criteriaPrivate = new Criteria('private', 0);
            $criteriaAlbum->add($criteriaPrivate);
        }
        $nbSections['countPhotos']  = $this->albumFactory->getCount($criteriaAlbum);
        $criteriaFriends            = new Criteria('friend1_uid', $this->uidOwner);
        $nbSections['countFriends'] = $this->friendshipsFactory->getCount($criteriaFriends);
        $criteriaUidAudio           = new Criteria('uid_owner', $this->uidOwner);
        $nbSections['countAudios']  = $this->audioFactory->getCount($criteriaUidAudio);
        $criteriaUidVideo           = new Criteria('uid_owner', $this->uidOwner);
        $nbSections['countVideos']  = $this->videosFactory->getCount($criteriaUidVideo);
        $criteriaUidNotes           = new Criteria('note_to', $this->uidOwner);
        $nbSections['countNotes']   = $this->notesFactory->getCount($criteriaUidNotes);

        return $nbSections;
    }

    /**
     * This creates the module factories
     */
    public function createFactories(): void
    {
        $this->albumFactory         = new ImageHandler($this->db);
        $this->visitorsFactory      = new VisitorsHandler($this->db);
        $this->audioFactory         = new AudioHandler($this->db);
        $this->videosFactory        = new VideoHandler($this->db);
        $this->friendrequestFactory = new FriendrequestHandler($this->db);
        $this->friendshipsFactory   = new FriendshipHandler($this->db);
        $this->relgroupusersFactory = new RelgroupuserHandler($this->db);
        $this->notesFactory         = new NotesHandler($this->db);
        $this->groupsFactory        = new GroupsHandler($this->db);
        $this->configsFactory       = new ConfigsHandler($this->db);
        $this->suspensionsFactory   = new SuspensionsHandler($this->db);
    }

    /**
     * @param $section
     * @return int
     */
    public function checkPrivilegeBySection($section)
    {
        global $xoopsModuleConfig;
        $configsectionname = 'enable_' . $section;
        if (null !== $xoopsModuleConfig) {
            if (\array_key_exists($configsectionname, $xoopsModuleConfig)) {
                if (0 === $this->helper->getConfig($configsectionname)) {
                    return -1;
                }
            }
        }
        //  if ($section=="Notes" && $xoopsModuleConfig['enable_notes']==0){
        //          return false;
        //      }
        //      if ($section=="pictures" && $xoopsModuleConfig['enable_pictures']==0){
        //          return false;
        //      }
        //
        //      if ($section=="pictures" && $xoopsModuleConfig['enable_pictures']==0){
        //          return false;
        //      }
        $criteria = new Criteria('config_uid', $this->owner->getVar('uid'));
        if (1 === $this->configsFactory->getCount($criteria)) {
            $configs = $this->configsFactory->getObjects($criteria);
            $config  = $configs[0]->getVar($section);
            if (!$this->checkPrivilegeLevel($config)) {
                return 0;
            }
        }

        return 1;
    }
}


1			<?php declare(strict_types=1);
2
3			namespace XoopsModules\Suico;
4
5			/*
6			You may not change or alter any portion of this comment or credits
7			of supporting developers from this source code or any supporting source code
8			which is considered copyrighted (c) material of the original comment or credit authors.
9
10			This program is distributed in the hope that it will be useful,
11			but WITHOUT ANY WARRANTY; without even the implied warranty of
12			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13			*/
14
15			use Criteria;
16			use CriteriaCompo;
17			use Xmf\Request;
18			use XoopsUser;
19			use XoopsUserHandler;
20
21			/**
22			* @category Module
23			* @copyright {@link https://xoops.org/ XOOPS Project}
24			* @license GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
25			* @author Marcello Brandão aka Suico, Mamba, LioMJ <https://xoops.org>
26			*/
27			require_once XOOPS_ROOT_PATH . '/kernel/object.php';
28			require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
29			require_once XOOPS_ROOT_PATH . '/class/criteria.php';
30			require_once XOOPS_ROOT_PATH . '/class/pagenav.php';
31
32			/**
33			* Class Controller
34			*/
35			class Controller extends \XoopsObject
36			{
37			public \XoopsDatabase $db;
38			public $user;
39			public int $isOwner;
40			public int $isUser;
41			public int $isAnonym;
42			public int $isFriend;
43			public $uidOwner;
44			public $nameOwner;
45			public $owner;
46			public $albumFactory;
47			public $visitorsFactory;
48			public $audioFactory;
49			public $videosFactory;
50			public $friendrequestFactory;
51			public $friendshipsFactory;
52			public $relgroupusersFactory;
53			public $suspensionsFactory;
54			public $groupsFactory;
55			public $notesFactory;
56			public $configsFactory;
57			public $section;
58			public $privilegeLevel;
59			public $isSuspended;
60			public Helper $helper;
61			public int $isSelfRequest;
62			public int $isOtherRequest;
63
64			/**
65			* Constructor
66			*
67			* @param \XoopsDatabase $xoopsDatabase
68			* @param $user
69			* @param null $xoopsModule
70			*/
71			public function __construct(\XoopsDatabase $xoopsDatabase, $user, $xoopsModule = null)
72			{
73			$this->helper = Helper::getInstance();
74			$this->db = $xoopsDatabase;
75			$this->user = $user;
76			$this->isOwner = 0;
77			$this->isAnonym = 1;
78			$this->isFriend = 0;
79			$this->isUser = 0;
80			$this->isSelfRequest = 0;
81			$this->isOtherRequest = 0;
82			$this->createFactories();
83			$this->getPermissions();
84			$this->checkPrivilege('');
85			$this->checkSuspension();
86			}
87
88			/**
89			* @return void
90			*/
91			public function checkSuspension(): void
92			{
93			$criteria_suspended = new Criteria('uid', $this->uidOwner);
94			if (1 === $this->isSuspended) {
95			$suspensions = $this->suspensionsFactory->getObjects($criteria_suspended);
96			/** @var Suspensions $suspension */
97			$suspension = $suspensions[0];
98			if (\time() > $suspension->getVar('suspension_time')) {
99			$suspension = $this->suspensionsFactory->create(false);
100			$suspension->load($this->uidOwner);
101			$this->owner->setVar('email', $suspension->getVar('old_email', 'n'));
102			$this->owner->setVar('pass', $suspension->getVar('old_pass', 'n'));
103			$this->owner->setVar('user_sig', $suspension->getVar('old_signature', 'n'));
104			$userHandler = new XoopsUserHandler($this->db);
105			$userHandler->insert($this->owner, true);
106			$criteria = new Criteria('uid', $this->uidOwner);
107			$this->suspensionsFactory->deleteAll($criteria);
108			}
109			}
110			}
111
112			/**
113			* @return void
114			*/
115			public function checkPrivilege()
116			{
117			}
118
119			/**
120			* Checkinf privilege levels
121			*
122			* @param int $privilegeNeeded 0 anonym 1 member 2 friend 3 owner
123			* @return bool true if privilege enough
124			*/
125			public function checkPrivilegeLevel(
126			$privilegeNeeded = 1
127			) {
128			return $privilegeNeeded <= $this->privilegeLevel;
129			}
130
131			/**
132			* Set permissions according to user is logged or not , is owner or not etc..
133			*/
134			public function getPermissions(): void
135			{
136			global $_GET, $xoopsUser;
137			/**
138			* @desc Check if the user uid exists if not redirect back to where he was
139			*/
140			if (!empty($_GET['uid'])) {
141			/** @var \XoopsMemberHandler $memberHandler */
142			$memberHandler = \xoops_getHandler('member');
143			$user = $memberHandler->getUser(Request::getInt('uid', 0, 'GET'));
144			if (!\is_object($user)) {
145			\redirect_header('index.php', 3, \_MD_SUICO_USER_DOESNTEXIST);
146			}
147			}
148			/**
149			* If anonymous and uid not set then redirect to admins profile
150			* Else redirects to own profile
151			*/
152			if (empty($this->user)) {
153			$this->isAnonym = 1;
154			$this->isUser = 0;
155			if (!empty($_GET['uid'])) {
156			$this->uidOwner = Request::getInt('uid', 0, 'GET');
157			} else {
158			$this->uidOwner = 1;
159			$this->isOwner = 0;
160			}
161			} else {
162			$this->isAnonym = 0;
163			$this->isUser = 1;
164			if (!empty($_GET['uid'])) {
165			$this->uidOwner = Request::getInt('uid', 0, 'GET');
166			$this->isOwner = $this->user->getVar('uid') === Request::getInt('uid', 0, 'GET') ? 1 : 0;
167			} else {
168			$this->uidOwner = $this->user->getVar('uid');
169			$this->isOwner = 1;
170			}
171			}
172			$this->owner = new XoopsUser($this->uidOwner);
173			$criteria_suspended = new Criteria('uid', $this->uidOwner);
174			$this->isSuspended = $this->suspensionsFactory->getCount($criteria_suspended) > 0 ? 1 : 0;
175			if ('' === $this->owner->getVar('name')) {
176			$this->nameOwner = $this->owner->getVar('uname');
177			} else {
178			$this->nameOwner = $this->owner->getVar('name');
179			}
180			//isFriend?
181			$criteria_friends = new Criteria('friend1_uid', $this->uidOwner);
182			if ($xoopsUser) {
183			$criteriaIsfriend = new CriteriaCompo(new Criteria('friend2_uid', $this->user->getVar('uid')));
184			$criteriaIsfriend->add($criteria_friends);
185			$this->isFriend = $this->friendshipsFactory->getCount($criteriaIsfriend);
186			} else {
187			$this->isFriend = 0;
188			}
189			$this->privilegeLevel = 1;
190			if (1 === $this->isAnonym) {
191			$this->privilegeLevel = 1;
192			}
193			if (1 === $this->isUser) {
194			$this->privilegeLevel = 2;
195			}
196			if (1 === $this->isFriend) {
197			$this->privilegeLevel = 3;
198			}
199			if (1 === $this->isOwner) {
200			$this->privilegeLevel = 4;
201			}
202			}
203
204			/**
205			* Get for each section the number of objects the user possess
206			*
207			* @return array(countGroups=>"",countPhotos=>"",countFriends=>"",countGroups=>"")
208			*/
209			public function getNumbersSections()
210			{
211			$criteriaGroups = new Criteria('rel_user_uid', $this->uidOwner);
212			$nbSections['countGroups'] = $this->relgroupusersFactory->getCount($criteriaGroups);
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-04-26 14:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$nbSections` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$nbSections = array();` before regardless. Loading history...
213			$criteriaUid = new Criteria('uid_owner', $this->uidOwner);
214			$criteriaAlbum = new CriteriaCompo($criteriaUid);
215			if (0 === $this->isOwner) {
216			$criteriaPrivate = new Criteria('private', 0);
217			$criteriaAlbum->add($criteriaPrivate);
218			}
219			$nbSections['countPhotos'] = $this->albumFactory->getCount($criteriaAlbum);
220			$criteriaFriends = new Criteria('friend1_uid', $this->uidOwner);
221			$nbSections['countFriends'] = $this->friendshipsFactory->getCount($criteriaFriends);
222			$criteriaUidAudio = new Criteria('uid_owner', $this->uidOwner);
223			$nbSections['countAudios'] = $this->audioFactory->getCount($criteriaUidAudio);
224			$criteriaUidVideo = new Criteria('uid_owner', $this->uidOwner);
225			$nbSections['countVideos'] = $this->videosFactory->getCount($criteriaUidVideo);
226			$criteriaUidNotes = new Criteria('note_to', $this->uidOwner);
227			$nbSections['countNotes'] = $this->notesFactory->getCount($criteriaUidNotes);
228
229			return $nbSections;
230			}
231
232			/**
233			* This creates the module factories
234			*/
235			public function createFactories(): void
236			{
237			$this->albumFactory = new ImageHandler($this->db);
238			$this->visitorsFactory = new VisitorsHandler($this->db);
239			$this->audioFactory = new AudioHandler($this->db);
240			$this->videosFactory = new VideoHandler($this->db);
241			$this->friendrequestFactory = new FriendrequestHandler($this->db);
242			$this->friendshipsFactory = new FriendshipHandler($this->db);
243			$this->relgroupusersFactory = new RelgroupuserHandler($this->db);
244			$this->notesFactory = new NotesHandler($this->db);
245			$this->groupsFactory = new GroupsHandler($this->db);
246			$this->configsFactory = new ConfigsHandler($this->db);
247			$this->suspensionsFactory = new SuspensionsHandler($this->db);
248			}
249
250			/**
251			* @param $section
252			* @return int
253			*/
254			public function checkPrivilegeBySection($section)
255			{
256			global $xoopsModuleConfig;
257			$configsectionname = 'enable_' . $section;
258			if (null !== $xoopsModuleConfig) {
259			if (\array_key_exists($configsectionname, $xoopsModuleConfig)) {
260			if (0 === $this->helper->getConfig($configsectionname)) {
261			return -1;
262			}
263			}
264			}
265			// if ($section=="Notes" && $xoopsModuleConfig['enable_notes']==0){
266			// return false;
267			// }
268			// if ($section=="pictures" && $xoopsModuleConfig['enable_pictures']==0){
269			// return false;
270			// }
271			//
272			// if ($section=="pictures" && $xoopsModuleConfig['enable_pictures']==0){
273			// return false;
274			// }
275			$criteria = new Criteria('config_uid', $this->owner->getVar('uid'));
276			if (1 === $this->configsFactory->getCount($criteria)) {
277			$configs = $this->configsFactory->getObjects($criteria);
278			$config = $configs[0]->getVar($section);
279			if (!$this->checkPrivilegeLevel($config)) {
280			return 0;
281			}
282			}
283
284			return 1;
285			}
286			}
287

XoopsModules25x / suico

Issues (432)

Security Analysis not enabled

class/Controller.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like