XoopsModules25x / suico

class/Controller.php

<?php declare(strict_types=1);

namespace XoopsModules\Suico;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

use Criteria;
use CriteriaCompo;
use Xmf\Request;
use XoopsUser;
use XoopsUserHandler;

/**
 * @category        Module
 * @copyright       {@link https://xoops.org/ XOOPS Project}
 * @license         GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author          Marcello Brandão aka  Suico, Mamba, LioMJ  <https://xoops.org>
 */
require_once XOOPS_ROOT_PATH . '/kernel/object.php';
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
require_once XOOPS_ROOT_PATH . '/class/criteria.php';
require_once XOOPS_ROOT_PATH . '/class/pagenav.php';

/**
 * Class Controller
 */
class Controller extends \XoopsObject
{
    public \XoopsDatabase $db;
    public                $user;
    public int            $isOwner;
    public int            $isUser;
    public int            $isAnonym;
    public int            $isFriend;
    public                $uidOwner;
    public $nameOwner;
    public $owner;
    public $albumFactory;
    public $visitorsFactory;
    public $audioFactory;
    public $videosFactory;
    public $friendrequestFactory;
    public $friendshipsFactory;
    public $relgroupusersFactory;
    public $suspensionsFactory;
    public $groupsFactory;
    public $notesFactory;
    public $configsFactory;
    public $section;
    public $privilegeLevel;
    public                $isSuspended;
    public Helper         $helper;
    public int            $isSelfRequest;
    public int            $isOtherRequest;

    /**
     * Constructor
     *
     * @param \XoopsDatabase $xoopsDatabase
     * @param                $user
     * @param null           $xoopsModule

Are you sure the doc-type for parameter $xoopsModule is correct as it would always require null to be passed?

     */
    public function __construct(\XoopsDatabase $xoopsDatabase, $user, $xoopsModule = null)

The parameter $xoopsModule is not used and could be removed.

    {
        $this->helper         = Helper::getInstance();
        $this->db             = $xoopsDatabase;
        $this->user           = $user;
        $this->isOwner        = 0;
        $this->isAnonym       = 1;
        $this->isFriend       = 0;
        $this->isUser         = 0;
        $this->isSelfRequest  = 0;
        $this->isOtherRequest = 0;
        $this->createFactories();
        $this->getPermissions();
        $this->checkPrivilege('');

The call to XoopsModules\Suico\Controller::checkPrivilege() has too many arguments starting with ''.

        $this->checkSuspension();
    }

    /**
     * @return void
     */
    public function checkSuspension(): void
    {
        $criteria_suspended = new Criteria('uid', $this->uidOwner);
        if (1 === $this->isSuspended) {
            $suspensions = $this->suspensionsFactory->getObjects($criteria_suspended);
            /** @var Suspensions $suspension */
            $suspension = $suspensions[0];
            if (\time() > $suspension->getVar('suspension_time')) {
                $suspension = $this->suspensionsFactory->create(false);
                $suspension->load($this->uidOwner);

The method load() does not exist on XoopsObject. It seems like you code against a sub-type of XoopsObject such as XoopsModules\Suico\Video or XoopsModules\Suico\Suspensions or XoopsBlock or XoopsModules\Suico\Notes or XoopsModules\Suico\Image or XoopsModules\Suico\Friendship or XoopsComments or XoopsModules\Suico\Visitors or XoopsModules\Suico\Relgroupuser or XoopsModules\Suico\Groups or XoopsModules\Suico\Configs or XoopsModules\Suico\Friendrequest or XoopsModules\Suico\Ishot or XoopsModules\Suico\Audio.

                $this->owner->setVar('email', $suspension->getVar('old_email', 'n'));
                $this->owner->setVar('pass', $suspension->getVar('old_pass', 'n'));
                $this->owner->setVar('user_sig', $suspension->getVar('old_signature', 'n'));
                $userHandler = new XoopsUserHandler($this->db);
                $userHandler->insert($this->owner, true);
                $criteria = new Criteria('uid', $this->uidOwner);
                $this->suspensionsFactory->deleteAll($criteria);
            }
        }
    }

    /**
     * @return void
     */
    public function checkPrivilege()
    {
    }

    /**
     * Checkinf privilege levels
     *
     * @param int $privilegeNeeded 0 anonym 1 member 2 friend 3 owner
     * @return bool true if privilege enough
     */
    public function checkPrivilegeLevel(
        $privilegeNeeded = 1
    ) {
        return $privilegeNeeded <= $this->privilegeLevel;
    }

    /**
     * Set permissions according to user is logged or not , is owner or not etc..
     */
    public function getPermissions(): void
    {
        global $_GET, $xoopsUser;
        /**
         * @desc Check if the user uid exists if not redirect back to where he was
         */
        if (!empty($_GET['uid'])) {
            /** @var \XoopsMemberHandler $memberHandler */
            $memberHandler = \xoops_getHandler('member');
            $user          = $memberHandler->getUser(Request::getInt('uid', 0, 'GET'));
            if (!\is_object($user)) {
                \redirect_header('index.php', 3, \_MD_SUICO_USER_DOESNTEXIST);
            }
        }
        /**
         * If anonymous and uid not set then redirect to admins profile
         * Else redirects to own profile
         */
        if (empty($this->user)) {
            $this->isAnonym = 1;
            $this->isUser   = 0;
            if (!empty($_GET['uid'])) {
                $this->uidOwner = Request::getInt('uid', 0, 'GET');
            } else {
                $this->uidOwner = 1;
                $this->isOwner  = 0;
            }
        } else {
            $this->isAnonym = 0;
            $this->isUser   = 1;
            if (!empty($_GET['uid'])) {
                $this->uidOwner = Request::getInt('uid', 0, 'GET');
                $this->isOwner  = $this->user->getVar('uid') === Request::getInt('uid', 0, 'GET') ? 1 : 0;
            } else {
                $this->uidOwner = $this->user->getVar('uid');
                $this->isOwner  = 1;
            }
        }
        $this->owner        = new XoopsUser($this->uidOwner);
        $criteria_suspended = new Criteria('uid', $this->uidOwner);
        $this->isSuspended  = $this->suspensionsFactory->getCount($criteria_suspended) > 0 ? 1 : 0;
        if ('' === $this->owner->getVar('name')) {
            $this->nameOwner = $this->owner->getVar('uname');
        } else {
            $this->nameOwner = $this->owner->getVar('name');
        }
        //isFriend?
        $criteria_friends = new Criteria('friend1_uid', $this->uidOwner);
        if ($xoopsUser) {
            $criteriaIsfriend = new CriteriaCompo(new Criteria('friend2_uid', $this->user->getVar('uid')));
            $criteriaIsfriend->add($criteria_friends);
            $this->isFriend = $this->friendshipsFactory->getCount($criteriaIsfriend);
        } else {
            $this->isFriend = 0;
        }
        $this->privilegeLevel = 1;
        if (1 === $this->isAnonym) {
            $this->privilegeLevel = 1;
        }
        if (1 === $this->isUser) {
            $this->privilegeLevel = 2;
        }
        if (1 === $this->isFriend) {
            $this->privilegeLevel = 3;
        }
        if (1 === $this->isOwner) {
            $this->privilegeLevel = 4;
        }
    }

    /**
     * Get for each section the number of objects the user possess
     *
     * @return array(countGroups=>"",countPhotos=>"",countFriends=>"",countGroups=>"")
     */
    public function getNumbersSections()
    {
        $criteriaGroups            = new Criteria('rel_user_uid', $this->uidOwner);
        $nbSections['countGroups'] = $this->relgroupusersFactory->getCount($criteriaGroups);

$nbSections was never initialized. Although not strictly required by PHP, it is generally a good practice to add $nbSections = array(); before regardless.

        $criteriaUid               = new Criteria('uid_owner', $this->uidOwner);
        $criteriaAlbum             = new CriteriaCompo($criteriaUid);
        if (0 === $this->isOwner) {
            $criteriaPrivate = new Criteria('private', 0);
            $criteriaAlbum->add($criteriaPrivate);
        }
        $nbSections['countPhotos']  = $this->albumFactory->getCount($criteriaAlbum);
        $criteriaFriends            = new Criteria('friend1_uid', $this->uidOwner);
        $nbSections['countFriends'] = $this->friendshipsFactory->getCount($criteriaFriends);
        $criteriaUidAudio           = new Criteria('uid_owner', $this->uidOwner);
        $nbSections['countAudios']  = $this->audioFactory->getCount($criteriaUidAudio);
        $criteriaUidVideo           = new Criteria('uid_owner', $this->uidOwner);
        $nbSections['countVideos']  = $this->videosFactory->getCount($criteriaUidVideo);
        $criteriaUidNotes           = new Criteria('note_to', $this->uidOwner);
        $nbSections['countNotes']   = $this->notesFactory->getCount($criteriaUidNotes);

        return $nbSections;
    }

    /**
     * This creates the module factories
     */
    public function createFactories(): void
    {
        $this->albumFactory         = new ImageHandler($this->db);
        $this->visitorsFactory      = new VisitorsHandler($this->db);
        $this->audioFactory         = new AudioHandler($this->db);
        $this->videosFactory        = new VideoHandler($this->db);
        $this->friendrequestFactory = new FriendrequestHandler($this->db);
        $this->friendshipsFactory   = new FriendshipHandler($this->db);
        $this->relgroupusersFactory = new RelgroupuserHandler($this->db);
        $this->notesFactory         = new NotesHandler($this->db);
        $this->groupsFactory        = new GroupsHandler($this->db);
        $this->configsFactory       = new ConfigsHandler($this->db);
        $this->suspensionsFactory   = new SuspensionsHandler($this->db);
    }

    /**
     * @param $section
     * @return int
     */
    public function checkPrivilegeBySection($section)
    {
        global $xoopsModuleConfig;
        $configsectionname = 'enable_' . $section;
        if (null !== $xoopsModuleConfig) {
            if (\array_key_exists($configsectionname, $xoopsModuleConfig)) {
                if (0 === $this->helper->getConfig($configsectionname)) {
                    return -1;
                }
            }
        }
        //  if ($section=="Notes" && $xoopsModuleConfig['enable_notes']==0){
        //          return false;
        //      }
        //      if ($section=="pictures" && $xoopsModuleConfig['enable_pictures']==0){
        //          return false;
        //      }
        //
        //      if ($section=="pictures" && $xoopsModuleConfig['enable_pictures']==0){
        //          return false;
        //      }
        $criteria = new Criteria('config_uid', $this->owner->getVar('uid'));

It seems like $this->owner->getVar('uid') can also be of type array and array; however, parameter $value of Criteria::__construct() does only seem to accept string, maybe add an additional type check?

        if (1 === $this->configsFactory->getCount($criteria)) {
            $configs = $this->configsFactory->getObjects($criteria);
            $config  = $configs[0]->getVar($section);
            if (!$this->checkPrivilegeLevel($config)) {
                return 0;
            }
        }

        return 1;
    }
}