Issues in AudioHandler.php (master) - Issues in master - XoopsModules25x/suico - Measure and Improve Code Quality continuously with Scrutinizer

Issues (432)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/AudioHandler.php (4 issues)

Labels

Severity

<?php declare(strict_types=1);

namespace XoopsModules\Suico;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * @category        Module
 * @copyright       {@link https://xoops.org/ XOOPS Project}
 * @license         GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author          Bruno Barthez, Marcello Brandão aka  Suico, Mamba, LioMJ  <https://xoops.org>
 */

use CriteriaCompo;
use CriteriaElement;
use Xmf\Request;
use XoopsDatabase;
use XoopsObject;
use XoopsPersistableObjectHandler;
use XoopsModules\Suico\{
    Helper
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
};
/** @var Helper $helper */
require_once XOOPS_ROOT_PATH . '/kernel/object.php';
require_once XOOPS_ROOT_PATH . '/class/uploader.php';

/**
 * AudioHandler class.
 * This class provides simple mechanism for suico_audio object
 */
class AudioHandler extends XoopsPersistableObjectHandler
{
    public $isAdmin;
    public $helper;

    /**
     * Constructor
     * @param \XoopsDatabase|null $xoopsDatabase
     * @param Helper|null $helper
     */
    public function __construct(
        ?XoopsDatabase $xoopsDatabase = null,
        $helper = null
    ) {
        /** @var Helper $this- >helper */
        if (null === $helper) {
            $this->helper = Helper::getInstance();
        } else {
            $this->helper = $helper;
        }
        $this->isAdmin = $this->helper->isUserAdmin();
        parent::__construct($xoopsDatabase, 'suico_audios', Audio::class, 'audio_id', 'title');
    }

    /**
     * @param bool $isNew
     *
     * @return XoopsObject
     */
    public function create($isNew = true)
    {
        $obj = parent::create($isNew);
        if ($isNew) {
            $obj->setNew();
        } else {
            $obj->unsetNew();
        }
        $obj->helper = $this->helper;

        return $obj;
    }

    /**
     * retrieve a suico_audio
     *
     * @param int|null $id of the suico_audio
     * @return false|\XoopsModules\Suico\Audio reference to the {@link suico_audio} object, FALSE if failed
     */
    public function get2(
        $id = null
        //        $fields = null
    )
    {
        $sql = 'SELECT * FROM ' . $this->db->prefix('suico_audios') . ' WHERE audio_id=' . $id;
        if (!$result = $this->db->query($sql)) {
            return false;
        }
        $numrows = $this->db->getRowsNum($result);
        if (1 === $numrows) {
            $suicoAudio = new Audio();
            $suicoAudio->assignVars($this->db->fetchArray($result));

            return $suicoAudio;
        }

        return false;
    }

    /**
     * insert a new Audio in the database
     *
     * @param XoopsObject $object reference to the {@link suico_audio}
     *                                 object
     * @param bool        $force
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */
    public function insert2(
        XoopsObject $object,
        $force = false
    ) {
        global $xoopsConfig;
        if (Audio::class !== \get_class($object)) {
            return false;
        }
        if (!$object->isDirty()) {
            return true;
        }
        if (!$object->cleanVars()) {
            return false;
        }
        foreach ($object->cleanVars as $k => $v) {
            ${$k} = $v;
        }
        $audio_id     = Request::getString('audio_id', '', 'POST');
        $uid_owner    = Request::getInt('audio_id', 0, 'POST');
        $title        = Request::getString('title', '', 'POST');
        $author       = Request::getString('author', '', 'POST');
        $description  = Request::getText('description', '', 'POST');
        $filename     = Request::getString('filename', '', 'POST');
        $date_created = Request::getString('date_created', \time(), 'POST');
        $date_updated = Request::getString('date_updated', \time(), 'POST');
        //        $now = 'date_add(now(), interval ' . $xoopsConfig['server_TZ'] . ' hour)';
        if ($object->isNew()) {
            // adding / modifying a suico_audio
            $object = new Audio();
            $format      = 'INSERT INTO %s (audio_id, title, author, description, filename, uid_owner, date_created, date_updated)';
            $format      .= ' VALUES (%u, %s, %s, %s, %s, %u, %s, %s)';
            $sql         = \sprintf(
                $format,
                $this->db->prefix('suico_audios'),
                $audio_id,
                $this->db->quoteString($author),
                $this->db->quoteString($title),
                $this->db->quoteString($description),
                $this->db->quoteString($filename),
                $uid_owner,
                $date_created,
                $date_updated
            );
            $force       = true;
        } else {
            $format = 'UPDATE %s SET ';
            $format .= 'audio_id=%u, title=%s, author=%s, filename=%s, description=%s,uid_owner=%u, date_created=%s, date_updated=%s';
            $format .= ' WHERE audio_id = %u';
            $sql    = \sprintf(
                $format,
                $this->db->prefix('suico_audios'),
                $audio_id,
                $this->db->quoteString($title),
                $this->db->quoteString($author),
                $this->db->quoteString($filename),
                $uid_owner,
                $date_created,
                $date_updated,
                $audio_id
            );
        }
        if ($force) {
            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }
        if (!$result) {
            return false;
        }
        if (empty($audio_id)) {
            $audio_id = $this->db->getInsertId();
        }
        $object->assignVar('audio_id', $audio_id);

        return true;
    }

    /**
     * delete a suico_audio from the database
     *
     * @param XoopsObject $object reference to the suico_audio to delete
     * @param bool        $force
     * @return bool FALSE if failed.
     */
    public function delete(
        XoopsObject $object,
        $force = false
    ) {
        if (Audio::class !== \get_class($object)) {
            return false;
        }
        $sql = \sprintf(
            'DELETE FROM %s WHERE audio_id = %u',
            $this->db->prefix('suico_audios'),
            (int)$object->getVar('audio_id')
        );
        if ($force) {
            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }
        if (!$result) {
            return false;
        }

        return true;
    }

    /**
     * retrieve suico_audios from the database
     *
     * @param \CriteriaElement|\CriteriaCompo|null $criteria {@link \CriteriaElement} conditions to be met
     * @param bool                                 $id_as_key       use the UID as key for the array?
     * @param bool                                 $as_object
     * @return array array of {@link suico_audio} objects
     */
    public function &getObjects(
        ?CriteriaElement $criteria = null,
        $id_as_key = false,
        $as_object = true
    ) {
        $ret   = [];
        $start = 0;
        $limit = 0;
        $sql   = 'SELECT * FROM ' . $this->db->prefix('suico_audios');
        if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql .= ' ' . $criteria->renderWhere();
            $sql .= ' ' . $criteria->/** @scrutinizer ignore-call */ renderWhere();
            if ('' !== $criteria->getSort()) {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
            $limit = $criteria->getLimit();
            $start = $criteria->getStart();
        }
        $result = $this->db->query($sql, $limit, $start);
        if (!$result) {
            return $ret;
        }
        while (false !== ($myrow = $this->db->fetchArray($result))) {
            $suicoAudio = new Audio();
            $suicoAudio->assignVars($myrow);
            if ($id_as_key) {
                $ret[$myrow['audio_id']] = &$suicoAudio;
            } else {
                $ret[] = &$suicoAudio;
            }
            unset($suicoAudio);
        }

        return $ret;
    }

    /**
     * count suico_audios matching a condition
     *
     * @param CriteriaElement|CriteriaCompo|null $criteria {@link \CriteriaElement} to match
     * @return int count of suico_audios
     */
    public function getCount(
        ?CriteriaElement $criteria = null
    ) {
        $sql = 'SELECT COUNT(*) FROM ' . $this->db->prefix('suico_audios');
        if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql .= ' ' . $criteria->renderWhere();
        }
        $result = $this->db->query($sql);
        if (!$result) {
            return 0;
        }
        [$count] = $this->db->fetchRow($result);

        return (int)$count;
    }

    /**
     * delete suico_audios matching a set of conditions
     *
     * @param CriteriaElement|CriteriaCompo|null $criteria {@link \CriteriaElement}
     * @param bool                               $force
     * @param bool                               $asObject
     * @return bool FALSE if deletion failed
     */
    public function deleteAll(
        ?CriteriaElement $criteria = null,
        $force = true,
        $asObject = false
    ) {
        $sql = 'DELETE FROM ' . $this->db->prefix('suico_audios');
        if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {

            return false;
        }

        return true;
    }

    /**
     * Upload the file and Save into database
     *
     * @param string $title       A litle description of the file
     * @param string $path_upload The path to where the file should be uploaded
     * @param string $author      the author of the music or audio file
     * @param        $maxfilebytes
     * @param        $description
     * @return bool FALSE if upload fails or database fails
     */
    public function receiveAudio(
        $title,
        $path_upload,
        $author,
        $maxfilebytes,
        $description
    ) {
        global $xoopsUser, $xoopsDB, $_POST, $_FILES;
        //busca id do user logado
        $uid = $xoopsUser->getVar('uid');
        //create a hash so it does not erase another file
        //$hash1 = date();
        //$hash = substr($hash1,0,4);
        // mimetypes and settings put this in admin part later
        $allowed_mimetypes = [
            'audio/mp3',
            'audio/x-mp3',
            'audio/mpeg',
        ];
        $maxfilesize       = $maxfilebytes;
        $uploadDir         = $path_upload;
        // create the object to upload
        $uploader = new \XoopsMediaUploader(
            $uploadDir,
            $allowed_mimetypes,
            $maxfilesize
        );
        // fetch the media
        if ($uploader->fetchMedia((Request::getArray('xoops_upload_file', '', 'POST')[0]))) {
            //lets create a name for it
            $uploader->setPrefix('aud_' . $uid . '_');
            //now let s upload the file
            if (!$uploader->upload()) {
                // if there are errors lets return them
                echo '<div style="color:#FF0000; background-color:#FFEAF4; border-color:#FF0000; border-width:thick; border-style:solid; text-align:center"><p>' . $uploader->getErrors() . '</p></div>';

                return false;
            }
            // now let s create a new object audio and set its variables
            //echo "passei aqui";
            $audio = $this->create();
            $audio->setVar('uid_owner', $xoopsUser->getVar('uid'));
            $audio->setVar('title', $title);
            $audio->setVar('author', $author);
            $audio->setVar('description', $description);
            $audio->setVar(
                'filename',
                $uploader->getSavedFileName()
            );
            $audio->setVar('date_created', \time());
            $audio->setVar('date_updated', \time());
            $this->insert($audio);
            $saved_destination = $uploader->getSavedDestination();

            //print_r($_FILES);
        } else {
            echo '<div style="color:#FF0000; background-color:#FFEAF4; border-color:#FF0000; border-width:thick; border-style:solid; text-align:center"><p>' . $uploader->getErrors() . '</p></div>';

            return false;
        }

        return true;
    }
}


XoopsModules25x / suico

Issues (432)

Security Analysis not enabled

class/AudioHandler.php (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like