| Total Complexity | 45 |
| Total Lines | 406 |
| Duplicated Lines | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like SysUtility often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SysUtility, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 35 | class SysUtility |
||
| 36 | { |
||
| 37 | use VersionChecks; |
||
|
|
|||
| 38 | use ServerStats; |
||
| 39 | use FilesManagement; |
||
| 40 | |||
| 41 | // Files Management Trait |
||
| 42 | |||
| 43 | //--------------- Custom module methods ----------------------------- |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @param $text |
||
| 47 | * @param $form_sort |
||
| 48 | * @return string |
||
| 49 | */ |
||
| 50 | |||
| 51 | public static function selectSorting($text, $form_sort) |
||
| 52 | { |
||
| 53 | global $start, $order, $file_cat, $sort, $xoopsModule; |
||
| 54 | |||
| 55 | $select_view = ''; |
||
| 56 | |||
| 57 | $moduleDirName = \basename(\dirname(__DIR__, 2)); |
||
| 58 | |||
| 59 | $helper = Helper::getInstance(); |
||
| 60 | |||
| 61 | // $pathModIcon16 = XOOPS_URL . '/modules/' . $moduleDirName . '/' . $helper->getModule()->getInfo('modicons16'); |
||
| 62 | |||
| 63 | $pathModIcon16 = $helper->url($helper->getModule()->getInfo('modicons16')); |
||
| 64 | |||
| 65 | $select_view = '<form name="form_switch" id="form_switch" action="' . Request::getString('REQUEST_URI', '', 'SERVER') . '" method="post"><span style="font-weight: bold;">' . $text . '</span>'; |
||
| 66 | |||
| 67 | //$sorts = $sort == 'asc' ? 'desc' : 'asc'; |
||
| 68 | |||
| 69 | if ($form_sort == $sort) { |
||
| 70 | $sel1 = 'asc' === $order ? 'selasc.png' : 'asc.png'; |
||
| 71 | |||
| 72 | $sel2 = 'desc' === $order ? 'seldesc.png' : 'desc.png'; |
||
| 73 | } else { |
||
| 74 | $sel1 = 'asc.png'; |
||
| 75 | |||
| 76 | $sel2 = 'desc.png'; |
||
| 77 | } |
||
| 78 | |||
| 79 | $select_view .= ' <a href="' . Request::getString('PHP_SELF', '', 'SERVER') . '?start=' . $start . '&sort=' . $form_sort . '&order=asc"><img src="' . $pathModIcon16 . '/' . $sel1 . '" title="ASC" alt="ASC"></a>'; |
||
| 80 | |||
| 81 | $select_view .= '<a href="' . Request::getString('PHP_SELF', '', 'SERVER') . '?start=' . $start . '&sort=' . $form_sort . '&order=desc"><img src="' . $pathModIcon16 . '/' . $sel2 . '" title="DESC" alt="DESC"></a>'; |
||
| 82 | |||
| 83 | $select_view .= '</form>'; |
||
| 84 | |||
| 85 | return $select_view; |
||
| 86 | } |
||
| 87 | |||
| 88 | /***************Blocks***************/ |
||
| 89 | |||
| 90 | /** |
||
| 91 | * @param array $cats |
||
| 92 | * @return string |
||
| 93 | */ |
||
| 94 | |||
| 95 | public static function blockAddCatSelect($cats) |
||
| 96 | { |
||
| 97 | $cat_sql = ''; |
||
| 98 | |||
| 99 | if (\is_array($cats) && !empty($cats)) { |
||
| 100 | $cat_sql = '(' . \current($cats); |
||
| 101 | |||
| 102 | \array_shift($cats); |
||
| 103 | |||
| 104 | foreach ($cats as $cat) { |
||
| 105 | $cat_sql .= ',' . $cat; |
||
| 106 | } |
||
| 107 | |||
| 108 | $cat_sql .= ')'; |
||
| 109 | } |
||
| 110 | |||
| 111 | return $cat_sql; |
||
| 112 | } |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @param $content |
||
| 116 | */ |
||
| 117 | |||
| 118 | public static function metaKeywords($content) |
||
| 119 | { |
||
| 120 | global $xoopsTpl, $xoTheme; |
||
| 121 | |||
| 122 | $myts = \MyTextSanitizer::getInstance(); |
||
| 123 | |||
| 124 | $content = $myts->undoHtmlSpecialChars($myts->displayTarea($content)); |
||
| 125 | |||
| 126 | if (null !== $xoTheme && \is_object($xoTheme)) { |
||
| 127 | $xoTheme->addMeta('meta', 'keywords', \strip_tags($content)); |
||
| 128 | } else { // Compatibility for old Xoops versions |
||
| 129 | $xoopsTpl->assign('xoops_metaKeywords', \strip_tags($content)); |
||
| 130 | } |
||
| 131 | } |
||
| 132 | |||
| 133 | /** |
||
| 134 | * @param $content |
||
| 135 | */ |
||
| 136 | |||
| 137 | public static function metaDescription($content) |
||
| 149 | } |
||
| 150 | } |
||
| 151 | |||
| 152 | /** |
||
| 153 | * @param $tableName |
||
| 154 | * @param $columnName |
||
| 155 | * |
||
| 156 | * @return array |
||
| 157 | */ |
||
| 158 | |||
| 159 | public static function enumerate($tableName, $columnName) |
||
| 160 | { |
||
| 161 | $table = $GLOBALS['xoopsDB']->prefix($tableName); |
||
| 162 | |||
| 163 | // $result = $GLOBALS['xoopsDB']->query("SELECT COLUMN_TYPE FROM INFORMATION_SCHEMA.COLUMNS |
||
| 164 | |||
| 165 | // WHERE TABLE_NAME = '" . $table . "' AND COLUMN_NAME = '" . $columnName . "'") |
||
| 166 | |||
| 167 | // || exit ($GLOBALS['xoopsDB']->error()); |
||
| 168 | |||
| 169 | $sql = 'SELECT COLUMN_TYPE FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = "' . $table . '" AND COLUMN_NAME = "' . $columnName . '"'; |
||
| 170 | |||
| 171 | $result = $GLOBALS['xoopsDB']->query($sql); |
||
| 172 | |||
| 173 | if (!$result) { |
||
| 174 | exit($GLOBALS['xoopsDB']->error()); |
||
| 175 | } |
||
| 176 | |||
| 177 | $row = $GLOBALS['xoopsDB']->fetchBoth($result); |
||
| 178 | |||
| 179 | $enumList = \explode(',', \str_replace("'", '', \mb_substr($row['COLUMN_TYPE'], 5, -6))); |
||
| 180 | |||
| 181 | return $enumList; |
||
| 182 | } |
||
| 183 | |||
| 184 | /** |
||
| 185 | * @param array|string $tableName |
||
| 186 | * @param int $id_field |
||
| 187 | * @param int $id |
||
| 188 | * |
||
| 189 | * @return mixed |
||
| 190 | */ |
||
| 191 | |||
| 192 | public static function cloneRecord($tableName, $id_field, $id) |
||
| 193 | { |
||
| 194 | $new_id = false; |
||
| 195 | |||
| 196 | $table = $GLOBALS['xoopsDB']->prefix($tableName); |
||
| 197 | |||
| 198 | // copy content of the record you wish to clone |
||
| 199 | |||
| 200 | $tempTable = $GLOBALS['xoopsDB']->fetchArray($GLOBALS['xoopsDB']->query("SELECT * FROM $table WHERE $id_field='$id' "), \MYSQLI_ASSOC) or exit('Could not select record'); |
||
| 201 | |||
| 202 | // set the auto-incremented id's value to blank. |
||
| 203 | |||
| 204 | unset($tempTable[$id_field]); |
||
| 205 | |||
| 206 | // insert cloned copy of the original record |
||
| 207 | |||
| 208 | $result = $GLOBALS['xoopsDB']->queryF("INSERT INTO $table (" . \implode(', ', \array_keys($tempTable)) . ") VALUES ('" . \implode("', '", $tempTable) . "')") or exit($GLOBALS['xoopsDB']->error()); |
||
| 209 | |||
| 210 | if ($result) { |
||
| 211 | // Return the new id |
||
| 212 | |||
| 213 | $new_id = $GLOBALS['xoopsDB']->getInsertId(); |
||
| 214 | } |
||
| 215 | |||
| 216 | return $new_id; |
||
| 217 | } |
||
| 218 | |||
| 219 | /** |
||
| 220 | * truncateHtml can truncate a string up to a number of characters while preserving whole words and HTML tags |
||
| 221 | * www.gsdesign.ro/blog/cut-html-string-without-breaking-the-tags |
||
| 222 | * www.cakephp.org |
||
| 223 | * |
||
| 224 | * @param string $text String to truncate. |
||
| 225 | * @param int $length Length of returned string, including ellipsis. |
||
| 226 | * @param string $ending Ending to be appended to the trimmed string. |
||
| 227 | * @param bool $exact If false, $text will not be cut mid-word |
||
| 228 | * @param bool $considerHtml If true, HTML tags would be handled correctly |
||
| 229 | * |
||
| 230 | * @return string Trimmed string. |
||
| 231 | */ |
||
| 232 | |||
| 233 | public static function truncateHtml($text, $length = 100, $ending = '...', $exact = false, $considerHtml = true) |
||
| 234 | { |
||
| 235 | $openTags = []; |
||
| 236 | |||
| 237 | if ($considerHtml) { |
||
| 238 | // if the plain text is shorter than the maximum length, return the whole text |
||
| 239 | |||
| 240 | if (\mb_strlen(\preg_replace('/<.*?' . '>/', '', $text)) <= $length) { |
||
| 241 | return $text; |
||
| 242 | } |
||
| 243 | |||
| 244 | // splits all html-tags to scanable lines |
||
| 245 | |||
| 246 | \preg_match_all('/(<.+?' . '>)?([^<>]*)/s', $text, $lines, \PREG_SET_ORDER); |
||
| 247 | |||
| 248 | $total_length = mb_strlen($ending); |
||
| 249 | |||
| 250 | //$openTags = []; |
||
| 251 | |||
| 252 | $truncate = ''; |
||
| 253 | |||
| 254 | foreach ($lines as $line_matchings) { |
||
| 255 | // if there is any html-tag in this line, handle it and add it (uncounted) to the output |
||
| 256 | |||
| 257 | if (!empty($line_matchings[1])) { |
||
| 258 | // if it's an "empty element" with or without xhtml-conform closing slash |
||
| 259 | |||
| 260 | if (\preg_match('/^<(\s*.+?\/\s*|\s*(img|br|input|hr|area|base|basefont|col|frame|isindex|link|meta|param)(\s.+?)?)>$/is', $line_matchings[1])) { |
||
| 261 | // do nothing |
||
| 262 | // if tag is a closing tag |
||
| 263 | } elseif (\preg_match('/^<\s*\/(\S+?)\s*>$/s', $line_matchings[1], $tag_matchings)) { |
||
| 264 | // delete tag from $openTags list |
||
| 265 | |||
| 266 | $pos = \array_search($tag_matchings[1], $openTags); |
||
| 267 | |||
| 268 | if (false !== $pos) { |
||
| 269 | unset($openTags[$pos]); |
||
| 270 | } |
||
| 271 | // if tag is an opening tag |
||
| 272 | } elseif (\preg_match('/^<\s*([^\s>!]+).*?' . '>$/s', $line_matchings[1], $tag_matchings)) { |
||
| 273 | // add tag to the beginning of $openTags list |
||
| 274 | |||
| 275 | \array_unshift($openTags, \mb_strtolower($tag_matchings[1])); |
||
| 276 | } |
||
| 277 | |||
| 278 | // add html-tag to $truncate'd text |
||
| 279 | |||
| 280 | $truncate .= $line_matchings[1]; |
||
| 281 | } |
||
| 282 | |||
| 283 | // calculate the length of the plain text part of the line; handle entities as one character |
||
| 284 | |||
| 285 | $content_length = \mb_strlen(\preg_replace('/&[0-9a-z]{2,8};|&#\d{1,7};|[0-9a-f]{1,6};/i', ' ', $line_matchings[2])); |
||
| 286 | |||
| 287 | if ($total_length + $content_length > $length) { |
||
| 288 | // the number of characters which are left |
||
| 289 | |||
| 290 | $left = $length - $total_length; |
||
| 291 | |||
| 292 | $entities_length = 0; |
||
| 293 | |||
| 294 | // search for html entities |
||
| 295 | |||
| 296 | if (\preg_match_all('/&[0-9a-z]{2,8};|&#\d{1,7};|[0-9a-f]{1,6};/i', $line_matchings[2], $entities, \PREG_OFFSET_CAPTURE)) { |
||
| 297 | // calculate the real length of all entities in the legal range |
||
| 298 | |||
| 299 | foreach ($entities[0] as $entity) { |
||
| 300 | if ($left >= $entity[1] + 1 - $entities_length) { |
||
| 301 | $left--; |
||
| 302 | |||
| 303 | $entities_length += \mb_strlen($entity[0]); |
||
| 304 | } else { |
||
| 305 | // no more characters left |
||
| 306 | |||
| 307 | break; |
||
| 308 | } |
||
| 309 | } |
||
| 310 | } |
||
| 311 | |||
| 312 | $truncate .= \mb_substr($line_matchings[2], 0, $left + $entities_length); |
||
| 313 | |||
| 314 | // maximum lenght is reached, so get off the loop |
||
| 315 | |||
| 316 | break; |
||
| 317 | } |
||
| 318 | |||
| 319 | $truncate .= $line_matchings[2]; |
||
| 320 | |||
| 321 | $total_length += $content_length; |
||
| 322 | |||
| 323 | // if the maximum length is reached, get off the loop |
||
| 324 | |||
| 325 | if ($total_length >= $length) { |
||
| 326 | break; |
||
| 327 | } |
||
| 328 | } |
||
| 329 | } elseif (\mb_strlen($text) <= $length) { |
||
| 330 | return $text; |
||
| 331 | } |
||
| 332 | |||
| 333 | $truncate = \mb_substr($text, 0, $length - \mb_strlen($ending)); |
||
| 334 | |||
| 335 | // if the words shouldn't be cut in the middle... |
||
| 336 | |||
| 337 | if (!$exact) { |
||
| 338 | // ...search the last occurance of a space... |
||
| 339 | |||
| 340 | $spacepos = \mb_strrpos($truncate, ' '); |
||
| 341 | |||
| 342 | if (isset($spacepos)) { |
||
| 343 | // ...and cut the text in this position |
||
| 344 | |||
| 345 | $truncate = \mb_substr($truncate, 0, $spacepos); |
||
| 346 | } |
||
| 347 | } |
||
| 348 | |||
| 349 | // add the defined ending to the text |
||
| 350 | |||
| 351 | $truncate .= $ending; |
||
| 352 | |||
| 353 | if ($considerHtml) { |
||
| 354 | // close all unclosed html-tags |
||
| 355 | |||
| 356 | foreach ($openTags as $tag) { |
||
| 357 | $truncate .= '</' . $tag . '>'; |
||
| 358 | } |
||
| 359 | } |
||
| 360 | |||
| 361 | return $truncate; |
||
| 362 | } |
||
| 363 | |||
| 364 | /** |
||
| 365 | * @param \Xmf\Module\Helper $helper |
||
| 366 | * @param array|null $options |
||
| 367 | * @return \XoopsFormDhtmlTextArea|\XoopsFormEditor |
||
| 368 | */ |
||
| 369 | |||
| 370 | public static function getEditor( |
||
| 423 | } |
||
| 424 | |||
| 425 | /** |
||
| 426 | * @param $fieldname |
||
| 427 | * @param $table |
||
| 428 | * |
||
| 429 | * @return bool |
||
| 430 | */ |
||
| 431 | |||
| 432 | public function fieldExists( |
||
| 441 | } |
||
| 442 | } |
||
| 443 |