YogurtField::getOutputValue()

Complexity

Conditions	39
Paths	160

Size

Total Lines	125
Code Lines	89

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getOutputValue(&$user, $profile)
    {
        if (file_exists($file = $GLOBALS['xoops']->path('modules/yogurt/language/' . $GLOBALS['xoopsConfig']['language'] . '/modinfo.php'))) {
            include_once $file;
        } else {
            include_once $GLOBALS['xoops']->path('modules/yogurt/language/english/modinfo.php');
        }

        $value = in_array($this->getVar('field_name'), $this->getUserVars()) ? $user->getVar($this->getVar('field_name')) : $profile->getVar($this->getVar('field_name'));

        switch ($this->getVar('field_type')) {
            default:
            case 'textbox':
                $value = is_array($value) ? $value[0] : $value;
                if ($this->getVar('field_name') === 'url' && $value !== '') {
                    return '<a href="' . formatURL($value) . '" rel="external">' . $value . '</a>';
                } else {
                    return $value;
                }
                break;
            case 'textarea':
            case 'dhtml':
            case 'theme':
            case 'language':
                return $value;
                break;

break is not strictly necessary here and could be removed.

            case 'select':
            case 'radio':
                $value = is_array($value) ? $value[0] : $value;
                $options = $this->getVar('field_options');
                if (isset($options[$value])) {
                    $value = htmlspecialchars(defined($options[$value]) ? constant($options[$value]) : $options[$value]);
                } else {
                    $value = '';
                }

                return $value;
                break;

            case 'select_multi':
            case 'checkbox':
                $options = $this->getVar('field_options');
                $ret     = array();
                if (count($options) > 0) {
                    foreach (array_keys($options) as $key) {
                        if (in_array($key, $value)) {

It seems like $value can also be of type boolean and null and string; however, parameter $haystack of in_array() does only seem to accept array, maybe add an additional type check?

                            $ret[$key] = htmlspecialchars(defined($options[$key]) ? constant($options[$key]) : $options[$key]);
                        }
                    }
                }

                return $ret;
                break;

            case 'group':
                /* @var XoopsMemberHandler $member_handler */
                $member_handler = xoops_getHandler('member');
                $options        = $member_handler->getGroupList();
                $ret            = isset($options[$value]) ? $options[$value] : '';

                return $ret;
                break;

            case 'group_multi':
                /* @var XoopsMemberHandler $member_handler */
                $member_handler = xoops_getHandler('member');
                $options        = $member_handler->getGroupList();
                $ret            = array();
                foreach (array_keys($options) as $key) {
                    if (in_array($key, $value)) {
                        $ret[$key] = htmlspecialchars($options[$key]);
                    }
                }

                return $ret;
                break;

            case 'longdate':
                //return YYYY/MM/DD format - not optimal as it is not using local date format, but how do we do that
                //when we cannot convert it to a UNIX timestamp?
                return str_replace('-', '/', $value);

            case 'date':
                return formatTimestamp($value, 's');
                break;

            case 'datetime':
                if (!empty($value)) {
                    return formatTimestamp($value, 'm');
                } else {
                    return $value = _MI_YOGURT_NEVER_LOGGED_IN;

The assignment to $value is dead and can be removed.

                }
                break;

            case 'autotext':
                $value = $user->getVar($this->getVar('field_name'), 'n'); //autotext can have HTML in it
                $value = str_replace('{X_UID}', $user->getVar('uid'), $value);
                $value = str_replace('{X_URL}', XOOPS_URL, $value);
                $value = str_replace('{X_UNAME}', $user->getVar('uname'), $value);

                return $value;
                break;

            case 'rank':
                $userrank       = $user->rank();
                $user_rankimage = '';
                if (isset($userrank['image']) && $userrank['image'] !== '') {
                    $user_rankimage = '<img src="' . XOOPS_UPLOAD_URL . '/' . $userrank['image'] . '" alt="' . $userrank['title'] . '" /> ';
                }

                return $user_rankimage . $userrank['title'];
                break;

            case 'yesno':
                return $value ? _YES : _NO;
                break;

            case 'timezone':
                include_once $GLOBALS['xoops']->path('class/xoopslists.php');
                $timezones = XoopsLists::getTimeZoneList();
                $value     = empty($value) ? '0' : (string)$value;

                return $timezones[str_replace('.0', '', $value)];
                break;
        }