XoopsModules\Yogurt\ProfileHandler::search()

Complexity

Conditions	16
Paths	864

Size

Total Lines	89
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function search(\CriteriaElement $criteria, $searchvars = [], $groups = null)
    {
        $uservars = $this->getUserVars();

        $searchvars_user = \array_intersect($searchvars, $uservars);

        $searchvars_profile = \array_diff($searchvars, $uservars);

        $sv = ['u.uid, u.uname, u.email, u.user_viewemail'];

        if (!empty($searchvars_user)) {
            $sv[0] .= ',u.' . \implode(', u.', $searchvars_user);
        }

        if (!empty($searchvars_profile)) {
            $sv[] = 'p.' . \implode(', p.', $searchvars_profile);
        }

        $sql_select = 'SELECT ' . (empty($searchvars) ? 'u.*, p.*' : \implode(', ', $sv));

        $sql_from = ' FROM ' . $this->db->prefix('users') . ' AS u LEFT JOIN ' . $this->table . ' AS p ON u.uid=p.profile_id' . (empty($groups) ? '' : ' LEFT JOIN ' . $this->db->prefix('groups_users_link') . ' AS g ON u.uid=g.uid');

        $sql_clause = ' WHERE 1=1';

        $sql_order = '';

        $limit = $start = 0;

        if (isset($criteria) && $criteria instanceof \CriteriaElement) {
            $sql_clause .= ' AND ' . $criteria->render();

            if ('' !== $criteria->getSort()) {
                $sql_order = ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }

            $limit = $criteria->getLimit();

            $start = $criteria->getStart();
        }

        if (!empty($groups)) {
            $sql_clause .= ' AND g.groupid IN (' . \implode(', ', $groups) . ')';
        }

        $sql_users = $sql_select . $sql_from . $sql_clause . $sql_order;

        $result = $this->db->query($sql_users, $limit, $start);

        if (!$result) {
            return [[], [], 0];
        }

        $user_handler = \xoops_getHandler('user');

        $uservars = $this->getUserVars();

        $users = [];

        $profiles = [];

        while (false !== ($myrow = $this->db->fetchArray($result))) {
            $profile = $this->create(false);

            $user = $user_handler->create(false);

Are you sure the assignment to $user is correct as $user_handler->create(false) targeting XoopsObjectHandler::create() seems to always return null.

The call to XoopsObjectHandler::create() has too many arguments starting with false.

            foreach ($myrow as $name => $value) {
                if (\in_array($name, $uservars)) {
                    $user->assignVar($name, $value);
                } else {
                    $profile->assignVar($name, $value);
                }
            }

            $profiles[$myrow['uid']] = $profile;

            $users[$myrow['uid']] = $user;
        }

        $count = \count($users);

        if ((!empty($limit) && $count >= $limit) || !empty($start)) {
            $sql_count = 'SELECT COUNT(*)' . $sql_from . $sql_clause;

            $result = $this->db->query($sql_count);

            [$count] = $this->db->fetchRow($result);
        }

        return [$users, $profiles, (int)$count];
    }