yogurt_getUserForm()

Complexity

Conditions	25
Paths	13824

Size

Total Lines	129
Code Lines	83

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function yogurt_getUserForm(XoopsUser $user, YogurtProfile $profile = null, $action = false)
{
    if ($action === false) {
        $action = $_SERVER['REQUEST_URI'];
    }
    if (empty($GLOBALS['xoopsConfigUser'])) {
        /* @var XoopsConfigHandler $config_handler */
        $config_handler             = xoops_getHandler('config');
        $GLOBALS['xoopsConfigUser'] = $config_handler->getConfigsByCat(XOOPS_CONF_USER);
    }

    include_once $GLOBALS['xoops']->path('class/xoopsformloader.php');

    $title = $user->isNew() ? _AM_YOGURT_ADDUSER : _US_EDITPROFILE;

    $form = new XoopsThemeForm($title, 'userinfo', $action, 'post', true);
    /* @var YogurtProfileHandler $profile_handler */
    $profile_handler = xoops_getModuleHandler('profile');
    // Dynamic fields
    if (!$profile) {
        /* @var YogurtProfileHandler $profile_handler */
        $profile_handler = xoops_getModuleHandler('profile', 'yogurt');
        $profile         = $profile_handler->get($user->getVar('uid'));
    }
    // Get fields
    $fields = $profile_handler->loadFields();
    // Get ids of fields that can be edited
    /* @var  XoopsGroupPermHandler $gperm_handler */
    $gperm_handler   = xoops_getHandler('groupperm');
    $editable_fields = $gperm_handler->getItemIds('profile_edit', $GLOBALS['xoopsUser']->getGroups(), $GLOBALS['xoopsModule']->getVar('mid'));

    if ($user->isNew() || $GLOBALS['xoopsUser']->isAdmin()) {
        $elements[0][] = array(

$elements was never initialized. Although not strictly required by PHP, it is generally a good practice to add $elements = array(); before regardless.

            'element'  => new XoopsFormText(_MD_YOGURT_NICKNAME, 'uname', 25, $GLOBALS['xoopsUser']->isAdmin() ? 60 : $GLOBALS['xoopsConfigUser']['maxuname'], $user->getVar('uname', 'e')),

It seems like $user->getVar('uname', 'e') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

            'required' => 1);
        $email_text    = new XoopsFormText('', 'email', 30, 60, $user->getVar('email'));
    } else {
        $elements[0][] = array('element' => new XoopsFormLabel(_MD_YOGURT_NICKNAME, $user->getVar('uname')), 'required' => 0);

It seems like $user->getVar('uname') can also be of type array and array; however, parameter $value of XoopsFormLabel::__construct() does only seem to accept string, maybe add an additional type check?

        $email_text    = new XoopsFormLabel('', $user->getVar('email'));
    }
    $email_tray = new XoopsFormElementTray(_MD_YOGURT_EMAILADDRESS, '<br>');
    $email_tray->addElement($email_text, ($user->isNew() || $GLOBALS['xoopsUser']->isAdmin()) ? 1 : 0);

$user->isNew() || $GLOBALS['xoopsUser']->isAdmin() ? 1 : 0 of type integer is incompatible with the type boolean expected by parameter $required of XoopsFormElementTray::addElement().

    $weights[0][]  = 0;

$weights was never initialized. Although not strictly required by PHP, it is generally a good practice to add $weights = array(); before regardless.

    $elements[0][] = array('element' => $email_tray, 'required' => 0);
    $weights[0][]  = 0;

    if ($GLOBALS['xoopsUser']->isAdmin() && $user->getVar('uid') != $GLOBALS['xoopsUser']->getVar('uid')) {
        //If the user is an admin and is editing someone else
        $pwd_text  = new XoopsFormPassword('', 'password', 10, 32);
        $pwd_text2 = new XoopsFormPassword('', 'vpass', 10, 32);
        $pwd_tray  = new XoopsFormElementTray(_MD_YOGURT_PASSWORD . '<br>' . _MD_YOGURT_CONFIRMPASSWORD);
        $pwd_tray->addElement($pwd_text);
        $pwd_tray->addElement($pwd_text2);
        $elements[0][] = array('element' => $pwd_tray, 'required' => 0); //cannot set an element tray required
        $weights[0][]  = 0;

        $level_radio = new XoopsFormRadio(_MD_YOGURT_USERLEVEL, 'level', $user->getVar('level'));

It seems like $user->getVar('level') can also be of type array and array; however, parameter $value of XoopsFormRadio::__construct() does only seem to accept string, maybe add an additional type check?

        $level_radio->addOption(1, _MD_YOGURT_ACTIVE);
        $level_radio->addOption(0, _MD_YOGURT_INACTIVE);
        //$level_radio->addOption(-1, _MD_YOGURT_DISABLED);
        $elements[0][] = array('element' => $level_radio, 'required' => 0);
        $weights[0][]  = 0;
    }

    $elements[0][] = array('element' => new XoopsFormHidden('uid', $user->getVar('uid')), 'required' => 0);

It seems like $user->getVar('uid') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

    $weights[0][]  = 0;
    $elements[0][] = array('element' => new XoopsFormHidden('op', 'save'), 'required' => 0);
    $weights[0][]  = 0;

    $cat_handler    = xoops_getModuleHandler('category');
    $categories     = array();
    $all_categories = $cat_handler->getObjects(null, true, false);
    $count_fields   = count($fields);

    foreach (array_keys($fields) as $i) {
        if (in_array($fields[$i]->getVar('field_id'), $editable_fields)) {
            // Set default value for user fields if available
            if ($user->isNew()) {
                $default = $fields[$i]->getVar('field_default');
                if ($default !== '' && $default !== null) {
                    $user->setVar($fields[$i]->getVar('field_name'), $default);
                }
            }

            if ($profile->getVar($fields[$i]->getVar('field_name'), 'n') === null) {
                $default = $fields[$i]->getVar('field_default', 'n');
                $profile->setVar($fields[$i]->getVar('field_name'), $default);
            }

            $fieldinfo['element']  = $fields[$i]->getEditElement($user, $profile);
            $fieldinfo['required'] = $fields[$i]->getVar('field_required');

            $key              = @$all_categories[$fields[$i]->getVar('cat_id')]['cat_weight'] * $count_fields + $fields[$i]->getVar('cat_id');
            $elements[$key][] = $fieldinfo;
            $weights[$key][]  = $fields[$i]->getVar('field_weight');
            $categories[$key] = @$all_categories[$fields[$i]->getVar('cat_id')];
        }
    }

    if ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser']->isAdmin()) {
        xoops_loadLanguage('admin', 'profile');
        /* @var  XoopsGroupPermHandler $gperm_handler */
        $gperm_handler = xoops_getHandler('groupperm');
        //If user has admin rights on groups
        include_once $GLOBALS['xoops']->path('modules/system/constants.php');
        if ($gperm_handler->checkRight('system_admin', XOOPS_SYSTEM_GROUP, $GLOBALS['xoopsUser']->getGroups(), 1)) {
            //add group selection
            $group_select  = new XoopsFormSelectGroup(_MD_YOGURT_USERGROUPS, 'groups', false, $user->getGroups(), 5, true);
            $elements[0][] = array('element' => $group_select, 'required' => 0);
            //set as latest;
            $weights[0][] = $count_fields + 1;
        }
    }

    ksort($elements);
    foreach (array_keys($elements) as $k) {
        array_multisort($weights[$k], SORT_ASC, array_keys($elements[$k]), SORT_ASC, $elements[$k]);
        $title = isset($categories[$k]) ? $categories[$k]['cat_title'] : _MD_YOGURT_DEFAULT;
        $desc  = isset($categories[$k]) ? $categories[$k]['cat_description'] : '';
        $form->addElement(new XoopsFormLabel("<h3>{$title}</h3>", $desc), false);
        foreach (array_keys($elements[$k]) as $i) {
            $form->addElement($elements[$k][$i]['element'], $elements[$k][$i]['required']);
        }
    }

    $form->addElement(new XoopsFormHidden('uid', $user->getVar('uid')));
    $form->addElement(new XoopsFormButton('', 'submit', _MD_YOGURT_SAVECHANGES, 'submit'));

    return $form;
}